paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
5e8279c2fb4331d2352edb93c73b690a2350fe3a
zulip/static/js
History
Steve Howell 5e8279c2fb refactor: Extract settings_config. 
This moves some code from settings_display.js
into the new module settings_config.js.

Extracting this module breaks some dependencies
on settings_display.js (which has some annoying
transitive dependencies, including jQuery).

In particular this isolates stream_data from
from settings_display.js.

Two of the three structures that we moved here
weren't even directly used by settings_display.js,
since we do a lot of rendering in the modules
admin.js and setting.js.

We make get_all_display_settings() a function
to avoid a require-time dependency on page_params.

Breaking the dependencies simplifies a few
node tests.

Most of the node test complexity came from the
following commit in March 2019:

5a130097bf

The commit itself seems harmless enough, but
dependencies can have a somewhat "viral" nature,
where making stream_data depend on settings_display
caused us to modify four different node tests.
2020-02-21 12:06:31 -08:00
..
analytics
…
billing
js: Convert _.contains(a, …) to a.includes(…).
2020-02-10 14:08:12 -08:00
bundles
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
portico
integrations_dev_panel: Convert loaded_fixtures from object to Map.
2020-02-12 10:39:01 -08:00
stats
stats: Convert data from object to Map.
2020-02-12 10:39:01 -08:00
types
dependencies: Upgrade stacktrace-gps from 3.0.3 to 3.0.4.
2020-02-04 22:13:33 -08:00
activity.js
channel: Don't send outgoing HTTP requests during a reload.
2020-02-13 15:45:39 -08:00
admin.js
refactor: Extract settings_config.
2020-02-21 12:06:31 -08:00
alert_words_ui.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
alert_words.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
archive.js
js: Use modern spread arguments syntax.
2020-02-11 17:43:35 -08:00
attachments_ui.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
avatar.js
…
blueslip_stacktrace.ts
dependencies: Upgrade stacktrace-gps from 3.0.3 to 3.0.4.
2020-02-04 22:13:33 -08:00
blueslip.js
channel: Don't send outgoing HTTP requests during a reload.
2020-02-13 15:45:39 -08:00
bot_data.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
buddy_data.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
buddy_list.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
channel.js
channel: Don't send outgoing HTTP requests during a reload.
2020-02-13 15:45:39 -08:00
click_handlers.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
color_data.js
…
colorspace.js
zjsunit: Use assert in strict mode.
2020-02-12 08:16:26 -05:00
common.js
common: Account for string.match returning null.
2020-02-13 16:37:52 -08:00
components.js
js: Convert _.find(a, …) to a.find(…).
2020-02-10 14:08:12 -08:00
compose_actions.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
compose_fade.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
compose_pm_pill.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
compose_state.js
util: Kill off rtrim() helper.
2020-02-15 12:20:20 -08:00
compose_ui.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
compose.js
util: Replace util.set_message_topic().
2020-02-21 09:53:45 -05:00
composebox_typeahead.js
pygments_data: Replace JS module with JSON module.
2020-02-12 10:09:12 -08:00
condense.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
confirm_dialog.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
copy_and_paste.js
upload: Replace jQuery filedrop with Uppy.
2020-02-13 16:43:19 -08:00
csrf.js
…
debug.js
debug: Convert sections from object to Map.
2020-02-12 10:39:01 -08:00
dict.ts
dict: Remove each method.
2020-02-04 12:22:03 -08:00
drafts.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
echo.js
util: Replace util.set_message_topic().
2020-02-21 09:53:45 -05:00
emoji_picker.js
emoji_picker: Convert intermediate complete_emoji_catalog to Map.
2020-02-12 10:39:01 -08:00
emoji.js
markdown: Extract emoji helpers.
2020-02-18 16:04:04 -08:00
favicon.js
…
feature_flags.js
…
feedback_widget.js
…
fenced_code.js
util: Kill off rtrim() helper.
2020-02-15 12:20:20 -08:00
fetch_status.js
…
filter.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
floating_recipient_bar.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
fold_dict.ts
dict: Remove each method.
2020-02-04 12:22:03 -08:00
gear_menu.js
gear_menu: Convert scroll_positions from object to Map.
2020-02-12 10:39:01 -08:00
global.d.ts
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
hash_util.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
hashchange.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
hbs.d.ts
…
hotkey.js
emoji_codes: Replace JS module with JSON module.
2020-02-12 10:09:12 -08:00
hotspots.js
hotspots: Convert HOTSPOT_LOCATIONS from object to Map.
2020-02-10 15:57:20 -08:00
info_overlay.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
input_pill.js
js: Convert _.find(a, …) to a.find(…).
2020-02-10 14:08:12 -08:00
int_dict.ts
dict: Remove each method.
2020-02-04 12:22:03 -08:00
integration_bot_widget.js
…
invite.js
invitations: Avoid adding to notifications stream unconditionally.
2020-01-27 15:36:59 -08:00
keydown_util.js
…
lazy_set.js
dict, lazy_set: Return an iterator from keys method.
2020-02-04 12:22:03 -08:00
lightbox_canvas.js
…
lightbox.js
lightbox: Convert asset_map from object to Map.
2020-02-12 10:39:01 -08:00
list_cursor.js
…
list_render.js
list_render: Remove unused listRenders object.
2020-02-12 10:39:01 -08:00
list_util.js
…
loading.js
…
local_message.js
local_message: Convert already_used from object to Set.
2020-02-12 10:39:01 -08:00
localstorage.js
…
markdown_config.js
markdown: Add helper configuration for mobile.
2020-02-18 16:13:38 -08:00
markdown.js
markdown: Add helper configuration for mobile.
2020-02-18 16:13:38 -08:00
message_edit.js
util: Replace util.set_message_topic().
2020-02-21 09:53:45 -05:00
message_events.js
util: Replace util.set_message_topic().
2020-02-21 09:53:45 -05:00
message_fetch.js
js: Convert remaining _.each(a, …) to a.forEach(…).
2020-02-10 14:08:12 -08:00
message_flags.js
js: Convert _.filter(a, …) to a.filter(…).
2020-02-10 14:08:12 -08:00
message_list_data.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
message_list_view.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
message_list.js
…
message_live_update.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
message_scroll.js
…
message_store.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
message_util.js
…
message_viewport.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
muting_ui.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
muting.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
narrow_state.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
narrow.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
navigate.js
…
night_mode.js
…
notifications.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
overlays.js
…
padded_widget.js
…
page_params.js
page_params: Record page_params_parse_time.
2020-01-15 12:01:14 -08:00
panels.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
people.js
markdown: Clean up userMentionHandler().
2020-02-18 16:04:12 -08:00
pm_conversations.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
pm_list_dom.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
pm_list.js
js: Convert _.contains(a, …) to a.includes(…).
2020-02-10 14:08:12 -08:00
pointer.js
…
poll_widget.js
js: Convert _.any(a, …), _.some(a, …) to a.some(…).
2020-02-10 14:08:12 -08:00
popovers.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
presence.js
presence: Re-introduce data filtering when offline.
2020-02-13 15:45:39 -08:00
reactions.js
emoji_codes: Replace JS module with JSON module.
2020-02-12 10:09:12 -08:00
ready.js
…
realm_icon.js
…
realm_logo.js
…
recent_senders.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
reload_state.js
…
reload.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
reminder.js
util: Replace util.set_message_topic().
2020-02-21 09:53:45 -05:00
resize.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
rows.js
…
rtl.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
schema.js
js: Convert _.isString to typeof.
2020-02-10 15:57:20 -08:00
scroll_bar.js
…
scroll_util.js
…
search_pill_widget.js
…
search_pill.js
…
search_suggestion.js
search_suggestion: Convert prev from object to Set.
2020-02-12 10:39:01 -08:00
search_util.js
js: Convert _.any(a, …), _.some(a, …) to a.some(…).
2020-02-10 14:08:12 -08:00
search.js
search_suggestions: Convert lookup_table from object to Map.
2020-02-12 10:39:01 -08:00
sent_messages.js
sent_messages: Convert messages from object to Map.
2020-02-12 10:39:01 -08:00
server_events_dispatch.js
refactor: Rename set_realm_filters().
2020-02-18 15:52:34 -08:00
server_events.js
channel: Don't send outgoing HTTP requests during a reload.
2020-02-13 15:45:39 -08:00
settings_account.js
settings_account: Convert all_field_template_types from object to Map.
2020-02-12 10:39:01 -08:00
settings_bots.js
js: Convert _.find(a, …) to a.find(…).
2020-02-10 14:08:12 -08:00
settings_config.js
refactor: Extract settings_config.
2020-02-21 12:06:31 -08:00
settings_display.js
refactor: Extract settings_config.
2020-02-21 12:06:31 -08:00
settings_emoji.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
settings_exports.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
settings_invites.js
settings_invites: Convert invited_as_values from object to Map.
2020-02-10 15:57:20 -08:00
settings_linkifiers.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
settings_muting.js
js: Clean up stream_id type confusion.
2020-01-16 13:23:47 -08:00
settings_notifications.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
settings_org.js
org settings: Convert for…of loop to .some.
2020-02-18 14:28:19 -08:00
settings_panel_menu.js
…
settings_profile_fields.js
settings_profile_fields: Iterate over field_types with Object.values.
2020-02-10 14:08:12 -08:00
settings_sections.js
settings_sections: Replace is_loaded Dict with loaded_groups Set.
2020-02-02 20:37:41 -08:00
settings_streams.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
settings_toggle.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
settings_ui.js
…
settings_user_groups.js
zjsunit: Use assert in strict mode.
2020-02-12 08:16:26 -05:00
settings_users.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
settings.js
refactor: Extract settings_config.
2020-02-21 12:06:31 -08:00
setup.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
starred_messages.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
stream_color.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
stream_create.js
refactor: Inline ajaxSubscribeForCreation.
2020-02-18 11:02:14 -08:00
stream_data.js
refactor: Extract settings_config.
2020-02-21 12:06:31 -08:00
stream_edit.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
stream_events.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
stream_list.js
js: Convert remaining _.each(a, …) to a.forEach(…).
2020-02-10 14:08:12 -08:00
stream_muting.js
…
stream_popover.js
…
stream_sort.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
stream_ui_updates.js
settings: Migrate to stream_post_policy structure.
2020-02-04 17:08:08 -08:00
submessage.js
js: Convert _.find(a, …) to a.find(…).
2020-02-10 14:08:12 -08:00
subs.js
subs: Convert hidden_ids from object to Map.
2020-02-12 10:39:01 -08:00
tab_bar.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
templates.js
js: Use modern spread arguments syntax.
2020-02-11 17:43:35 -08:00
tictactoe_widget.js
tictactoe_widget: Convert square_values from object to Map.
2020-02-12 10:39:01 -08:00
timerender.js
zjsunit: Use assert in strict mode.
2020-02-12 08:16:26 -05:00
todo_widget.js
js: Convert _.any(a, …), _.some(a, …) to a.some(…).
2020-02-10 14:08:12 -08:00
top_left_corner.js
top_left_corner: Don't export should_expand_pm_list().
2020-02-11 14:14:59 -08:00
topic_data.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
topic_generator.js
js: Convert _.reject(a, … => …) to a.filter(… => !…).
2020-02-10 14:08:12 -08:00
topic_list_data.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
topic_list.js
js: Convert _.map(a, …) to a.map(…).
2020-02-10 14:08:12 -08:00
topic_zoom.js
…
translations.js
…
transmit.js
util: Replace util.set_message_topic().
2020-02-21 09:53:45 -05:00
tslint.json
…
tutorial.js
…
typeahead_helper.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
typing_data.js
util.js: Remove util from window.
2020-02-15 12:20:20 -08:00
typing_events.js
people: Rename method to get_by_user_id().
2020-02-05 12:04:56 -08:00
typing.js
…
ui_init.js
markdown: Add helper configuration for mobile.
2020-02-18 16:13:38 -08:00
ui_report.js
ui_report: Fix HTML escaping of &.
2020-02-13 17:50:59 -08:00
ui_util.js
…
ui.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
unread_ops.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
unread_ui.js
topic list: Use vdom techniques.
2020-02-05 13:04:16 -08:00
unread.js
util: Replace util.get_message_topic().
2020-02-21 09:53:45 -05:00
upload_widget.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
upload.js
upload: Replace jQuery filedrop with Uppy.
2020-02-13 16:43:19 -08:00
user_events.js
people: Rename method to get_by_user_id().
2020-02-05 12:04:56 -08:00
user_groups.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
user_pill.js
js: Convert _.any(a, …), _.some(a, …) to a.some(…).
2020-02-10 14:08:12 -08:00
user_search.js
…
user_status_ui.js
…
user_status.js
user_status: Iterate over page_params.user_status with Object.entries.
2020-02-07 14:09:47 -08:00
util.js
util: Replace util.set_message_topic().
2020-02-21 09:53:45 -05:00
vdom.js
vdom: Use _.escape for correct HTML escaping.
2020-02-13 17:50:59 -08:00
widgetize.js
widgetize: Convert widget_contents from object to Map.
2020-02-06 17:24:43 -08:00
zcommand.js
js: Convert a.indexOf(…) !== -1 to a.includes(…).
2020-02-10 14:08:12 -08:00
zform.js
js: Automatically convert _.each to for…of.
2020-02-07 14:09:47 -08:00
zulip.js
…