mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 14:03:30 +00:00
This seems like a small change (apart from all the test changes), but it fundamentally changes how the app finds "topic" on message objects. Now all code that used to set "subject" now sets "topic" on message-like objects. We convert incoming messages to have topic, and we write to "topic" all the way up to hitting the server (which now accepts "topic" on incoming endpoints). We fall back to subject as needed, but the code will emit a warning that should be heeded--the "subject" field is prone to becoming stale for things like topic changes.
198 lines
5.8 KiB
JavaScript
198 lines
5.8 KiB
JavaScript
var message_store = (function () {
|
|
|
|
var exports = {};
|
|
var stored_messages = {};
|
|
|
|
exports.get = function get(message_id) {
|
|
return stored_messages[message_id];
|
|
};
|
|
|
|
exports.get_pm_emails = function (message) {
|
|
|
|
function email(user_id) {
|
|
var person = people.get_person_from_user_id(user_id);
|
|
if (!person) {
|
|
blueslip.error('Unknown user id ' + user_id);
|
|
return '?';
|
|
}
|
|
return person.email;
|
|
}
|
|
|
|
var user_ids = people.pm_with_user_ids(message);
|
|
var emails = _.map(user_ids, email).sort();
|
|
|
|
return emails.join(', ');
|
|
};
|
|
|
|
exports.get_pm_full_names = function (message) {
|
|
|
|
function name(user_id) {
|
|
var person = people.get_person_from_user_id(user_id);
|
|
if (!person) {
|
|
blueslip.error('Unknown user id ' + user_id);
|
|
return '?';
|
|
}
|
|
return person.full_name;
|
|
}
|
|
|
|
var user_ids = people.pm_with_user_ids(message);
|
|
var names = _.map(user_ids, name).sort();
|
|
|
|
return names.join(', ');
|
|
};
|
|
|
|
exports.process_message_for_recent_private_messages = function (message) {
|
|
var user_ids = people.pm_with_user_ids(message);
|
|
if (!user_ids) {
|
|
return;
|
|
}
|
|
|
|
_.each(user_ids, function (user_id) {
|
|
pm_conversations.set_partner(user_id);
|
|
});
|
|
|
|
var user_ids_string = user_ids.join(',');
|
|
|
|
pm_conversations.recent.insert(user_ids_string, message.timestamp);
|
|
};
|
|
|
|
exports.set_message_booleans = function (message) {
|
|
var flags = message.flags || [];
|
|
|
|
function convert_flag(flag_name) {
|
|
return flags.indexOf(flag_name) >= 0;
|
|
}
|
|
|
|
message.unread = !convert_flag('read');
|
|
message.historical = convert_flag('historical');
|
|
message.starred = convert_flag('starred');
|
|
message.mentioned = convert_flag('mentioned') || convert_flag('wildcard_mentioned');
|
|
message.mentioned_me_directly = convert_flag('mentioned');
|
|
message.collapsed = convert_flag('collapsed');
|
|
message.alerted = convert_flag('has_alert_word');
|
|
|
|
// Once we have set boolean flags here, the `flags` attribute is
|
|
// just a distraction, so we delete it. (All the downstream code
|
|
// uses booleans.)
|
|
delete message.flags;
|
|
|
|
};
|
|
|
|
exports.init_booleans = function (message) {
|
|
// This initializes booleans for the local-echo path where
|
|
// we don't have flags from the server yet. (We want to
|
|
// explicitly set flags to false to be consistent with other
|
|
// codepaths.)
|
|
message.unread = false;
|
|
message.historical = false;
|
|
message.starred = false;
|
|
message.mentioned = false;
|
|
message.mentioned_me_directly = false;
|
|
message.collapsed = false;
|
|
message.alerted = false;
|
|
};
|
|
|
|
exports.update_booleans = function (message, flags) {
|
|
// When we get server flags for local echo or message edits,
|
|
// we are vulnerable to race conditions, so only update flags
|
|
// that are driven by message content.
|
|
function convert_flag(flag_name) {
|
|
return flags.indexOf(flag_name) >= 0;
|
|
}
|
|
|
|
message.mentioned = convert_flag('mentioned') || convert_flag('wildcard_mentioned');
|
|
message.mentioned_me_directly = convert_flag('mentioned');
|
|
message.alerted = convert_flag('has_alert_word');
|
|
};
|
|
|
|
exports.add_message_metadata = function (message) {
|
|
var cached_msg = stored_messages[message.id];
|
|
if (cached_msg !== undefined) {
|
|
// Copy the match topic and content over if they exist on
|
|
// the new message
|
|
if (util.get_match_topic(message) !== undefined) {
|
|
util.set_match_data(cached_msg, message);
|
|
}
|
|
return cached_msg;
|
|
}
|
|
|
|
message.sent_by_me = people.is_current_user(message.sender_email);
|
|
|
|
people.extract_people_from_message(message);
|
|
people.maybe_incr_recipient_count(message);
|
|
|
|
var sender = people.get_person_from_user_id(message.sender_id);
|
|
if (sender) {
|
|
message.sender_full_name = sender.full_name;
|
|
message.sender_email = sender.email;
|
|
}
|
|
|
|
// Convert topic even for PMs, as legacy code
|
|
// wants the empty field.
|
|
util.convert_message_topic(message);
|
|
|
|
switch (message.type) {
|
|
case 'stream':
|
|
message.is_stream = true;
|
|
message.stream = message.display_recipient;
|
|
message.reply_to = message.sender_email;
|
|
|
|
topic_data.add_message({
|
|
stream_id: message.stream_id,
|
|
topic_name: util.get_message_topic(message),
|
|
message_id: message.id,
|
|
});
|
|
|
|
recent_senders.process_message_for_senders(message);
|
|
break;
|
|
|
|
case 'private':
|
|
message.is_private = true;
|
|
message.reply_to = util.normalize_recipients(
|
|
exports.get_pm_emails(message));
|
|
message.display_reply_to = exports.get_pm_full_names(message);
|
|
message.pm_with_url = people.pm_with_url(message);
|
|
message.to_user_ids = people.pm_reply_user_string(message);
|
|
|
|
exports.process_message_for_recent_private_messages(message);
|
|
break;
|
|
}
|
|
|
|
alert_words.process_message(message);
|
|
if (!message.reactions) {
|
|
message.reactions = [];
|
|
}
|
|
stored_messages[message.id] = message;
|
|
return message;
|
|
};
|
|
|
|
exports.reify_message_id = function (opts) {
|
|
var old_id = opts.old_id;
|
|
var new_id = opts.new_id;
|
|
if (pointer.furthest_read === old_id) {
|
|
pointer.furthest_read = new_id;
|
|
}
|
|
if (stored_messages[old_id]) {
|
|
stored_messages[new_id] = stored_messages[old_id];
|
|
delete stored_messages[old_id];
|
|
}
|
|
|
|
_.each([message_list.all, home_msg_list, message_list.narrowed], function (msg_list) {
|
|
if (msg_list !== undefined) {
|
|
msg_list.change_message_id(old_id, new_id);
|
|
|
|
if (msg_list.view !== undefined) {
|
|
msg_list.view.change_message_id(old_id, new_id);
|
|
}
|
|
}
|
|
});
|
|
};
|
|
|
|
return exports;
|
|
|
|
}());
|
|
if (typeof module !== 'undefined') {
|
|
module.exports = message_store;
|
|
}
|
|
window.message_store = message_store;
|