mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 22:13:26 +00:00
dcbb2a78ca
JsonableError has two major benefits over json_error: * It can be raised from anywhere in the codebase, rather than being a return value, which is much more convenient for refactoring, as one doesn't potentially need to change error handling style when extracting a bit of view code to a function. * It is guaranteed to contain the `code` property, which is helpful for API consistency. Various stragglers are not updated because JsonableError requires subclassing in order to specify custom data or HTTP status codes.
34 lines
1.0 KiB
Python
34 lines
1.0 KiB
Python
from typing import Any, Dict
|
|
|
|
from django.http import HttpRequest, HttpResponse
|
|
from django.utils.translation import gettext as _
|
|
|
|
from zerver.decorator import webhook_view
|
|
from zerver.lib.exceptions import JsonableError
|
|
from zerver.lib.request import REQ, has_request_variables
|
|
from zerver.lib.response import json_success
|
|
from zerver.lib.webhooks.common import check_send_webhook_message
|
|
from zerver.models import UserProfile
|
|
|
|
|
|
@webhook_view("IFTTT")
|
|
@has_request_variables
|
|
def api_iftt_app_webhook(
|
|
request: HttpRequest,
|
|
user_profile: UserProfile,
|
|
payload: Dict[str, Any] = REQ(argument_type="body"),
|
|
) -> HttpResponse:
|
|
topic = payload.get("topic")
|
|
content = payload.get("content")
|
|
|
|
if topic is None:
|
|
topic = payload.get("subject") # Backwards-compatibility
|
|
if topic is None:
|
|
raise JsonableError(_("Topic can't be empty"))
|
|
|
|
if content is None:
|
|
raise JsonableError(_("Content can't be empty"))
|
|
|
|
check_send_webhook_message(request, user_profile, topic, content)
|
|
return json_success()
|