mirror of
https://github.com/zulip/zulip.git
synced 2025-11-02 21:13:36 +00:00
sendfile already applied a Content-Disposition header, but the
algorithm may provide both `filename=` and `filename*=` values (which
is potentially confusing to clients) and incorrectly slash-escapes
quotes in Unicode strings.
Django provides a correct implementation, but it is only accessible to
FileResponse objects. Since the entire point is to offload the
filehandle handling, we cannot use a FileResponse.
Django 4.2 will make the function available outside of FileResponse.
Until then, extract our own Content-Disposition handling, based on
Django's.
We remove the very verbose comment added in d4360e2287, describing
Content-Disposition headers, as it does not add much.
173 lines
6.4 KiB
Python
173 lines
6.4 KiB
Python
import os
|
|
from mimetypes import guess_type
|
|
from typing import Union
|
|
from urllib.parse import quote, urlparse
|
|
|
|
from django.conf import settings
|
|
from django.contrib.auth.models import AnonymousUser
|
|
from django.core.files.uploadedfile import UploadedFile
|
|
from django.http import HttpRequest, HttpResponse, HttpResponseForbidden, HttpResponseNotFound
|
|
from django.shortcuts import redirect
|
|
from django.utils.cache import patch_cache_control
|
|
from django.utils.translation import gettext as _
|
|
from django_sendfile import sendfile
|
|
|
|
from zerver.context_processors import get_valid_realm_from_request
|
|
from zerver.lib.exceptions import JsonableError
|
|
from zerver.lib.response import json_success
|
|
from zerver.lib.upload import check_upload_within_quota, upload_message_image_from_request
|
|
from zerver.lib.upload.base import INLINE_MIME_TYPES
|
|
from zerver.lib.upload.local import (
|
|
generate_unauthed_file_access_url,
|
|
get_local_file_path,
|
|
get_local_file_path_id_from_token,
|
|
)
|
|
from zerver.lib.upload.s3 import get_signed_upload_url
|
|
from zerver.models import UserProfile, validate_attachment_request
|
|
|
|
|
|
def patch_disposition_header(response: HttpResponse, url: str, is_attachment: bool) -> None:
|
|
"""
|
|
This replicates django.utils.http.content_disposition_header's
|
|
algorithm, which is introduced in Django 4.2.
|
|
|
|
"""
|
|
# TODO: Replace this with django.utils.http.content_disposition_header when we upgrade in Django 4.2
|
|
disposition = "attachment" if is_attachment else "inline"
|
|
|
|
# Trim to only the filename part of the URL
|
|
filename = os.path.basename(urlparse(url).path)
|
|
|
|
# Content-Disposition is defined in RFC 6266:
|
|
# https://datatracker.ietf.org/doc/html/rfc6266
|
|
#
|
|
# For the 'filename' attribute of it, see RFC 8187:
|
|
# https://datatracker.ietf.org/doc/html/rfc8187
|
|
try:
|
|
# If the filename is pure-ASCII (determined by trying to
|
|
# encode it as such), then we escape slashes and quotes, and
|
|
# provide a filename="..."
|
|
filename.encode("ascii")
|
|
file_expr = 'filename="{}"'.format(filename.replace("\\", "\\\\").replace('"', r"\""))
|
|
except UnicodeEncodeError:
|
|
# If it contains non-ASCII characters, we URI-escape it and
|
|
# provide a filename*=encoding'language'value
|
|
file_expr = "filename*=utf-8''{}".format(quote(filename))
|
|
|
|
response.headers["Content-Disposition"] = f"{disposition}; {file_expr}"
|
|
|
|
|
|
def serve_s3(
|
|
request: HttpRequest, url_path: str, url_only: bool, download: bool = False
|
|
) -> HttpResponse:
|
|
url = get_signed_upload_url(url_path, download=download)
|
|
if url_only:
|
|
return json_success(request, data=dict(url=url))
|
|
|
|
return redirect(url)
|
|
|
|
|
|
def serve_local(
|
|
request: HttpRequest, path_id: str, url_only: bool, download: bool = False
|
|
) -> HttpResponse:
|
|
local_path = get_local_file_path(path_id)
|
|
if local_path is None:
|
|
return HttpResponseNotFound("<p>File not found</p>")
|
|
|
|
if url_only:
|
|
url = generate_unauthed_file_access_url(path_id)
|
|
return json_success(request, data=dict(url=url))
|
|
|
|
mimetype, encoding = guess_type(local_path)
|
|
attachment = download or mimetype not in INLINE_MIME_TYPES
|
|
|
|
response = sendfile(
|
|
request, local_path, attachment=attachment, mimetype=mimetype, encoding=encoding
|
|
)
|
|
patch_cache_control(response, private=True, immutable=True)
|
|
# sendfile adds a content-disposition header, but it incorrectly
|
|
# slash-escapes Unicode filenames; Django has a correct
|
|
# implementation, but it is not easily callable until Django 4.2.
|
|
patch_disposition_header(response, local_path, attachment)
|
|
return response
|
|
|
|
|
|
def serve_file_download_backend(
|
|
request: HttpRequest, user_profile: UserProfile, realm_id_str: str, filename: str
|
|
) -> HttpResponse:
|
|
return serve_file(request, user_profile, realm_id_str, filename, url_only=False, download=True)
|
|
|
|
|
|
def serve_file_backend(
|
|
request: HttpRequest,
|
|
maybe_user_profile: Union[UserProfile, AnonymousUser],
|
|
realm_id_str: str,
|
|
filename: str,
|
|
) -> HttpResponse:
|
|
return serve_file(request, maybe_user_profile, realm_id_str, filename, url_only=False)
|
|
|
|
|
|
def serve_file_url_backend(
|
|
request: HttpRequest, user_profile: UserProfile, realm_id_str: str, filename: str
|
|
) -> HttpResponse:
|
|
"""
|
|
We should return a signed, short-lived URL
|
|
that the client can use for native mobile download, rather than serving a redirect.
|
|
"""
|
|
|
|
return serve_file(request, user_profile, realm_id_str, filename, url_only=True)
|
|
|
|
|
|
def serve_file(
|
|
request: HttpRequest,
|
|
maybe_user_profile: Union[UserProfile, AnonymousUser],
|
|
realm_id_str: str,
|
|
filename: str,
|
|
url_only: bool = False,
|
|
download: bool = False,
|
|
) -> HttpResponse:
|
|
path_id = f"{realm_id_str}/{filename}"
|
|
realm = get_valid_realm_from_request(request)
|
|
is_authorized = validate_attachment_request(maybe_user_profile, path_id, realm)
|
|
|
|
if is_authorized is None:
|
|
return HttpResponseNotFound(_("<p>File not found.</p>"))
|
|
if not is_authorized:
|
|
return HttpResponseForbidden(_("<p>You are not authorized to view this file.</p>"))
|
|
if settings.LOCAL_UPLOADS_DIR is not None:
|
|
return serve_local(request, path_id, url_only, download=download)
|
|
|
|
return serve_s3(request, path_id, url_only, download=download)
|
|
|
|
|
|
def serve_local_file_unauthed(request: HttpRequest, token: str, filename: str) -> HttpResponse:
|
|
path_id = get_local_file_path_id_from_token(token)
|
|
if path_id is None:
|
|
raise JsonableError(_("Invalid token"))
|
|
if path_id.split("/")[-1] != filename:
|
|
raise JsonableError(_("Invalid filename"))
|
|
|
|
return serve_local(request, path_id, url_only=False)
|
|
|
|
|
|
def upload_file_backend(request: HttpRequest, user_profile: UserProfile) -> HttpResponse:
|
|
if len(request.FILES) == 0:
|
|
raise JsonableError(_("You must specify a file to upload"))
|
|
if len(request.FILES) != 1:
|
|
raise JsonableError(_("You may only upload one file at a time"))
|
|
|
|
user_file = list(request.FILES.values())[0]
|
|
assert isinstance(user_file, UploadedFile)
|
|
file_size = user_file.size
|
|
assert file_size is not None
|
|
if settings.MAX_FILE_UPLOAD_SIZE * 1024 * 1024 < file_size:
|
|
raise JsonableError(
|
|
_("Uploaded file is larger than the allowed limit of {} MiB").format(
|
|
settings.MAX_FILE_UPLOAD_SIZE,
|
|
)
|
|
)
|
|
check_upload_within_quota(user_profile.realm, file_size)
|
|
|
|
uri = upload_message_image_from_request(user_file, user_profile, file_size)
|
|
return json_success(request, data={"uri": uri})
|