mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 21:43:21 +00:00
8b12cc606a
This is a prep commit that extracts the following two methods from '/actions/scheduled_messages' to reuse in the next commit. * extract_stream_id * extract_direct_message_recipient_ids The 'to' parameter for 'POST /typing' will follow the same pattern in the next commit as we currently have for the 'to' parameter in 'POST /scheduled_messages', so we can reuse these functions.
47 lines
1.9 KiB
Python
47 lines
1.9 KiB
Python
import orjson
|
|
|
|
from zerver.lib.exceptions import JsonableError
|
|
from zerver.lib.recipient_parsing import extract_direct_message_recipient_ids, extract_stream_id
|
|
from zerver.lib.test_classes import ZulipTestCase
|
|
|
|
|
|
class TestRecipientParsing(ZulipTestCase):
|
|
def test_extract_stream_id(self) -> None:
|
|
# stream message recipient = single stream ID.
|
|
stream_id = extract_stream_id("1")
|
|
self.assertEqual(stream_id, 1)
|
|
|
|
with self.assertRaisesRegex(JsonableError, "Invalid data type for stream ID"):
|
|
extract_stream_id("1,2")
|
|
|
|
with self.assertRaisesRegex(JsonableError, "Invalid data type for stream ID"):
|
|
extract_stream_id("[1]")
|
|
|
|
with self.assertRaisesRegex(JsonableError, "Invalid data type for stream ID"):
|
|
extract_stream_id("general")
|
|
|
|
def test_extract_recipient_ids(self) -> None:
|
|
# direct message recipients = user IDs.
|
|
user_ids = "[3,2,1]"
|
|
result = sorted(extract_direct_message_recipient_ids(user_ids))
|
|
self.assertEqual(result, [1, 2, 3])
|
|
|
|
# JSON list w/duplicates
|
|
user_ids = orjson.dumps([3, 3, 12]).decode()
|
|
result = sorted(extract_direct_message_recipient_ids(user_ids))
|
|
self.assertEqual(result, [3, 12])
|
|
|
|
# Invalid data
|
|
user_ids = "1, 12"
|
|
with self.assertRaisesRegex(JsonableError, "Invalid data type for recipients"):
|
|
extract_direct_message_recipient_ids(user_ids)
|
|
|
|
user_ids = orjson.dumps(dict(recipient=12)).decode()
|
|
with self.assertRaisesRegex(JsonableError, "Invalid data type for recipients"):
|
|
extract_direct_message_recipient_ids(user_ids)
|
|
|
|
# Heterogeneous lists are not supported
|
|
user_ids = orjson.dumps([3, 4, "eeshan@example.com"]).decode()
|
|
with self.assertRaisesRegex(JsonableError, "Recipient list may only contain user IDs"):
|
|
extract_direct_message_recipient_ids(user_ids)
|