mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 22:43:42 +00:00
69730a78cc
Automatically generated by the following script, based on the output
of lint with flake8-comma:
import re
import sys
last_filename = None
last_row = None
lines = []
for msg in sys.stdin:
m = re.match(
r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg
)
if m:
filename, row_str, col_str, err = m.groups()
row, col = int(row_str), int(col_str)
if filename == last_filename:
assert last_row != row
else:
if last_filename is not None:
with open(last_filename, "w") as f:
f.writelines(lines)
with open(filename) as f:
lines = f.readlines()
last_filename = filename
last_row = row
line = lines[row - 1]
if err in ["C812", "C815"]:
lines[row - 1] = line[: col - 1] + "," + line[col - 1 :]
elif err in ["C819"]:
assert line[col - 2] == ","
lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ")
if last_filename is not None:
with open(last_filename, "w") as f:
f.writelines(lines)
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
55 lines
2.4 KiB
Python
55 lines
2.4 KiB
Python
from unittest import mock
|
|
|
|
from zerver.lib.test_classes import ZulipTestCase
|
|
from zerver.lib.redis_utils import get_redis_client, get_dict_from_redis, put_dict_in_redis, \
|
|
ZulipRedisKeyTooLongError, ZulipRedisKeyOfWrongFormatError, MAX_KEY_LENGTH
|
|
|
|
class RedisUtilsTest(ZulipTestCase):
|
|
key_format = "test_redis_utils_{token}"
|
|
expiration_seconds = 60
|
|
|
|
@classmethod
|
|
def setUpClass(cls) -> None:
|
|
cls.redis_client = get_redis_client()
|
|
return super().setUpClass()
|
|
|
|
def test_put_and_get_data(self) -> None:
|
|
data = {
|
|
"a": 1,
|
|
"b": "some value",
|
|
}
|
|
key = put_dict_in_redis(self.redis_client, self.key_format, data,
|
|
expiration_seconds=self.expiration_seconds)
|
|
retrieved_data = get_dict_from_redis(self.redis_client, self.key_format, key)
|
|
self.assertEqual(data, retrieved_data)
|
|
|
|
def test_put_data_key_length_check(self) -> None:
|
|
data = {
|
|
"a": 1,
|
|
"b": "some value",
|
|
}
|
|
|
|
max_valid_token_length = MAX_KEY_LENGTH - (len(self.key_format) - len('{token}'))
|
|
key = put_dict_in_redis(self.redis_client, self.key_format, data,
|
|
expiration_seconds=self.expiration_seconds,
|
|
token_length=max_valid_token_length)
|
|
retrieved_data = get_dict_from_redis(self.redis_client, self.key_format, key)
|
|
self.assertEqual(data, retrieved_data)
|
|
|
|
# Trying to put data under an overly long key should get stopped before even
|
|
# generating the random token.
|
|
with mock.patch("zerver.lib.redis_utils.generate_random_token") as mock_generate:
|
|
with self.assertRaises(ZulipRedisKeyTooLongError):
|
|
put_dict_in_redis(self.redis_client, self.key_format, data,
|
|
expiration_seconds=self.expiration_seconds,
|
|
token_length=max_valid_token_length + 1)
|
|
mock_generate.assert_not_called()
|
|
|
|
def test_get_data_key_length_check(self) -> None:
|
|
with self.assertRaises(ZulipRedisKeyTooLongError):
|
|
get_dict_from_redis(self.redis_client, key_format='{token}', key='A' * (MAX_KEY_LENGTH + 1))
|
|
|
|
def test_get_data_key_format_validation(self) -> None:
|
|
with self.assertRaises(ZulipRedisKeyOfWrongFormatError):
|
|
get_dict_from_redis(self.redis_client, self.key_format, 'nonmatching_format_1111')
|