zulip

mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00

Files

Anders Kaseorg 6988622fe8 ruff: Enable B023 Function definition does not bind loop variable.

Python’s loop scoping is misdesigned, resulting in a very common
gotcha for functions that close over loop variables [1].  The general
problem is so bad that even the Go developers plan to break
compatibility in order to fix the same design mistake in their
language [2].

Enable the Ruff rule function-uses-loop-variable (B023) [3], which
conservatively prohibits functions from binding loop variables at all.

[1] https://docs.python-guide.org/writing/gotchas/#late-binding-closures
[2] https://go.dev/s/loopvar-design
[3] https://beta.ruff.rs/docs/rules/function-uses-loop-variable/

Signed-off-by: Anders Kaseorg <anders@zulip.com>

2023-09-11 18:03:45 -07:00

__init__.py

…

add_mock_conversation.py

emojis: Use get_emoji_data.

2023-07-17 09:35:53 -07:00

calculate_first_visible_message_id.py

management: Fix typing for management scripts.

2021-08-20 05:54:18 -07:00

compare_messages.py

render_messages: Use JSON Lines format.

2021-05-20 13:12:16 -07:00