Files
zulip/tools/check-frontend-i18n
Anders Kaseorg 5901e7ba7e python: Convert function type annotations to Python 3 style.
Generated by com2ann (slightly patched to avoid also converting
assignment type annotations, which require Python 3.6), followed by
some manual whitespace adjustment, and six fixes for runtime issues:

-    def __init__(self, token: Token, parent: Optional[Node]) -> None:
+    def __init__(self, token: Token, parent: "Optional[Node]") -> None:

-def main(options: argparse.Namespace) -> NoReturn:
+def main(options: argparse.Namespace) -> "NoReturn":

-def fetch_request(url: str, callback: Any, **kwargs: Any) -> Generator[Callable[..., Any], Any, None]:
+def fetch_request(url: str, callback: Any, **kwargs: Any) -> "Generator[Callable[..., Any], Any, None]":

-def assert_server_running(server: subprocess.Popen[bytes], log_file: Optional[str]) -> None:
+def assert_server_running(server: "subprocess.Popen[bytes]", log_file: Optional[str]) -> None:

-def server_is_up(server: subprocess.Popen[bytes], log_file: Optional[str]) -> bool:
+def server_is_up(server: "subprocess.Popen[bytes]", log_file: Optional[str]) -> bool:

-    method_kwarg_pairs: List[FuncKwargPair],
+    method_kwarg_pairs: "List[FuncKwargPair]",

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-18 20:42:48 -07:00

52 lines
1.5 KiB
Python
Executable File

#!/usr/bin/env python3
from typing import List
# check for the venv
from lib import sanity_check
sanity_check.check_venv(__file__)
import argparse
import json
import os
import sys
import subprocess
sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
from scripts.lib.zulip_tools import WARNING, FAIL, ENDC
def find_handlebars(translatable_strings: List[str]) -> List[str]:
errored = []
for string in translatable_strings:
if '{{' in string:
errored.append(string)
return errored
if __name__ == '__main__':
parser = argparse.ArgumentParser()
parser.add_argument('--no-generate',
action='store_true', dest='no_generate', default=False,
help="Don't run makemessages command.")
args = parser.parse_args()
if not args.no_generate:
subprocess.call(['./manage.py', 'makemessages', '--locale', 'en'],
stderr=subprocess.STDOUT)
with open('locale/en/translations.json') as f:
data = json.load(f)
found = find_handlebars(list(data.keys()))
if not found:
sys.exit(0)
print(WARNING + "Translation strings contain handlebars:" + ENDC)
print('\n'.join(found))
print(WARNING +
"See https://zulip.readthedocs.io/en/latest/translating/translating.html#frontend-translations "
"on how you can insert variables in the frontend translatable "
"strings." +
ENDC)
print(FAIL + "Failed!" + ENDC)
sys.exit(1)