mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 21:43:21 +00:00
b369177341
It helps to avoid creating unintended savepoints in the future. This is as a part of our plan to explicitly mark all the transaction.atomic calls with either 'savepoint=False' or 'durable=True' as required.
83 lines
3.2 KiB
Python
83 lines
3.2 KiB
Python
# Documented in https://zulip.readthedocs.io/en/latest/subsystems/queuing.html
|
|
import logging
|
|
import time
|
|
from collections.abc import Mapping
|
|
from types import FrameType
|
|
from typing import Any
|
|
|
|
from django.db import transaction
|
|
from typing_extensions import override
|
|
|
|
from zerver.actions.message_edit import do_update_embedded_data
|
|
from zerver.actions.message_send import render_incoming_message
|
|
from zerver.lib.url_preview import preview as url_preview
|
|
from zerver.lib.url_preview.types import UrlEmbedData
|
|
from zerver.models import Message, Realm
|
|
from zerver.worker.base import InterruptConsumeError, QueueProcessingWorker, assign_queue
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
@assign_queue("embed_links")
|
|
class FetchLinksEmbedData(QueueProcessingWorker):
|
|
# This is a slow queue with network requests, so a disk write is negligible.
|
|
# Update stats file after every consume call.
|
|
CONSUME_ITERATIONS_BEFORE_UPDATE_STATS_NUM = 1
|
|
|
|
@override
|
|
def consume(self, event: Mapping[str, Any]) -> None:
|
|
url_embed_data: dict[str, UrlEmbedData | None] = {}
|
|
for url in event["urls"]:
|
|
start_time = time.time()
|
|
url_embed_data[url] = url_preview.get_link_embed_data(url)
|
|
logging.info(
|
|
"Time spent on get_link_embed_data for %s: %s", url, time.time() - start_time
|
|
)
|
|
|
|
# Ideally, we should use `durable=True` here. However, in the
|
|
# `test_message_update_race_condition` test, this function is not called
|
|
# as the outermost transaction. As a result, it's acceptable to make an
|
|
# exception and not use `durable=True` in this case.
|
|
#
|
|
# For more details on why the `consume` method is called directly in tests, see:
|
|
# https://zulip.readthedocs.io/en/latest/subsystems/queuing.html#publishing-events-into-a-queue
|
|
with transaction.atomic(savepoint=False):
|
|
try:
|
|
message = Message.objects.select_for_update().get(id=event["message_id"])
|
|
except Message.DoesNotExist:
|
|
# Message may have been deleted
|
|
return
|
|
|
|
# If the message changed, we will run this task after updating the message
|
|
# in zerver.actions.message_edit.check_update_message
|
|
if message.content != event["message_content"]:
|
|
return
|
|
|
|
# Fetch the realm whose settings we're using for rendering
|
|
realm = Realm.objects.get(id=event["message_realm_id"])
|
|
|
|
# If rendering fails, the called code will raise a JsonableError.
|
|
rendering_result = render_incoming_message(
|
|
message,
|
|
message.content,
|
|
realm,
|
|
url_embed_data=url_embed_data,
|
|
)
|
|
do_update_embedded_data(message.sender, message, rendering_result)
|
|
|
|
@override
|
|
def timer_expired(
|
|
self, limit: int, events: list[dict[str, Any]], signal: int, frame: FrameType | None
|
|
) -> None:
|
|
assert len(events) == 1
|
|
event = events[0]
|
|
|
|
logging.warning(
|
|
"Timed out in %s after %s seconds while fetching URLs for message %s: %s",
|
|
self.queue_name,
|
|
limit,
|
|
event["message_id"],
|
|
event["urls"],
|
|
)
|
|
raise InterruptConsumeError
|