mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 22:13:26 +00:00
4a8074000c
In tools/commit-msg line 9:
if [ $(grep '^[^#]' .git/COMMIT_EDITMSG --count) -ne 0 ]; then
^-- SC2046: Quote this to prevent word splitting.
In tools/commit-msg line 10:
lint_cmd="cd ~/zulip && cat \"$1\" | python -m gitlint.cli"
^-- SC2089: Quotes/backslashes will be treated literally. Use an array.
In tools/commit-msg line 11:
if [ -z "$VIRTUAL_ENV" ] && `which vagrant > /dev/null` && [ -e .vagrant ]; then
^-- SC2092: Remove backticks to avoid executing output.
^-- SC2006: Use $(..) instead of legacy `..`.
^-- SC2230: which is non-standard. Use builtin 'command -v' instead.
In tools/commit-msg line 14:
$lint_cmd
^-- SC2090: Quotes/backslashes in this variable will not be respected.
In tools/commit-msg line 17:
if [ $? -ne 0 ]; then
^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
23 lines
631 B
Bash
Executable File
23 lines
631 B
Bash
Executable File
#!/bin/bash
|
|
|
|
# This hook runs gitlint on your commit message.
|
|
|
|
# If your machine contains a provisioned Zulip development environment, the
|
|
# linter will be invoked through `vagrant ssh`.
|
|
|
|
# Do not invoke gitlint if commit message is empty
|
|
if grep -q '^[^#]' "$1"; then
|
|
lint_cmd="cd ~/zulip && python -m gitlint.cli"
|
|
if \
|
|
if [ -z "$VIRTUAL_ENV" ] && command -v vagrant > /dev/null && [ -e .vagrant ]; then
|
|
! vagrant ssh -c "$lint_cmd"
|
|
else
|
|
! eval "$lint_cmd"
|
|
fi < "$1"
|
|
then
|
|
echo "WARNING: Your commit message does not match Zulip's style guide."
|
|
fi
|
|
fi
|
|
|
|
exit 0
|