mirror of
https://github.com/zulip/zulip.git
synced 2025-11-16 20:02:15 +00:00
504ec9d489
For historical reasons we were creating Recipient objects at some point in the typing-notifications codepath. Now we just work with UserProfiles. This removes some queries, as indicated by the change to `len(queries)` in a couple of the tests. The one subtle thing that changes here is huddles. If user 10 sends a typing notification that they are talking to users 20 and 30, there might not actually be a huddle for users 10/20/30, but we were actually creating huddles on the fly! There is no need to create huddles just for typing notifications, since we don't even share huddle ids with our clients. The clients just infer the huddles. Some of the code that gets killed off here as somewhat "collateral damage" is some defensive code related to formerly supporting streams in typing indicators. The support for streams was killed off almost as soon as we released the feature, and the codepath is pretty clearly user-centric at this point.