Varun Singh 50e0f336f0 settings_streams: Fix error thrown when adding 'default-channels'. ...

The 'Select channel' dropdown in 'Add default channels' modal is
the LAST dropdown element on the modal and it does not contain
`data-stream-id` attribute.

.attr('data-stream-id') would return undefined for this element
and as a result the returned `Set` would have its last element a
`NaN` --- passing a `NaN` inside 'data' field of 'channel.post' threw
an error.

We tweaked the selector string to selectively map over the elements with
'data-stream-id' attribute.
Also we removed '.toString()' converting stream-id to a string (stream-id is a
'number' type).

2024-05-30 10:53:19 -07:00

..

lib

eslint: Outsmart formatjs/enforce-default-message.

2024-05-26 19:20:10 -07:00

templates

popovers: Add hotkey hints support via a new handlebar template.

2024-04-11 15:57:24 -07:00

activity.test.js

web: Convert .data("search-results-empty") to .attr.

2024-05-03 12:45:46 -07:00

alert_words_ui.test.js

node tests: Use noop helper function pattern in test files.

2023-12-14 14:51:33 -08:00

alert_words.test.js

alert_words: Highlight overlapping alert words more accurately.

2024-03-19 11:20:16 -07:00

blueslip_stacktrace.test.js

upload: Convert module to TypeScript.

2024-05-15 10:53:09 -07:00

bot_data.test.js

models: Extract zerver.models.users.

2023-12-16 22:08:44 -08:00

browser_history.test.js

…

buddy_data.test.js

compose fade users: Remove fade logic in favor of buddy list split.

2024-02-22 16:05:27 -08:00

buddy_list.test.js

typos: Fix typos caught by mwic.

2024-05-20 13:55:00 -07:00

channel.test.js

channel: Use base_page_params.

2024-02-27 21:18:00 -05:00

color_data.test.js

…

common.test.js

common: Remove copy_data_attribute_value.

2024-05-03 12:45:46 -07:00

components.test.js

components: Convert .data("tab-id") to .attr.

2024-05-03 12:45:46 -07:00

compose_actions.test.js

compose_reply: Convert module to TypeScript.

2024-05-15 10:53:09 -07:00

compose_closed_ui.test.js

message_list: Only update selected id and banner for current list.

2024-05-03 12:42:22 -07:00

compose_fade.test.js

compose fade users: Remove fade logic in favor of buddy list split.

2024-02-22 16:05:27 -08:00

compose_pm_pill.test.js

…

compose_state.test.js

stream picker: Remove stream colorblock.

2024-03-15 11:11:04 -07:00

compose_ui.test.js

compose_ui: Add message_type to ComposeTriggeredOptions.

2024-04-02 17:26:12 -07:00

compose_validate.test.js

web: Convert .data("user-id") to .attr.

2024-05-03 12:45:46 -07:00

compose_video.test.js

upload: Don't render upload button instead of hiding.

2024-05-14 12:21:49 -07:00

compose.test.js

upload: Don't render upload button instead of hiding.

2024-05-14 12:21:49 -07:00

composebox_typeahead.test.js

composebox_typeahead: Convert module to typescript.

2024-05-16 14:53:26 -07:00

copy_and_paste.test.js

turndown: Enable turndown in production.

2024-03-28 13:07:34 -07:00

deprecated_feature_notice.test.js

…

dispatch_subs.test.js

tests: Replace unneeded override_rewire uses by whole-module mocks.

2024-03-15 17:29:47 -04:00

dispatch.test.js

message_helper: Convert module to typescript.

2024-05-29 16:45:36 -07:00

drafts.test.js

draft: Only auto-restore drafts edited since adding the feature.

2024-04-20 13:27:25 -07:00

echo.test.js

message_list: Don't always cache "Combined feed" view.

2024-04-25 09:20:43 -07:00

emoji_picker.test.js

…

emoji.test.js

…

example1.test.js

docs: Add missing spaces around code spans.

2023-12-14 00:05:44 -08:00

example2.test.js

message_helper: Be more explicit about converting subject to topic.

2024-05-29 16:45:36 -07:00

example3.test.js

narrow_state: Use message_lists.current to return current filter.

2024-02-24 08:31:18 -08:00

example4.test.js

user_profile: Update the profile tab after editing.

2024-05-28 14:34:57 -07:00

example5.test.js

message_helper: Convert module to typescript.

2024-05-29 16:45:36 -07:00

example6.test.js

node tests: Use noop helper function pattern in test files.

2023-12-14 14:51:33 -08:00

example7.test.js

message_list: Don't always cache "Combined feed" view.

2024-04-25 09:20:43 -07:00

example8.test.js

narrow_state: Use message_lists.current to return current filter.

2024-02-24 08:31:18 -08:00

fenced_code.test.js

…

fetch_status.test.js

…

filter.test.js

filter: Fix combined feed navigating to muted unread message.

2024-05-23 09:17:40 -07:00

fold_dict.test.js

…

gear_menu_util.test.js

page_params: Split out state data for realm.

2024-02-15 10:22:52 -08:00

hash_util.test.js

hash_parser: Add utility function to dynamically detect hash.

2024-05-17 10:47:22 -07:00

hashchange.test.js

narrow: Rename save_narrow.

2024-05-20 15:01:48 -07:00

hotkey.test.js

onboarding_steps: Remove hotspot as an onboarding_step.

2024-05-10 12:30:22 -07:00

i18n.test.js

popovers: Rename actions_popover.hbs.

2024-05-20 09:10:36 -07:00

input_pill.test.js

input_pill: Add test for input event handler.

2024-05-20 09:13:26 -07:00

internal_url.test.js

…

keydown_util.test.js

…

lazy_set.test.js

…

left_sidebar_navigation_area.test.js

filter: Remove incorrect check for All messages view.

2024-01-15 12:26:24 -08:00

linkifiers.test.js

…

list_cursor.test.js

node tests: Use noop helper function pattern in test files.

2023-12-14 14:51:33 -08:00

list_widget.test.js

list_widget: Convert .data("sort"), .data("sort-prop") to .attr.

2024-05-03 12:45:46 -07:00

markdown_parse.test.js

markdown: Remove wrapper around get_topic_links.

2024-02-01 12:12:06 -08:00

markdown.test.js

mentions: Add "channel" as a wildcard mention.

2024-04-04 11:16:07 -07:00

message_edit.test.js

page_params: Split out state data for realm.

2024-02-15 10:22:52 -08:00

message_events.test.js

message_helper: Convert module to typescript.

2024-05-29 16:45:36 -07:00

message_flags.test.js

web-narrow: Update operators to use channel and channels.

2024-04-24 17:03:36 -07:00

message_list_data.test.js

user_topics: Always store stream name in UserTopic.

2024-03-30 16:25:34 -07:00

message_list_view.test.js

eslint: Fix no-jquery/no-append-html errors that need test changes.

2024-04-04 10:11:57 -07:00

message_list.test.js

message_list: Remove nth_most_recent_id.

2024-05-23 18:56:59 -07:00

message_store.test.js

message_helper: Convert module to typescript.

2024-05-29 16:45:36 -07:00

muted_users.test.js

…

narrow_activate.test.js

narrow: Add 'more topics' state to browser history.

2024-05-28 12:09:57 -07:00

narrow_local.test.js

filter: Make excludes_muted_topics a method of the Filter class.

2024-02-24 08:31:18 -08:00

narrow_state.test.js

narrow_state: Remove narrowed_to_topic function.

2024-05-24 10:24:16 -07:00

narrow_unread.test.js

narrow_state: Use message_lists.current to return current filter.

2024-02-24 08:31:18 -08:00

narrow.test.js

web-narrow: Update operators to use channel and channels.

2024-04-24 17:03:36 -07:00

navbar_alerts.test.js

page_params: Split out state data for realm.

2024-02-15 10:22:52 -08:00

notifications.test.js

ui_util: Fix HTML injection bug in replace_emoji_with_text.

2024-04-03 13:11:47 -07:00

password.test.js

password_quality: Convert .data("minLength") et al. to .attr.

2024-05-03 12:45:46 -07:00

peer_data.test.js

page_params: Split out state data for current user.

2024-02-15 10:22:52 -08:00

people_errors.test.js

people: Remove string type for user_id.

2024-01-19 17:54:07 -08:00

people.test.js

people: Split search terms inside the search function.

2024-05-16 09:20:43 -07:00

pill_typeahead.test.js

bootstrap_typeahead: Remove fixed argument.

2024-05-08 10:05:27 -07:00

pm_conversations.test.js

…

pm_list_data.test.js

pm_list: Show DM row for empty conversations in left sidebar.

2024-04-17 17:51:12 -07:00

pm_list.test.js

pm_list: Remove not needed narrow_state mock.

2024-01-18 08:31:48 -08:00

poll_widget.test.js

widgets: Cache event handler instead of entire jquery for each widget.

2024-05-08 16:47:07 -07:00

popover_menus_data.test.js

actions_popover: Rename "View message source".

2024-04-11 15:57:24 -07:00

presence.test.js

page_params: Split out state data for realm.

2024-02-15 10:22:52 -08:00

reactions.test.js

message_helper: Set clean reactions when processing the raw message.

2024-05-29 16:45:36 -07:00

realm_playground.test.js

pygments_data: Move data to typescript.

2024-01-24 17:06:03 -08:00

recent_senders.test.js

message_util: Convert module to typescript.

2024-01-05 10:47:12 -08:00

recent_view.test.js

recent_view: Rename filters_should_hide_topic.

2024-05-16 09:20:43 -07:00

reload_state.test.js

…

reload.test.js

node tests: Use noop helper function pattern in test files.

2023-12-14 14:51:33 -08:00

rendered_markdown.test.js

rendered_markdown: Fix code getting copied when visiting playground.

2024-05-06 15:50:39 -07:00

resolved_topic.test.js

…

rtl.test.js

…

scheduled_messages.test.js

compose_send_menu_popover: Rename module to reflect broader uses.

2024-04-20 13:27:25 -07:00

scroll_util.test.js

…

search_suggestion.test.js

web-search-suggestions: Update to use channel and channels.

2024-04-24 17:03:36 -07:00

search.test.js

bootstrap_typeahead: Remove create and lookup API.

2024-05-06 15:02:45 -07:00

server_events.test.js

server_events: Fix infinite loading indicator on page load.

2024-05-16 09:10:07 -07:00

settings_bots.test.js

page_params: Split out state data for realm.

2024-02-15 10:22:52 -08:00

settings_config.test.js

web-stream-settings: Update strings for stream rename channel.

2024-04-24 14:35:04 -07:00

settings_data.test.js

page_params: Split out state data for realm.

2024-02-15 10:22:52 -08:00

settings_emoji.test.js

…

settings_muted_users.test.js

node tests: Use noop helper function pattern in test files.

2023-12-14 14:51:33 -08:00

settings_org.test.js

settings: Do not scroll to save button when typing in textarea / input.

2024-04-10 11:18:17 -07:00

settings_profile_fields.test.js

settings_profile_fields: Convert Module to TypeScript.

2024-05-20 11:17:58 -07:00

settings_realm_domains.test.js

settings_realm_domains: Fix implicit use of any.

2024-05-03 15:39:55 -07:00

settings_user_topics.test.js

settings_user_topics: Fix implicit use of any.

2024-05-03 15:39:55 -07:00

spoilers.test.js

rendered_markdown: Convert module to typescript.

2024-01-19 17:54:07 -08:00

starred_messages.test.js

…

stream_create_subscribers_data.test.js

page_params: Split out state data for current user.

2024-02-15 10:22:52 -08:00

stream_data.test.js

settings_streams: Fix error thrown when adding 'default-channels'.

2024-05-30 10:53:19 -07:00

stream_edit.test.js

…

stream_events.test.js

streams-settings: Update ID of overlay container element.

2024-04-30 14:44:12 -07:00

stream_list_sort.test.js

left_sidebar: Add colon : to the list of stream word separators.

2024-05-03 09:20:53 -07:00

stream_list.test.js

eslint: Fix no-jquery/no-append-html errors that need test changes.

2024-04-04 10:11:57 -07:00

stream_pill.test.js

…

stream_search.test.js

stream_list: Convert module to typescript.

2024-02-23 16:18:48 -08:00

stream_settings_ui.test.js

streams: Close color picker when scrolling stream settings.

2024-05-15 17:22:03 -07:00

stream_topic_history.test.js

node tests: Use noop helper function pattern in test files.

2023-12-14 14:51:33 -08:00

submessage.test.js

submessage: Replace bogus test data with valid objects.

2024-03-28 12:59:12 -07:00

support.test.js

support: Fix implicit use of any.

2024-05-03 15:39:55 -07:00

templates.test.js

hotkeys: Show Level 2 Shift key symbol for Shift key in popovers.

2024-04-11 15:57:24 -07:00

time_zone_util.test.js

time_zone_util: Avoid relying on timeZoneName: "longOffset".

2023-11-29 09:57:10 -08:00

timerender.test.js

message_row: Assign inner .date_row span a class.

2024-04-30 12:42:41 -07:00

topic_generator.test.js

topic_generator: Convert module to typescript.

2024-01-28 14:20:45 -08:00

topic_list_data.test.js

topic_list: Show topic row for empty conversations in left sidebar.

2024-04-17 17:51:12 -07:00

transmit.test.js

message_list: Don't always cache "Combined feed" view.

2024-04-25 09:20:43 -07:00

typeahead_helper.test.js

composebox_typeahead: Convert module to typescript.

2024-05-16 14:53:26 -07:00

typeahead.test.js

typeahead: Add option for word order not mattering for query matching.

2024-03-22 15:20:40 -07:00

typing_data.test.js

settings: Add option to disable seeing typing notifications.

2024-04-16 11:38:12 -07:00

typing_events.test.js

narrow_state: Use message_lists.current to return current filter.

2024-02-24 08:31:18 -08:00

typing_status.test.js

typing_status: Use TypeScript unions for 'Recipient' type.

2024-02-07 09:12:49 -08:00

ui_util.test.js

notifications: Collapse blockquotes and "user said" paragraphs.

2024-01-30 17:22:20 -08:00

unread.test.js

user_topics: Always store stream name in UserTopic.

2024-03-30 16:25:34 -07:00

upload.test.js

upload: Convert module to TypeScript.

2024-05-15 10:53:09 -07:00

user_events.test.js

user_profile: Update the profile tab after editing.

2024-05-28 14:34:57 -07:00

user_group_pill.test.js

settings: Refactor UserGroupPill to improve consistency.

2024-05-17 10:47:22 -07:00

user_groups.test.js

group-settings: Handle invalid urls correctly.

2024-02-22 13:09:33 -08:00

user_pill.test.js

pill_typeahead: Differentiate between pills with type attribute.

2024-04-17 10:45:14 -07:00

user_search.test.js

web: Convert .data("search-results-empty") to .attr.

2024-05-03 12:45:46 -07:00

user_status.test.js

emoji: Restrict reaction_type for compatibility with typeahead.Emoji.

2024-05-16 14:51:28 -07:00

user_topics.test.js

user_topics: Always store stream name in UserTopic.

2024-03-30 16:25:34 -07:00

util.test.js

mentions: Add "channel" as a wildcard mention.

2024-04-04 11:16:07 -07:00

vdom.test.js

eslint: Fix no-jquery/no-append-html errors that need test changes.

2024-04-04 10:11:57 -07:00

watchdog.test.js

…

widgetize.test.js

widgets: Cache event handler instead of entire jquery for each widget.

2024-05-08 16:47:07 -07:00

zblueslip.test.js

…

zjquery.test.js

…