mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	And convert the corresponding function expressions to arrow style
while we’re here.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);
for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;
  recast.visit(ast, {
    visitCallExpression(path) {
      const { callee, arguments: args } = path.node;
      if (
        n.MemberExpression.check(callee) &&
        !callee.computed &&
        n.Identifier.check(callee.object) &&
        callee.object.name === "_" &&
        n.Identifier.check(callee.property) &&
        callee.property.name === "map" &&
        args.length === 2 &&
        checkExpression(args[0]) &&
        checkExpression(args[1])
      ) {
        const [arr, fn] = args;
        path.replace(
          b.callExpression(b.memberExpression(arr, b.identifier("map")), [
            n.FunctionExpression.check(fn) ||
            n.ArrowFunctionExpression.check(fn)
              ? b.arrowFunctionExpression(
                  fn.params,
                  n.BlockStatement.check(fn.body) &&
                    fn.body.body.length === 1 &&
                    n.ReturnStatement.check(fn.body.body[0])
                    ? fn.body.body[0].argument || b.identifier("undefined")
                    : fn.body
                )
              : fn,
          ])
        );
        changed = true;
      }
      this.traverse(path);
    },
  });
  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
		
	
		
			
				
	
	
		
			243 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			243 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
const IntDict = require('./int_dict').IntDict;
 | 
						|
const FoldDict = require('./fold_dict').FoldDict;
 | 
						|
 | 
						|
const stream_dict = new IntDict(); // stream_id -> topic_history object
 | 
						|
const fetched_stream_ids = new Set();
 | 
						|
 | 
						|
exports.is_complete_for_stream_id = (stream_id) => {
 | 
						|
    if (fetched_stream_ids.has(stream_id)) {
 | 
						|
        return true;
 | 
						|
    }
 | 
						|
 | 
						|
    /*
 | 
						|
        TODO: We should possibly move all_topics_in_cache
 | 
						|
        from stream_data to here, since the function
 | 
						|
        mostly looks at message_list.all and has little
 | 
						|
        to do with typical stream_data stuff.  (We just
 | 
						|
        need sub.first_message_id.)
 | 
						|
    */
 | 
						|
    const sub = stream_data.get_sub_by_id(stream_id);
 | 
						|
    const in_cache = stream_data.all_topics_in_cache(sub);
 | 
						|
 | 
						|
    if (in_cache) {
 | 
						|
        /*
 | 
						|
            If the stream is cached, we can add it to
 | 
						|
            fetched_stream_ids.  Note that for the opposite
 | 
						|
            scenario, we don't delete from
 | 
						|
            fetched_stream_ids, because we may just be
 | 
						|
            waiting for the initial message fetch.
 | 
						|
        */
 | 
						|
        fetched_stream_ids.add(stream_id);
 | 
						|
    }
 | 
						|
 | 
						|
    return in_cache;
 | 
						|
};
 | 
						|
 | 
						|
exports.stream_has_topics = function (stream_id) {
 | 
						|
    if (!stream_dict.has(stream_id)) {
 | 
						|
        return false;
 | 
						|
    }
 | 
						|
 | 
						|
    const history = stream_dict.get(stream_id);
 | 
						|
 | 
						|
    return history.has_topics();
 | 
						|
};
 | 
						|
 | 
						|
exports.topic_history = function (stream_id) {
 | 
						|
    /*
 | 
						|
        Each stream has a dictionary of topics.
 | 
						|
        The main getter of this object is
 | 
						|
        get_recent_names, and we just sort on
 | 
						|
        the fly every time we are called.
 | 
						|
    */
 | 
						|
 | 
						|
    const topics = new FoldDict();
 | 
						|
 | 
						|
    const self = {};
 | 
						|
 | 
						|
    self.has_topics = function () {
 | 
						|
        return topics.size !== 0;
 | 
						|
    };
 | 
						|
 | 
						|
    self.add_or_update = function (opts) {
 | 
						|
        const name = opts.name;
 | 
						|
        let message_id = opts.message_id || 0;
 | 
						|
 | 
						|
        message_id = parseInt(message_id, 10);
 | 
						|
 | 
						|
        const existing = topics.get(name);
 | 
						|
 | 
						|
        if (!existing) {
 | 
						|
            topics.set(opts.name, {
 | 
						|
                message_id: message_id,
 | 
						|
                pretty_name: name,
 | 
						|
                historical: false,
 | 
						|
                count: 1,
 | 
						|
            });
 | 
						|
            return;
 | 
						|
        }
 | 
						|
 | 
						|
        if (!existing.historical) {
 | 
						|
            existing.count += 1;
 | 
						|
        }
 | 
						|
 | 
						|
        if (message_id > existing.message_id) {
 | 
						|
            existing.message_id = message_id;
 | 
						|
            existing.pretty_name = name;
 | 
						|
        }
 | 
						|
    };
 | 
						|
 | 
						|
    self.maybe_remove = function (topic_name) {
 | 
						|
        const existing = topics.get(topic_name);
 | 
						|
 | 
						|
        if (!existing) {
 | 
						|
            return;
 | 
						|
        }
 | 
						|
 | 
						|
        if (existing.historical) {
 | 
						|
            // We can't trust that a topic rename applied to
 | 
						|
            // the entire history of historical topic, so we
 | 
						|
            // will always leave it in the sidebar.
 | 
						|
            return;
 | 
						|
        }
 | 
						|
 | 
						|
        if (existing.count <= 1) {
 | 
						|
            topics.delete(topic_name);
 | 
						|
            return;
 | 
						|
        }
 | 
						|
 | 
						|
        existing.count -= 1;
 | 
						|
    };
 | 
						|
 | 
						|
    self.add_history = function (server_history) {
 | 
						|
        // This method populates historical topics from the
 | 
						|
        // server.  We have less data about these than the
 | 
						|
        // client can maintain for newer topics.
 | 
						|
 | 
						|
        for (const obj of server_history) {
 | 
						|
            const name = obj.name;
 | 
						|
            const message_id = obj.max_id;
 | 
						|
 | 
						|
            const existing = topics.get(name);
 | 
						|
 | 
						|
            if (existing) {
 | 
						|
                if (!existing.historical) {
 | 
						|
                    // Trust out local data more, since it
 | 
						|
                    // maintains counts.
 | 
						|
                    continue;
 | 
						|
                }
 | 
						|
            }
 | 
						|
 | 
						|
            // If we get here, we are either finding out about
 | 
						|
            // the topic for the first time, or we are getting
 | 
						|
            // more current data for it.
 | 
						|
 | 
						|
            topics.set(name, {
 | 
						|
                message_id: message_id,
 | 
						|
                pretty_name: name,
 | 
						|
                historical: true,
 | 
						|
            });
 | 
						|
        }
 | 
						|
    };
 | 
						|
 | 
						|
    self.get_recent_names = function () {
 | 
						|
        const my_recents = Array.from(topics.values());
 | 
						|
 | 
						|
        const missing_topics = unread.get_missing_topics({
 | 
						|
            stream_id: stream_id,
 | 
						|
            topic_dict: topics,
 | 
						|
        });
 | 
						|
 | 
						|
        const recents = my_recents.concat(missing_topics);
 | 
						|
 | 
						|
        recents.sort(function (a, b) {
 | 
						|
            return b.message_id - a.message_id;
 | 
						|
        });
 | 
						|
 | 
						|
        const names = recents.map(obj => obj.pretty_name);
 | 
						|
 | 
						|
        return names;
 | 
						|
    };
 | 
						|
 | 
						|
    return self;
 | 
						|
};
 | 
						|
 | 
						|
exports.remove_message = function (opts) {
 | 
						|
    const stream_id = opts.stream_id;
 | 
						|
    const name = opts.topic_name;
 | 
						|
    const history = stream_dict.get(stream_id);
 | 
						|
 | 
						|
    // This is the special case of "removing" a message from
 | 
						|
    // a topic, which happens when we edit topics.
 | 
						|
 | 
						|
    if (!history) {
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    // This is the normal case of an incoming message.
 | 
						|
    history.maybe_remove(name);
 | 
						|
};
 | 
						|
 | 
						|
exports.find_or_create = function (stream_id) {
 | 
						|
    let history = stream_dict.get(stream_id);
 | 
						|
 | 
						|
    if (!history) {
 | 
						|
        history = exports.topic_history(stream_id);
 | 
						|
        stream_dict.set(stream_id, history);
 | 
						|
    }
 | 
						|
 | 
						|
    return history;
 | 
						|
};
 | 
						|
 | 
						|
exports.add_message = function (opts) {
 | 
						|
    const stream_id = opts.stream_id;
 | 
						|
    const message_id = opts.message_id;
 | 
						|
    const name = opts.topic_name;
 | 
						|
 | 
						|
    const history = exports.find_or_create(stream_id);
 | 
						|
 | 
						|
    history.add_or_update({
 | 
						|
        name: name,
 | 
						|
        message_id: message_id,
 | 
						|
    });
 | 
						|
};
 | 
						|
 | 
						|
exports.add_history = function (stream_id, server_history) {
 | 
						|
    const history = exports.find_or_create(stream_id);
 | 
						|
    history.add_history(server_history);
 | 
						|
    fetched_stream_ids.add(stream_id);
 | 
						|
};
 | 
						|
 | 
						|
exports.get_server_history = function (stream_id, on_success) {
 | 
						|
    if (fetched_stream_ids.has(stream_id)) {
 | 
						|
        on_success();
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    const url = '/json/users/me/' + stream_id + '/topics';
 | 
						|
 | 
						|
    channel.get({
 | 
						|
        url: url,
 | 
						|
        data: {},
 | 
						|
        success: function (data) {
 | 
						|
            const server_history = data.topics;
 | 
						|
            exports.add_history(stream_id, server_history);
 | 
						|
            on_success();
 | 
						|
        },
 | 
						|
    });
 | 
						|
};
 | 
						|
 | 
						|
exports.get_recent_names = function (stream_id) {
 | 
						|
    const history = exports.find_or_create(stream_id);
 | 
						|
 | 
						|
    return history.get_recent_names();
 | 
						|
};
 | 
						|
 | 
						|
exports.reset = function () {
 | 
						|
    // This is only used by tests.
 | 
						|
    stream_dict.clear();
 | 
						|
    fetched_stream_ids.clear();
 | 
						|
};
 | 
						|
 | 
						|
window.topic_data = exports;
 |