mirror of
https://github.com/zulip/zulip.git
synced 2025-10-31 20:13:46 +00:00
9986e41999
The following elements in the top left corner
are major components of our app:
All messages
Private messages
Starred messages
Mentions
We can now find them directly:
$('.top_left_all_messages')
$('.top_left_private_messages')
$('.top_left_starred_messages')
$('.top_left_mentions')
Before this, we had to build up complicated selectors
like below:
exports.get_global_filter_li = function (filter_name) {
var selector = "#global_filters li[data-name='"
+ filter_name + "']";
return $(selector);
};
I don't think any newbie would know to grep for "global_filter",
and I've seen a PR where somebody added specific markup here
to "Private messages" because they couldn't grok the old scheme.
Another thing to note is that we still have a "home-link"
class for "All messages", which overlapped with portico
code that had the same name. (There were some inaccurate
comments in the code relating to the tab bar, but we don't
actually have a way to click to the home view in the tab
bar any more.) I'll eliminate that cruft in another commit.
For this commit the four elements still have the
"global-filter" class, since there's some benefit to being
able to style them all as a group, although we should give
it a nicer name in a subsequent commit.
Most of this PR is basic search/replace, but I did add a
two-line helper: `top_left_corner.update_starred_count`
120 lines
3.2 KiB
JavaScript
120 lines
3.2 KiB
JavaScript
var top_left_corner = (function () {
|
|
|
|
var exports = {};
|
|
|
|
exports.update_count_in_dom = function (unread_count_elem, count) {
|
|
var count_span = unread_count_elem.find('.count');
|
|
var value_span = count_span.find('.value');
|
|
|
|
if (count === 0) {
|
|
count_span.hide();
|
|
value_span.text('');
|
|
return;
|
|
}
|
|
|
|
count_span.show();
|
|
value_span.text(count);
|
|
};
|
|
|
|
exports.update_starred_count = function (count) {
|
|
var starred_li = $('.top_left_starred_messages');
|
|
exports.update_count_in_dom(starred_li, count);
|
|
};
|
|
|
|
exports.update_dom_with_unread_counts = function (counts) {
|
|
// Note that "Private messages" counts are handled in pm_list.js.
|
|
|
|
// mentioned/home have simple integer counts
|
|
var mentioned_li = $('.top_left_mentions');
|
|
var home_li = $('.top_left_all_messages');
|
|
|
|
exports.update_count_in_dom(mentioned_li, counts.mentioned_message_count);
|
|
exports.update_count_in_dom(home_li, counts.home_unread_messages);
|
|
|
|
unread_ui.animate_mention_changes(mentioned_li,
|
|
counts.mentioned_message_count);
|
|
};
|
|
|
|
function deselect_top_left_corner_items() {
|
|
function remove(elem) {
|
|
elem.removeClass('active-filter active-sub-filter');
|
|
}
|
|
|
|
remove($('.top_left_all_messages'));
|
|
remove($('.top_left_private_messages'));
|
|
remove($('.top_left_starred_messages'));
|
|
remove($('.top_left_mentions'));
|
|
}
|
|
|
|
exports.handle_narrow_activated = function (filter) {
|
|
deselect_top_left_corner_items();
|
|
|
|
var ops;
|
|
var filter_name;
|
|
var filter_li;
|
|
|
|
// TODO: handle confused filters like "in:all stream:foo"
|
|
ops = filter.operands('in');
|
|
if (ops.length >= 1) {
|
|
filter_name = ops[0];
|
|
if (filter_name === 'home') {
|
|
filter_li = $('.top_left_all_messages');
|
|
filter_li.addClass('active-filter');
|
|
}
|
|
}
|
|
ops = filter.operands('is');
|
|
if (ops.length >= 1) {
|
|
filter_name = ops[0];
|
|
if (filter_name === 'starred') {
|
|
filter_li = $('.top_left_starred_messages');
|
|
filter_li.addClass('active-filter');
|
|
} else if (filter_name === 'mentioned') {
|
|
filter_li = $('.top_left_mentions');
|
|
filter_li.addClass('active-filter');
|
|
}
|
|
}
|
|
|
|
if (exports.should_expand_pm_list(filter)) {
|
|
var op_pm = filter.operands('pm-with');
|
|
pm_list.expand(op_pm);
|
|
} else {
|
|
pm_list.close();
|
|
}
|
|
};
|
|
|
|
exports.should_expand_pm_list = function (filter) {
|
|
var op_is = filter.operands('is');
|
|
|
|
if (op_is.length >= 1 && _.contains(op_is, "private")) {
|
|
return true;
|
|
}
|
|
|
|
var op_pm = filter.operands('pm-with');
|
|
|
|
if (op_pm.length !== 1) {
|
|
return false;
|
|
}
|
|
|
|
var emails_strings = op_pm[0];
|
|
var emails = emails_strings.split(',');
|
|
|
|
var has_valid_emails = people.is_valid_bulk_emails_for_compose(emails);
|
|
|
|
return has_valid_emails;
|
|
};
|
|
|
|
exports.handle_narrow_deactivated = function () {
|
|
deselect_top_left_corner_items();
|
|
pm_list.close();
|
|
|
|
var filter_li = $('.top_left_all_messages');
|
|
filter_li.addClass('active-filter');
|
|
};
|
|
|
|
return exports;
|
|
}());
|
|
if (typeof module !== 'undefined') {
|
|
module.exports = top_left_corner;
|
|
}
|
|
window.top_left_corner = top_left_corner;
|