Files
zulip/static/js/settings_display.js
Anders Kaseorg 02511bff1c js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
  n.Statement.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;
  let inLoop = false;
  let replaceReturn = false;

  const visitLoop = (...args: string[]) =>
    function(this: Context, path: NodePath) {
      for (const arg of args) {
        this.visit(path.get(arg));
      }
      const old = { inLoop };
      inLoop = true;
      this.visit(path.get("body"));
      inLoop = old.inLoop;
      return false;
    };

  recast.visit(ast, {
    visitDoWhileStatement: visitLoop("test"),

    visitExpressionStatement(path) {
      const { expression, comments } = path.node;
      let valueOnly;
      if (
        n.CallExpression.check(expression) &&
        n.MemberExpression.check(expression.callee) &&
        !expression.callee.computed &&
        n.Identifier.check(expression.callee.object) &&
        expression.callee.object.name === "_" &&
        n.Identifier.check(expression.callee.property) &&
        ["each", "forEach"].includes(expression.callee.property.name) &&
        [2, 3].includes(expression.arguments.length) &&
        checkExpression(expression.arguments[0]) &&
        (n.FunctionExpression.check(expression.arguments[1]) ||
          n.ArrowFunctionExpression.check(expression.arguments[1])) &&
        [1, 2].includes(expression.arguments[1].params.length) &&
        n.Identifier.check(expression.arguments[1].params[0]) &&
        ((valueOnly = expression.arguments[1].params[1] === undefined) ||
          n.Identifier.check(expression.arguments[1].params[1])) &&
        (expression.arguments[2] === undefined ||
          n.ThisExpression.check(expression.arguments[2]))
      ) {
        const old = { inLoop, replaceReturn };
        inLoop = false;
        replaceReturn = true;
        this.visit(
          path
            .get("expression")
            .get("arguments")
            .get(1)
            .get("body")
        );
        inLoop = old.inLoop;
        replaceReturn = old.replaceReturn;

        const [right, { body, params }] = expression.arguments;
        const loop = b.forOfStatement(
          b.variableDeclaration("let", [
            b.variableDeclarator(
              valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
            ),
          ]),
          valueOnly
            ? right
            : b.callExpression(
                b.memberExpression(right, b.identifier("entries")),
                []
              ),
          checkStatement(body) ? body : b.expressionStatement(body)
        );
        loop.comments = comments;
        path.replace(loop);
        changed = true;
      }
      this.traverse(path);
    },

    visitForStatement: visitLoop("init", "test", "update"),

    visitForInStatement: visitLoop("left", "right"),

    visitForOfStatement: visitLoop("left", "right"),

    visitFunction(path) {
      this.visit(path.get("params"));
      const old = { replaceReturn };
      replaceReturn = false;
      this.visit(path.get("body"));
      replaceReturn = old.replaceReturn;
      return false;
    },

    visitReturnStatement(path) {
      if (replaceReturn) {
        assert(!inLoop); // could use labeled continue if this ever fires
        const { argument, comments } = path.node;
        if (argument === null) {
          const s = b.continueStatement();
          s.comments = comments;
          path.replace(s);
        } else {
          const s = b.expressionStatement(argument);
          s.comments = comments;
          path.replace(s, b.continueStatement());
        }
        return false;
      }
      this.traverse(path);
    },

    visitWhileStatement: visitLoop("test"),
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-07 14:09:47 -08:00

211 lines
7.1 KiB
JavaScript

const meta = {
loaded: false,
};
function change_display_setting(data, status_element, success_msg, sticky) {
const $status_el = $(status_element);
const status_is_sticky = $status_el.data('is_sticky');
const display_message = status_is_sticky ? $status_el.data('sticky_msg') : success_msg;
const opts = {
success_msg: display_message,
sticky: status_is_sticky || sticky,
};
if (sticky) {
$status_el.data('is_sticky', true);
$status_el.data('sticky_msg', success_msg);
}
settings_ui.do_settings_change(channel.patch, '/json/settings/display', data, status_element, opts);
}
exports.demote_inactive_streams_values = {
automatic: {
code: 1,
description: i18n.t("Automatic"),
},
always: {
code: 2,
description: i18n.t("Always"),
},
never: {
code: 3,
description: i18n.t("Never"),
},
};
exports.twenty_four_hour_time_values = {
twenty_four_hour_clock: {
value: true,
description: i18n.t("24-hour clock (17:00)"),
},
twelve_hour_clock: {
value: false,
description: i18n.t("12-hour clock (5:00 PM)"),
},
};
exports.all_display_settings = {
settings: {
user_display_settings: [
"dense_mode",
"night_mode",
"high_contrast_mode",
"left_side_userlist",
"starred_message_counts",
"fluid_layout_width",
],
},
render_only: {
high_contrast_mode: page_params.development_environment,
dense_mode: page_params.development_environment,
},
};
exports.set_up = function () {
meta.loaded = true;
$("#display-settings-status").hide();
$("#user_timezone").val(page_params.timezone);
$("#demote_inactive_streams").val(page_params.demote_inactive_streams);
$("#twenty_four_hour_time").val(JSON.stringify(page_params.twenty_four_hour_time));
$(".emojiset_choice[value=" + page_params.emojiset + "]").prop("checked", true);
$("#default_language_modal [data-dismiss]").click(function () {
overlays.close_modal('default_language_modal');
});
for (const setting of exports.all_display_settings.settings.user_display_settings) {
$("#" + setting).change(function () {
const data = {};
data[setting] = JSON.stringify($(this).prop('checked'));
if (["left_side_userlist"].indexOf(setting) > -1) {
change_display_setting(
data,
"#display-settings-status",
i18n.t("Saved. Please <a class='reload_link'>reload</a> for the change to take effect."), true);
} else {
change_display_setting(data, "#display-settings-status");
}
});
}
$("#default_language_modal .language").click(function (e) {
e.preventDefault();
e.stopPropagation();
overlays.close_modal('default_language_modal');
const $link = $(e.target).closest("a[data-code]");
const setting_value = $link.attr('data-code');
const data = {default_language: JSON.stringify(setting_value)};
const new_language = $link.attr('data-name');
$('#default_language_name').text(new_language);
change_display_setting(data, '#language-settings-status',
i18n.t("Saved. Please <a class='reload_link'>reload</a> for the change to take effect."), true);
});
$('#default_language').on('click', function (e) {
e.preventDefault();
e.stopPropagation();
overlays.open_modal('default_language_modal');
});
$('#demote_inactive_streams').change(function () {
const data = {demote_inactive_streams: this.value};
change_display_setting(data, '#display-settings-status');
});
$('body').on('click', '.reload_link', function () {
window.location.reload();
});
$("#twenty_four_hour_time").change(function () {
const data = {twenty_four_hour_time: this.value};
change_display_setting(data, '#time-settings-status');
});
$("#user_timezone").change(function () {
const data = {timezone: JSON.stringify(this.value)};
change_display_setting(data, '#time-settings-status');
});
$(".emojiset_choice").click(function () {
const data = {emojiset: JSON.stringify($(this).val())};
const current_emojiset = JSON.stringify(page_params.emojiset);
if (current_emojiset === data.emojiset) {
return;
}
const spinner = $("#emoji-settings-status").expectOne();
loading.make_indicator(spinner, {text: settings_ui.strings.saving });
channel.patch({
url: '/json/settings/display',
data: data,
success: function () {
},
error: function (xhr) {
ui_report.error(settings_ui.strings.failure, xhr, $('#emoji-settings-status').expectOne());
},
});
});
$("#translate_emoticons").change(function () {
const data = {translate_emoticons: JSON.stringify(this.checked)};
change_display_setting(data, '#emoji-settings-status');
});
};
exports.report_emojiset_change = function () {
// TODO: Clean up how this works so we can use
// change_display_setting. The challenge is that we don't want to
// report success before the server_events request returns that
// causes the actual sprite sheet to change. The current
// implementation is wrong, though, in that it displays the UI
// update in all active browser windows.
function emoji_success() {
if ($("#emoji-settings-status").length) {
loading.destroy_indicator($("#emojiset_spinner"));
$("#emojiset_select").val(page_params.emojiset);
ui_report.success(i18n.t("Emojiset changed successfully!"),
$('#emoji-settings-status').expectOne());
const spinner = $("#emoji-settings-status").expectOne();
settings_ui.display_checkmark(spinner);
}
}
let emojiset = page_params.emojiset;
if (page_params.emojiset === 'text') {
// For `text` emojiset we fallback to `google-blob` emojiset
// for displaying emojis in emoji picker and typeahead.
emojiset = 'google-blob';
}
const sprite = new Image();
sprite.onload = function () {
const sprite_css_href = "/static/generated/emoji/" + emojiset + "-sprite.css";
$("#emoji-spritesheet").attr('href', sprite_css_href);
emoji_success();
};
sprite.src = "/static/generated/emoji/sheet-" + emojiset + "-64.png";
};
exports.update_page = function () {
$("#left_side_userlist").prop('checked', page_params.left_side_userlist);
$("#default_language_name").text(page_params.default_language_name);
$("#translate_emoticons").prop('checked', page_params.translate_emoticons);
$("#night_mode").prop('checked', page_params.night_mode);
$("#twenty_four_hour_time").val(JSON.stringify(page_params.twenty_four_hour_time));
// TODO: Set emojiset selector here.
// Longer term, we'll want to automate this function
};
window.settings_display = exports;