Files
zulip/static/js/topic_data.js
Anders Kaseorg 02511bff1c js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
  n.Statement.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;
  let inLoop = false;
  let replaceReturn = false;

  const visitLoop = (...args: string[]) =>
    function(this: Context, path: NodePath) {
      for (const arg of args) {
        this.visit(path.get(arg));
      }
      const old = { inLoop };
      inLoop = true;
      this.visit(path.get("body"));
      inLoop = old.inLoop;
      return false;
    };

  recast.visit(ast, {
    visitDoWhileStatement: visitLoop("test"),

    visitExpressionStatement(path) {
      const { expression, comments } = path.node;
      let valueOnly;
      if (
        n.CallExpression.check(expression) &&
        n.MemberExpression.check(expression.callee) &&
        !expression.callee.computed &&
        n.Identifier.check(expression.callee.object) &&
        expression.callee.object.name === "_" &&
        n.Identifier.check(expression.callee.property) &&
        ["each", "forEach"].includes(expression.callee.property.name) &&
        [2, 3].includes(expression.arguments.length) &&
        checkExpression(expression.arguments[0]) &&
        (n.FunctionExpression.check(expression.arguments[1]) ||
          n.ArrowFunctionExpression.check(expression.arguments[1])) &&
        [1, 2].includes(expression.arguments[1].params.length) &&
        n.Identifier.check(expression.arguments[1].params[0]) &&
        ((valueOnly = expression.arguments[1].params[1] === undefined) ||
          n.Identifier.check(expression.arguments[1].params[1])) &&
        (expression.arguments[2] === undefined ||
          n.ThisExpression.check(expression.arguments[2]))
      ) {
        const old = { inLoop, replaceReturn };
        inLoop = false;
        replaceReturn = true;
        this.visit(
          path
            .get("expression")
            .get("arguments")
            .get(1)
            .get("body")
        );
        inLoop = old.inLoop;
        replaceReturn = old.replaceReturn;

        const [right, { body, params }] = expression.arguments;
        const loop = b.forOfStatement(
          b.variableDeclaration("let", [
            b.variableDeclarator(
              valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
            ),
          ]),
          valueOnly
            ? right
            : b.callExpression(
                b.memberExpression(right, b.identifier("entries")),
                []
              ),
          checkStatement(body) ? body : b.expressionStatement(body)
        );
        loop.comments = comments;
        path.replace(loop);
        changed = true;
      }
      this.traverse(path);
    },

    visitForStatement: visitLoop("init", "test", "update"),

    visitForInStatement: visitLoop("left", "right"),

    visitForOfStatement: visitLoop("left", "right"),

    visitFunction(path) {
      this.visit(path.get("params"));
      const old = { replaceReturn };
      replaceReturn = false;
      this.visit(path.get("body"));
      replaceReturn = old.replaceReturn;
      return false;
    },

    visitReturnStatement(path) {
      if (replaceReturn) {
        assert(!inLoop); // could use labeled continue if this ever fires
        const { argument, comments } = path.node;
        if (argument === null) {
          const s = b.continueStatement();
          s.comments = comments;
          path.replace(s);
        } else {
          const s = b.expressionStatement(argument);
          s.comments = comments;
          path.replace(s, b.continueStatement());
        }
        return false;
      }
      this.traverse(path);
    },

    visitWhileStatement: visitLoop("test"),
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-07 14:09:47 -08:00

245 lines
6.2 KiB
JavaScript

const IntDict = require('./int_dict').IntDict;
const FoldDict = require('./fold_dict').FoldDict;
const stream_dict = new IntDict(); // stream_id -> topic_history object
const fetched_stream_ids = new Set();
exports.is_complete_for_stream_id = (stream_id) => {
if (fetched_stream_ids.has(stream_id)) {
return true;
}
/*
TODO: We should possibly move all_topics_in_cache
from stream_data to here, since the function
mostly looks at message_list.all and has little
to do with typical stream_data stuff. (We just
need sub.first_message_id.)
*/
const sub = stream_data.get_sub_by_id(stream_id);
const in_cache = stream_data.all_topics_in_cache(sub);
if (in_cache) {
/*
If the stream is cached, we can add it to
fetched_stream_ids. Note that for the opposite
scenario, we don't delete from
fetched_stream_ids, because we may just be
waiting for the initial message fetch.
*/
fetched_stream_ids.add(stream_id);
}
return in_cache;
};
exports.stream_has_topics = function (stream_id) {
if (!stream_dict.has(stream_id)) {
return false;
}
const history = stream_dict.get(stream_id);
return history.has_topics();
};
exports.topic_history = function (stream_id) {
/*
Each stream has a dictionary of topics.
The main getter of this object is
get_recent_names, and we just sort on
the fly every time we are called.
*/
const topics = new FoldDict();
const self = {};
self.has_topics = function () {
return topics.size !== 0;
};
self.add_or_update = function (opts) {
const name = opts.name;
let message_id = opts.message_id || 0;
message_id = parseInt(message_id, 10);
const existing = topics.get(name);
if (!existing) {
topics.set(opts.name, {
message_id: message_id,
pretty_name: name,
historical: false,
count: 1,
});
return;
}
if (!existing.historical) {
existing.count += 1;
}
if (message_id > existing.message_id) {
existing.message_id = message_id;
existing.pretty_name = name;
}
};
self.maybe_remove = function (topic_name) {
const existing = topics.get(topic_name);
if (!existing) {
return;
}
if (existing.historical) {
// We can't trust that a topic rename applied to
// the entire history of historical topic, so we
// will always leave it in the sidebar.
return;
}
if (existing.count <= 1) {
topics.delete(topic_name);
return;
}
existing.count -= 1;
};
self.add_history = function (server_history) {
// This method populates historical topics from the
// server. We have less data about these than the
// client can maintain for newer topics.
for (const obj of server_history) {
const name = obj.name;
const message_id = obj.max_id;
const existing = topics.get(name);
if (existing) {
if (!existing.historical) {
// Trust out local data more, since it
// maintains counts.
continue;
}
}
// If we get here, we are either finding out about
// the topic for the first time, or we are getting
// more current data for it.
topics.set(name, {
message_id: message_id,
pretty_name: name,
historical: true,
});
}
};
self.get_recent_names = function () {
const my_recents = Array.from(topics.values());
const missing_topics = unread.get_missing_topics({
stream_id: stream_id,
topic_dict: topics,
});
const recents = my_recents.concat(missing_topics);
recents.sort(function (a, b) {
return b.message_id - a.message_id;
});
const names = _.map(recents, function (obj) {
return obj.pretty_name;
});
return names;
};
return self;
};
exports.remove_message = function (opts) {
const stream_id = opts.stream_id;
const name = opts.topic_name;
const history = stream_dict.get(stream_id);
// This is the special case of "removing" a message from
// a topic, which happens when we edit topics.
if (!history) {
return;
}
// This is the normal case of an incoming message.
history.maybe_remove(name);
};
exports.find_or_create = function (stream_id) {
let history = stream_dict.get(stream_id);
if (!history) {
history = exports.topic_history(stream_id);
stream_dict.set(stream_id, history);
}
return history;
};
exports.add_message = function (opts) {
const stream_id = opts.stream_id;
const message_id = opts.message_id;
const name = opts.topic_name;
const history = exports.find_or_create(stream_id);
history.add_or_update({
name: name,
message_id: message_id,
});
};
exports.add_history = function (stream_id, server_history) {
const history = exports.find_or_create(stream_id);
history.add_history(server_history);
fetched_stream_ids.add(stream_id);
};
exports.get_server_history = function (stream_id, on_success) {
if (fetched_stream_ids.has(stream_id)) {
on_success();
return;
}
const url = '/json/users/me/' + stream_id + '/topics';
channel.get({
url: url,
data: {},
success: function (data) {
const server_history = data.topics;
exports.add_history(stream_id, server_history);
on_success();
},
});
};
exports.get_recent_names = function (stream_id) {
const history = exports.find_or_create(stream_id);
return history.get_recent_names();
};
exports.reset = function () {
// This is only used by tests.
stream_dict.clear();
fetched_stream_ids.clear();
};
window.topic_data = exports;