mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 22:43:42 +00:00
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
194 lines
5.5 KiB
JavaScript
194 lines
5.5 KiB
JavaScript
exports.eq_array = (a, b, eq) => {
|
|
if (a === b) {
|
|
// either both are undefined, or they
|
|
// are referentially equal
|
|
return true;
|
|
}
|
|
|
|
if (a === undefined || b === undefined) {
|
|
return false;
|
|
}
|
|
|
|
if (a.length !== b.length) {
|
|
return false;
|
|
}
|
|
|
|
return _.all(a, (item, i) => {
|
|
return eq(item, b[i]);
|
|
});
|
|
};
|
|
|
|
exports.ul = (opts) => {
|
|
return {
|
|
tag_name: 'ul',
|
|
opts: opts,
|
|
};
|
|
};
|
|
|
|
exports.render_tag = (tag) => {
|
|
/*
|
|
This renders a tag into a string. It will
|
|
automatically escape attributes, but it's your
|
|
responsibility to make sure keyed_nodes provide
|
|
a `render` method that escapes HTML properly.
|
|
(One option is to use templates.)
|
|
|
|
Do NOT call this method directly, except for
|
|
testing. The vdom scheme expects you to use
|
|
the `update` method.
|
|
*/
|
|
const opts = tag.opts;
|
|
const tag_name = tag.tag_name;
|
|
const attr_str = _.map(opts.attrs, (attr) => {
|
|
return ' ' + attr[0] + '="' + util.escape_html(attr[1]) + '"';
|
|
}).join('');
|
|
|
|
const start_tag = '<' + tag_name + attr_str + '>';
|
|
const end_tag = '</' + tag_name + '>';
|
|
|
|
if (opts.keyed_nodes === undefined) {
|
|
blueslip.error("We need keyed_nodes to render innards.");
|
|
return;
|
|
}
|
|
|
|
const innards = _.map(opts.keyed_nodes, (node) => {
|
|
return node.render();
|
|
}).join('\n');
|
|
return start_tag + '\n' + innards + '\n' + end_tag;
|
|
};
|
|
|
|
exports.update = (replace_content, find, new_dom, old_dom) => {
|
|
/*
|
|
The update method allows you to continually
|
|
update a "virtual" representation of your DOM,
|
|
and then this method actually updates the
|
|
real DOM using jQuery. The caller will pass
|
|
in a method called `replace_content` that will replace
|
|
the entire html and a method called `find` to
|
|
find the existing DOM for more surgical updates.
|
|
|
|
The first "update" will be more like a create,
|
|
because your `old_dom` should be undefined.
|
|
After that initial call, it is important that
|
|
you always pass in a correct value of `old_dom`;
|
|
otherwise, things will be incredibly confusing.
|
|
|
|
The basic scheme here is simple:
|
|
|
|
1) If old_dom is undefined, we render
|
|
everything for the first time.
|
|
|
|
2) If the keys of your new children are no
|
|
longer the same order as the old
|
|
children, then we just render
|
|
everything anew.
|
|
(We may refine this in the future.)
|
|
|
|
3) If your key structure remains the same,
|
|
then we update your child nodes on
|
|
a child-by-child basis, and we avoid
|
|
updates where the data had remained
|
|
the same.
|
|
|
|
The key to making this all work is that
|
|
`new_dom` should include a `keyed_nodes` option
|
|
where each `keyed_node` has a `key` and supports
|
|
these methods:
|
|
|
|
eq - can compare itself to similar nodes
|
|
for data equality
|
|
|
|
render - can create an HTML representation
|
|
of itself
|
|
|
|
The `new_dom` should generally be created with
|
|
something like `vdom.ul`, which will set a
|
|
tag field internally and which will want options
|
|
like `attrs` for attributes.
|
|
|
|
For examples of creating vdom objects, look at
|
|
`pm_list_dom.js`.
|
|
*/
|
|
function do_full_update() {
|
|
const rendered_dom = exports.render_tag(new_dom);
|
|
replace_content(rendered_dom);
|
|
}
|
|
|
|
if (old_dom === undefined) {
|
|
do_full_update();
|
|
return;
|
|
}
|
|
|
|
const new_opts = new_dom.opts;
|
|
const old_opts = old_dom.opts;
|
|
|
|
if (new_opts.keyed_nodes === undefined) {
|
|
// We generally want to use vdom on lists, and
|
|
// adding keys for childrens lets us avoid unnecessary
|
|
// redraws (or lets us know we should just rebuild
|
|
// the dom).
|
|
blueslip.error("We need keyed_nodes for updates.");
|
|
return;
|
|
}
|
|
|
|
const same_structure = exports.eq_array(
|
|
new_opts.keyed_nodes,
|
|
old_opts.keyed_nodes,
|
|
(a, b) => a.key === b.key
|
|
);
|
|
|
|
if (!same_structure) {
|
|
/* We could do something smarter like detecting row
|
|
moves, but it's overkill for small lists.
|
|
*/
|
|
do_full_update();
|
|
return;
|
|
}
|
|
|
|
/*
|
|
DO "QUICK" UPDATES:
|
|
|
|
We've gotten this far, so we know we have the
|
|
same overall structure for our parent tag, and
|
|
the only thing left to do with our child nodes
|
|
is to possibly update them in place (via jQuery).
|
|
We will only update nodes whose data has changed.
|
|
*/
|
|
|
|
const child_elems = find().children();
|
|
|
|
for (const [i, new_node] of new_opts.keyed_nodes.entries()) {
|
|
const old_node = old_opts.keyed_nodes[i];
|
|
if (new_node.eq(old_node)) {
|
|
continue;
|
|
}
|
|
const rendered_dom = new_node.render();
|
|
child_elems.eq(i).replaceWith(rendered_dom);
|
|
}
|
|
|
|
exports.update_attrs(
|
|
find(),
|
|
new_opts.attrs,
|
|
old_opts.attrs
|
|
);
|
|
};
|
|
|
|
exports.update_attrs = (elem, new_attrs, old_attrs) => {
|
|
const new_dict = new Map(new_attrs);
|
|
const old_dict = new Map(old_attrs);
|
|
|
|
for (const [k, v] of new_attrs) {
|
|
if (v !== old_dict.get(k)) {
|
|
elem.attr(k, v);
|
|
}
|
|
}
|
|
|
|
for (const [k] of old_attrs) {
|
|
if (!new_dict.has(k)) {
|
|
elem.removeAttr(k);
|
|
}
|
|
}
|
|
};
|
|
|
|
window.vdom = exports;
|