Files
zulip/static/js/poll_widget.js
Anders Kaseorg 02511bff1c js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
  n.Statement.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;
  let inLoop = false;
  let replaceReturn = false;

  const visitLoop = (...args: string[]) =>
    function(this: Context, path: NodePath) {
      for (const arg of args) {
        this.visit(path.get(arg));
      }
      const old = { inLoop };
      inLoop = true;
      this.visit(path.get("body"));
      inLoop = old.inLoop;
      return false;
    };

  recast.visit(ast, {
    visitDoWhileStatement: visitLoop("test"),

    visitExpressionStatement(path) {
      const { expression, comments } = path.node;
      let valueOnly;
      if (
        n.CallExpression.check(expression) &&
        n.MemberExpression.check(expression.callee) &&
        !expression.callee.computed &&
        n.Identifier.check(expression.callee.object) &&
        expression.callee.object.name === "_" &&
        n.Identifier.check(expression.callee.property) &&
        ["each", "forEach"].includes(expression.callee.property.name) &&
        [2, 3].includes(expression.arguments.length) &&
        checkExpression(expression.arguments[0]) &&
        (n.FunctionExpression.check(expression.arguments[1]) ||
          n.ArrowFunctionExpression.check(expression.arguments[1])) &&
        [1, 2].includes(expression.arguments[1].params.length) &&
        n.Identifier.check(expression.arguments[1].params[0]) &&
        ((valueOnly = expression.arguments[1].params[1] === undefined) ||
          n.Identifier.check(expression.arguments[1].params[1])) &&
        (expression.arguments[2] === undefined ||
          n.ThisExpression.check(expression.arguments[2]))
      ) {
        const old = { inLoop, replaceReturn };
        inLoop = false;
        replaceReturn = true;
        this.visit(
          path
            .get("expression")
            .get("arguments")
            .get(1)
            .get("body")
        );
        inLoop = old.inLoop;
        replaceReturn = old.replaceReturn;

        const [right, { body, params }] = expression.arguments;
        const loop = b.forOfStatement(
          b.variableDeclaration("let", [
            b.variableDeclarator(
              valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
            ),
          ]),
          valueOnly
            ? right
            : b.callExpression(
                b.memberExpression(right, b.identifier("entries")),
                []
              ),
          checkStatement(body) ? body : b.expressionStatement(body)
        );
        loop.comments = comments;
        path.replace(loop);
        changed = true;
      }
      this.traverse(path);
    },

    visitForStatement: visitLoop("init", "test", "update"),

    visitForInStatement: visitLoop("left", "right"),

    visitForOfStatement: visitLoop("left", "right"),

    visitFunction(path) {
      this.visit(path.get("params"));
      const old = { replaceReturn };
      replaceReturn = false;
      this.visit(path.get("body"));
      replaceReturn = old.replaceReturn;
      return false;
    },

    visitReturnStatement(path) {
      if (replaceReturn) {
        assert(!inLoop); // could use labeled continue if this ever fires
        const { argument, comments } = path.node;
        if (argument === null) {
          const s = b.continueStatement();
          s.comments = comments;
          path.replace(s);
        } else {
          const s = b.expressionStatement(argument);
          s.comments = comments;
          path.replace(s, b.continueStatement());
        }
        return false;
      }
      this.traverse(path);
    },

    visitWhileStatement: visitLoop("test"),
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-07 14:09:47 -08:00

372 lines
10 KiB
JavaScript

const render_widgets_poll_widget = require('../templates/widgets/poll_widget.hbs');
const render_widgets_poll_widget_results = require('../templates/widgets/poll_widget_results.hbs');
exports.poll_data_holder = function (is_my_poll, question, options) {
// This object just holds data for a poll, although it
// works closely with the widget's concept of how data
// should be represented for rendering, plus how the
// server sends us data.
const self = {};
const me = people.my_current_user_id();
let poll_question = question;
const key_to_option = new Map();
let my_idx = 1;
let input_mode = is_my_poll; // for now
self.set_question = function (new_question) {
input_mode = false;
poll_question = new_question;
};
self.get_question = function () {
return poll_question;
};
self.set_input_mode = function () {
input_mode = true;
};
self.clear_input_mode = function () {
input_mode = false;
};
self.get_input_mode = function () {
return input_mode;
};
if (question) {
self.set_question(question);
}
self.get_widget_data = function () {
const options = [];
for (const [key, obj] of key_to_option) {
const voters = Array.from(obj.votes.keys());
const current_user_vote = _.contains(voters, me);
options.push({
option: obj.option,
names: people.safe_full_names(voters),
count: voters.length,
key: key,
current_user_vote: current_user_vote,
});
}
const widget_data = {
options: options,
question: poll_question,
};
return widget_data;
};
self.handle = {
new_option: {
outbound: function (option) {
const event = {
type: 'new_option',
idx: my_idx,
option: option,
};
my_idx += 1;
return event;
},
inbound: function (sender_id, data) {
const idx = data.idx;
const key = sender_id + ',' + idx;
const option = data.option;
const votes = new Map();
key_to_option.set(key, {
option: option,
user_id: sender_id,
votes: votes,
});
if (my_idx <= idx) {
my_idx = idx + 1;
}
},
},
question: {
outbound: function (question) {
const event = {
type: 'question',
question: question,
};
if (is_my_poll) {
return event;
}
return;
},
inbound: function (sender_id, data) {
self.set_question(data.question);
},
},
vote: {
outbound: function (key) {
let vote = 1;
// toggle
if (key_to_option.get(key).votes.get(me)) {
vote = -1;
}
const event = {
type: 'vote',
key: key,
vote: vote,
};
return event;
},
inbound: function (sender_id, data) {
const key = data.key;
const vote = data.vote;
const option = key_to_option.get(key);
if (option === undefined) {
blueslip.warn('unknown key for poll: ' + key);
return;
}
const votes = option.votes;
if (vote === 1) {
votes.set(sender_id, 1);
} else {
votes.delete(sender_id);
}
},
},
};
self.handle_event = function (sender_id, data) {
const type = data.type;
if (self.handle[type]) {
self.handle[type].inbound(sender_id, data);
}
};
// function to check whether option already exists
self.is_option_present = function (data, latest_option) {
return _.any(data, function (el) {
return el.option === latest_option;
});
};
// function to add all options added along with the /poll command
for (const [i, option] of options.entries()) {
self.handle.new_option.inbound('canned', {
idx: i,
option: option,
});
}
return self;
};
exports.activate = function (opts) {
const elem = opts.elem;
const callback = opts.callback;
let question = '';
let options = [];
if (opts.extra_data) {
question = opts.extra_data.question || '';
options = opts.extra_data.options || [];
}
const is_my_poll = people.is_my_user_id(opts.message.sender_id);
const poll_data = exports.poll_data_holder(is_my_poll, question, options);
function update_edit_controls() {
const has_question = elem.find('input.poll-question').val().trim() !== '';
elem.find('button.poll-question-check').toggle(has_question);
}
function render_question() {
const question = poll_data.get_question();
const input_mode = poll_data.get_input_mode();
const can_edit = is_my_poll && !input_mode;
const has_question = question.trim() !== '';
const can_vote = has_question;
const waiting = !is_my_poll && !has_question;
const author_help = is_my_poll && !has_question;
elem.find('.poll-question-header').toggle(!input_mode);
elem.find('.poll-question-header').text(question);
elem.find('.poll-edit-question').toggle(can_edit);
update_edit_controls();
elem.find('.poll-question-bar').toggle(input_mode);
elem.find('.poll-option-bar').toggle(can_vote);
elem.find('.poll-please-wait').toggle(waiting);
elem.find('.poll-author-help').toggle(author_help);
}
function start_editing() {
poll_data.set_input_mode();
const question = poll_data.get_question();
elem.find('input.poll-question').val(question);
render_question();
elem.find('input.poll-question').focus();
}
function abort_edit() {
poll_data.clear_input_mode();
render_question();
}
function submit_question() {
const poll_question_input = elem.find("input.poll-question");
let new_question = poll_question_input.val().trim();
const old_question = poll_data.get_question();
// We should disable the button for blank questions,
// so this is just defensive code.
if (new_question.trim() === '') {
new_question = old_question;
}
// Optimistically set the question locally.
poll_data.set_question(new_question);
render_question();
// If there were no actual edits, we can exit now.
if (new_question === old_question) {
return;
}
// Broadcast the new question to our peers.
const data = poll_data.handle.question.outbound(new_question);
callback(data);
}
function submit_option() {
const poll_option_input = elem.find("input.poll-option");
const option = poll_option_input.val().trim();
const options = poll_data.get_widget_data().options;
if (poll_data.is_option_present(options, option)) {
return;
}
if (option === '') {
return;
}
poll_option_input.val('').focus();
const data = poll_data.handle.new_option.outbound(option);
callback(data);
}
function submit_vote(key) {
const data = poll_data.handle.vote.outbound(key);
callback(data);
}
function build_widget() {
const html = render_widgets_poll_widget();
elem.html(html);
elem.find('input.poll-question').on('keyup', function (e) {
e.stopPropagation();
update_edit_controls();
});
elem.find('input.poll-question').on('keydown', function (e) {
e.stopPropagation();
if (e.keyCode === 13) {
submit_question();
return;
}
if (e.keyCode === 27) {
abort_edit();
return;
}
});
elem.find('.poll-edit-question').on('click', function (e) {
e.stopPropagation();
start_editing();
});
elem.find("button.poll-question-check").on('click', function (e) {
e.stopPropagation();
submit_question();
});
elem.find("button.poll-question-remove").on('click', function (e) {
e.stopPropagation();
abort_edit();
});
elem.find("button.poll-option").on('click', function (e) {
e.stopPropagation();
submit_option();
});
elem.find('input.poll-option').on('keydown', function (e) {
e.stopPropagation();
if (e.keyCode === 13) {
submit_option();
return;
}
if (e.keyCode === 27) {
$('input.poll-option').val('');
return;
}
});
}
function render_results() {
const widget_data = poll_data.get_widget_data();
const html = render_widgets_poll_widget_results(widget_data);
elem.find('ul.poll-widget').html(html);
elem.find("button.poll-vote").off('click').on('click', function (e) {
e.stopPropagation();
const key = $(e.target).attr('data-key');
submit_vote(key);
});
}
elem.handle_events = function (events) {
for (const event of events) {
poll_data.handle_event(event.sender_id, event.data);
}
render_question();
render_results();
};
build_widget();
render_question();
render_results();
};
window.poll_widget = exports;