mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 05:53:43 +00:00
b0859f4b1e
tools/linter_lib/pyflakes.py:35: error: Argument 3 to "run_pyflakes" has incompatible type "List[Tuple[bytes, bytes]]"; expected "List[Tuple[str, str]]"
tools/linter_lib/custom_check.py:110: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:214: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:214: error: Argument "shebang_rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:502: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:502: error: Argument "shebang_rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:519: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:706: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:728: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:738: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:779: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
tools/linter_lib/custom_check.py:779: error: Argument "length_exclude" to "RuleList" has incompatible type "Set[str]"; expected "List[str]"
tools/linter_lib/custom_check.py:803: error: Argument "length_exclude" to "RuleList" has incompatible type "Set[str]"; expected "List[str]"
tools/linter_lib/custom_check.py:805: error: Unsupported operand types for + ("List[Rule]" and "List[Dict[str, Any]]")
tools/linter_lib/custom_check.py:819: error: Argument "rules" to "RuleList" has incompatible type "List[Dict[str, Any]]"; expected "List[Rule]"
These were missed the `zulint` package was missing PEP 561 type
annotation markers, and if it’d had them, mypy daemon mode would’ve
required us to set `follow_imports = skip` for it.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
36 lines
1.2 KiB
Python
36 lines
1.2 KiB
Python
from __future__ import print_function
|
|
from __future__ import absolute_import
|
|
|
|
import argparse
|
|
|
|
from typing import List
|
|
|
|
from zulint.linters import run_pyflakes
|
|
|
|
|
|
def check_pyflakes(files, options):
|
|
# type: (List[str], argparse.Namespace) -> bool
|
|
suppress_patterns = [
|
|
("scripts/lib/pythonrc.py", "imported but unused"),
|
|
('', "'scripts.lib.setup_path_on_import' imported but unused"),
|
|
# Intentionally imported by zerver/lib/webhooks/common.py
|
|
('', "'zerver.lib.exceptions.UnexpectedWebhookEventType' imported but unused"),
|
|
|
|
|
|
# Our ipython startup pythonrc file intentionally imports *
|
|
("scripts/lib/pythonrc.py",
|
|
" import *' used; unable to detect undefined names"),
|
|
|
|
# Special dev_settings.py import
|
|
('', "from .prod_settings_template import *"),
|
|
|
|
("settings.py", "settings import *' used; unable to detect undefined names"),
|
|
("settings.py", "may be undefined, or defined from star imports"),
|
|
|
|
# Sphinx adds `tags` specially to the environment when running conf.py.
|
|
("docs/conf.py", "undefined name 'tags'"),
|
|
]
|
|
if options.full:
|
|
suppress_patterns = []
|
|
return run_pyflakes(files, options, suppress_patterns)
|