7f9c3bb4d0
Currently, when there are some old starred messages in a topic, it is possible that some of them won't be unstarred on doing "Unstar all messages in topic". This happens when those messages haven't been fetched yet from the server, and we have no way to verify if they actually belong to the topic. This commit fixes that by changing this mechanism to first fetch all starred messages in the topic from the server, and then send their IDs back to the backend to unstar them. While doing this, we assume that the user does not have more than 1000 starred messages in that topic. Note that, we still depend on the local data to decide whether or not the "Unstar all messages in topic" option should be shown in the topic popover. A method similar to the above cannot be used here, because making server requests before opening the popover could visually slow down the popover opening. Using local data for the topic popover would probably not be a big problem, because users would want to unstar all messages in a topic probably after noticing that there are a lot of them, meaning there was at least one starred message from that topic which was already fetched, which is sufficient for us to conclude that we need to show the option in the topic popover. Fixes #17790
Zulip overview
Zulip is a powerful, open source group chat application that combines the immediacy of real-time chat with the productivity benefits of threaded conversations. Zulip is used by open source projects, Fortune 500 companies, large standards bodies, and others who need a real-time chat system that allows users to easily process hundreds or thousands of messages a day. With over 700 contributors merging over 500 commits a month, Zulip is also the largest and fastest growing open source group chat project.
Getting started
Click on the appropriate link below. If nothing seems to apply, join us on the Zulip community server and tell us what's up!
You might be interested in:
-
Contributing code. Check out our guide for new contributors to get started. Zulip prides itself on maintaining a clean and well-tested codebase, and a stock of hundreds of beginner-friendly issues.
-
Contributing non-code. Report an issue, translate Zulip into your language, write for the Zulip blog, or give us feedback. We would love to hear from you, even if you're just trying the product out.
-
Supporting Zulip. Advocate for your organization to use Zulip, become a sponsor, write a review in the mobile app stores, or upvote Zulip on product comparison sites.
-
Checking Zulip out. The best way to see Zulip in action is to drop by the Zulip community server. We also recommend reading Zulip for open source, Zulip for companies, or Zulip for working groups and part time communities.
-
Running a Zulip server. Use a preconfigured DigitalOcean droplet, install Zulip directly, or use Zulip's experimental Docker image. Commercial support is available; see https://zulip.com/plans for details.
-
Using Zulip without setting up a server. https://zulip.com offers free and commercial hosting, including providing our paid plan for free to fellow open source projects.
-
Participating in outreach programs like Google Summer of Code.
You may also be interested in reading our blog or following us on Twitter. Zulip is distributed under the Apache 2.0 license.