Aman Agrawal 814abf6764 resize: Don't use visible selector to find element states. ...

This change decreases the time required to open compose
after clicking a message. The amount of time reduced varies with pc.

The time reduction was around 0.4s to 0.6s for me after using a
6x CPU slowdown. This may not sound convincing but the profile
uploaded in #21979 clearly shows the root cause of having a message
click take 10s was the `:visible` query.

Fixes #21979

2022-05-03 09:19:01 -07:00

..

analytics

…

billing

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

bundles

styles: Rename night_mode.css to dark_theme.css.

2021-11-18 16:55:35 -08:00

portico

apps: Link to release page for Android, rather than directly to APK.

2022-04-05 17:52:52 -07:00

stats

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

types/stacktrace-gps

…

about_zulip.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

activity.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

add_subscribers_pill.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

admin.js

frontend: Add org_type to realm settings updates and events.

2022-04-26 16:29:12 -07:00

alert_popup.ts

…

alert_words_ui.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

alert_words.js

alert_words: Fix alert words with HTML special characters.

2022-03-04 12:26:49 -08:00

all_messages_data.js

…

attachments_ui.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

avatar.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

blueslip_stacktrace.ts

js: Fix no-jquery/no-parse-html-literal.

2022-03-17 13:16:34 -07:00

blueslip.ts

lint: Fix typos found by codespell.

2021-10-19 16:51:13 -07:00

bot_data.js

…

browser_history.js

docs: Consistently hyphenate “web-public”.

2022-01-28 17:45:45 -08:00

buddy_data.js

hash_util: Rename _uri functions to _url.

2022-03-01 18:14:31 -08:00

buddy_list.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

channel.js

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

click_handlers.js

message controls: Use login_to_access modal for reactions/stars.

2022-04-29 16:35:49 -07:00

color_class.ts

…

color_data.ts

…

colorspace.ts

…

common.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

components.ts

js: Fix no-jquery/no-parse-html-literal.

2022-03-17 13:16:34 -07:00

compose_actions.js

compose_box: Add button to go the narrow message is being composed to.

2022-04-28 12:57:42 -07:00

compose_closed_ui.js

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

compose_error.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

compose_fade_helper.js

…

compose_fade_users.js

…

compose_fade.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

compose_pm_pill.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

compose_state.js

compose_state: Add is_topic_field_empty().

2022-04-26 12:58:28 -07:00

compose_ui.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

compose_validate.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

compose.js

compose_box: Add button to go the narrow message is being composed to.

2022-04-28 12:57:42 -07:00

composebox_typeahead.js

compose: Remove "stream" mention in case of PMs.

2022-04-13 16:06:05 -07:00

condense.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

confirm_dialog.js

dialog_widget: Migrate modal to Micromodal.

2021-10-26 18:20:17 -07:00

copy_and_paste.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

csrf.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

css_variables.js

…

dark_theme.js

gear_menu: Allow user to configure preferred theme.

2022-02-18 11:29:48 -08:00

debug.js

…

deprecated_feature_notice.js

deprecated_feature_notice: Migrate modal to dialog_widget.

2021-10-29 16:09:39 -07:00

desktop_integration.js

…

dialog_widget.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

drafts.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

dropdown_list_widget.js

dropdown_list_widget: Convert DropdownListWidget to ES6 class.

2022-04-27 22:09:10 -07:00

echo.js

narrow: Fix messages being cached without flags set.

2022-03-24 08:10:14 -07:00

emoji_picker.js

message controls: Use login_to_access modal for reactions/stars.

2022-04-29 16:35:49 -07:00

emoji.js

emojis: Swap the loops to build the emojis map.

2022-04-04 13:28:49 -07:00

emojisets.js

…

favicon.js

lint: Fix JS style in last commit.

2021-11-01 11:07:01 -07:00

feature_flags.ts

…

feedback_widget.js

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

fetch_status.js

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

filter.js

resolved_topic: Add and use predicate is_resolved.

2022-03-07 21:35:00 -08:00

flatpickr.js

flatpickr: Use 24-hour time in time picker when appropriate.

2022-04-08 15:01:36 -07:00

floating_recipient_bar.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

fold_dict.ts

fold_dict: Fix @typescript-eslint/member-ordering.

2021-10-17 07:15:09 -07:00

gear_menu.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

giphy.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

global.d.ts

…

hash_util.js

web_public_view: Redirect to current narrow after login.

2022-04-28 10:47:49 -07:00

hashchange.js

hash_util: Move enc/decodeHashComponent to shared.

2022-03-01 18:14:31 -08:00

hbs.d.ts

…

hotkey.js

overlays: Add is_modal_open check along with is_active check.

2022-04-06 14:27:20 -07:00

hotspots.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

huddle_data.js

…

i18n.ts

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

info_overlay.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

input_pill.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

invite.js

invite: Add custom option for invite expiration time in frontend.

2022-04-20 13:31:37 -07:00

keydown_util.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

lazy_set.ts

ts: Convert lazy_set module to typescript.

2022-01-18 13:24:02 -08:00

lightbox.js

lightbox: Make the "download" link use the new download endpoint.

2022-03-22 15:05:02 -07:00

linkifiers.js

markdown: Use options, not rules, for linkifier regexes.

2022-04-04 14:07:18 -07:00

list_cursor.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

list_util.ts

…

list_widget.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

loading.ts

js: Fix no-jquery/no-parse-html-literal.

2022-03-17 13:16:34 -07:00

local_message.js

…

localstorage.js

…

markdown_config.js

markdown: Narrow stream/user_group types for mobile.

2022-04-04 14:07:18 -07:00

markdown.js

markdown: Avoid blueslip dependency.

2022-04-05 15:22:53 +00:00

message_edit_history.js

spectators: Fix double modal bug with message edit history.

2022-04-29 16:35:49 -07:00

message_edit.js

dropdown_list_widget: Separate setup method from constructor.

2022-04-27 22:09:10 -07:00

message_events.js

narrow: Fix messages being cached without flags set.

2022-03-24 08:10:14 -07:00

message_fetch.js

narrow: Fix messages being cached without flags set.

2022-03-24 08:10:14 -07:00

message_flags.js

…

message_helper.js

narrow: Fix messages being cached without flags set.

2022-03-24 08:10:14 -07:00

message_list_data.js

message_list: Add helper for checking if a message list has unreads.

2022-02-18 14:48:31 -08:00

message_list_view.js

message_list_view: For spectators, show login button for failed images.

2022-03-24 10:50:00 -07:00

message_list.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

message_lists.js

…

message_live_update.js

events: Add functionality to mark messages as unread.

2022-03-15 18:00:35 -07:00

message_parser.ts

…

message_scroll.js

message_scroll: Use fadeOut effect to hide the scroll to bottom button.

2022-03-24 12:48:57 -07:00

message_store.js

markdown: Simulate message flags in frontend markdown processor.

2022-03-24 08:10:14 -07:00

message_user_ids.ts

…

message_util.js

message_events: Ask server if cannot filter locally.

2022-02-17 12:56:33 -08:00

message_view_header.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

message_viewport.js

overlays: Add is_modal_open check along with is_active check.

2022-04-06 14:27:20 -07:00

muted_topics_ui.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

muted_topics.js

…

muted_users_ui.js

dialog_widget: Append dialog_widget to the body element.

2021-10-26 18:20:17 -07:00

muted_users.js

…

narrow_banner.js

narrow_banner: Simplify empty narrow messages for spectators.

2022-04-29 16:35:49 -07:00

narrow_error.js

narrow_banner: Move empty narrow messages to handlebar templates.

2021-12-07 13:38:48 -08:00

narrow_state.js

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

narrow.js

compose_box: Add button to go the narrow message is being composed to.

2022-04-28 12:57:42 -07:00

navbar_alerts.js

navbar_alerts: Adjust height of recent topics when alert is visible.

2022-03-31 11:25:09 -07:00

navigate.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

notifications.js

js: Fix no-jquery/no-parse-html-literal.

2022-03-17 13:16:34 -07:00

overlays.js

overlays: Add is_modal_open check along with is_active check.

2022-04-06 14:27:20 -07:00

padded_widget.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

page_params.ts

settings: Add user_can_create_web_public_streams function.

2021-11-23 10:48:20 -08:00

password_quality.ts

password_quality: Switch zxcvbn to zxcvbn-ts.

2022-03-17 15:24:46 -07:00

peer_data.js

…

people.js

people: Extract _calc_user_and_other_ids from get_recipients.

2022-03-24 12:21:38 -07:00

pill_typeahead.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

pm_conversations.js

…

pm_list_data.js

left-sidebar: Use same logic as of Topics view to render PMs.

2022-04-06 16:51:15 -07:00

pm_list_dom.js

left sidebar: Rename convos => conversations variable names.

2022-04-06 16:51:15 -07:00

pm_list.js

left sidebar: Rename convos => conversations variable names.

2022-04-06 16:51:15 -07:00

poll_widget.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

popover_menus.js

tippyjs: Avoid unsafe allowHTML API in favor of <template> elements.

2022-03-03 10:13:24 -08:00

popovers.js

message_feed_ui: Remove "Unmute topic" from message action menu.

2022-04-25 17:35:02 -07:00

presence.js

js: Remove unused buddy_data.huddle_fraction_present function.

2022-02-03 10:59:33 -08:00

reactions.js

emojis: Un-share the emoji.js module.

2022-04-04 13:28:49 -07:00

ready.ts

…

realm_icon.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

realm_logo.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

realm_playground.js

…

realm_user_settings_defaults.ts

user_settings: Add a setting to display names of users who reacted.

2022-04-19 17:30:16 -07:00

recent_senders.js

…

recent_topics_data.js

…

recent_topics_ui.js

compose_box: Add button to go the narrow message is being composed to.

2022-04-28 12:57:42 -07:00

recent_topics_util.js

overlays: Add is_modal_open check along with is_active check.

2022-04-06 14:27:20 -07:00

reload_state.ts

…

reload.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

reminder.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

rendered_markdown.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

resize.js

resize: Don't use visible selector to find element states.

2022-05-03 09:19:01 -07:00

rows.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

rtl.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

schema.js

…

scroll_bar.js

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

scroll_util.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

search_pill_widget.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

search_pill.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

search_suggestion.js

search_suggestions: Remove filters unusable by spectator.

2022-02-10 11:37:38 -08:00

search_util.ts

…

search.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

sent_messages.js

…

server_events_dispatch.js

frontend: Add org_type to realm settings updates and events.

2022-04-26 16:29:12 -07:00

server_events.js

narrow: Fix messages being cached without flags set.

2022-03-24 08:10:14 -07:00

settings_account.js

settings: Fix length of custom profile field URL input.

2022-04-04 12:10:05 -07:00

settings_bots.js

dropdown_list_widget: Separate setup method from constructor.

2022-04-27 22:09:10 -07:00

settings_config.ts

frontend: Add org_type to realm settings updates and events.

2022-04-26 16:29:12 -07:00

settings_data.ts

settings_data: Remove redundant check from user_can_edit_topic_of_any_message.

2021-11-24 10:37:51 -08:00

settings_display.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_emoji.js

emojis: Un-share the emoji.js module.

2022-04-04 13:28:49 -07:00

settings_exports.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_invites.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_linkifiers.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_muted_topics.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_muted_users.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_notifications.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_org.js

dropdown_list_widget: Separate setup method from constructor.

2022-04-27 22:09:10 -07:00

settings_panel_menu.js

js: Fix no-jquery/no-sizzle.

2022-03-17 13:10:23 -07:00

settings_playgrounds.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_profile_fields.js

js: Fix no-jquery/no-sizzle.

2022-03-17 13:10:23 -07:00

settings_realm_user_settings_defaults.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_sections.js

settings: Add sorting feature for list of alert words.

2022-02-25 17:33:11 -08:00

settings_streams.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_toggle.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_ui.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_user_groups.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

settings_users.js

dropdown_list_widget: Separate setup method from constructor.

2022-04-27 22:09:10 -07:00

settings.js

settings: Fix push notifications tooltip being incorrectly shown.

2022-03-30 11:31:29 -07:00

setup.js

channel: Simplify password change tracking.

2021-10-05 10:23:43 -07:00

spectators.js

login_to_access: Change message displayed for empty narrows.

2022-04-29 16:35:49 -07:00

spoilers.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

starred_messages_ui.js

dialog_widget: Append dialog_widget to the body element.

2021-10-26 18:20:17 -07:00

starred_messages.js

…

stream_bar.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

stream_color.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

stream_create_subscribers_data.js

stream create: Overhaul create-stream add-subscribers UI.

2022-03-07 16:58:58 -08:00

stream_create_subscribers.js

js: Fix no-jquery/no-event-shorthand.

2022-03-17 13:10:23 -07:00

stream_create.js

streams: Check/uncheck the announce checkbox as per the previous state.

2022-04-17 17:27:22 -07:00

stream_data.js

stream_settings: Improve stream_post_policy_values order, description.

2022-03-10 15:11:06 -08:00

stream_edit_subscribers.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

stream_edit.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

stream_events.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

stream_list.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

stream_muting.js

overlays: Add is_modal_open check along with is_active check.

2022-04-06 14:27:20 -07:00

stream_pill.js

node tests: Directly test simple stream_pill helpers.

2022-02-22 16:29:36 -08:00

stream_popover.js

dropdown_list_widget: Separate setup method from constructor.

2022-04-27 22:09:10 -07:00

stream_settings_containers.js

stream settings: Extract stream_settings_containers.js.

2021-12-16 15:28:11 -08:00

stream_settings_data.js

hash_util: Rename _uri functions to _url.

2022-03-01 18:14:31 -08:00

stream_settings_ui.js

stream_settings: Live update the banner on changing subscription.

2022-04-01 14:52:06 -07:00

stream_sort.js

…

stream_topic_history_util.js

…

stream_topic_history.js

…

stream_ui_updates.js

stream_settings: Live update the banner on changing subscription.

2022-04-01 14:52:06 -07:00

sub_store.ts

…

submessage.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

subscriber_api.js

subscribers: Extract subscriber_api.

2022-02-22 16:29:36 -08:00

templates.js

…

timerender.ts

js: Fix no-jquery/no-parse-html-literal.

2022-03-17 13:16:34 -07:00

tippyjs.js

compose: Display current narrow in go to conversation tooltip.

2022-04-28 12:57:42 -07:00

todo_widget.js

js: Fix no-jquery/no-event-shorthand.

2022-03-17 13:10:23 -07:00

top_left_corner.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

topic_generator.js

…

topic_list_data.js

resolved_topic: Implement resolve, unresolve, and display.

2022-03-07 21:35:00 -08:00

topic_list.js

left sidebar: Rename convos => conversations variable names.

2022-04-06 16:51:15 -07:00

topic_zoom.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

transmit.js

reminder: Don't ack server for reminder / scheduled messages.

2021-11-10 09:12:23 -08:00

tutorial.js

…

typeahead_helper.js

compose: Fix sorting of wildcard mentions in case of PMs.

2022-04-28 12:53:46 -07:00

types.ts

lint: Fix typos found by codespell.

2021-10-19 16:51:13 -07:00

typing_data.js

js: Convert _.uniq(a) to Array.from(new Set(a)).

2022-01-24 15:54:21 -08:00

typing_events.js

typing_notifications: Show several users are typing if num of typists > 3.

2021-10-07 16:32:08 -07:00

typing.js

typing_notifications: Send requests only if send_private_typing_notifications.

2021-10-07 17:40:32 -07:00

ui_init.js

compose_box: Add button to go the narrow message is being composed to.

2022-04-28 12:57:42 -07:00

ui_report.ts

js: Fix no-jquery/no-parse-html-literal.

2022-03-17 13:16:34 -07:00

ui_util.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

ui.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

unread_ops.js

events: Add functionality to mark messages as unread.

2022-03-15 18:00:35 -07:00

unread_ui.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

unread.js

events: Add functionality to mark messages as unread.

2022-03-15 18:00:35 -07:00

upload_widget.ts

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

upload.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

user_events.js

js: Shorten Object.prototype.hasOwnProperty.call to Object.hasOwn.

2022-01-24 09:57:09 -08:00

user_group_pill.js

node tests: Directly test user_group_pill helpers.

2022-02-22 16:29:36 -08:00

user_groups.ts

…

user_pill.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

user_profile.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

user_search.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

user_settings.ts

user_settings: Add a setting to display names of users who reacted.

2022-04-19 17:30:16 -07:00

user_status_ui.js

emojis: Un-share the emoji.js module.

2022-04-04 13:28:49 -07:00

user_status.js

emojis: Un-share the emoji.js module.

2022-04-04 13:28:49 -07:00

util.js

messages: Show tippy tooltip for inline images.

2022-03-21 15:36:10 -07:00

vdom.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

watchdog.ts

…

webpack_public_path.js

…

widgetize.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

zcommand.js

markdown: Extract parse_non_message().

2022-04-04 14:07:18 -07:00

zform.js

js: Prefix jQuery object variable names with $.

2022-03-16 12:52:07 -07:00

zulip_test.js

stream create: Overhaul create-stream add-subscribers UI.

2022-03-07 16:58:58 -08:00