mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-03 21:43:21 +00:00 
			
		
		
		
	When I added this "Deployed code" feature to the error reporting, I apparently hadn't worked out enough of how this code works to realize that `notify_server_error` may be in a different process, at a different time and potentially even on a different machine from the actual error being reported. Given that architecture, all the data about the error must be computed in `AdminNotifyHandler`, before sending the report through the queue, or else it risks being wrong. The job of `notify_server_error` and friends is only to format the data and send it off. So, move the implementation of this feature in order to do that. (@showell added some "nocoverage" directives here for code that is hard to test (exceptions being thrown, deployment files not existing) and that was originally part of a file that didn't require 100% coverage)
		
			
				
	
	
		
			148 lines
		
	
	
		
			5.2 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			148 lines
		
	
	
		
			5.2 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
# System documented in https://zulip.readthedocs.io/en/latest/subsystems/logging.html
 | 
						|
 | 
						|
import logging
 | 
						|
 | 
						|
from collections import defaultdict
 | 
						|
from django.conf import settings
 | 
						|
from django.core.mail import mail_admins
 | 
						|
from django.http import HttpResponse
 | 
						|
from django.utils.translation import ugettext as _
 | 
						|
from typing import Any, Dict, Optional, Text
 | 
						|
 | 
						|
from zerver.models import get_system_bot
 | 
						|
from zerver.lib.actions import internal_send_message
 | 
						|
from zerver.lib.response import json_success, json_error
 | 
						|
 | 
						|
def format_subject(subject: str) -> str:
 | 
						|
    """
 | 
						|
    Escape CR and LF characters.
 | 
						|
    """
 | 
						|
    return subject.replace('\n', '\\n').replace('\r', '\\r')
 | 
						|
 | 
						|
def logger_repr(report: Dict[str, Any]) -> str:
 | 
						|
    return ("Logger %(logger_name)s, from module %(log_module)s line %(log_lineno)d:"
 | 
						|
            % report)
 | 
						|
 | 
						|
def user_info_str(report: Dict[str, Any]) -> str:
 | 
						|
    if report['user_full_name'] and report['user_email']:
 | 
						|
        user_info = "%(user_full_name)s (%(user_email)s)" % (report)
 | 
						|
    else:
 | 
						|
        user_info = "Anonymous user (not logged in)"
 | 
						|
 | 
						|
    user_info += " on %s deployment"  % (report['deployment'],)
 | 
						|
    return user_info
 | 
						|
 | 
						|
def deployment_repr(report: Dict[str, Any]) -> str:
 | 
						|
    deployment = 'Deployed code:\n'
 | 
						|
    for (label, field) in [('git', 'git_described'),
 | 
						|
                           ('ZULIP_VERSION', 'zulip_version_const'),
 | 
						|
                           ('version', 'zulip_version_file'),
 | 
						|
                           ]:
 | 
						|
        if report[field] is not None:
 | 
						|
            deployment += '- %s: %s\n' % (label, report[field])
 | 
						|
    return deployment
 | 
						|
 | 
						|
def notify_browser_error(report: Dict[str, Any]) -> None:
 | 
						|
    report = defaultdict(lambda: None, report)
 | 
						|
    if settings.ERROR_BOT:
 | 
						|
        zulip_browser_error(report)
 | 
						|
    email_browser_error(report)
 | 
						|
 | 
						|
def email_browser_error(report: Dict[str, Any]) -> None:
 | 
						|
    subject = "Browser error for %s" % (user_info_str(report))
 | 
						|
 | 
						|
    body = ("User: %(user_full_name)s <%(user_email)s> on %(deployment)s\n\n"
 | 
						|
            "Message:\n%(message)s\n\nStacktrace:\n%(stacktrace)s\n\n"
 | 
						|
            "IP address: %(ip_address)s\n"
 | 
						|
            "User agent: %(user_agent)s\n"
 | 
						|
            "href: %(href)s\n"
 | 
						|
            "Server path: %(server_path)s\n"
 | 
						|
            "Deployed version: %(version)s\n"
 | 
						|
            % (report))
 | 
						|
 | 
						|
    more_info = report['more_info']
 | 
						|
    if more_info is not None:
 | 
						|
        body += "\nAdditional information:"
 | 
						|
        for (key, value) in more_info.items():
 | 
						|
            body += "\n  %s: %s" % (key, value)
 | 
						|
 | 
						|
    body += "\n\nLog:\n%s" % (report['log'],)
 | 
						|
 | 
						|
    mail_admins(subject, body)
 | 
						|
 | 
						|
def zulip_browser_error(report: Dict[str, Any]) -> None:
 | 
						|
    subject = "JS error: %s" % (report['user_email'],)
 | 
						|
 | 
						|
    user_info = user_info_str(report)
 | 
						|
 | 
						|
    body = "User: %s\n" % (user_info,)
 | 
						|
    body += ("Message: %(message)s\n"
 | 
						|
             % (report))
 | 
						|
 | 
						|
    realm = get_system_bot(settings.ERROR_BOT).realm
 | 
						|
    internal_send_message(realm, settings.ERROR_BOT,
 | 
						|
                          "stream", "errors", format_subject(subject), body)
 | 
						|
 | 
						|
def notify_server_error(report: Dict[str, Any]) -> None:
 | 
						|
    report = defaultdict(lambda: None, report)
 | 
						|
    email_server_error(report)
 | 
						|
    if settings.ERROR_BOT:
 | 
						|
        zulip_server_error(report)
 | 
						|
 | 
						|
def zulip_server_error(report: Dict[str, Any]) -> None:
 | 
						|
    subject = '%(node)s: %(message)s' % (report)
 | 
						|
 | 
						|
    logger_str = logger_repr(report)
 | 
						|
    user_info = user_info_str(report)
 | 
						|
    deployment = deployment_repr(report)
 | 
						|
 | 
						|
    if report['has_request']:
 | 
						|
        request_repr = (
 | 
						|
            "Request info:\n~~~~\n"
 | 
						|
            "- path: %(path)s\n"
 | 
						|
            "- %(method)s: %(data)s\n") % (report)
 | 
						|
        for field in ["REMOTE_ADDR", "QUERY_STRING", "SERVER_NAME"]:
 | 
						|
            request_repr += "- %s: \"%s\"\n" % (field, report.get(field.lower()))
 | 
						|
        request_repr += "~~~~"
 | 
						|
    else:
 | 
						|
        request_repr = "Request info: none"
 | 
						|
 | 
						|
    message = ("%s\nError generated by %s\n\n~~~~ pytb\n%s\n\n~~~~\n%s\n%s"
 | 
						|
               % (logger_str, user_info, report['stack_trace'], deployment, request_repr))
 | 
						|
 | 
						|
    realm = get_system_bot(settings.ERROR_BOT).realm
 | 
						|
    internal_send_message(realm, settings.ERROR_BOT, "stream", "errors",
 | 
						|
                          format_subject(subject), message)
 | 
						|
 | 
						|
def email_server_error(report: Dict[str, Any]) -> None:
 | 
						|
    subject = '%(node)s: %(message)s' % (report)
 | 
						|
 | 
						|
    logger_str = logger_repr(report)
 | 
						|
    user_info = user_info_str(report)
 | 
						|
    deployment = deployment_repr(report)
 | 
						|
 | 
						|
    if report['has_request']:
 | 
						|
        request_repr = (
 | 
						|
            "Request info:\n"
 | 
						|
            "- path: %(path)s\n"
 | 
						|
            "- %(method)s: %(data)s\n") % (report)
 | 
						|
        for field in ["REMOTE_ADDR", "QUERY_STRING", "SERVER_NAME"]:
 | 
						|
            request_repr += "- %s: \"%s\"\n" % (field, report.get(field.lower()))
 | 
						|
    else:
 | 
						|
        request_repr = "Request info: none\n"
 | 
						|
 | 
						|
    message = ("%s\nError generated by %s\n\n%s\n\n%s\n\n%s"
 | 
						|
               % (logger_str, user_info, report['stack_trace'], deployment, request_repr))
 | 
						|
 | 
						|
    mail_admins(format_subject(subject), message, fail_silently=True)
 | 
						|
 | 
						|
def do_report_error(deployment_name: Text, type: Text, report: Dict[str, Any]) -> HttpResponse:
 | 
						|
    report['deployment'] = deployment_name
 | 
						|
    if type == 'browser':
 | 
						|
        notify_browser_error(report)
 | 
						|
    elif type == 'server':
 | 
						|
        notify_server_error(report)
 | 
						|
    else:
 | 
						|
        return json_error(_("Invalid type parameter"))
 | 
						|
    return json_success()
 |