Steve Howell df03e30d68 popovers: Fix is-active checks for popovers. ...

We were incorrectly reporting active bots as non-active in
popovers, and we had no test coverage for cross-realm bots.

We also rename the function to is_active_user_for_popover,
since the old name, realm_user_is_active_human_or_bot, suggested
the wrong semantics for cross-realm bots.

Last but not least, we only do a blueslip warning if a user id
is not found.  When lookups fail, we are pretty confident that
the user is not active, so an error is overkill.  We can change
that as part of issue #7120.

Fixes #7153

2017-10-26 13:56:32 -07:00

..

casper_lib

casper: Always use REALMS_HAVE_SUBDOMAINS.

2017-08-24 20:44:37 -07:00

casper_tests

home.html: Cleanup to use 4 space indentation.

2017-10-25 10:58:49 -07:00

node_tests

popovers: Fix is-active checks for popovers.

2017-10-26 13:56:32 -07:00

zjsunit

eslint: Add and enforce space-in-parens lint rule.

2017-10-06 12:36:59 -07:00

.eslintrc.json

node tests: Extract zrequire helper.

2017-08-09 12:32:09 -07:00

run-casper

frontend_tests: Replace optparse with argparse.

2017-09-30 09:31:06 -07:00