mirror of
https://github.com/zulip/zulip.git
synced 2025-11-02 04:53:36 +00:00
897476d4fb
django.request logs responses with 5xx response codes (our configuration of the logger prevents it from logging 4xx as well which it normally does too). However, it does it without the traceback which results in quite unhelpful log message that look like "Bad Gateway:/api/v1/users/me/apns_device_token" - particularly confusing when sent via email to server admins. The solution here is to do the logging ourselves, using Django's log_response() (which is meant for this purpose), and including the traceback. Django tracks (via response._has_been_logged attribute) that the response has already been logged, and knows to not duplicate that action. See log_response() in django's codebase for these details. Fixes #19596.