Alex Vandiver
8998aa00cd
Revert "create_user: Use transaction.atomic decorator for do_create_user."
...
This reverts commit 851d68e0fc .
That commit widened how long the transaction is open, which made it
much more likely that after the user was created in the transaction,
and the memcached caches were flushed, some other request will fill
the `get_realm_user_dicts` cache with data which did not include the
new user (because it had not been committed yet).
If a user creation request lost this race, the user would, upon first
request to `/`, get a blank page and a Javascript error:
Unknown user_id in get_by_user_id: 12345
...where 12345 was their own user-id. This error would persist until
the cache expired (in 7 days) or something else expunged it.
Reverting this does not prevent the race, as the post_save hook's call
to flush_user_profile is still in a transaction (and has been since
168f241ff0 ), and thus leaves the potential race window open.
However, it much shortens the potential window of opportunity, and is
a reasonable short-term stopgap.
2023-02-17 21:20:52 -05:00
..
2023-01-31 16:07:48 -08:00
2022-03-15 12:47:21 -07:00
2022-06-06 23:06:00 -07:00
2022-06-06 23:06:00 -07:00
2023-01-26 10:16:30 -08:00
2023-02-10 17:35:49 -08:00
2023-02-10 17:35:49 -08:00
2022-11-17 16:52:00 -08:00
2023-02-04 16:34:55 -08:00
2022-06-06 23:06:00 -07:00
2023-02-10 17:35:49 -08:00
2023-02-14 14:58:15 -08:00
2023-02-02 10:40:13 -08:00
2023-02-02 10:40:13 -08:00
2022-07-26 18:00:24 -07:00
2023-02-10 17:35:49 -08:00
2022-07-21 15:25:11 -07:00
2023-02-02 10:40:13 -08:00
2023-02-14 17:17:06 -05:00
2022-11-17 16:52:00 -08:00
2023-02-17 21:20:52 -05:00
2023-02-17 21:20:52 -05:00
2023-02-17 21:20:52 -05:00
2023-02-10 17:35:49 -08:00
2022-11-17 16:52:00 -08:00
2022-11-17 16:52:00 -08:00
2022-11-03 12:10:15 -07:00
2023-02-10 17:40:33 -08:00
2022-04-14 17:14:35 -07:00
2023-02-03 15:23:35 -08:00
2023-02-02 10:40:13 -08:00
2023-02-02 10:40:13 -08:00
2022-11-03 12:10:15 -07:00
2022-09-13 11:05:37 -07:00
2023-01-04 16:25:07 -08:00
2023-01-03 11:09:50 -08:00
2023-01-24 11:29:50 -08:00
2023-02-09 22:34:51 -08:00
2021-12-06 13:22:47 -08:00
2023-02-02 10:40:13 -08:00
2022-03-09 16:33:51 -08:00
2023-02-08 12:46:05 -08:00
2023-02-10 17:35:49 -08:00
2023-01-03 11:09:50 -08:00
2023-02-17 21:20:52 -05:00
2022-11-17 16:52:00 -08:00
2023-01-06 17:08:20 -08:00
2023-02-02 10:40:13 -08:00
2022-10-07 10:09:38 -07:00
2023-02-10 17:35:49 -08:00
2023-02-10 15:39:57 -08:00
2023-01-04 16:25:07 -08:00
2023-01-24 11:16:21 -08:00
2023-02-02 10:40:13 -08:00
2022-06-01 16:01:54 -07:00
2023-02-10 17:35:49 -08:00
2022-04-25 16:16:15 -07:00
2023-02-02 10:40:13 -08:00
2023-02-02 10:40:13 -08:00
2023-01-23 11:18:36 -08:00
2022-01-21 13:38:13 -08:00
2023-02-04 16:34:55 -08:00
2022-09-13 11:05:37 -07:00
2023-02-10 15:39:57 -08:00
2022-09-16 15:27:52 -07:00
2023-01-31 17:28:33 -08:00
2023-01-26 10:49:19 -08:00
2022-06-06 23:06:00 -07:00
2022-11-04 14:44:07 -07:00
2023-02-10 17:40:33 -08:00
2022-06-23 22:05:12 -07:00
2022-02-07 18:51:06 -08:00
2023-01-09 18:23:58 -05:00
2022-12-27 10:34:30 -08:00
2022-11-05 15:13:46 -07:00
2022-11-17 16:52:00 -08:00
2022-08-25 12:13:03 -07:00
2022-11-17 16:52:00 -08:00
2023-02-02 10:40:13 -08:00
2023-02-10 17:35:49 -08:00
2023-02-10 17:35:49 -08:00
2023-02-02 10:40:13 -08:00
2022-10-17 11:32:52 -07:00
2023-02-14 17:17:06 -05:00
2022-04-14 17:14:30 -07:00
2023-02-05 14:46:36 -08:00
2022-11-17 16:52:00 -08:00
2022-05-30 11:59:47 -07:00
2022-11-17 16:52:00 -08:00
2022-11-17 16:52:00 -08:00
2023-01-04 16:25:07 -08:00
2022-07-05 17:54:17 -07:00
2023-01-09 18:23:58 -05:00
2023-01-24 11:16:21 -08:00
2022-10-17 11:32:52 -07:00
2023-02-14 17:17:06 -05:00
2023-02-02 17:23:31 -08:00
2022-12-13 14:58:58 -08:00
2022-09-23 12:27:54 -07:00
2023-02-10 15:39:57 -08:00
2023-02-10 17:35:49 -08:00
2023-02-02 10:40:13 -08:00
2022-09-13 11:05:37 -07:00
2022-06-06 23:06:00 -07:00
2022-08-12 17:08:04 -07:00