mirror of
				https://github.com/zulip/zulip.git
				synced 2025-10-31 12:03:46 +00:00 
			
		
		
		
	It's not always clear whether user_ids are strings or integers, so we explicitly convert them to integers for sorting when creating keys for PMs. To keep the tests passing, this commit removes some unneeded defensive code in message_store.js that only applies to contrived test input.
		
			
				
	
	
		
			256 lines
		
	
	
		
			7.0 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			256 lines
		
	
	
		
			7.0 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| add_dependencies({
 | |
|     people: 'js/people.js',
 | |
|     pm_conversations: 'js/pm_conversations.js',
 | |
|     util: 'js/util.js',
 | |
| });
 | |
| 
 | |
| var noop = function () {};
 | |
| var with_overrides = global.with_overrides;
 | |
| var people = global.people;
 | |
| 
 | |
| set_global('$', global.make_zjquery());
 | |
| set_global('document', 'document-stub');
 | |
| 
 | |
| set_global('alert_words', {
 | |
|     process_message: noop,
 | |
| });
 | |
| 
 | |
| set_global('topic_data' , {
 | |
|     add_message: noop,
 | |
| });
 | |
| 
 | |
| set_global('recent_senders', {
 | |
|     process_message_for_senders: noop,
 | |
| });
 | |
| 
 | |
| set_global('page_params', {
 | |
|     realm_allow_message_editing: true,
 | |
|     is_admin: true,
 | |
| });
 | |
| 
 | |
| set_global('blueslip', {});
 | |
| 
 | |
| var me = {
 | |
|     email: 'me@example.com',
 | |
|     user_id: 101,
 | |
|     full_name: 'Me Myself',
 | |
| };
 | |
| 
 | |
| var alice = {
 | |
|     email: 'alice@example.com',
 | |
|     user_id: 102,
 | |
|     full_name: 'Alice',
 | |
| };
 | |
| 
 | |
| var bob = {
 | |
|     email: 'bob@example.com',
 | |
|     user_id: 103,
 | |
|     full_name: 'Bob',
 | |
| };
 | |
| 
 | |
| var cindy = {
 | |
|     email: 'cindy@example.com',
 | |
|     user_id: 104,
 | |
|     full_name: 'Cindy',
 | |
| };
 | |
| 
 | |
| people.add_in_realm(me);
 | |
| people.add_in_realm(alice);
 | |
| people.add_in_realm(bob);
 | |
| people.add_in_realm(cindy);
 | |
| 
 | |
| global.people.initialize_current_user(me.user_id);
 | |
| 
 | |
| var message_store = require('js/message_store.js');
 | |
| 
 | |
| (function test_insert_recent_private_message() {
 | |
|     message_store.insert_recent_private_message('1', 1001);
 | |
|     message_store.insert_recent_private_message('2', 2001);
 | |
|     message_store.insert_recent_private_message('1', 3001);
 | |
| 
 | |
|     // try to backdate user1's timestamp
 | |
|     message_store.insert_recent_private_message('1', 555);
 | |
| 
 | |
|     assert.deepEqual(message_store.recent_private_messages, [
 | |
|         {user_ids_string: '1', timestamp: 3001},
 | |
|         {user_ids_string: '2', timestamp: 2001},
 | |
|     ]);
 | |
| }());
 | |
| 
 | |
| (function test_add_message_metadata() {
 | |
|     var message = {
 | |
|         sender_email: 'me@example.com',
 | |
|         sender_id: me.user_id,
 | |
|         type: 'private',
 | |
|         display_recipient: [me, bob, cindy],
 | |
|         flags: ['has_alert_word'],
 | |
|         id: 2067,
 | |
|     };
 | |
|     message_store.add_message_metadata(message);
 | |
| 
 | |
|     assert.equal(message.is_private, true);
 | |
|     assert.equal(message.reply_to, 'bob@example.com,cindy@example.com');
 | |
|     assert.equal(message.to_user_ids, '103,104');
 | |
|     assert.equal(message.display_reply_to, 'Bob, Cindy');
 | |
|     assert.equal(message.alerted, true);
 | |
|     assert.equal(message.is_me_message, false);
 | |
| 
 | |
|     var retrieved_message = message_store.get(2067);
 | |
|     assert.equal(retrieved_message, message);
 | |
| 
 | |
|     // access cached previous message, and test match subject/content
 | |
|     message = {
 | |
|         id: 2067,
 | |
|         match_subject: "subject foo",
 | |
|         match_content: "bar content",
 | |
|     };
 | |
|     message = message_store.add_message_metadata(message);
 | |
| 
 | |
|     assert.equal(message.reply_to, 'bob@example.com,cindy@example.com');
 | |
|     assert.equal(message.to_user_ids, '103,104');
 | |
|     assert.equal(message.display_reply_to, 'Bob, Cindy');
 | |
|     assert.equal(message.match_subject, 'subject foo');
 | |
|     assert.equal(message.match_content, 'bar content');
 | |
| 
 | |
|     message = {
 | |
|         sender_email: 'me@example.com',
 | |
|         sender_id: me.user_id,
 | |
|         type: 'stream',
 | |
|         display_recipient: [me, cindy],
 | |
|         stream: 'Zoolippy',
 | |
|         topic: 'cool thing',
 | |
|         subject: 'the_subject',
 | |
|         id: 2068,
 | |
|     };
 | |
| 
 | |
|     // test stream properties
 | |
|     with_overrides(function (override) {
 | |
|         override('compose.empty_topic_placeholder', function () {
 | |
|             return 'the_subject';
 | |
|         });
 | |
|         global.with_stub(function (stub) {
 | |
|             set_global('composebox_typeahead', {add_topic: stub.f});
 | |
|             message_store.add_message_metadata(message);
 | |
|             var typeahead_added = stub.get_args('stream', 'subject');
 | |
|             assert.deepEqual(typeahead_added.stream, [me, cindy]);
 | |
|             assert.equal(message.subject, typeahead_added.subject);
 | |
|         });
 | |
| 
 | |
|         assert.equal(message.always_visible_topic_edit, true);
 | |
|         assert.equal(message.on_hover_topic_edit, false);
 | |
|         assert.deepEqual(message.stream, [me, cindy]);
 | |
|         assert.equal(message.reply_to, 'me@example.com');
 | |
|         assert.deepEqual(message.flags, []);
 | |
|         assert.equal(message.alerted, false);
 | |
| 
 | |
|         override('compose.empty_topic_placeholder', function () {
 | |
|             return 'not_the_subject';
 | |
|         });
 | |
| 
 | |
|         message = {
 | |
|             sender_id: me.user_id,
 | |
|             type: 'stream',
 | |
|             id: 2069,
 | |
|             display_recipient: [me],
 | |
|             sender_email: 'me@example.org',
 | |
|         };
 | |
|         message_store.add_message_metadata(message);
 | |
| 
 | |
|         assert.equal(message.always_visible_topic_edit, false);
 | |
|         assert.equal(message.on_hover_topic_edit, true);
 | |
|     });
 | |
| 
 | |
|     page_params.realm_allow_message_editing = false;
 | |
|     message = {
 | |
|         sender_id: me.user_id,
 | |
|         type: 'stream',
 | |
|         id: 2070,
 | |
|         display_recipient: [me],
 | |
|         sender_email: 'me@example.org',
 | |
|     };
 | |
|     message_store.add_message_metadata(message);
 | |
|     assert.equal(message.always_visible_topic_edit, false);
 | |
|     assert.equal(message.on_hover_topic_edit, false);
 | |
| }());
 | |
| 
 | |
| (function test_errors() {
 | |
|     // Test a user that doesn't exist
 | |
|     var message = {
 | |
|         type: 'private',
 | |
|         display_recipient: [{user_id: 92714}],
 | |
|     };
 | |
| 
 | |
|     var blueslip_errors = 0;
 | |
|     blueslip.error = function () {
 | |
|         blueslip_errors += 1;
 | |
|     };
 | |
| 
 | |
|     // Expect each to throw two blueslip errors
 | |
|     // One from message_store.js, one from person.js
 | |
|     var emails = message_store.get_pm_emails(message);
 | |
|     assert.equal(emails, '?');
 | |
|     assert.equal(blueslip_errors, 2);
 | |
| 
 | |
|     blueslip_errors = 0;
 | |
|     var names = message_store.get_pm_full_names(message);
 | |
|     assert.equal(names, '?');
 | |
|     assert.equal(blueslip_errors, 2);
 | |
| 
 | |
|     message = {
 | |
|         type: 'stream',
 | |
|         display_recipient: [{}],
 | |
|     };
 | |
| 
 | |
|     // This should early return and not run pm_conversation.set_partner
 | |
|     var num_partner = 0;
 | |
|     set_global('pm_conversation', {
 | |
|         set_partner: function () {
 | |
|             num_partner += 1;
 | |
|         },
 | |
|     });
 | |
|     message_store.process_message_for_recent_private_messages(message);
 | |
|     assert.equal(num_partner, 0);
 | |
| }());
 | |
| 
 | |
| (function test_message_id_change() {
 | |
|     var message = {
 | |
|         sender_email: 'me@example.com',
 | |
|         sender_id: me.user_id,
 | |
|         type: 'private',
 | |
|         display_recipient: [me, bob, cindy],
 | |
|         flags: ['has_alert_word'],
 | |
|         id: 401,
 | |
|     };
 | |
|     message_store.add_message_metadata(message);
 | |
| 
 | |
|     set_global('pointer', {
 | |
|         furthest_read: 401,
 | |
|     });
 | |
| 
 | |
|     set_global('message_list', {});
 | |
|     set_global('home_msg_list', {});
 | |
| 
 | |
|     var opts = {
 | |
|         old_id: 401,
 | |
|         new_id: 402,
 | |
|     };
 | |
| 
 | |
|     global.with_stub(function (stub) {
 | |
|         home_msg_list.change_message_id = stub.f;
 | |
|         message_store.reify_message_id(opts);
 | |
|         var msg_id = stub.get_args('old', 'new');
 | |
|         assert.equal(msg_id.old, 401);
 | |
|         assert.equal(msg_id.new, 402);
 | |
|     });
 | |
| 
 | |
|     home_msg_list.view = {};
 | |
|     global.with_stub(function (stub) {
 | |
|         home_msg_list.view.change_message_id = stub.f;
 | |
|         message_store.reify_message_id(opts);
 | |
|         var msg_id = stub.get_args('old', 'new');
 | |
|         assert.equal(msg_id.old, 401);
 | |
|         assert.equal(msg_id.new, 402);
 | |
|     });
 | |
| 
 | |
| }());
 |