paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 02:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
8b55a310f1753fb8a217ace9ca5a33cfff35d45d
zulip/frontend_tests/node_tests
History
Tim Abbott 8b55a310f1 typing: Fix invalid typing notifications for stream messages. 
In e42c3f7418, we made the assumption
that compose_pm_pill.get_recipient() would return no users for stream
messages.  It turns out, due to the confusing name of
compose_state.recipient (which we just renamed to
compose_state.private_message_recipient), this assumption was wrong.

As a result, when composing a stream message using the reply hotkeys,
we'd end up sending typing notiifcations to the person who sent the
message we're replying to as though a PM was being composed.

We fix this by avoiding passing an (expected to be unused) value for
private_message_recipient to compose_state.start.
2019-12-02 09:31:16 -08:00
..
.eslintrc.json
lint: Add JS indentation eslint rules for node_tests.
2018-05-06 19:35:18 -07:00
activity.js
compose_state: Rename compost_state.recipient to be about PMs only.
2019-12-02 08:53:55 -08:00
alert_words_ui.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
alert_words.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
billing_helpers.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
billing.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
blueslip_stacktrace.js
blueslip: Make stack trace more readable.
2019-10-31 13:47:54 -07:00
bot_data.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
buddy_data.js
sidebar: Move the buddy list tooltip content logic to JS.
2019-11-20 17:04:31 -08:00
buddy_list.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
channel.js
node tests: Consolidate some set_global() calls.
2018-08-02 08:02:12 -04:00
color_data.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
colorspace.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
common.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
components.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
compose_actions.js
compose_state: Rename compost_state.recipient to be about PMs only.
2019-12-02 08:53:55 -08:00
compose_fade.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
compose_pm_pill.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
compose_ui.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
compose.js
compose_state: Rename compost_state.recipient to be about PMs only.
2019-12-02 08:53:55 -08:00
composebox_typeahead.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
copy_and_paste.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
dict.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
dispatch.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
drafts.js
compose_state: Rename compost_state.recipient to be about PMs only.
2019-12-02 08:53:55 -08:00
echo.js
echo: Update topic_links when we get messages back from server. (#12832)
2019-07-20 14:38:52 -07:00
emoji_picker.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
emoji.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
fetch_status.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
filter.js
js: Automatically convert var to let and const in more files.
2019-11-20 14:10:47 -08:00
general.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
hash_util.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
hashchange.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
hotkey.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
i18n.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
input_pill.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
keydown_util.js
keydown_util: Ignore alt-arrow and similar things.
2018-12-04 12:24:39 -08:00
lightbox.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
list_cursor.js
node tests: Bring list_cursor to 100% coverage.
2018-08-24 10:00:04 -07:00
list_render.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
markdown.js
js: Automatically convert var to let and const in more files.
2019-11-20 14:10:47 -08:00
message_edit.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
message_events.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
message_fetch.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
message_flags.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
message_list_data.js
search: Don't mark messages as read in search narrow.
2019-07-17 17:58:20 -07:00
message_list_view.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
message_list.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
message_store.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
muting.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
narrow_activate.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
narrow_local.js
narrow: Fix to show last message in narrow when narrow allows.
2019-11-22 12:31:43 -08:00
narrow_state.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
narrow_unread.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
narrow.js
compose_state: Rename compost_state.recipient to be about PMs only.
2019-12-02 08:53:55 -08:00
notifications.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
password.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
people_errors.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
people.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
pm_conversations.js
pm_conversations: Initialize using server data.
2019-11-21 17:01:41 -08:00
pm_list.js
buddy_data: Fix node tests.
2019-11-20 15:16:08 -08:00
popovers.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
presence.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
reactions.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
recent_senders.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
rtl.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
schema.js
lint: Fix comma spacing in node tests.
2018-12-07 13:14:28 -08:00
scroll_util.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
search_legacy.js
Simplify narrow/search interactions.
2018-10-24 16:54:35 -07:00
search_pill.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
search_suggestion_legacy.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
search_suggestion.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
search.js
Revert "search: Open typeahead on empty string only if lookup triggered by Tab."
2018-12-04 13:58:00 -08:00
server_events.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
settings_bots.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
settings_muting.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
settings_org.js
org_settings: Change new user 24-hour setting to dropdown.
2019-11-08 17:39:59 -08:00
settings_profile_fields.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
settings_user_groups.js
js: Automatically convert var to let and const in more files.
2019-11-20 14:10:47 -08:00
stream_data.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
stream_events.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
stream_list.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
stream_search.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
stream_sort.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
submessage.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
subs.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
support.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
templates.js
sidebar: Move the buddy list tooltip content logic to JS.
2019-11-20 17:04:31 -08:00
timerender.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
top_left_corner.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
topic_data.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
topic_generator.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
topic_list.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
transmit.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
typeahead_helper.js
zjsunit: Remove set_global side effect from zrequire.
2019-11-13 14:29:17 -08:00
typing_data.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
typing_status.js
typing: Fix invalid typing notifications for stream messages.
2019-12-02 09:31:16 -08:00
ui_init.js
pm_conversations: Initialize using server data.
2019-11-21 17:01:41 -08:00
ui.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
unread.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
upgrade.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
upload.js
zjsunit: Make window a Proxy for global.
2019-11-13 14:27:13 -08:00
user_events.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
user_groups.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
user_pill.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
user_status.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
util.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
voting_widget.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00
widgetize.js
poll-widget: Refactor comment to option.
2019-01-29 09:34:14 -08:00
zblueslip.js
blueslip: Replace jQuery wrappers with error event listener.
2019-07-09 11:38:20 -07:00
zjquery.js
js: Automatically convert var to let and const in most files.
2019-11-03 12:42:39 -08:00