mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	Enforcing a consistent `type` helps us double-check that we're not playing fast-and-loose with any file paths for local files. As noted in the comment, this is purely for defense-in-depth. Passing `write_local_file` a consistent `type` requires removing the "avatars" out of `realm_avatar_and_logo_path` -- which makes it consistent across upload backends. This, in turn, requires a compensatory change to zerver.lib.export, to be explicit that the realm icons are exported from the avatars directory. This clarity is likely an improvement.