mirror of
https://github.com/zulip/zulip.git
synced 2025-10-23 04:52:12 +00:00
`/usr/bin/pg_dump` on Ubuntu and Debian is actually a tool which attempts to choose which `pg_dump` binary from all of the `postgresql-client-*` packages that are installed to run. However, its logic is confused by passing empty `--host` and `--port` options -- instead of looking at the running server instance on the server, it instead assumes some remote host and chooses the highest versioned `pg_dump` which is installed. Because Zulip writes binary database backups, they are sensitive to the version of the client `pg_dump` binary is used -- and the output may not be backwards compatible. Using a PostgreSQL 16 `pg_dump` writes archive format 1.15, which cannot be read by a PostgreSQL 15 `pg_restore`. Zulip does not currently support PostgreSQL 16 as a server. This means that backups on servers with `postgresql-client-16` installed did not successfully round-trip Zulip backups -- their backups are written using PostgreSQL 16's client, and the `pg_restore` chosen on restore was correctly chosen as the one whose version matched the server (PostgreSQL 15 or below), and thus did not understand the new archive format. Existing `./manage.py backups` taken since `postgresql-client-16` were installed are thus not directly usable by the `restore-backup` script. They are not useless, however, since they can theoretically be converted into a format readable by PostgreSQL 15 -- by importing into a PostgreSQL 16 instance, and re-dumping with a PostgreSQL 15 `pg_dump`. Fix this issue by hard-coding path to the binary whose version matches the version of the server we are connected to. This may theoretically fail if we are connected to a remote PostgreSQL instance and we do not have a `postgresql-client` package locally installed which matches the remote PostgreSQL server's version. However, choosing a matching version is the only way to ensure that it will be able to be imported cleanly -- and it is preferable that we fail the backup process rather than write backups that we cannot easily restore from. Fixes: #27160.
141 lines
5.4 KiB
Python
141 lines
5.4 KiB
Python
import os
|
|
import re
|
|
import tempfile
|
|
from argparse import ArgumentParser, RawTextHelpFormatter
|
|
from typing import Any
|
|
|
|
from django.conf import settings
|
|
from django.core.management.base import CommandParser
|
|
from django.db import connection
|
|
from django.utils.timezone import now as timezone_now
|
|
|
|
from scripts.lib.zulip_tools import TIMESTAMP_FORMAT, parse_os_release, run
|
|
from version import ZULIP_VERSION
|
|
from zerver.lib.management import ZulipBaseCommand
|
|
from zerver.logging_handlers import try_git_describe
|
|
|
|
|
|
class Command(ZulipBaseCommand):
|
|
# Fix support for multi-line usage strings
|
|
def create_parser(self, prog_name: str, subcommand: str, **kwargs: Any) -> CommandParser:
|
|
parser = super().create_parser(prog_name, subcommand, **kwargs)
|
|
parser.formatter_class = RawTextHelpFormatter
|
|
return parser
|
|
|
|
def add_arguments(self, parser: ArgumentParser) -> None:
|
|
parser.add_argument("--output", help="Filename of output tarball")
|
|
parser.add_argument("--skip-db", action="store_true", help="Skip database backup")
|
|
parser.add_argument("--skip-uploads", action="store_true", help="Skip uploads backup")
|
|
|
|
def handle(self, *args: Any, **options: Any) -> None:
|
|
timestamp = timezone_now().strftime(TIMESTAMP_FORMAT)
|
|
with tempfile.TemporaryDirectory(
|
|
prefix=f"zulip-backup-{timestamp}-",
|
|
) as tmp:
|
|
os.mkdir(os.path.join(tmp, "zulip-backup"))
|
|
members = []
|
|
paths = []
|
|
|
|
with open(os.path.join(tmp, "zulip-backup", "zulip-version"), "w") as f:
|
|
print(ZULIP_VERSION, file=f)
|
|
git = try_git_describe()
|
|
if git:
|
|
print(git, file=f)
|
|
members.append("zulip-backup/zulip-version")
|
|
|
|
with open(os.path.join(tmp, "zulip-backup", "os-version"), "w") as f:
|
|
print(
|
|
"{ID} {VERSION_ID}".format(**parse_os_release()),
|
|
file=f,
|
|
)
|
|
members.append("zulip-backup/os-version")
|
|
|
|
with open(os.path.join(tmp, "zulip-backup", "postgres-version"), "w") as f:
|
|
pg_server_version = connection.cursor().connection.server_version
|
|
major_pg_version = pg_server_version // 10000
|
|
print(pg_server_version, file=f)
|
|
members.append("zulip-backup/postgres-version")
|
|
|
|
if settings.DEVELOPMENT:
|
|
members.append(
|
|
os.path.join(settings.DEPLOY_ROOT, "zproject", "dev-secrets.conf"),
|
|
)
|
|
paths.append(
|
|
("zproject", os.path.join(settings.DEPLOY_ROOT, "zproject")),
|
|
)
|
|
else:
|
|
members.append("/etc/zulip")
|
|
paths.append(("settings", "/etc/zulip"))
|
|
|
|
if not options["skip_db"]:
|
|
pg_dump_command = [
|
|
f"/usr/lib/postgresql/{major_pg_version}/bin/pg_dump",
|
|
"--format=directory",
|
|
"--file=" + os.path.join(tmp, "zulip-backup", "database"),
|
|
"--host=" + settings.DATABASES["default"]["HOST"],
|
|
"--port=" + settings.DATABASES["default"]["PORT"],
|
|
"--username=" + settings.DATABASES["default"]["USER"],
|
|
"--dbname=" + settings.DATABASES["default"]["NAME"],
|
|
"--no-password",
|
|
]
|
|
os.environ["PGPASSWORD"] = settings.DATABASES["default"]["PASSWORD"]
|
|
|
|
run(
|
|
pg_dump_command,
|
|
cwd=tmp,
|
|
)
|
|
members.append("zulip-backup/database")
|
|
|
|
if (
|
|
not options["skip_uploads"]
|
|
and settings.LOCAL_UPLOADS_DIR is not None
|
|
and os.path.exists(
|
|
os.path.join(settings.DEPLOY_ROOT, settings.LOCAL_UPLOADS_DIR),
|
|
)
|
|
):
|
|
members.append(
|
|
os.path.join(settings.DEPLOY_ROOT, settings.LOCAL_UPLOADS_DIR),
|
|
)
|
|
paths.append(
|
|
(
|
|
"uploads",
|
|
os.path.join(settings.DEPLOY_ROOT, settings.LOCAL_UPLOADS_DIR),
|
|
),
|
|
)
|
|
|
|
assert not any("|" in name or "|" in path for name, path in paths)
|
|
transform_args = [
|
|
r"--transform=s|^{}(/.*)?$|zulip-backup/{}\1|x".format(
|
|
re.escape(path),
|
|
name.replace("\\", r"\\"),
|
|
)
|
|
for name, path in paths
|
|
]
|
|
|
|
try:
|
|
if options["output"] is None:
|
|
tarball_path = tempfile.NamedTemporaryFile(
|
|
prefix=f"zulip-backup-{timestamp}-",
|
|
suffix=".tar.gz",
|
|
delete=False,
|
|
).name
|
|
else:
|
|
tarball_path = options["output"]
|
|
|
|
run(
|
|
[
|
|
"tar",
|
|
f"--directory={tmp}",
|
|
"-cPzf",
|
|
tarball_path,
|
|
*transform_args,
|
|
"--",
|
|
*members,
|
|
]
|
|
)
|
|
print(f"Backup tarball written to {tarball_path}")
|
|
except BaseException:
|
|
if options["output"] is None:
|
|
os.unlink(tarball_path)
|
|
raise
|