mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 21:43:21 +00:00
92817e147d
This removes zerver/webhooks/trello/view/exceptions.py, which contained legacy Trello webhook exception related classes. We replace them with UnexpectedWebhookEventType, which results in our standard exception handling for unknown event types running (avoiding too-high priority error logging). Fixes #13467.
46 lines
1.8 KiB
Python
46 lines
1.8 KiB
Python
# Webhooks for external integrations.
|
|
import ujson
|
|
from typing import Mapping, Any, Tuple, Optional
|
|
from django.http import HttpRequest, HttpResponse
|
|
from zerver.decorator import api_key_only_webhook_view, return_success_on_head_request
|
|
from zerver.lib.response import json_success
|
|
from zerver.lib.request import REQ, has_request_variables
|
|
from zerver.lib.webhooks.common import check_send_webhook_message, \
|
|
UnexpectedWebhookEventType
|
|
from zerver.models import UserProfile
|
|
|
|
from .card_actions import SUPPORTED_CARD_ACTIONS, \
|
|
IGNORED_CARD_ACTIONS, process_card_action
|
|
from .board_actions import SUPPORTED_BOARD_ACTIONS, process_board_action
|
|
|
|
@api_key_only_webhook_view('Trello')
|
|
@return_success_on_head_request
|
|
@has_request_variables
|
|
def api_trello_webhook(request: HttpRequest,
|
|
user_profile: UserProfile,
|
|
payload: Mapping[str, Any]=REQ(argument_type='body')) -> HttpResponse:
|
|
payload = ujson.loads(request.body)
|
|
action_type = payload['action'].get('type')
|
|
try:
|
|
message = get_subject_and_body(payload, action_type)
|
|
if message is None:
|
|
return json_success()
|
|
else:
|
|
subject, body = message
|
|
except UnexpectedWebhookEventType:
|
|
if action_type in IGNORED_CARD_ACTIONS:
|
|
return json_success()
|
|
|
|
raise UnexpectedWebhookEventType('Trello', action_type)
|
|
|
|
check_send_webhook_message(request, user_profile, subject, body)
|
|
return json_success()
|
|
|
|
def get_subject_and_body(payload: Mapping[str, Any], action_type: str) -> Optional[Tuple[str, str]]:
|
|
if action_type in SUPPORTED_CARD_ACTIONS:
|
|
return process_card_action(payload, action_type)
|
|
if action_type in SUPPORTED_BOARD_ACTIONS:
|
|
return process_board_action(payload, action_type)
|
|
|
|
raise UnexpectedWebhookEventType("Trello", '{} is not supported'.format(action_type))
|