mirror of
https://github.com/zulip/zulip.git
synced 2025-10-27 10:03:56 +00:00
951514dd7d
We now forbid tags of the form `<foo ... />` in most
places, and we also forbid it even for several void
tags.
We make exceptions for tags that are already formatted
in two different ways in our codebase. This is mostly
svg tags, plus these common cases:
- br
- hr
- img
- input
It would be nice to lock down a convention for these,
even though the HTML specification is unopinionated
on these. We'll probably want to stay flexible for
svg tags, since they are sometimes copy/pasted from
other sources (although it's probably rare enough for
them that we can tolerate just doing minor edits as
needed).
134 lines
5.3 KiB
Python
134 lines
5.3 KiB
Python
import unittest
|
|
import os
|
|
|
|
import tools.lib.template_parser
|
|
|
|
from tools.lib.html_branches import (
|
|
get_tag_info,
|
|
html_branches,
|
|
html_tag_tree,
|
|
build_id_dict,
|
|
split_for_id_and_class,
|
|
)
|
|
|
|
ZULIP_PATH = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
|
|
TEST_TEMPLATES_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), "test_template_data")
|
|
|
|
class TestHtmlBranches(unittest.TestCase):
|
|
|
|
def test_get_tag_info(self) -> None:
|
|
html = """
|
|
<p id="test" class="test1 test2">foo</p>
|
|
"""
|
|
|
|
start_tag, end_tag = tools.lib.template_parser.tokenize(html)
|
|
|
|
start_tag_info = get_tag_info(start_tag)
|
|
end_tag_info = get_tag_info(end_tag)
|
|
|
|
self.assertEqual(start_tag_info.text(), 'p.test1.test2#test')
|
|
self.assertEqual(end_tag_info.text(), 'p')
|
|
|
|
def test_html_tag_tree(self) -> None:
|
|
html = """
|
|
<!-- test -->
|
|
<!DOCTYPE html>
|
|
<html>
|
|
<!-- test -->
|
|
<head>
|
|
<title>Test</title>
|
|
<meta charset="utf-8" />
|
|
<link rel="stylesheet" href="style.css" />
|
|
</head>
|
|
<body>
|
|
<p>Hello<br>world!</p>
|
|
<p>Goodbye<!-- test -->world!</p>
|
|
</body>
|
|
</html>
|
|
<!-- test -->
|
|
"""
|
|
|
|
tree = html_tag_tree(html)
|
|
|
|
self.assertEqual(tree.children[0].token.kind, 'html_start')
|
|
self.assertEqual(tree.children[0].token.tag, 'html')
|
|
|
|
self.assertEqual(tree.children[0].children[0].token.kind, 'html_start')
|
|
self.assertEqual(tree.children[0].children[0].token.tag, 'head')
|
|
|
|
self.assertEqual(tree.children[0].children[0].children[0].token.kind, 'html_start')
|
|
self.assertEqual(tree.children[0].children[0].children[0].token.tag, 'title')
|
|
|
|
self.assertEqual(tree.children[0].children[1].token.kind, 'html_start')
|
|
self.assertEqual(tree.children[0].children[1].token.tag, 'body')
|
|
|
|
self.assertEqual(tree.children[0].children[1].children[0].token.kind, 'html_start')
|
|
self.assertEqual(tree.children[0].children[1].children[0].token.tag, 'p')
|
|
|
|
self.assertEqual(tree.children[0].children[1].children[0].children[0].token.kind, 'html_singleton')
|
|
self.assertEqual(tree.children[0].children[1].children[0].children[0].token.tag, 'br')
|
|
|
|
self.assertEqual(tree.children[0].children[1].children[1].token.kind, 'html_start')
|
|
self.assertEqual(tree.children[0].children[1].children[1].token.tag, 'p')
|
|
|
|
def test_html_branches(self) -> None:
|
|
html = """
|
|
<!-- test -->
|
|
<!DOCTYPE html>
|
|
<html>
|
|
<!-- test -->
|
|
<head>
|
|
<title>Test</title>
|
|
<meta charset="utf-8" />
|
|
<link rel="stylesheet" href="style.css" />
|
|
</head>
|
|
<body>
|
|
<p>Hello<br>world!</p>
|
|
<p>Goodbye<!-- test -->world!</p>
|
|
</body>
|
|
</html>
|
|
<!-- test -->
|
|
"""
|
|
|
|
branches = html_branches(html)
|
|
|
|
self.assertEqual(branches[0].text(), 'html head title')
|
|
self.assertEqual(branches[1].text(), 'html body p br')
|
|
self.assertEqual(branches[2].text(), 'html body p')
|
|
|
|
self.assertEqual(branches[0].staircase_text(), '\n html\n head\n title\n')
|
|
self.assertEqual(branches[1].staircase_text(), '\n html\n body\n p\n br\n')
|
|
self.assertEqual(branches[2].staircase_text(), '\n html\n body\n p\n')
|
|
|
|
def test_build_id_dict(self) -> None:
|
|
templates = ["test_template1.html", "test_template2.html"]
|
|
templates = [os.path.join(TEST_TEMPLATES_DIR, fn) for fn in templates]
|
|
|
|
template_id_dict = build_id_dict(templates)
|
|
|
|
self.assertEqual(set(template_id_dict.keys()), {'below_navbar', 'hello_{{ message }}', 'intro'})
|
|
self.assertEqual(template_id_dict['hello_{{ message }}'], [
|
|
'Line 12:%s/tools/tests/test_template_data/test_template1.html' % (ZULIP_PATH,),
|
|
'Line 12:%s/tools/tests/test_template_data/test_template2.html' % (ZULIP_PATH,)])
|
|
self.assertEqual(template_id_dict['intro'], [
|
|
'Line 10:%s/tools/tests/test_template_data/test_template1.html' % (ZULIP_PATH,),
|
|
'Line 11:%s/tools/tests/test_template_data/test_template1.html' % (ZULIP_PATH,),
|
|
'Line 11:%s/tools/tests/test_template_data/test_template2.html' % (ZULIP_PATH,)])
|
|
self.assertEqual(template_id_dict['below_navbar'], [
|
|
'Line 10:%s/tools/tests/test_template_data/test_template2.html' % (ZULIP_PATH,)])
|
|
|
|
def test_split_for_id_and_class(self) -> None:
|
|
id1 = "{{ red|blue }}"
|
|
id2 = "search_box_{{ page }}"
|
|
|
|
class1 = "chat_box message"
|
|
class2 = "stream_{{ topic }}"
|
|
class3 = "foo {{ a|b|c }} bar"
|
|
|
|
self.assertEqual(split_for_id_and_class(id1), ['{{ red|blue }}'])
|
|
self.assertEqual(split_for_id_and_class(id2), ['search_box_{{ page }}'])
|
|
|
|
self.assertEqual(split_for_id_and_class(class1), ['chat_box', 'message'])
|
|
self.assertEqual(split_for_id_and_class(class2), ['stream_{{ topic }}'])
|
|
self.assertEqual(split_for_id_and_class(class3), ['foo', '{{ a|b|c }}', 'bar'])
|