mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 22:13:26 +00:00
9c8fa3930f
For most functions that we were using __Rewire__ for,
it's better to just use the override helper, which
use __Rewire__ under the hood, but also resets
the reference at the end of run_tests.
Another nice thing about override() is that it reports
when you never actually needed the mock, and this
commit fixes the instances found here.
I didn't replace every call to __Rewire__. The
remaining ones fall under these categories:
* I looked for ") =>" in my code sweep,
so I missed stuff like "noop" helpers.
* Sometimes we directly update something
in a module that's not a function. This
is generally evil, and we should use setters.
* Some tests have setup() helpers or similar
that complicated this code sweep, so I
simply punted.
* Somes modules rely on intra-test leaks. We
should fix those, but I just punted for the
main code sweep.
118 lines
3.7 KiB
JavaScript
118 lines
3.7 KiB
JavaScript
"use strict";
|
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
const {mock_module, zrequire} = require("../zjsunit/namespace");
|
|
const {run_test} = require("../zjsunit/test");
|
|
|
|
const reload_state = mock_module("reload_state", {
|
|
is_in_progress: () => false,
|
|
});
|
|
|
|
const people = zrequire("people");
|
|
|
|
const me = {
|
|
email: "me@example.com",
|
|
user_id: 30,
|
|
full_name: "Me Myself",
|
|
timezone: "America/Los_Angeles",
|
|
};
|
|
|
|
people.init();
|
|
people.add_active_user(me);
|
|
people.initialize_current_user(me.user_id);
|
|
|
|
run_test("report_late_add", () => {
|
|
blueslip.expect("error", "Added user late: user_id=55 email=foo@example.com");
|
|
people.report_late_add(55, "foo@example.com");
|
|
|
|
blueslip.expect("log", "Added user late: user_id=55 email=foo@example.com");
|
|
reload_state.is_in_progress = () => true;
|
|
people.report_late_add(55, "foo@example.com");
|
|
});
|
|
|
|
run_test("is_my_user_id", () => {
|
|
blueslip.expect("error", "user_id is a string in my_user_id: 999");
|
|
assert.equal(people.is_my_user_id("999"), false);
|
|
|
|
blueslip.expect("error", "user_id is a string in my_user_id: 30");
|
|
assert.equal(people.is_my_user_id(me.user_id.toString()), true);
|
|
});
|
|
|
|
run_test("blueslip", (override) => {
|
|
const unknown_email = "alicebobfred@example.com";
|
|
|
|
blueslip.expect("debug", "User email operand unknown: " + unknown_email);
|
|
people.id_matches_email_operand(42, unknown_email);
|
|
|
|
blueslip.expect("error", "Unknown user_id: 9999");
|
|
people.get_actual_name_from_user_id(9999);
|
|
|
|
blueslip.expect("error", "Unknown email for get_user_id: " + unknown_email);
|
|
people.get_user_id(unknown_email);
|
|
|
|
blueslip.expect("warn", "No user_id provided for person@example.com");
|
|
const person = {
|
|
email: "person@example.com",
|
|
user_id: undefined,
|
|
full_name: "Person Person",
|
|
};
|
|
people.add_active_user(person);
|
|
|
|
blueslip.expect("error", "No user_id found for person@example.com");
|
|
const user_id = people.get_user_id("person@example.com");
|
|
assert.equal(user_id, undefined);
|
|
|
|
blueslip.expect("warn", "Unknown user ids: 1,2");
|
|
people.user_ids_string_to_emails_string("1,2");
|
|
|
|
blueslip.expect("warn", "Unknown emails: " + unknown_email);
|
|
people.email_list_to_user_ids_string([unknown_email]);
|
|
|
|
let message = {
|
|
type: "private",
|
|
display_recipient: [],
|
|
sender_id: me.user_id,
|
|
};
|
|
blueslip.expect("error", "Empty recipient list in message", 4);
|
|
people.pm_with_user_ids(message);
|
|
people.group_pm_with_user_ids(message);
|
|
people.all_user_ids_in_pm(message);
|
|
assert.equal(people.pm_perma_link(message), undefined);
|
|
|
|
const charles = {
|
|
email: "charles@example.com",
|
|
user_id: 451,
|
|
full_name: "Charles Dickens",
|
|
avatar_url: "charles.com/foo.png",
|
|
};
|
|
const maria = {
|
|
email: "athens@example.com",
|
|
user_id: 452,
|
|
full_name: "Maria Athens",
|
|
};
|
|
people.add_active_user(charles);
|
|
people.add_active_user(maria);
|
|
|
|
message = {
|
|
type: "private",
|
|
display_recipient: [{id: maria.user_id}, {id: 42}, {id: charles.user_id}],
|
|
sender_id: charles.user_id,
|
|
};
|
|
blueslip.expect("error", "Unknown user id in message: 42");
|
|
const reply_to = people.pm_reply_to(message);
|
|
assert(reply_to.includes("?"));
|
|
|
|
override(people, "pm_with_user_ids", () => [42]);
|
|
override(people, "get_by_user_id", () => {});
|
|
blueslip.expect("error", "Unknown people in message");
|
|
const uri = people.pm_with_url({});
|
|
assert.equal(uri.indexOf("unk"), uri.length - 3);
|
|
|
|
blueslip.expect("error", "Undefined field id");
|
|
assert.equal(people.my_custom_profile_data(undefined), undefined);
|
|
|
|
blueslip.expect("error", "Trying to set undefined field id");
|
|
people.set_custom_profile_field_data(maria.user_id, {});
|
|
});
|