mirror of
https://github.com/zulip/zulip.git
synced 2025-11-02 21:13:36 +00:00
a3e265f5b8
I consolidate most of our users toward the top of the file, so that we don't have to clutter up individual tests. This also avoids some confusion where charles/maria got repeated in different tests with different ids. I also introduce a couple four-digit ids to try to expose more bugs related to sorting. Note that it's still easy to keep tests isolated here, as we have always been able to cheaply re-initialize `people.js` and then add individual users back. There are still some tests where it makes sense to just declare users locally, especially if we are mutating their data. There are a few minor incidental cleanups here, mostly involving replacing hard coded ids with things like `maria.user_id`.