Alex Vandiver a40b3e1118 realm_emoji: Stop swallowing all exceptions from upload_emoji_image. ...

Putting all of the logic in a `finally` block is equivalent to a bare
`except` block, which silently consumes all exceptions.

Move only the most-necessary parts into the except; this lets
`BadImageError` exceptions from `zerver/lib/upload.py` to escape,
allowing better the generic "Image file upload failed" to be replaced
with a more specific message.

It also allows unexpected exceptions, as the previous commit resolved,
to escape and 500.  This lets them be detected and resolved, rather
than give users a silently bad experience.

2022-02-17 12:19:47 -08:00

..

fixtures

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

images

upload: Fix resizing non-animated images.

2022-02-17 12:19:47 -08:00

__init__.py

…

test_alert_words.py

…

test_attachments.py

…

test_audit_log.py

refactor: Pass realm to bulk_remove_subscriptions.

2021-12-28 12:15:02 -08:00

test_auth_backends.py

test_auth_backends: Remove deprecated match_querystring argument.

2022-02-10 11:40:34 -08:00

test_bots.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_cache.py

…

test_compatibility.py

…

test_create_video_call.py

integrations: Switch BigBlueButton over to SHA256.

2021-11-25 07:58:27 -08:00

test_custom_profile_data.py

types: Fix declared type of custom profile field values.

2021-09-22 16:22:46 -07:00

test_data_types.py

…

test_decorators.py

backend: Add request as parameter to json_success.

2022-02-04 15:16:56 -08:00

test_digest.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_docs.py

portico: Add iDrift AS case study.

2022-02-07 14:40:31 -08:00

test_drafts.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_email_change.py

confirmation: Use error status codes for confirmation link error pages.

2021-12-01 23:14:04 +00:00

test_email_log.py

…

test_email_mirror.py

upload: Pass the target realm to create_attachment.

2022-01-27 17:23:44 -08:00

test_email_notifications.py

send_custom_email: Add support for emailing remote server contacts.

2021-12-14 18:11:23 -08:00

test_embedded_bot_system.py

tests: Ensure stream senders get a UserMessage row.

2021-12-10 09:40:04 -08:00

test_event_queue.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_event_system.py

docs: Add missing space to compound verbs “back up”, “log in”, etc.

2022-02-07 19:20:54 -08:00

test_events.py

docs: Consistently hyphenate “web-public”.

2022-01-28 17:45:45 -08:00

test_example.py

performance: Avoid Recipient lookup.

2021-12-28 12:15:02 -08:00

test_external.py

remote_server: Migrate RemoteZulipServer.uuid to be UUIDField.

2021-12-28 10:11:34 -08:00

test_github.py

…

test_gitter_importer.py

…

test_home.py

docs: Add missing space to compound verbs “back up”, “log in”, etc.

2022-02-07 19:20:54 -08:00

test_hotspots.py

hotspots: Remove intro_reply hotspot.

2021-12-07 21:55:59 -08:00

test_i18n.py

invite: Extend invite api for handling expiration duration.

2021-09-10 16:53:03 -07:00

test_import_export.py

import: Ensure that .author gets set when importing RealmEmoji.

2022-02-11 18:21:38 +01:00

test_integrations_dev_panel.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_integrations.py

…

test_internet.py

…

test_legacy_subject.py

…

test_link_embed.py

tests: Ensure stream senders get a UserMessage row.

2021-12-10 09:40:04 -08:00

test_logging_handlers.py

…

test_management_commands.py

export: Remove --delete-after-upload flag in realm export.

2021-11-03 11:14:02 -07:00

test_markdown.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_mattermost_importer.py

tests: Verify emoji codes.

2021-12-06 13:22:47 -08:00

test_message_dict.py

tests: Ensure stream senders get a UserMessage row.

2021-12-10 09:40:04 -08:00

test_message_edit_notifications.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_message_edit.py

message_edit: Fix unused parameter in most tests.

2022-02-09 15:13:04 -08:00

test_message_fetch.py

pgroonga: Re-enable PGroonga in development.

2022-02-13 19:11:49 -08:00

test_message_flags.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_message_send.py

message: Check mandatory_topics setting in backend as well.

2022-02-02 10:11:35 -08:00

test_message_topics.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_messages.py

…

test_middleware.py

mypy: Add types-beautifulsoup4.

2022-01-23 23:39:40 -08:00

test_migrations.py

…

test_mirror_users.py

…

test_muting_topics.py

topic: Return JsonableError for race condition in topic mute.

2022-02-09 14:35:12 -08:00

test_muting_users.py

tests: Ensure stream senders get a UserMessage row.

2021-12-10 09:40:04 -08:00

test_new_users.py

test_new_users: Select test emails deterministically.

2022-02-11 18:09:43 -08:00

test_notification_data.py

notifications: Don't enqueue notifications for bots.

2022-01-03 09:55:06 -08:00

test_onboarding.py

…

test_openapi.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_outgoing_http.py

python: Replace requests.packages.urllib3 alias with urllib3.

2022-01-23 22:14:17 -08:00

test_outgoing_webhook_interfaces.py

outgoing webhooks: Fix inconsistencies with Slack's API.

2021-09-23 11:19:20 -07:00

test_outgoing_webhook_system.py

…

test_populate_db.py

…

test_presence.py

…

test_push_notifications.py

push_notifications: Fix for aioapns 2.1.

2022-02-08 15:16:31 -08:00

test_queue_worker.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_queue.py

test_queue_error_json: Acknowledge the received message.

2022-01-21 13:38:13 -08:00

test_rate_limiter.py

…

test_reactions.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_realm_domains.py

…

test_realm_emoji.py

realm_emoji: Stop swallowing all exceptions from upload_emoji_image.

2022-02-17 12:19:47 -08:00

test_realm_export.py

test_classes: Extract assert_streaming_content helper.

2022-01-21 13:37:26 -08:00

test_realm_linkifiers.py

linkifiers: Support URL percent-encoded bytes.

2021-10-22 13:00:20 -07:00

test_realm_playgrounds.py

…

test_realm.py

pricing: Replace "Zulip Standard" with "Zulip Cloud Standard".

2022-02-09 11:00:24 -08:00

test_redis_utils.py

…

test_report.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_retention.py

upload: Pass the target realm to create_attachment.

2022-01-27 17:23:44 -08:00

test_rocketchat_importer.py

tests: Verify emoji codes.

2021-12-06 13:22:47 -08:00

test_scim.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_send_email.py

send_email: Log error if EMAIL_HOST_USER is set without password.

2022-02-09 11:04:40 -08:00

test_service_bot_system.py

…

test_sessions.py

auth: Add login buttons for web public access.

2021-10-05 16:30:40 -07:00

test_settings.py

timezone: List only canonical timezone identifiers.

2022-02-11 17:38:57 -08:00

test_signup.py

timezone: List only canonical timezone identifiers.

2022-02-11 17:38:57 -08:00

test_slack_importer.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_slack_message_conversion.py

…

test_soft_deactivation.py

…

test_subdomains.py

…

test_submessage.py

tests: Ensure stream senders get a UserMessage row.

2021-12-10 09:40:04 -08:00

test_subs.py

pricing: Replace "Zulip Standard" with "Zulip Cloud Standard".

2022-02-09 11:00:24 -08:00

test_templates.py

markdown/tabbed_sections: Raise exception for missing tab name.

2021-10-01 16:25:17 -07:00

test_thumbnail.py

…

test_timestamp.py

…

test_timezone.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_tornado.py

…

test_transfer.py

tests: Use read_test_image_file.

2022-01-13 14:59:46 -08:00

test_tutorial.py

onboarding: Manage occurrence of 'help' command.

2021-12-06 11:32:00 -08:00

test_type_debug.py

…

test_typing.py

typing_notifications: Make privacy settings functional.

2021-10-07 17:39:22 -07:00

test_upload.py

realm_emoji: Stop swallowing all exceptions from upload_emoji_image.

2022-02-17 12:19:47 -08:00

test_urls.py

test_urls: Fix get_callback_string logic.

2021-12-28 09:31:55 -08:00

test_user_groups.py

tests: Use more selective query in user group tests.

2021-10-19 17:02:10 -07:00

test_user_status.py

…

test_users.py

do_set_realm_property: Use transaction.atomic.

2022-01-28 13:03:39 -08:00

test_webhooks_common.py

docs: Fix many spelling mistakes.

2022-02-07 18:51:06 -08:00

test_widgets.py

…

test_zcommand.py

zcommand: Replace "mode" with "theme" in the returned message.

2021-11-22 14:59:16 -08:00

test_zephyr.py

…