mirror of
https://github.com/zulip/zulip.git
synced 2025-11-08 16:01:58 +00:00
404439e98c
The TeamCity webhook plugin supports multiple payload formats that are customized to be used by different services such as Slack, Flowdock, etc. We don't support such payloads, so we should ignore them and stick to parsing only the generic ones. We should also notify that bot owner about the error.
56 lines
4.0 KiB
Python
56 lines
4.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
import ujson
|
|
|
|
from zerver.lib.test_classes import WebhookTestCase
|
|
from zerver.lib.send_email import FromAddress
|
|
from zerver.models import Recipient, get_user, get_realm
|
|
from zerver.webhooks.teamcity.view import MISCONFIGURED_PAYLOAD_TYPE_ERROR_MESSAGE
|
|
|
|
class TeamcityHookTests(WebhookTestCase):
|
|
STREAM_NAME = 'teamcity'
|
|
URL_TEMPLATE = u"/api/v1/external/teamcity?stream={stream}&api_key={api_key}"
|
|
SUBJECT = u"Project :: Compile"
|
|
FIXTURE_DIR_NAME = 'teamcity'
|
|
|
|
def test_teamcity_success(self) -> None:
|
|
expected_message = u"Project :: Compile build 5535 - CL 123456 was successful! :thumbs_up:\nDetails: [changes](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952&tab=buildChangesDiv), [build log](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952)"
|
|
self.send_and_test_stream_message('success', self.SUBJECT, expected_message)
|
|
|
|
def test_teamcity_success_branch(self) -> None:
|
|
expected_message = u"Project :: Compile build 5535 - CL 123456 was successful! :thumbs_up:\nDetails: [changes](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952&tab=buildChangesDiv), [build log](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952)"
|
|
expected_subject = u"Project :: Compile (MyBranch)"
|
|
self.send_and_test_stream_message('success_branch', expected_subject, expected_message)
|
|
|
|
def test_teamcity_broken(self) -> None:
|
|
expected_message = u"Project :: Compile build 5535 - CL 123456 is broken with status Exit code 1 (new)! :thumbs_down:\nDetails: [changes](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952&tab=buildChangesDiv), [build log](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952)"
|
|
self.send_and_test_stream_message('broken', self.SUBJECT, expected_message)
|
|
|
|
def test_teamcity_failure(self) -> None:
|
|
expected_message = u"Project :: Compile build 5535 - CL 123456 is still broken with status Exit code 1! :thumbs_down:\nDetails: [changes](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952&tab=buildChangesDiv), [build log](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952)"
|
|
self.send_and_test_stream_message('failure', self.SUBJECT, expected_message)
|
|
|
|
def test_teamcity_fixed(self) -> None:
|
|
expected_message = u"Project :: Compile build 5535 - CL 123456 has been fixed! :thumbs_up:\nDetails: [changes](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952&tab=buildChangesDiv), [build log](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952)"
|
|
self.send_and_test_stream_message('fixed', self.SUBJECT, expected_message)
|
|
|
|
def test_teamcity_personal(self) -> None:
|
|
expected_message = u"Your personal build of Project :: Compile build 5535 - CL 123456 is broken with status Exit code 1 (new)! :thumbs_down:\nDetails: [changes](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952&tab=buildChangesDiv), [build log](http://teamcity/viewLog.html?buildTypeId=Project_Compile&buildId=19952)"
|
|
payload = ujson.dumps(ujson.loads(self.webhook_fixture_data(self.FIXTURE_DIR_NAME, 'personal')))
|
|
self.client_post(self.url, payload, content_type="application/json")
|
|
msg = self.get_last_message()
|
|
|
|
self.assertEqual(msg.content, expected_message)
|
|
self.assertEqual(msg.recipient.type, Recipient.PERSONAL)
|
|
|
|
def test_non_generic_payload_ignore_pm_notification(self) -> None:
|
|
expected_message = MISCONFIGURED_PAYLOAD_TYPE_ERROR_MESSAGE.format(
|
|
bot_name=get_user('webhook-bot@zulip.com', get_realm('zulip')).full_name,
|
|
support_email=FromAddress.SUPPORT
|
|
).strip()
|
|
payload = self.get_body('slack_non_generic_payload')
|
|
self.client_post(self.url, payload, content_type="application/json")
|
|
msg = self.get_last_message()
|
|
|
|
self.assertEqual(msg.content, expected_message)
|
|
self.assertEqual(msg.recipient.type, Recipient.PERSONAL)
|