Files
zulip/web/tests/user_topics.test.js
Hardik Dharmani aab252f657 user_topics: Update user_topics.js to include all visibility policies.
Updated user_topics.js to include all visibility policies
rather than just mute/inherit visibility policies.

Replaced muted_topics Map with `all_user_topics` Map which has
structure: {stream_id:{topic_name:{date_updated,visibility_policy}}}.

Removed add_muted_topic, remove_muted_topic functions which were
adding/removing topics in muted_topics Map. Added new function
update_user_topics which take parameter stream_id, topic,
visibility_policy, and date_updated(optional) which adds a topic
to all_user_topics with date_updated and visibility_policy,
if visibility_policy is not equal to inherit.
else, removes topic from all_user_topics.

Added get_topic_visibility_policy which returns visibility_policy
if stream_id is not undefined else return false.

Added 2 helper functions is_topic_muted and is_topic_unmuted which
uses get_topic_visibility_policy and return true if topic is
muted and unmuted respectively else return false.

Replaced switch case statement which was using add_muted_topic
and remove_muted_topic functions in set_user_topic with new function
update_user_topics.

Fixes #24244
2023-04-11 09:51:01 -07:00

205 lines
6.2 KiB
JavaScript

"use strict";
const {strict: assert} = require("assert");
const {all_visibility_policies} = require("../src/user_topics");
const {zrequire} = require("./lib/namespace");
const {run_test} = require("./lib/test");
const blueslip = require("./lib/zblueslip");
const {page_params} = require("./lib/zpage_params");
const user_topics = zrequire("user_topics");
const stream_data = zrequire("stream_data");
const design = {
stream_id: 100,
name: "design",
};
const devel = {
stream_id: 101,
name: "devel",
};
const office = {
stream_id: 102,
name: "office",
};
const social = {
stream_id: 103,
name: "social",
};
const unknown = {
stream_id: 999,
name: "whatever",
};
stream_data.add_sub(design);
stream_data.add_sub(devel);
stream_data.add_sub(office);
stream_data.add_sub(social);
function test(label, f) {
run_test(label, ({override}) => {
user_topics.set_user_topics([]);
f({override});
});
}
test("edge_cases", () => {
// private messages
assert.ok(!user_topics.is_topic_muted(undefined, undefined));
});
test("add_and_remove_mutes", () => {
assert.ok(!user_topics.is_topic_muted(devel.stream_id, "java"));
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.MUTED);
assert.ok(user_topics.is_topic_muted(devel.stream_id, "java"));
// test idempotency
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.MUTED);
assert.ok(user_topics.is_topic_muted(devel.stream_id, "java"));
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.INHERIT);
assert.ok(!user_topics.is_topic_muted(devel.stream_id, "java"));
// test idempotency
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.INHERIT);
assert.ok(!user_topics.is_topic_muted(devel.stream_id, "java"));
// test unknown stream is harmless too
user_topics.update_user_topics(unknown.stream_id, "java", all_visibility_policies.INHERIT);
assert.ok(!user_topics.is_topic_muted(unknown.stream_id, "java"));
});
test("add_and_remove_unmutes", () => {
assert.ok(!user_topics.is_topic_unmuted(devel.stream_id, "java"));
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.UNMUTED);
assert.ok(user_topics.is_topic_unmuted(devel.stream_id, "java"));
// test idempotency
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.UNMUTED);
assert.ok(user_topics.is_topic_unmuted(devel.stream_id, "java"));
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.INHERIT);
assert.ok(!user_topics.is_topic_unmuted(devel.stream_id, "java"));
// test idempotency
user_topics.update_user_topics(devel.stream_id, "java", all_visibility_policies.INHERIT);
assert.ok(!user_topics.is_topic_unmuted(devel.stream_id, "java"));
// test unknown stream is harmless too
user_topics.update_user_topics(unknown.stream_id, "java", all_visibility_policies.INHERIT);
assert.ok(!user_topics.is_topic_unmuted(unknown.stream_id, "java"));
});
test("get_mutes", () => {
assert.deepEqual(user_topics.get_muted_topics(), []);
user_topics.update_user_topics(
office.stream_id,
"gossip",
all_visibility_policies.MUTED,
1577836800,
);
user_topics.update_user_topics(
devel.stream_id,
"java",
all_visibility_policies.MUTED,
1577836700,
);
const all_muted_topics = user_topics
.get_muted_topics()
.sort((a, b) => a.date_muted - b.date_muted);
assert.deepEqual(all_muted_topics, [
{
date_muted: 1577836700000,
date_muted_str: "Dec 31, 2019",
stream: devel.name,
stream_id: devel.stream_id,
topic: "java",
},
{
date_muted: 1577836800000,
date_muted_str: "Jan 1, 2020",
stream: office.name,
stream_id: office.stream_id,
topic: "gossip",
},
]);
});
test("set_user_topics", () => {
blueslip.expect("warn", "Unknown stream ID in set_user_topic: 999");
user_topics.set_user_topics([]);
assert.ok(!user_topics.is_topic_muted(social.stream_id, "breakfast"));
assert.ok(!user_topics.is_topic_muted(design.stream_id, "typography"));
page_params.user_topics = [
{
stream_id: social.stream_id,
topic_name: "breakfast",
last_updated: "1577836800",
visibility_policy: all_visibility_policies.MUTED,
},
{
stream_id: design.stream_id,
topic_name: "typography",
last_updated: "1577836800",
visibility_policy: all_visibility_policies.MUTED,
},
{
stream_id: 999, // BOGUS STREAM ID
topic_name: "random",
last_updated: "1577836800",
visibility_policy: all_visibility_policies.MUTED,
},
];
user_topics.initialize();
assert.deepEqual(user_topics.get_muted_topics().sort(), [
{
date_muted: 1577836800000,
date_muted_str: "Jan 1, 2020",
stream: social.name,
stream_id: social.stream_id,
topic: "breakfast",
},
{
date_muted: 1577836800000,
date_muted_str: "Jan 1, 2020",
stream: design.name,
stream_id: design.stream_id,
topic: "typography",
},
]);
user_topics.set_user_topic({
stream_id: design.stream_id,
topic_name: "typography",
last_updated: "1577836800",
visibility_policy: all_visibility_policies.INHERIT,
});
assert.ok(!user_topics.is_topic_muted(design.stream_id, "typography"));
});
test("case_insensitivity", () => {
user_topics.set_user_topics([]);
assert.ok(!user_topics.is_topic_muted(social.stream_id, "breakfast"));
user_topics.set_user_topics([
{
stream_id: social.stream_id,
topic_name: "breakfast",
last_updated: "1577836800",
visibility_policy: all_visibility_policies.MUTED,
},
]);
assert.ok(user_topics.is_topic_muted(social.stream_id, "breakfast"));
assert.ok(user_topics.is_topic_muted(social.stream_id, "breakFAST"));
});