mirror of
https://github.com/zulip/zulip.git
synced 2025-10-23 04:52:12 +00:00
3bad36ef8c
This commit renames the 'queue_json_publish' function to 'queue_json_publish_rollback_unsafe' to reflect the fact that it doesn't wait for the db transaction (within which it gets called, if any) to commit and sends event irrespective of commit or rollback. In most of the cases we don't want to send event in the case of rollbacks, so the caller should be aware that calling the function directly is rollback unsafe. Fixes part of #30489.
50 lines
1.7 KiB
Python
50 lines
1.7 KiB
Python
from django.conf import settings
|
|
from django.db import migrations
|
|
from django.db.backends.base.schema import BaseDatabaseSchemaEditor
|
|
from django.db.migrations.state import StateApps
|
|
|
|
from zerver.lib.queue import queue_json_publish_rollback_unsafe
|
|
|
|
|
|
def reupload_realm_emoji(apps: StateApps, schema_editor: BaseDatabaseSchemaEditor) -> None:
|
|
"""As detailed in https://github.com/zulip/zulip/issues/21608, it is
|
|
possible for the deferred_work queue from Zulip 4.x to have been
|
|
started up by puppet during the deployment before migrations were
|
|
run on Zulip 5.0.
|
|
|
|
This means that the deferred_work events originally produced by
|
|
migration 0376 might have been processed and discarded without
|
|
effect.
|
|
|
|
That code has been removed from the 0376 migration, and we run it
|
|
here, after the upgrade code has been fixed; servers which already
|
|
processed that migration might at worst do this work twice, which
|
|
is harmless aside from being a small waste of resources.
|
|
"""
|
|
|
|
Realm = apps.get_model("zerver", "Realm")
|
|
if settings.TEST_SUITE:
|
|
# There are no custom emoji in the test suite data set, and
|
|
# the below code won't work because RabbitMQ isn't enabled for
|
|
# the test suite.
|
|
return
|
|
|
|
for realm_id in Realm.objects.order_by("id").values_list("id", flat=True):
|
|
event = {
|
|
"type": "reupload_realm_emoji",
|
|
"realm_id": realm_id,
|
|
}
|
|
queue_json_publish_rollback_unsafe("deferred_work", event)
|
|
|
|
|
|
class Migration(migrations.Migration):
|
|
dependencies = [
|
|
("zerver", "0386_fix_attachment_caches"),
|
|
]
|
|
|
|
operations = [
|
|
migrations.RunPython(
|
|
reupload_realm_emoji, reverse_code=migrations.RunPython.noop, elidable=True
|
|
),
|
|
]
|