paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 00:46:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
b38cbc8f34d9a4da55bb388ae0c072ec9985749d
zulip/static/js
History
ryanreh99 b38cbc8f34 typeahead: Fix stream+topic completions for empty query. 
This fixes a bug where the autocomplete for topics
deleted all the text content, if the topic jump is used
without entering any text.

The topic typeahead is automatically set up, on entering
the ">" key for stream completions. Therefore there is a
case where the user can select a typeahead item without
entering any text.

Thus the token length will be 0 and `beginning.slice(0, -0)` returns
"" instead of the `beginning` string.  The case is only relevant for
"topic_list" completion as we don't set up the typeahead for empty
strings.

Fix this by reverting a hunk of
48f5e5179a, adding a test.

Fixes #16599.

Co-authored-by: Rohitt Vashishtha <aero31aero@gmail.com>
2020-10-29 11:02:17 -07:00
..
analytics
support: Confirm the string_id before scrubbing the realm.
2020-09-28 15:37:49 -07:00
billing
eslint: Fix unicorn/prefer-add-event-listener.
2020-10-07 16:00:33 -07:00
bundles
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
portico
apps: Link android download button directly to APK file.
2020-10-28 23:04:14 -07:00
stats
eslint: Fix unicorn/no-reduce.
2020-10-07 16:00:33 -07:00
types
js: Reformat with Prettier.
2020-07-17 14:31:25 -07:00
activity.js
web_public_guest: Rename to web_public_visitor for clarity.
2020-10-13 16:59:52 -07:00
admin.js
settings_org: Add frontend to change wildcard_mention_policy.
2020-10-22 15:00:27 -07:00
alert_words_ui.js
docs: Fix capitalization of keyboard keys.
2020-08-11 10:25:53 -07:00
alert_words.js
eslint: Fix no-useless-concat.
2020-10-07 16:00:33 -07:00
archive.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
attachments_ui.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
avatar.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
blueslip_stacktrace.ts
blueslip_stacktrace: Add missing exception handlers.
2020-07-28 11:01:35 -07:00
blueslip.js
eslint: Fix no-useless-concat.
2020-10-07 16:00:33 -07:00
bot_data.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
buddy_data.js
eslint: Fix unicorn/better-regex.
2020-10-07 16:00:33 -07:00
buddy_list.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
channel.js
eslint: Fix unicorn/catch-error-name.
2020-10-07 16:00:33 -07:00
click_handlers.js
recent_topics: Go to topic if user clicks anywhere in topic col.
2020-10-08 17:05:06 -07:00
color_data.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
colorspace.js
eslint: Fix unicorn/no-zero-fractions.
2020-10-07 16:00:33 -07:00
common.js
eslint: Fix unicorn/better-regex.
2020-10-07 16:00:33 -07:00
components.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
compose_actions.js
video_calls: Refactor zoom_xhrs to support other OAuth video applications.
2020-10-28 23:08:16 -07:00
compose_fade.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
compose_pm_pill.js
compose_pm_pill: Don’t reference nonexistent input_pull members.
2020-09-25 15:12:33 -07:00
compose_state.js
eslint: Fix no-implicit-coercion.
2020-10-07 16:00:33 -07:00
compose_ui.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
compose.js
video_calls: Refactor zoom_xhrs to support other OAuth video applications.
2020-10-28 23:08:16 -07:00
composebox_typeahead.js
typeahead: Fix stream+topic completions for empty query.
2020-10-29 11:02:17 -07:00
condense.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
confirm_dialog.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
copy_and_paste.js
eslint: Fix unicorn/better-regex.
2020-10-07 16:00:33 -07:00
csrf.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
debug.js
debug: Remove debug from globals.
2020-07-29 11:17:24 -07:00
drafts.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
dropdown_list_widget.js
dropdown_list_widget: Move require to top level.
2020-09-25 15:12:24 -07:00
echo.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
emoji_picker.js
js: Optimize out unnecessary jQuery filter calls.
2020-10-07 16:00:33 -07:00
emojisets.js
eslint: Fix unicorn/prefer-add-event-listener.
2020-10-07 16:00:33 -07:00
favicon.js
favicon: Invalidate favicon_state.image without a network request.
2020-10-28 23:06:26 -07:00
feature_flags.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
feedback_widget.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
fetch_status.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
filter.js
eslint: Fix unicorn/escape-case and unicorn/no-hex-escape.
2020-10-07 16:00:33 -07:00
floating_recipient_bar.js
eslint: Fix unicorn/no-for-loop.
2020-10-07 16:00:33 -07:00
fold_dict.ts
typescript: Enable strictNullChecks.
2020-07-28 11:01:35 -07:00
gear_menu.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
global.d.ts
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
hash_util.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
hashchange.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
hbs.d.ts
blueslip: Make stack trace more readable.
2019-10-31 13:47:54 -07:00
hotkey.js
js: Optimize out unnecessary jQuery filter calls.
2020-10-07 16:00:33 -07:00
hotspots.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
huddle_data.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
i18n.js
docs: Add comment links to i18n documentation.
2020-09-18 11:44:04 -07:00
info_overlay.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
input_pill.js
eslint: Fix unicorn/prefer-text-content.
2020-10-07 16:00:33 -07:00
invite.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
keydown_util.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
lazy_set.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
lightbox_canvas.js
eslint: Fix unicorn/prefer-add-event-listener.
2020-10-07 16:00:33 -07:00
lightbox.js
eslint: Fix no-implicit-coercion.
2020-10-07 16:00:33 -07:00
list_cursor.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
list_render.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
list_util.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
loading.js
loading: Add aria-hidden="true" attribute to loading spinners.
2020-08-09 16:47:56 -07:00
local_message.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
localstorage.js
eslint: Fix unicorn/prefer-optional-catch-binding.
2020-10-07 16:00:33 -07:00
markdown_config.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
markdown.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
message_edit_history.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
message_edit.js
video_calls: Refactor zoom_xhrs to support other OAuth video applications.
2020-10-28 23:08:16 -07:00
message_events.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
message_fetch.js
eslint: Fix unicorn/prefer-set-has.
2020-10-07 16:00:33 -07:00
message_flags.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
message_list_data.js
eslint: Fix unicorn/prefer-type-error.
2020-10-07 16:00:33 -07:00
message_list_view.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
message_list.js
eslint: Fix unicorn/prefer-type-error.
2020-10-07 16:00:33 -07:00
message_live_update.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
message_scroll.js
message_scroll: Rename actively_scrolling() to is_actively_scrolling().
2020-09-25 15:12:24 -07:00
message_store.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
message_util.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
message_view_header.js
shortcuts: Fixed Keyboard shortcut in Firefox.
2020-10-20 17:07:48 -07:00
message_viewport.js
styles: Rename .scss files back to .css.
2020-09-15 16:33:28 -07:00
muting_ui.js
eslint: Fix unicorn/prefer-includes.
2020-10-07 16:00:33 -07:00
muting.js
js: Use destructuring for require statements.
2020-09-23 09:06:07 -04:00
narrow_state.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
narrow.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
navigate.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
night_mode.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
notifications.js
notifications: Use a dynamic SVG favicon for unread counts.
2020-10-21 07:43:00 -07:00
overlays.js
docs: Add spaces to “check out”, “log in”, “set up”, “sign up” as verbs.
2020-10-13 15:47:13 -07:00
padded_widget.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
page_params.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
panels.js
js: Optimize out unnecessary jQuery filter calls.
2020-10-07 16:00:33 -07:00
people.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
pill_typeahead.js
eslint: Fix unicorn/prefer-includes.
2020-10-07 16:00:33 -07:00
pm_conversations.js
js: Convert pm_conversations module to ES6.
2020-09-01 19:55:58 -07:00
pm_list_dom.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
pm_list.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
poll_widget.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
popovers.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
presence.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
reactions.js
reactions: Handle missing realm emojis.
2020-10-06 17:22:54 -07:00
ready.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
realm_icon.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
realm_logo.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
recent_senders.js
js: Use destructuring for require statements.
2020-09-23 09:06:07 -04:00
recent_topics.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
reload_state.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
reload.js
eslint: Fix unicorn/catch-error-name.
2020-10-07 16:00:33 -07:00
reminder.js
eslint: Fix unicorn/prefer-array-find.
2020-10-07 16:00:33 -07:00
rendered_markdown.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
resize.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
rows.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
rtl.js
eslint: Fix unicorn/prefer-set-has.
2020-10-07 16:00:33 -07:00
schema.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
scroll_bar.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
scroll_util.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
search_pill_widget.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
search_pill.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
search_suggestion.js
eslint: Fix unicorn/prefer-string-slice.
2020-10-07 16:00:33 -07:00
search_util.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
search.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
sent_messages.js
eslint: Fix no-useless-concat.
2020-10-07 16:00:33 -07:00
server_events_dispatch.js
settings_org: Add frontend to change wildcard_mention_policy.
2020-10-22 15:00:27 -07:00
server_events.js
web_public_guest: Rename to web_public_visitor for clarity.
2020-10-13 16:59:52 -07:00
settings_account.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
settings_bots.js
eslint: Fix unicorn/better-regex.
2020-10-07 16:00:33 -07:00
settings_config.js
settings_org: Add frontend to change wildcard_mention_policy.
2020-10-22 15:00:27 -07:00
settings_data.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
settings_display.js
js: Elide .js and .ts extensions from imports and requires.
2020-09-01 16:43:02 -07:00
settings_emoji.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
settings_exports.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
settings_invites.js
invites: Display name of referrer instead of email in invites list.
2020-09-22 15:42:53 -07:00
settings_linkifiers.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
settings_muting.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
settings_notifications.js
notifications: Use a dynamic SVG favicon for unread counts.
2020-10-21 07:43:00 -07:00
settings_org.js
settings_org: Add frontend to change wildcard_mention_policy.
2020-10-22 15:00:27 -07:00
settings_panel_menu.js
settings: Hide open popovers when switching panels in settings overlay.
2020-08-12 17:31:25 -07:00
settings_profile_fields.js
eslint: Fix unicorn/no-for-loop.
2020-10-07 16:00:33 -07:00
settings_sections.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
settings_streams.js
eslint: Fix no-useless-concat.
2020-10-07 16:00:33 -07:00
settings_toggle.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
settings_ui.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
settings_user_groups.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
settings_users.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
settings.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
setup.js
setup: Add setter for password_change_in_progress.
2020-09-25 15:12:24 -07:00
spoilers.js
docs: Capitalize Markdown consistently.
2020-08-11 10:23:06 -07:00
starred_messages.js
starred_messages: Rename count() to get_count().
2020-09-25 15:12:33 -07:00
stream_color.js
eslint: Fix unicorn/better-regex.
2020-10-07 16:00:33 -07:00
stream_create.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
stream_data.js
eslint: Fix unicorn/better-regex.
2020-10-07 16:00:33 -07:00
stream_edit.js
popover: Show normal popover for the stream_subscription_info users.
2020-10-12 17:42:52 -07:00
stream_events.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
stream_list.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
stream_muting.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
stream_pill.js
eslint: Fix unicorn/prefer-string-slice.
2020-10-07 16:00:33 -07:00
stream_popover.js
eslint: Fix unicorn/no-reduce.
2020-10-07 16:00:33 -07:00
stream_sort.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
stream_topic_history.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
stream_ui_updates.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
submessage.js
eslint: Fix unicorn/catch-error-name.
2020-10-07 16:00:33 -07:00
subs.js
docs: Fix more capitalization issues.
2020-10-23 11:46:55 -07:00
templates.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
tictactoe_widget.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
timerender.js
timerender: Extract func to calculate days_old from time.
2020-10-08 17:05:06 -07:00
todo_widget.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
top_left_corner.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
topic_generator.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
topic_list_data.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
topic_list.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
topic_zoom.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
transmit.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
tutorial.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
typeahead_helper.js
eslint: Fix unicorn/prefer-string-slice.
2020-10-07 16:00:33 -07:00
typing_data.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
typing_events.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
typing.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
ui_init.js
markdown: bugfix: Fix importing pygments data for codeblock header creation.
2020-09-28 15:39:31 -07:00
ui_report.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
ui_util.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
ui.js
dependencies: Downgrade simplebar to 5.2.1.
2020-09-24 16:13:47 -07:00
unread_ops.js
notifications: Rename window_has_focus variable and function.
2020-09-25 15:12:24 -07:00
unread_ui.js
notifications: Use a dynamic SVG favicon for unread counts.
2020-10-21 07:43:00 -07:00
unread.js
js: Use destructuring for require statements.
2020-09-23 09:06:07 -04:00
upload_widget.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
upload.js
eslint: Fix unicorn/prefer-optional-catch-binding.
2020-10-07 16:00:33 -07:00
user_events.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
user_groups.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
user_pill.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
user_search.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
user_status_ui.js
js: Purge people module from window.
2020-09-01 19:55:58 -07:00
user_status.js
eslint: Fix unicorn/prefer-number-properties.
2020-10-07 16:00:33 -07:00
util.js
eslint: Fix unicorn/catch-error-name.
2020-10-07 16:00:33 -07:00
vdom.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
widgetize.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
zcommand.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00
zform.js
eslint: Replace empty-returns with consistent-return.
2020-09-25 15:17:59 -07:00
zulip.js
js: Add "use strict" directive to CommonJS files.
2020-07-31 22:09:46 -07:00