mirror of
https://github.com/zulip/zulip.git
synced 2025-10-23 04:52:12 +00:00
The URL structure for a shared link has changed since this function was returned and this commit makes sure our code is in compliance with that structure. The concept of an album doesn't exist anymore and folders exist in-lieu of that. For dropbox links that are folders on non-image files, we show previews same as any other link previews. It is not possible to get information about the shared link except whether it is a file or folder. So for title and description for that linked preview, we use `Dropbox file` or `Dropbox folder` respectively. Earlier, we were just having raw=1 as the query param to get the image file if required, but now for every dropbox sharing link, preserving query params is important (otherwise we get a 404), this commit makes changes to address that. For /sc/ links, it is not possible to generate them anymore (afaik), but it is possible to view those existing links, so we support that link but treat it as a folder instead. You can check https://www.dropboxforum.com/discussions/101001012/shared-link--scl-to-s/689070/replies/695266 for URL structure info. We have used inline ignore for codespell since fo can be a valid misspell of `of` and we don't want to ignore that. https://chat.zulip.org/#narrow/channel/9-issues/topic/.F0.9F.93.82.20message_inline_ref.20dropbox.20links Co-authored-by: Tim Abbott <tabbott@zulip.com>