mirror of
https://github.com/zulip/zulip.git
synced 2025-11-12 18:06:44 +00:00
42435db492
This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
418 lines
12 KiB
JavaScript
418 lines
12 KiB
JavaScript
// These unit tests for static/js/message_list.js emphasize the model-ish
|
|
// aspects of the MessageList class. We have to stub out a few functions
|
|
// related to views and events to get the tests working.
|
|
|
|
var noop = function () {};
|
|
|
|
set_global('Filter', noop);
|
|
global.stub_out_jquery();
|
|
set_global('document', null);
|
|
|
|
zrequire('FetchStatus', 'js/fetch_status');
|
|
zrequire('util');
|
|
zrequire('muting');
|
|
zrequire('MessageListData', 'js/message_list_data');
|
|
zrequire('MessageListView', 'js/message_list_view');
|
|
var MessageList = zrequire('message_list').MessageList;
|
|
|
|
set_global('i18n', global.stub_i18n);
|
|
set_global('feature_flags', {});
|
|
|
|
var with_overrides = global.with_overrides; // make lint happy
|
|
|
|
run_test('basics', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
|
|
var messages = [
|
|
{
|
|
id: 50,
|
|
content: 'fifty',
|
|
},
|
|
{
|
|
id: 60,
|
|
},
|
|
{
|
|
id: 70,
|
|
},
|
|
{
|
|
id: 80,
|
|
},
|
|
];
|
|
|
|
assert.equal(list.empty(), true);
|
|
|
|
list.append(messages, true);
|
|
|
|
assert.equal(list.num_items(), 4);
|
|
assert.equal(list.empty(), false);
|
|
assert.equal(list.first().id, 50);
|
|
assert.equal(list.last().id, 80);
|
|
|
|
assert.equal(list.get(50).content, 'fifty');
|
|
|
|
assert.equal(list.closest_id(49), 50);
|
|
assert.equal(list.closest_id(50), 50);
|
|
assert.equal(list.closest_id(51), 50);
|
|
assert.equal(list.closest_id(59), 60);
|
|
assert.equal(list.closest_id(60), 60);
|
|
assert.equal(list.closest_id(61), 60);
|
|
|
|
assert.deepEqual(list.all_messages(), messages);
|
|
|
|
global.$.Event = function (ev) {
|
|
assert.equal(ev, 'message_selected.zulip');
|
|
};
|
|
list.select_id(50);
|
|
|
|
assert.equal(list.selected_id(), 50);
|
|
assert.equal(list.selected_idx(), 0);
|
|
|
|
list.advance_past_messages([60, 80]);
|
|
assert.equal(list.selected_id(), 60);
|
|
assert.equal(list.selected_idx(), 1);
|
|
|
|
// Make sure not rerendered when reselected
|
|
var num_renders = 0;
|
|
list.rerender = function () {
|
|
num_renders += 1;
|
|
};
|
|
list.reselect_selected_id();
|
|
assert.equal(num_renders, 0);
|
|
assert.equal(list.selected_id(), 60);
|
|
|
|
var old_messages = [
|
|
{
|
|
id: 30,
|
|
},
|
|
{
|
|
id: 40,
|
|
},
|
|
];
|
|
list.prepend(old_messages, true);
|
|
assert.equal(list.first().id, 30);
|
|
assert.equal(list.last().id, 80);
|
|
|
|
var new_messages = [
|
|
{
|
|
id: 90,
|
|
},
|
|
];
|
|
list.append(new_messages, true);
|
|
assert.equal(list.last().id, 90);
|
|
|
|
list.view.clear_table = function () {};
|
|
|
|
list.remove_and_rerender([{id: 60}]);
|
|
var removed = list.all_messages().filter(function (msg) {
|
|
return msg.id !== 60;
|
|
});
|
|
assert.deepEqual(list.all_messages(), removed);
|
|
|
|
list.clear();
|
|
assert.deepEqual(list.all_messages(), []);
|
|
});
|
|
|
|
run_test('message_range', () => {
|
|
var table;
|
|
var filter = {};
|
|
var list = new MessageList(table, filter);
|
|
|
|
var messages = [{id: 30}, {id: 40}, {id: 50}, {id: 60}];
|
|
list.append(messages, true);
|
|
assert.deepEqual(list.message_range(2, 30), [{id: 30}]);
|
|
assert.deepEqual(list.message_range(2, 31), [{id: 30}, {id: 40}]);
|
|
assert.deepEqual(list.message_range(30, 40), [{id: 30}, {id: 40}]);
|
|
assert.deepEqual(list.message_range(31, 39), [{id: 40}]);
|
|
assert.deepEqual(list.message_range(31, 1000), [{id: 40}, {id: 50}, {id: 60}]);
|
|
});
|
|
|
|
run_test('updates', () => {
|
|
var table;
|
|
var filter = {};
|
|
var list = new MessageList(table, filter);
|
|
list.view.rerender_the_whole_thing = noop;
|
|
|
|
var messages = [
|
|
{
|
|
id: 1,
|
|
sender_id: 100,
|
|
sender_full_name: "tony",
|
|
stream_id: 32,
|
|
stream: "denmark",
|
|
small_avatar_url: "http://zulip.spork",
|
|
},
|
|
{
|
|
id: 2,
|
|
sender_id: 39,
|
|
sender_full_name: "jeff",
|
|
stream_id: 64,
|
|
stream: "russia",
|
|
small_avatar_url: "http://github.com",
|
|
},
|
|
];
|
|
|
|
list.append(messages, true);
|
|
list.update_user_full_name(100, "Anthony");
|
|
assert.equal(list.get(1).sender_full_name, "Anthony");
|
|
assert.equal(list.get(2).sender_full_name, "jeff");
|
|
|
|
list.update_user_avatar(100, "http://zulip.org");
|
|
assert.equal(list.get(1).small_avatar_url, "http://zulip.org");
|
|
assert.equal(list.get(2).small_avatar_url, "http://github.com");
|
|
|
|
list.update_stream_name(64, "Finland");
|
|
assert.equal(list.get(2).stream, "Finland");
|
|
assert.equal(list.get(1).stream, "denmark");
|
|
});
|
|
|
|
run_test('nth_most_recent_id', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
list.append([{id:10}, {id:20}, {id:30}]);
|
|
assert.equal(list.nth_most_recent_id(1), 30);
|
|
assert.equal(list.nth_most_recent_id(2), 20);
|
|
assert.equal(list.nth_most_recent_id(3), 10);
|
|
assert.equal(list.nth_most_recent_id(4), -1);
|
|
});
|
|
|
|
run_test('change_message_id', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
list.append([{id: 10.5, content: "good job"}, {id: 20.5, content: "ok!"}]);
|
|
list.change_message_id(10.5, 11);
|
|
assert.equal(list.get(11).content, "good job");
|
|
|
|
list.change_message_id(20.5, 10);
|
|
assert.equal(list.get(10).content, "ok!");
|
|
});
|
|
|
|
run_test('last_sent_by_me', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
var items = [
|
|
{
|
|
id: 1,
|
|
sender_id: 3,
|
|
},
|
|
{
|
|
id: 2,
|
|
sender_id: 3,
|
|
},
|
|
{
|
|
id: 3,
|
|
sender_id: 6,
|
|
},
|
|
];
|
|
|
|
list.append(items);
|
|
set_global("page_params", {user_id: 3});
|
|
// Look for the last message where user_id == 3 (our ID)
|
|
assert.equal(list.get_last_message_sent_by_me().id, 2);
|
|
});
|
|
|
|
run_test('local_echo', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
list.append([{id:10}, {id:20}, {id:30}, {id:20.02}, {id:20.03}, {id:40}, {id:50}, {id:60}]);
|
|
list._local_only= {20.02: {id:20.02}, 20.03: {id:20.03}};
|
|
|
|
assert.equal(list.closest_id(10), 10);
|
|
assert.equal(list.closest_id(20), 20);
|
|
assert.equal(list.closest_id(30), 30);
|
|
assert.equal(list.closest_id(20.02), 20.02);
|
|
assert.equal(list.closest_id(20.03), 20.03);
|
|
assert.equal(list.closest_id(29), 30);
|
|
assert.equal(list.closest_id(40), 40);
|
|
assert.equal(list.closest_id(50), 50);
|
|
assert.equal(list.closest_id(60), 60);
|
|
|
|
assert.equal(list.closest_id(60), 60);
|
|
assert.equal(list.closest_id(21), 20);
|
|
assert.equal(list.closest_id(29), 30);
|
|
assert.equal(list.closest_id(31), 30);
|
|
assert.equal(list.closest_id(54), 50);
|
|
assert.equal(list.closest_id(58), 60);
|
|
|
|
|
|
list = new MessageList(table, filter);
|
|
list.append([
|
|
{id:10}, {id:20}, {id:30}, {id:20.02}, {id:20.03}, {id:40},
|
|
{id:50}, {id: 50.01}, {id: 50.02}, {id:60}]);
|
|
list._local_only= {20.02: {id:20.02}, 20.03: {id:20.03},
|
|
50.01: {id: 50.01}, 50.02: {id: 50.02}};
|
|
|
|
assert.equal(list.closest_id(10), 10);
|
|
assert.equal(list.closest_id(20), 20);
|
|
assert.equal(list.closest_id(30), 30);
|
|
assert.equal(list.closest_id(20.02), 20.02);
|
|
assert.equal(list.closest_id(20.03), 20.03);
|
|
assert.equal(list.closest_id(40), 40);
|
|
assert.equal(list.closest_id(50), 50);
|
|
assert.equal(list.closest_id(60), 60);
|
|
|
|
assert.equal(list.closest_id(60), 60);
|
|
assert.equal(list.closest_id(21), 20);
|
|
assert.equal(list.closest_id(29), 30);
|
|
assert.equal(list.closest_id(31), 30);
|
|
assert.equal(list.closest_id(47), 50);
|
|
assert.equal(list.closest_id(51), 50.02);
|
|
assert.equal(list.closest_id(59), 60);
|
|
assert.equal(list.closest_id(50.01), 50.01);
|
|
});
|
|
|
|
run_test('bookend', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
|
|
with_overrides(function (override) {
|
|
var expected = "translated: You subscribed to stream IceCream";
|
|
list.view.clear_trailing_bookend = noop;
|
|
list.narrowed = true;
|
|
|
|
override("narrow_state.stream", function () {
|
|
return "IceCream";
|
|
});
|
|
|
|
override("stream_data.is_subscribed", function () {
|
|
return true;
|
|
});
|
|
|
|
global.with_stub(function (stub) {
|
|
list.view.render_trailing_bookend = stub.f;
|
|
list.update_trailing_bookend();
|
|
var bookend = stub.get_args('content', 'subscribed', 'show_button');
|
|
assert.equal(bookend.content, expected);
|
|
assert.equal(bookend.subscribed, true);
|
|
assert.equal(bookend.show_button, true);
|
|
});
|
|
|
|
expected = "translated: You unsubscribed from stream IceCream";
|
|
list.last_message_historical = false;
|
|
override("stream_data.is_subscribed", function () {
|
|
return false;
|
|
});
|
|
|
|
override("stream_data.get_sub", function () {
|
|
return {invite_only: false};
|
|
});
|
|
|
|
global.with_stub(function (stub) {
|
|
list.view.render_trailing_bookend = stub.f;
|
|
list.update_trailing_bookend();
|
|
var bookend = stub.get_args('content', 'subscribed', 'show_button');
|
|
assert.equal(bookend.content, expected);
|
|
assert.equal(bookend.subscribed, false);
|
|
assert.equal(bookend.show_button, true);
|
|
});
|
|
|
|
// Test when the stream is privates (invite only)
|
|
expected = "translated: You unsubscribed from stream IceCream";
|
|
override("stream_data.is_subscribed", function () {
|
|
return false;
|
|
});
|
|
|
|
override("stream_data.get_sub", function () {
|
|
return {invite_only: true};
|
|
});
|
|
|
|
global.with_stub(function (stub) {
|
|
list.view.render_trailing_bookend = stub.f;
|
|
list.update_trailing_bookend();
|
|
var bookend = stub.get_args('content', 'subscribed', 'show_button');
|
|
assert.equal(bookend.content, expected);
|
|
assert.equal(bookend.subscribed, false);
|
|
assert.equal(bookend.show_button, false);
|
|
});
|
|
|
|
expected = "translated: You are not subscribed to stream IceCream";
|
|
list.last_message_historical = true;
|
|
|
|
global.with_stub(function (stub) {
|
|
list.view.render_trailing_bookend = stub.f;
|
|
list.update_trailing_bookend();
|
|
var bookend = stub.get_args('content', 'subscribed', 'show_button');
|
|
assert.equal(bookend.content, expected);
|
|
assert.equal(bookend.subscribed, false);
|
|
assert.equal(bookend.show_button, true);
|
|
});
|
|
});
|
|
});
|
|
|
|
run_test('unmuted_messages', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
|
|
var unmuted = [
|
|
{
|
|
id: 50,
|
|
stream: 'bad',
|
|
mentioned: true,
|
|
},
|
|
{
|
|
id: 60,
|
|
stream: 'good',
|
|
mentioned: false,
|
|
},
|
|
];
|
|
var muted = [
|
|
{
|
|
id: 70,
|
|
stream: 'bad',
|
|
mentioned: false,
|
|
},
|
|
];
|
|
|
|
with_overrides(function (override) {
|
|
override('muting.is_topic_muted', function (stream) {
|
|
return stream === 'bad';
|
|
});
|
|
|
|
// Make sure unmuted_message filters out the "muted" entry,
|
|
// which we mark as having a muted topic, and not mentioned.
|
|
var test_unmuted = list.unmuted_messages(unmuted.concat(muted));
|
|
assert.deepEqual(unmuted, test_unmuted);
|
|
});
|
|
});
|
|
|
|
run_test('add_remove_rerender', () => {
|
|
var table;
|
|
var filter = {};
|
|
|
|
var list = new MessageList(table, filter);
|
|
|
|
var messages = [{id: 1}, {id: 2}, {id: 3}];
|
|
|
|
list.data.unmuted_messages = function (msgs) { return msgs; };
|
|
global.with_stub(function (stub) {
|
|
list.view.rerender_the_whole_thing = stub.f;
|
|
list.add_and_rerender(messages);
|
|
|
|
// Make sure the function has triggered a rerender
|
|
// and that all 3 items were added to the list.
|
|
assert.equal(stub.num_calls, 1);
|
|
assert.equal(list.num_items(), 3);
|
|
});
|
|
|
|
global.with_stub(function (stub) {
|
|
list.rerender = stub.f;
|
|
list.remove_and_rerender(messages);
|
|
assert.equal(stub.num_calls, 1);
|
|
assert.equal(list.num_items(), 0);
|
|
});
|
|
});
|