mirror of
https://github.com/zulip/zulip.git
synced 2025-10-28 18:43:52 +00:00
f06bd41586
Before this fix, if you scrolled back in your PM history for a person that you've had recent conversations with, then we would backdate the record of their most recent conversation, and this would make the sort ordering under the "Private messages" section incorrect. This commit fixes this error by re-writing the function message_store.insert_recent_private_message() to check any prior timestamps for that user. It also optimizes the function a bit to short-circuit in O(1) time for cases where a recipient already has a more recent timestamp, by having a Dict keyed on user_ids_string.
81 lines
1.9 KiB
JavaScript
81 lines
1.9 KiB
JavaScript
global.stub_out_jquery();
|
|
|
|
add_dependencies({
|
|
people: 'js/people.js',
|
|
util: 'js/util.js',
|
|
});
|
|
|
|
var noop = function () {};
|
|
var people = global.people;
|
|
|
|
set_global('alert_words', {
|
|
process_message: noop,
|
|
});
|
|
|
|
var me = {
|
|
email: 'me@example.com',
|
|
user_id: 101,
|
|
full_name: 'Me Myself',
|
|
};
|
|
|
|
var alice = {
|
|
email: 'alice@example.com',
|
|
user_id: 102,
|
|
full_name: 'Alice',
|
|
};
|
|
|
|
var bob = {
|
|
email: 'bob@example.com',
|
|
user_id: 103,
|
|
full_name: 'Bob',
|
|
};
|
|
|
|
var cindy = {
|
|
email: 'cindy@example.com',
|
|
user_id: 104,
|
|
full_name: 'Cindy',
|
|
};
|
|
|
|
people.add_in_realm(me);
|
|
people.add_in_realm(alice);
|
|
people.add_in_realm(bob);
|
|
people.add_in_realm(cindy);
|
|
|
|
global.people.initialize_current_user(me.user_id);
|
|
|
|
global.util.execute_early = noop;
|
|
|
|
var message_store = require('js/message_store.js');
|
|
|
|
(function test_insert_recent_private_message() {
|
|
message_store.insert_recent_private_message('1', 1001);
|
|
message_store.insert_recent_private_message('2', 2001);
|
|
message_store.insert_recent_private_message('1', 3001);
|
|
|
|
// try to backdate user1's timestamp
|
|
message_store.insert_recent_private_message('1', 555);
|
|
|
|
assert.deepEqual(message_store.recent_private_messages, [
|
|
{user_ids_string: '1', timestamp: 3001},
|
|
{user_ids_string: '2', timestamp: 2001},
|
|
]);
|
|
}());
|
|
|
|
(function test_add_message_metadata() {
|
|
var message = {
|
|
sender_email: 'me@example.com',
|
|
sender_id: me.user_id,
|
|
type: 'private',
|
|
display_recipient: [me, bob, cindy],
|
|
flags: ['has_alert_word'],
|
|
};
|
|
message_store.add_message_metadata(message);
|
|
|
|
assert.equal(message.is_private, true);
|
|
assert.equal(message.reply_to, 'bob@example.com,cindy@example.com');
|
|
assert.equal(message.to_user_ids, '103,104');
|
|
assert.equal(message.display_reply_to, 'Bob, Cindy');
|
|
assert.equal(message.alerted, true);
|
|
assert.equal(message.is_me_message, false);
|
|
}());
|