Files
zulip/zerver/actions/message_delete.py
Mateusz Mandera 51cef01c29 message: Use .is_channel_message column instead of is_stream_message().
This avoids a potential unnecessary message.recipient fetch required by
is_stream_message(). is_stream_message() methods precedes the addition
of the denormalized is_channel_message column and is now unnecessary.

In practice, we usually fetch Message objects with `.recipient` already,
so I don't expect any notable performance impact here - but it's still a
useful change to make.
2025-08-19 23:37:07 -07:00

149 lines
5.2 KiB
Python

from collections import defaultdict
from collections.abc import Iterable
from typing import TypedDict
from zerver.lib import retention
from zerver.lib.message import event_recipient_ids_for_action_on_messages
from zerver.lib.retention import move_messages_to_archive
from zerver.models import Message, Realm, Stream, UserProfile
from zerver.tornado.django_api import send_event_on_commit
class DeleteMessagesEvent(TypedDict, total=False):
type: str
message_ids: list[int]
message_type: str
topic: str
stream_id: int
def check_update_first_message_id(
realm: Realm, stream: Stream, message_ids: list[int], users_to_notify: Iterable[int]
) -> None:
# This will not update the `first_message_id` of streams where the
# first message was deleted prior to the implementation of this function.
assert stream.recipient_id is not None
if stream.first_message_id not in message_ids:
return
current_first_message_id = (
Message.objects.filter(realm_id=realm.id, recipient_id=stream.recipient_id)
.values_list("id", flat=True)
.order_by("id")
.first()
)
stream.first_message_id = current_first_message_id
stream.save(update_fields=["first_message_id"])
stream_event = dict(
type="stream",
op="update",
property="first_message_id",
value=stream.first_message_id,
stream_id=stream.id,
name=stream.name,
)
send_event_on_commit(realm, stream_event, users_to_notify)
def _process_grouped_messages_deletion(
realm: Realm,
grouped_messages: list[Message],
*,
stream: Stream | None,
topic: str | None,
acting_user: UserProfile | None,
) -> None:
"""
Helper for do_delete_messages. Should not be called directly otherwise.
"""
message_ids = [message.id for message in grouped_messages]
if not message_ids:
return # nocoverage
event: DeleteMessagesEvent = {
"type": "delete_message",
"message_ids": sorted(message_ids),
}
if stream is None:
assert topic is None
message_type = "private"
archiving_chunk_size = retention.MESSAGE_BATCH_SIZE
else:
assert topic is not None
message_type = "stream"
event["stream_id"] = stream.id
event["topic"] = topic
archiving_chunk_size = retention.STREAM_MESSAGE_BATCH_SIZE
event["message_type"] = message_type
# We exclude long-term idle users, since they by definition have no active clients.
users_to_notify = event_recipient_ids_for_action_on_messages(
grouped_messages,
channel=stream if message_type == "stream" else None,
)
if acting_user is not None:
# Always send event to the user who deleted the message.
users_to_notify.add(acting_user.id)
move_messages_to_archive(message_ids, realm=realm, chunk_size=archiving_chunk_size)
if stream is not None:
check_update_first_message_id(realm, stream, message_ids, users_to_notify)
send_event_on_commit(realm, event, users_to_notify)
def do_delete_messages(
realm: Realm, messages: Iterable[Message], *, acting_user: UserProfile | None
) -> None:
"""1:1 Direct messages must be grouped to a single convesration by
the caller, since this logic does not know how to handle multiple
senders sharing a single Recipient object.
When the Recipient.PERSONAL is no longer a case to consider, this
restriction can be deleted.
"""
private_messages_by_recipient: defaultdict[int, list[Message]] = defaultdict(list)
stream_messages_by_recipient_and_topic: defaultdict[tuple[int, str], list[Message]] = (
defaultdict(list)
)
stream_by_recipient_id = {}
for message in messages:
if message.is_channel_message:
recipient_id = message.recipient_id
# topics are case-insensitive.
topic_name = message.topic_name().lower()
stream_messages_by_recipient_and_topic[(recipient_id, topic_name)].append(message)
else:
recipient_id = message.recipient.id
private_messages_by_recipient[recipient_id].append(message)
for recipient_id, grouped_messages in sorted(private_messages_by_recipient.items()):
_process_grouped_messages_deletion(
realm, grouped_messages, stream=None, topic=None, acting_user=acting_user
)
for (
(recipient_id, topic_name),
grouped_messages,
) in sorted(stream_messages_by_recipient_and_topic.items()):
if recipient_id not in stream_by_recipient_id:
stream_by_recipient_id[recipient_id] = Stream.objects.get(recipient_id=recipient_id)
stream = stream_by_recipient_id[recipient_id]
_process_grouped_messages_deletion(
realm, grouped_messages, stream=stream, topic=topic_name, acting_user=acting_user
)
def do_delete_messages_by_sender(user: UserProfile) -> None:
message_ids = list(
# Uses index: zerver_message_realm_sender_recipient (prefix)
Message.objects.filter(realm_id=user.realm_id, sender=user)
.values_list("id", flat=True)
.order_by("id")
)
if message_ids:
move_messages_to_archive(message_ids, chunk_size=retention.STREAM_MESSAGE_BATCH_SIZE)