mirror of
https://github.com/zulip/zulip.git
synced 2025-11-11 01:16:19 +00:00
93678e89cd
These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
144 lines
8.6 KiB
Python
144 lines
8.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
from typing import Dict, Text
|
|
|
|
from mock import MagicMock, patch
|
|
|
|
from zerver.lib.test_classes import WebhookTestCase
|
|
from zerver.lib.webhooks.git import COMMITS_LIMIT
|
|
|
|
class BeanstalkHookTests(WebhookTestCase):
|
|
STREAM_NAME = 'commits'
|
|
URL_TEMPLATE = u"/api/v1/external/beanstalk?stream={stream}"
|
|
|
|
def test_git_single(self) -> None:
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 1 commit to branch master.
|
|
|
|
* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_singlecommit', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_git_single_filtered_by_branches(self) -> None:
|
|
self.url = self.build_webhook_url(branches='master,development')
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 1 commit to branch master.
|
|
|
|
* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_singlecommit', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_git_multiple_committers(self) -> None:
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master. Commits by Leo Franchi (2) and Tomasz Kolek (1).
|
|
|
|
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
|
|
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
|
|
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_multiple_committers', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_git_multiple_committers_filtered_by_branches(self) -> None:
|
|
self.url = self.build_webhook_url(branches='master,development')
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master. Commits by Leo Franchi (2) and Tomasz Kolek (1).
|
|
|
|
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
|
|
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
|
|
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_multiple_committers', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_git_multiple(self) -> None:
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master.
|
|
|
|
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
|
|
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
|
|
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_multiple', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_git_multiple_filtered_by_branches(self) -> None:
|
|
self.url = self.build_webhook_url(branches='master,development')
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master.
|
|
|
|
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
|
|
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
|
|
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_multiple', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_git_more_than_limit(self) -> None:
|
|
commits_info = "* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))\n"
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 50 commits to branch master.
|
|
|
|
{}[and {} more commit(s)]""".format((commits_info * COMMITS_LIMIT), 50 - COMMITS_LIMIT)
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_morethanlimitcommits', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_git_more_than_limit_filtered_by_branches(self) -> None:
|
|
self.url = self.build_webhook_url(branches='master,development')
|
|
commits_info = "* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))\n"
|
|
expected_subject = "work-test / master"
|
|
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 50 commits to branch master.
|
|
|
|
{}[and {} more commit(s)]""".format((commits_info * COMMITS_LIMIT), 50 - COMMITS_LIMIT)
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'git_morethanlimitcommits', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
|
|
def test_git_single_filtered_by_branches_ignore(self, check_send_webhook_message_mock: MagicMock) -> None:
|
|
self.url = self.build_webhook_url(branches='changes,development')
|
|
payload = self.get_body('git_singlecommit')
|
|
result = self.api_post(self.TEST_USER_EMAIL, self.url, payload)
|
|
self.assertFalse(check_send_webhook_message_mock.called)
|
|
self.assert_json_success(result)
|
|
|
|
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
|
|
def test_git_multiple_committers_filtered_by_branches_ignore(
|
|
self, check_send_webhook_message_mock: MagicMock) -> None:
|
|
self.url = self.build_webhook_url(branches='changes,development')
|
|
payload = self.get_body('git_multiple_committers')
|
|
result = self.api_post(self.TEST_USER_EMAIL, self.url, payload)
|
|
self.assertFalse(check_send_webhook_message_mock.called)
|
|
self.assert_json_success(result)
|
|
|
|
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
|
|
def test_git_multiple_filtered_by_branches_ignore(
|
|
self, check_send_webhook_message_mock: MagicMock) -> None:
|
|
self.url = self.build_webhook_url(branches='changes,development')
|
|
payload = self.get_body('git_multiple')
|
|
result = self.api_post(self.TEST_USER_EMAIL, self.url, payload)
|
|
self.assertFalse(check_send_webhook_message_mock.called)
|
|
self.assert_json_success(result)
|
|
|
|
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
|
|
def test_git_more_than_limit_filtered_by_branches_ignore(
|
|
self, check_send_webhook_message_mock: MagicMock) -> None:
|
|
self.url = self.build_webhook_url(branches='changes,development')
|
|
payload = self.get_body('git_morethanlimitcommits')
|
|
result = self.api_post(self.TEST_USER_EMAIL, self.url, payload)
|
|
self.assertFalse(check_send_webhook_message_mock.called)
|
|
self.assert_json_success(result)
|
|
|
|
def test_svn_addremove(self) -> None:
|
|
expected_subject = "svn r3"
|
|
expected_message = """Leo Franchi pushed [revision 3](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/3):
|
|
|
|
> Removed a file and added another one!"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'svn_addremove', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def test_svn_changefile(self) -> None:
|
|
expected_subject = "svn r2"
|
|
expected_message = """Leo Franchi pushed [revision 2](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/2):
|
|
|
|
> Added some code"""
|
|
self.api_stream_message(self.TEST_USER_EMAIL, 'svn_changefile', expected_subject, expected_message,
|
|
content_type=None)
|
|
|
|
def get_body(self, fixture_name: Text) -> Dict[str, Text]:
|
|
return {'payload': self.fixture_data('beanstalk', fixture_name)}
|