zulip

mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00

Files

Tushar912 c60f48c889 registration: Move "already in realm" check outside of validation.

Checking for `validate_email_not_already_in_realm` again (after the
form already did so), but only in the case that the form fails to
validate, means that we may be spending time pushing totally invalid
emails to the DB to check.  In the case of emails containing nulls,
this can even trigger a 500 error from PostgreSQL.

Stop calling `validate_email_not_already_in_realm` in the form
validation. The form is currently only used in two places -- in
`accounts_home` and in `maybe_send_to_registration`.  The latter is
only called if the address is known to not currently have an account,
so checking in there is unnecessary; and in the former case, we wish
different behaviour (the redirect) than just validation failure, which
is all the validator can do.

Fixes #17015.

Co-authored-by: Alex Vandiver <alexmv@zulip.com>

2021-01-13 11:28:32 -08:00

data_import

hipchat_import: Remove tool from codebase.

2020-12-23 08:28:49 -08:00

lib

change_subdomain: Create a deactivated realm on updating subdomain.

2021-01-07 14:15:22 -08:00

management

imports: Add better checking for subdomains.

2021-01-12 17:54:01 -08:00

migrations

api: Require can_create_users permission to create users via API.