mirror of
				https://github.com/zulip/zulip.git
				synced 2025-10-30 19:43:47 +00:00 
			
		
		
		
	Earlier, we were using 'send_event' & 'queue_json_publish' in 'do_send_messages' which can lead to a situation where we enqueue events but the transaction fails at a later stage. Events should not be sent until we know we're not rolling back.
		
			
				
	
	
		
			6604 lines
		
	
	
		
			274 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			6604 lines
		
	
	
		
			274 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
| import hashlib
 | |
| import random
 | |
| from datetime import timedelta
 | |
| from io import StringIO
 | |
| from typing import TYPE_CHECKING, Any, Dict, List, Optional, Sequence, Set, Union
 | |
| from unittest import mock
 | |
| 
 | |
| import orjson
 | |
| from django.conf import settings
 | |
| from django.core.exceptions import ValidationError
 | |
| from django.http import HttpResponse
 | |
| from django.utils.timezone import now as timezone_now
 | |
| from typing_extensions import override
 | |
| 
 | |
| from zerver.actions.bots import do_change_bot_owner
 | |
| from zerver.actions.create_realm import do_create_realm
 | |
| from zerver.actions.default_streams import (
 | |
|     do_add_default_stream,
 | |
|     do_add_streams_to_default_stream_group,
 | |
|     do_change_default_stream_group_description,
 | |
|     do_change_default_stream_group_name,
 | |
|     do_create_default_stream_group,
 | |
|     do_remove_default_stream,
 | |
|     do_remove_default_stream_group,
 | |
|     do_remove_streams_from_default_stream_group,
 | |
|     lookup_default_stream_groups,
 | |
| )
 | |
| from zerver.actions.realm_settings import do_change_realm_plan_type, do_set_realm_property
 | |
| from zerver.actions.streams import (
 | |
|     bulk_add_subscriptions,
 | |
|     bulk_remove_subscriptions,
 | |
|     deactivated_streams_by_old_name,
 | |
|     do_change_stream_group_based_setting,
 | |
|     do_change_stream_permission,
 | |
|     do_change_stream_post_policy,
 | |
|     do_deactivate_stream,
 | |
|     do_unarchive_stream,
 | |
| )
 | |
| from zerver.actions.user_groups import add_subgroups_to_user_group, check_add_user_group
 | |
| from zerver.actions.users import do_change_user_role, do_deactivate_user
 | |
| from zerver.lib.attachments import (
 | |
|     validate_attachment_request,
 | |
|     validate_attachment_request_for_spectator_access,
 | |
| )
 | |
| from zerver.lib.default_streams import (
 | |
|     get_default_stream_ids_for_realm,
 | |
|     get_default_streams_for_realm_as_dicts,
 | |
| )
 | |
| from zerver.lib.email_mirror_helpers import encode_email_address_helper
 | |
| from zerver.lib.exceptions import JsonableError
 | |
| from zerver.lib.message import UnreadStreamInfo, aggregate_unread_data, get_raw_unread_data
 | |
| from zerver.lib.response import json_success
 | |
| from zerver.lib.stream_color import STREAM_ASSIGNMENT_COLORS, pick_colors
 | |
| from zerver.lib.stream_subscription import (
 | |
|     get_active_subscriptions_for_stream_id,
 | |
|     num_subscribers_for_stream_id,
 | |
|     subscriber_ids_with_stream_history_access,
 | |
| )
 | |
| from zerver.lib.stream_traffic import (
 | |
|     get_average_weekly_stream_traffic,
 | |
|     round_to_2_significant_digits,
 | |
| )
 | |
| from zerver.lib.streams import (
 | |
|     StreamDict,
 | |
|     access_stream_by_id,
 | |
|     access_stream_by_name,
 | |
|     can_access_stream_history,
 | |
|     can_access_stream_user_ids,
 | |
|     create_stream_if_needed,
 | |
|     create_streams_if_needed,
 | |
|     do_get_streams,
 | |
|     ensure_stream,
 | |
|     filter_stream_authorization,
 | |
|     list_to_streams,
 | |
| )
 | |
| from zerver.lib.subscription_info import (
 | |
|     bulk_get_subscriber_user_ids,
 | |
|     gather_subscriptions,
 | |
|     gather_subscriptions_helper,
 | |
|     validate_user_access_to_subscribers_helper,
 | |
| )
 | |
| from zerver.lib.test_classes import ZulipTestCase, get_topic_messages
 | |
| from zerver.lib.test_helpers import (
 | |
|     HostRequestMock,
 | |
|     cache_tries_captured,
 | |
|     get_subscription,
 | |
|     most_recent_message,
 | |
|     most_recent_usermessage,
 | |
|     queries_captured,
 | |
|     reset_email_visibility_to_everyone_in_zulip_realm,
 | |
| )
 | |
| from zerver.lib.types import (
 | |
|     APIStreamDict,
 | |
|     APISubscriptionDict,
 | |
|     NeverSubscribedStreamDict,
 | |
|     SubscriptionInfo,
 | |
| )
 | |
| from zerver.models import (
 | |
|     Attachment,
 | |
|     DefaultStream,
 | |
|     DefaultStreamGroup,
 | |
|     Message,
 | |
|     NamedUserGroup,
 | |
|     Realm,
 | |
|     RealmAuditLog,
 | |
|     Recipient,
 | |
|     Stream,
 | |
|     Subscription,
 | |
|     UserGroup,
 | |
|     UserMessage,
 | |
|     UserProfile,
 | |
| )
 | |
| from zerver.models.realms import get_realm
 | |
| from zerver.models.streams import get_default_stream_groups, get_stream
 | |
| from zerver.models.users import active_non_guest_user_ids, get_user, get_user_profile_by_id_in_realm
 | |
| from zerver.views.streams import compose_views
 | |
| 
 | |
| if TYPE_CHECKING:
 | |
|     from django.test.client import _MonkeyPatchedWSGIResponse as TestHttpResponse
 | |
| 
 | |
| 
 | |
| class TestMiscStuff(ZulipTestCase):
 | |
|     def test_test_helper(self) -> None:
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         s = self.subscribed_stream_name_list(cordelia)
 | |
|         self.assertIn("* Verona", s)
 | |
|         self.assertNotIn("* Denmark", s)
 | |
| 
 | |
|     def test_pick_colors(self) -> None:
 | |
|         used_colors: Set[str] = set()
 | |
|         color_map: Dict[int, str] = {}
 | |
|         recipient_ids = list(range(30))
 | |
|         user_color_map = pick_colors(used_colors, color_map, recipient_ids)
 | |
|         self.assertEqual(
 | |
|             user_color_map,
 | |
|             {
 | |
|                 0: "#76ce90",
 | |
|                 1: "#fae589",
 | |
|                 2: "#a6c7e5",
 | |
|                 3: "#e79ab5",
 | |
|                 4: "#bfd56f",
 | |
|                 5: "#f4ae55",
 | |
|                 6: "#b0a5fd",
 | |
|                 7: "#addfe5",
 | |
|                 8: "#f5ce6e",
 | |
|                 9: "#c2726a",
 | |
|                 10: "#94c849",
 | |
|                 11: "#bd86e5",
 | |
|                 12: "#ee7e4a",
 | |
|                 13: "#a6dcbf",
 | |
|                 14: "#95a5fd",
 | |
|                 15: "#53a063",
 | |
|                 16: "#9987e1",
 | |
|                 17: "#e4523d",
 | |
|                 18: "#c2c2c2",
 | |
|                 19: "#4f8de4",
 | |
|                 20: "#c6a8ad",
 | |
|                 21: "#e7cc4d",
 | |
|                 22: "#c8bebf",
 | |
|                 23: "#a47462",
 | |
|                 # start repeating
 | |
|                 24: "#76ce90",
 | |
|                 25: "#fae589",
 | |
|                 26: "#a6c7e5",
 | |
|                 27: "#e79ab5",
 | |
|                 28: "#bfd56f",
 | |
|                 29: "#f4ae55",
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         color_map = {98: "color98", 99: "color99"}
 | |
|         used_colors = set(STREAM_ASSIGNMENT_COLORS) - {"#c6a8ad", "#9987e1"}
 | |
|         recipient_ids = [99, 98, 1, 2, 3, 4]
 | |
|         user_color_map = pick_colors(used_colors, color_map, recipient_ids)
 | |
|         self.assertEqual(
 | |
|             user_color_map,
 | |
|             {98: "color98", 99: "color99", 1: "#9987e1", 2: "#c6a8ad", 3: "#e79ab5", 4: "#bfd56f"},
 | |
|         )
 | |
| 
 | |
|         """
 | |
|         If we are assigning colors to a user with 24+ streams, we have to start
 | |
|         re-using old colors.  Our algorithm basically uses recipient_id % 24, so
 | |
|         the following code reflects the worse case scenario that our new
 | |
|         streams have recipient ids spaced out by exact multiples of 24.  We
 | |
|         don't try to work around this edge case, since users who really depend
 | |
|         on the stream colors can always just assign themselves custom colors
 | |
|         for the streams that they really want to stand out.
 | |
| 
 | |
|         Even if recipient_ids were completely random, the odds of collisions
 | |
|         are low, but it's often the case that bulk-adds are done for streams
 | |
|         that either were or are being created at roughly the same time, so the
 | |
|         recipient_ids tend to have even fewer collisions.
 | |
|         """
 | |
|         used_colors = set(STREAM_ASSIGNMENT_COLORS)
 | |
|         color_map = {}
 | |
|         recipient_ids = [2, 26, 50, 74]
 | |
|         user_color_map = pick_colors(used_colors, color_map, recipient_ids)
 | |
|         self.assertEqual(
 | |
|             user_color_map,
 | |
|             {2: "#a6c7e5", 26: "#a6c7e5", 50: "#a6c7e5", 74: "#a6c7e5"},
 | |
|         )
 | |
| 
 | |
|     def test_empty_results(self) -> None:
 | |
|         # These are essentially just tests to ensure line
 | |
|         # coverage for codepaths that won't ever really be
 | |
|         # called in practice.
 | |
| 
 | |
|         user_profile = self.example_user("cordelia")
 | |
| 
 | |
|         result = bulk_get_subscriber_user_ids(
 | |
|             stream_dicts=[],
 | |
|             user_profile=user_profile,
 | |
|             subscribed_stream_ids=set(),
 | |
|         )
 | |
|         self.assertEqual(result, {})
 | |
| 
 | |
|         streams = do_get_streams(
 | |
|             user_profile=user_profile,
 | |
|             include_public=False,
 | |
|             include_subscribed=False,
 | |
|             include_all_active=False,
 | |
|             include_default=False,
 | |
|         )
 | |
|         self.assertEqual(streams, [])
 | |
| 
 | |
|     def test_api_fields(self) -> None:
 | |
|         """Verify that all the fields from `Stream.API_FIELDS` and `Subscription.API_FIELDS` present
 | |
|         in `APIStreamDict` and `APISubscriptionDict`, respectively.
 | |
|         """
 | |
|         expected_fields = set(Stream.API_FIELDS) | {"stream_id"}
 | |
|         expected_fields -= {"id", "can_remove_subscribers_group_id"}
 | |
|         expected_fields |= {"can_remove_subscribers_group"}
 | |
| 
 | |
|         stream_dict_fields = set(APIStreamDict.__annotations__.keys())
 | |
|         computed_fields = {"is_announcement_only", "is_default", "stream_weekly_traffic"}
 | |
| 
 | |
|         self.assertEqual(stream_dict_fields - computed_fields, expected_fields)
 | |
| 
 | |
|         expected_fields = set(Subscription.API_FIELDS)
 | |
| 
 | |
|         subscription_dict_fields = set(APISubscriptionDict.__annotations__.keys())
 | |
|         computed_fields = {"in_home_view", "email_address", "stream_weekly_traffic", "subscribers"}
 | |
|         # `APISubscriptionDict` is a subclass of `APIStreamDict`, therefore having all the
 | |
|         # fields in addition to the computed fields and `Subscription.API_FIELDS` that
 | |
|         # need to be excluded here.
 | |
|         self.assertEqual(
 | |
|             subscription_dict_fields - computed_fields - stream_dict_fields,
 | |
|             expected_fields,
 | |
|         )
 | |
| 
 | |
| 
 | |
| class TestCreateStreams(ZulipTestCase):
 | |
|     def test_creating_streams(self) -> None:
 | |
|         stream_names = ["new1", "new2", "new3"]
 | |
|         stream_descriptions = ["des1", "des2", "des3"]
 | |
|         realm = get_realm("zulip")
 | |
| 
 | |
|         # Test stream creation events.
 | |
|         with self.capture_send_event_calls(expected_num_events=1) as events:
 | |
|             ensure_stream(realm, "Public stream", invite_only=False, acting_user=None)
 | |
| 
 | |
|         self.assertEqual(events[0]["event"]["type"], "stream")
 | |
|         self.assertEqual(events[0]["event"]["op"], "create")
 | |
|         # Send public stream creation event to all active users.
 | |
|         self.assertEqual(events[0]["users"], active_non_guest_user_ids(realm.id))
 | |
|         self.assertEqual(events[0]["event"]["streams"][0]["name"], "Public stream")
 | |
|         self.assertEqual(events[0]["event"]["streams"][0]["stream_weekly_traffic"], None)
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=1) as events:
 | |
|             ensure_stream(realm, "Private stream", invite_only=True, acting_user=None)
 | |
| 
 | |
|         self.assertEqual(events[0]["event"]["type"], "stream")
 | |
|         self.assertEqual(events[0]["event"]["op"], "create")
 | |
|         # Send private stream creation event to only realm admins.
 | |
|         self.assert_length(events[0]["users"], 2)
 | |
|         self.assertTrue(self.example_user("iago").id in events[0]["users"])
 | |
|         self.assertTrue(self.example_user("desdemona").id in events[0]["users"])
 | |
|         self.assertEqual(events[0]["event"]["streams"][0]["name"], "Private stream")
 | |
|         self.assertEqual(events[0]["event"]["streams"][0]["stream_weekly_traffic"], None)
 | |
| 
 | |
|         moderators_system_group = NamedUserGroup.objects.get(
 | |
|             name="role:moderators", realm=realm, is_system_group=True
 | |
|         )
 | |
|         new_streams, existing_streams = create_streams_if_needed(
 | |
|             realm,
 | |
|             [
 | |
|                 {
 | |
|                     "name": stream_name,
 | |
|                     "description": stream_description,
 | |
|                     "invite_only": True,
 | |
|                     "stream_post_policy": Stream.STREAM_POST_POLICY_ADMINS,
 | |
|                     "message_retention_days": -1,
 | |
|                     "can_remove_subscribers_group": moderators_system_group,
 | |
|                 }
 | |
|                 for (stream_name, stream_description) in zip(stream_names, stream_descriptions)
 | |
|             ],
 | |
|         )
 | |
| 
 | |
|         self.assert_length(new_streams, 3)
 | |
|         self.assert_length(existing_streams, 0)
 | |
| 
 | |
|         actual_stream_names = {stream.name for stream in new_streams}
 | |
|         self.assertEqual(actual_stream_names, set(stream_names))
 | |
|         actual_stream_descriptions = {stream.description for stream in new_streams}
 | |
|         self.assertEqual(actual_stream_descriptions, set(stream_descriptions))
 | |
|         for stream in new_streams:
 | |
|             self.assertTrue(stream.invite_only)
 | |
|             self.assertTrue(stream.stream_post_policy == Stream.STREAM_POST_POLICY_ADMINS)
 | |
|             self.assertTrue(stream.message_retention_days == -1)
 | |
|             self.assertEqual(stream.can_remove_subscribers_group.id, moderators_system_group.id)
 | |
|             # Streams created where acting_user is None have no creator
 | |
|             self.assertIsNone(stream.creator_id)
 | |
| 
 | |
|         new_streams, existing_streams = create_streams_if_needed(
 | |
|             realm,
 | |
|             [
 | |
|                 {"name": stream_name, "description": stream_description, "invite_only": True}
 | |
|                 for (stream_name, stream_description) in zip(stream_names, stream_descriptions)
 | |
|             ],
 | |
|         )
 | |
| 
 | |
|         self.assert_length(new_streams, 0)
 | |
|         self.assert_length(existing_streams, 3)
 | |
| 
 | |
|         actual_stream_names = {stream.name for stream in existing_streams}
 | |
|         self.assertEqual(actual_stream_names, set(stream_names))
 | |
|         actual_stream_descriptions = {stream.description for stream in existing_streams}
 | |
|         self.assertEqual(actual_stream_descriptions, set(stream_descriptions))
 | |
|         for stream in existing_streams:
 | |
|             self.assertTrue(stream.invite_only)
 | |
| 
 | |
|     def test_create_api_multiline_description(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         realm = user.realm
 | |
|         self.login_user(user)
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new_stream", "description": "multi\nline\ndescription"}]
 | |
|             ).decode(),
 | |
|             "invite_only": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip")
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("new_stream", realm)
 | |
|         self.assertEqual(stream.description, "multi line description")
 | |
| 
 | |
|     def test_history_public_to_subscribers_on_stream_creation(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
|         stream_dicts: List[StreamDict] = [
 | |
|             {
 | |
|                 "name": "publicstream",
 | |
|                 "description": "Public stream with public history",
 | |
|             },
 | |
|             {"name": "webpublicstream", "description": "Web-public stream", "is_web_public": True},
 | |
|             {
 | |
|                 "name": "privatestream",
 | |
|                 "description": "Private stream with non-public history",
 | |
|                 "invite_only": True,
 | |
|             },
 | |
|             {
 | |
|                 "name": "privatewithhistory",
 | |
|                 "description": "Private stream with public history",
 | |
|                 "invite_only": True,
 | |
|                 "history_public_to_subscribers": True,
 | |
|             },
 | |
|             {
 | |
|                 "name": "publictrywithouthistory",
 | |
|                 "description": "Public stream without public history (disallowed)",
 | |
|                 "invite_only": False,
 | |
|                 "history_public_to_subscribers": False,
 | |
|             },
 | |
|         ]
 | |
| 
 | |
|         created, existing = create_streams_if_needed(realm, stream_dicts)
 | |
| 
 | |
|         self.assert_length(created, 5)
 | |
|         self.assert_length(existing, 0)
 | |
|         for stream in created:
 | |
|             if stream.name == "publicstream":
 | |
|                 self.assertTrue(stream.history_public_to_subscribers)
 | |
|             if stream.name == "webpublicstream":
 | |
|                 self.assertTrue(stream.history_public_to_subscribers)
 | |
|             if stream.name == "privatestream":
 | |
|                 self.assertFalse(stream.history_public_to_subscribers)
 | |
|             if stream.name == "privatewithhistory":
 | |
|                 self.assertTrue(stream.history_public_to_subscribers)
 | |
|             if stream.name == "publictrywithouthistory":
 | |
|                 self.assertTrue(stream.history_public_to_subscribers)
 | |
| 
 | |
|     def test_add_stream_as_default_on_stream_creation(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
| 
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "default_stream", "description": "This stream is default for new users"}]
 | |
|             ).decode(),
 | |
|             "is_default_stream": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.api_post(
 | |
|             user_profile, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip"
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         result = self.api_post(
 | |
|             user_profile, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip"
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         default_stream = get_stream("default_stream", realm)
 | |
|         self.assertTrue(default_stream.id in get_default_stream_ids_for_realm(realm.id))
 | |
| 
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [
 | |
|                     {
 | |
|                         "name": "private_default_stream",
 | |
|                         "description": "This stream is private and default for new users",
 | |
|                     }
 | |
|                 ]
 | |
|             ).decode(),
 | |
|             "invite_only": orjson.dumps(True).decode(),
 | |
|             "is_default_stream": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.api_post(
 | |
|             user_profile, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip"
 | |
|         )
 | |
|         self.assert_json_error(result, "A default channel cannot be private.")
 | |
| 
 | |
|     def test_history_public_to_subscribers_zephyr_realm(self) -> None:
 | |
|         realm = get_realm("zephyr")
 | |
| 
 | |
|         stream, created = create_stream_if_needed(realm, "private_stream", invite_only=True)
 | |
|         self.assertTrue(created)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertFalse(stream.history_public_to_subscribers)
 | |
| 
 | |
|         stream, created = create_stream_if_needed(realm, "public_stream", invite_only=False)
 | |
|         self.assertTrue(created)
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assertFalse(stream.history_public_to_subscribers)
 | |
| 
 | |
|     def test_auto_mark_stream_created_message_as_read_for_stream_creator(self) -> None:
 | |
|         # This test relies on email == delivery_email for
 | |
|         # convenience.
 | |
|         reset_email_visibility_to_everyone_in_zulip_realm()
 | |
| 
 | |
|         realm = Realm.objects.get(name="Zulip Dev")
 | |
|         iago = self.example_user("iago")
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         aaron = self.example_user("aaron")
 | |
| 
 | |
|         # Establish a stream for notifications.
 | |
|         announce_stream = ensure_stream(
 | |
|             realm, "announce", False, "announcements here.", acting_user=None
 | |
|         )
 | |
|         realm.new_stream_announcements_stream_id = announce_stream.id
 | |
|         realm.save(update_fields=["new_stream_announcements_stream_id"])
 | |
| 
 | |
|         self.subscribe(iago, announce_stream.name)
 | |
|         self.subscribe(hamlet, announce_stream.name)
 | |
| 
 | |
|         self.login_user(iago)
 | |
| 
 | |
|         initial_message_count = Message.objects.count()
 | |
|         initial_usermessage_count = UserMessage.objects.count()
 | |
| 
 | |
|         data = {
 | |
|             "subscriptions": '[{"name":"brand new stream","description":""}]',
 | |
|             "history_public_to_subscribers": "true",
 | |
|             "invite_only": "false",
 | |
|             "announce": "true",
 | |
|             "principals": orjson.dumps([iago.id, aaron.id, cordelia.id, hamlet.id]).decode(),
 | |
|             "stream_post_policy": "1",
 | |
|         }
 | |
| 
 | |
|         response = self.client_post("/json/users/me/subscriptions", data)
 | |
| 
 | |
|         final_message_count = Message.objects.count()
 | |
|         final_usermessage_count = UserMessage.objects.count()
 | |
| 
 | |
|         expected_response = {
 | |
|             "result": "success",
 | |
|             "msg": "",
 | |
|             "subscribed": {
 | |
|                 "AARON@zulip.com": ["brand new stream"],
 | |
|                 "cordelia@zulip.com": ["brand new stream"],
 | |
|                 "hamlet@zulip.com": ["brand new stream"],
 | |
|                 "iago@zulip.com": ["brand new stream"],
 | |
|             },
 | |
|             "already_subscribed": {},
 | |
|         }
 | |
|         self.assertEqual(response.status_code, 200)
 | |
|         self.assertEqual(orjson.loads(response.content), expected_response)
 | |
| 
 | |
|         # 2 messages should be created, one in announce and one in the new stream itself.
 | |
|         self.assertEqual(final_message_count - initial_message_count, 2)
 | |
|         # 4 UserMessages per subscriber: One for each of the subscribers, plus 1 for
 | |
|         # each user in the notifications stream.
 | |
|         announce_stream_subs = Subscription.objects.filter(recipient=announce_stream.recipient)
 | |
|         self.assertEqual(
 | |
|             final_usermessage_count - initial_usermessage_count, 4 + announce_stream_subs.count()
 | |
|         )
 | |
| 
 | |
|         def get_unread_stream_data(user: UserProfile) -> List[UnreadStreamInfo]:
 | |
|             raw_unread_data = get_raw_unread_data(user)
 | |
|             aggregated_data = aggregate_unread_data(raw_unread_data)
 | |
|             return aggregated_data["streams"]
 | |
| 
 | |
|         stream_id = Stream.objects.get(name="brand new stream").id
 | |
|         iago_unread_messages = get_unread_stream_data(iago)
 | |
|         hamlet_unread_messages = get_unread_stream_data(hamlet)
 | |
| 
 | |
|         # The stream creation messages should be unread for Hamlet
 | |
|         self.assert_length(hamlet_unread_messages, 2)
 | |
| 
 | |
|         # According to the code in zerver/views/streams/add_subscriptions_backend
 | |
|         # the notification stream message is sent first, then the new stream's message.
 | |
|         self.assertEqual(hamlet_unread_messages[1]["stream_id"], stream_id)
 | |
| 
 | |
|         # But it should be marked as read for Iago, the stream creator.
 | |
|         self.assert_length(iago_unread_messages, 0)
 | |
| 
 | |
|     def test_can_remove_subscribers_group_on_stream_creation(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         realm = user.realm
 | |
|         self.login_user(user)
 | |
|         moderators_system_group = NamedUserGroup.objects.get(
 | |
|             name="role:moderators", realm=realm, is_system_group=True
 | |
|         )
 | |
|         admins_system_group = NamedUserGroup.objects.get(
 | |
|             name="role:administrators", realm=realm, is_system_group=True
 | |
|         )
 | |
| 
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new_stream1", "description": "First new stream"}]
 | |
|             ).decode(),
 | |
|             "can_remove_subscribers_group": orjson.dumps(moderators_system_group.id).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip")
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("new_stream1", realm)
 | |
|         self.assertEqual(stream.can_remove_subscribers_group.id, moderators_system_group.id)
 | |
| 
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new_stream2", "description": "Second new stream"}]
 | |
|             ).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip")
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("new_stream2", realm)
 | |
|         self.assertEqual(stream.can_remove_subscribers_group.id, admins_system_group.id)
 | |
| 
 | |
|         hamletcharacters_group = NamedUserGroup.objects.get(name="hamletcharacters", realm=realm)
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new_stream3", "description": "Third new stream"}]
 | |
|             ).decode(),
 | |
|             "can_remove_subscribers_group": orjson.dumps(hamletcharacters_group.id).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip")
 | |
|         self.assert_json_error(
 | |
|             result, "'can_remove_subscribers_group' must be a system user group."
 | |
|         )
 | |
| 
 | |
|         internet_group = NamedUserGroup.objects.get(
 | |
|             name="role:internet", is_system_group=True, realm=realm
 | |
|         )
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new_stream3", "description": "Third new stream"}]
 | |
|             ).decode(),
 | |
|             "can_remove_subscribers_group": orjson.dumps(internet_group.id).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip")
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             "'can_remove_subscribers_group' setting cannot be set to 'role:internet' group.",
 | |
|         )
 | |
| 
 | |
|         owners_group = NamedUserGroup.objects.get(
 | |
|             name="role:owners", is_system_group=True, realm=realm
 | |
|         )
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new_stream3", "description": "Third new stream"}]
 | |
|             ).decode(),
 | |
|             "can_remove_subscribers_group": orjson.dumps(owners_group.id).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip")
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             "'can_remove_subscribers_group' setting cannot be set to 'role:owners' group.",
 | |
|         )
 | |
| 
 | |
|         nobody_group = NamedUserGroup.objects.get(
 | |
|             name="role:nobody", is_system_group=True, realm=realm
 | |
|         )
 | |
|         post_data = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new_stream3", "description": "Third new stream"}]
 | |
|             ).decode(),
 | |
|             "can_remove_subscribers_group": orjson.dumps(nobody_group.id).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", post_data, subdomain="zulip")
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             "'can_remove_subscribers_group' setting cannot be set to 'role:nobody' group.",
 | |
|         )
 | |
| 
 | |
|     def test_acting_user_is_creator(self) -> None:
 | |
|         """
 | |
|         If backend calls provide an acting_user while trying to
 | |
|         create streams, assign acting_user as the stream creator
 | |
|         """
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         new_streams, _ = create_streams_if_needed(
 | |
|             hamlet.realm,
 | |
|             [
 | |
|                 StreamDict(
 | |
|                     name="hamlet's test stream",
 | |
|                     description="No description",
 | |
|                     invite_only=True,
 | |
|                     is_web_public=True,
 | |
|                     stream_post_policy=Stream.STREAM_POST_POLICY_ADMINS,
 | |
|                 )
 | |
|             ],
 | |
|             acting_user=hamlet,
 | |
|         )
 | |
|         created_stream = new_streams[0]
 | |
|         self.assertEqual(created_stream.creator_id, hamlet.id)
 | |
| 
 | |
| 
 | |
| class RecipientTest(ZulipTestCase):
 | |
|     def test_recipient(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
|         stream = get_stream("Verona", realm)
 | |
|         recipient = Recipient.objects.get(
 | |
|             type_id=stream.id,
 | |
|             type=Recipient.STREAM,
 | |
|         )
 | |
|         self.assertEqual(repr(recipient), f"<Recipient: Verona ({stream.id}, {Recipient.STREAM})>")
 | |
| 
 | |
| 
 | |
| class StreamAdminTest(ZulipTestCase):
 | |
|     def test_make_stream_public(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         self.make_stream("private_stream_1", invite_only=True)
 | |
|         self.make_stream("private_stream_2", invite_only=True)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         stream_id = get_stream("private_stream_1", user_profile.realm).id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         stream = self.subscribe(user_profile, "private_stream_1")
 | |
|         self.assertFalse(stream.is_in_zephyr_realm)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         realm = user_profile.realm
 | |
|         stream = get_stream("private_stream_1", realm)
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assertTrue(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**King Hamlet|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Private, protected history** to **Public**."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
| 
 | |
|         history_public_to_subscribers_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert history_public_to_subscribers_log is not None
 | |
| 
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: False,
 | |
|             RealmAuditLog.NEW_VALUE: True,
 | |
|             "property": "history_public_to_subscribers",
 | |
|         }
 | |
|         self.assertEqual(history_public_to_subscribers_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         invite_only_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).order_by("-id")[1]
 | |
|         assert invite_only_log is not None
 | |
| 
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: True,
 | |
|             RealmAuditLog.NEW_VALUE: False,
 | |
|             "property": "invite_only",
 | |
|         }
 | |
|         self.assertEqual(invite_only_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         stream = self.subscribe(user_profile, "private_stream_2")
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", params)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|     def test_make_stream_private(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         self.make_stream("public_stream_1", realm=realm)
 | |
|         self.make_stream("public_stream_2")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         stream_id = self.subscribe(user_profile, "public_stream_1").id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("public_stream_1", realm)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertFalse(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**King Hamlet|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Public** to **Private, protected history**."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
| 
 | |
|         history_public_to_subscribers_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert history_public_to_subscribers_log is not None
 | |
| 
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: True,
 | |
|             RealmAuditLog.NEW_VALUE: False,
 | |
|             "property": "history_public_to_subscribers",
 | |
|         }
 | |
|         self.assertEqual(history_public_to_subscribers_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         invite_only_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).order_by("-id")[1]
 | |
|         assert invite_only_log is not None
 | |
| 
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: False,
 | |
|             RealmAuditLog.NEW_VALUE: True,
 | |
|             "property": "invite_only",
 | |
|         }
 | |
|         self.assertEqual(invite_only_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         default_stream = self.make_stream("default_stream", realm=realm)
 | |
|         do_add_default_stream(default_stream)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{default_stream.id}", params)
 | |
|         self.assert_json_error(result, "A default channel cannot be private.")
 | |
|         self.assertFalse(default_stream.invite_only)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         stream = self.subscribe(user_profile, "public_stream_2")
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", params)
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|     def test_create_web_public_stream(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         owner = self.example_user("desdemona")
 | |
| 
 | |
|         stream_names = ["new1", "new2", "new3"]
 | |
|         stream_descriptions = ["des1", "des2", "des3"]
 | |
|         streams_raw: List[StreamDict] = [
 | |
|             {"name": stream_name, "description": stream_description, "is_web_public": True}
 | |
|             for (stream_name, stream_description) in zip(stream_names, stream_descriptions)
 | |
|         ]
 | |
| 
 | |
|         self.assertFalse(user_profile.can_create_web_public_streams())
 | |
|         self.assertTrue(owner.can_create_web_public_streams())
 | |
|         # As per create_web_public_stream_policy, only owners can create web-public streams by default.
 | |
|         with self.assertRaisesRegex(JsonableError, "Insufficient permission"):
 | |
|             list_to_streams(
 | |
|                 streams_raw,
 | |
|                 user_profile,
 | |
|                 autocreate=True,
 | |
|             )
 | |
| 
 | |
|         with self.settings(WEB_PUBLIC_STREAMS_ENABLED=False):
 | |
|             self.assertFalse(user_profile.can_create_web_public_streams())
 | |
|             self.assertFalse(owner.can_create_web_public_streams())
 | |
|             with self.assertRaisesRegex(JsonableError, "Web-public channels are not enabled."):
 | |
|                 list_to_streams(
 | |
|                     streams_raw,
 | |
|                     owner,
 | |
|                     autocreate=True,
 | |
|                 )
 | |
| 
 | |
|         existing_streams, new_streams = list_to_streams(
 | |
|             streams_raw,
 | |
|             owner,
 | |
|             autocreate=True,
 | |
|         )
 | |
| 
 | |
|         self.assert_length(new_streams, 3)
 | |
|         self.assert_length(existing_streams, 0)
 | |
| 
 | |
|         actual_stream_names = {stream.name for stream in new_streams}
 | |
|         self.assertEqual(actual_stream_names, set(stream_names))
 | |
|         actual_stream_descriptions = {stream.description for stream in new_streams}
 | |
|         self.assertEqual(actual_stream_descriptions, set(stream_descriptions))
 | |
|         for stream in new_streams:
 | |
|             self.assertTrue(stream.is_web_public)
 | |
| 
 | |
|     def test_make_stream_public_zephyr_mirror(self) -> None:
 | |
|         user_profile = self.mit_user("starnine")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         self.make_stream("target_stream", realm=realm, invite_only=True)
 | |
|         self.subscribe(user_profile, "target_stream")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         stream_id = get_stream("target_stream", realm).id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params, subdomain="zephyr")
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("target_stream", realm)
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assertFalse(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**{user_profile.full_name}|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Private, protected history** to **Public, protected history**."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: True,
 | |
|             RealmAuditLog.NEW_VALUE: False,
 | |
|             "property": "invite_only",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|     def test_make_stream_private_with_public_history(self) -> None:
 | |
|         # Convert a public stream to a private stream with shared history
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         self.make_stream("public_history_stream", realm=realm)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         stream_id = self.subscribe(user_profile, "public_history_stream").id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("public_history_stream", realm)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertTrue(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**King Hamlet|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Public** to **Private, shared history**."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: False,
 | |
|             RealmAuditLog.NEW_VALUE: True,
 | |
|             "property": "invite_only",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         # Convert a private stream with protected history to a private stream
 | |
|         # with shared history.
 | |
|         self.make_stream(
 | |
|             "private_protected_stream",
 | |
|             realm=realm,
 | |
|             invite_only=True,
 | |
|             history_public_to_subscribers=False,
 | |
|         )
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         stream_id = self.subscribe(user_profile, "private_protected_stream").id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("private_protected_stream", realm)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertTrue(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**King Hamlet|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Private, protected history** to **Private, shared history**."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: False,
 | |
|             RealmAuditLog.NEW_VALUE: True,
 | |
|             "property": "history_public_to_subscribers",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|     def test_make_stream_web_public(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         self.make_stream("test_stream", realm=realm)
 | |
|         stream_id = self.subscribe(user_profile, "test_stream").id
 | |
| 
 | |
|         params = {
 | |
|             "is_web_public": orjson.dumps(True).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm, "create_web_public_stream_policy", Realm.POLICY_OWNERS_ONLY, acting_user=None
 | |
|         )
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm, "create_web_public_stream_policy", Realm.POLICY_NOBODY, acting_user=None
 | |
|         )
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_OWNER, acting_user=None)
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm, "create_web_public_stream_policy", Realm.POLICY_OWNERS_ONLY, acting_user=None
 | |
|         )
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_OWNER, acting_user=None)
 | |
|         with self.settings(WEB_PUBLIC_STREAMS_ENABLED=False):
 | |
|             result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Web-public channels are not enabled.")
 | |
| 
 | |
|         bad_params = {
 | |
|             "is_web_public": orjson.dumps(True).decode(),
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", bad_params)
 | |
|         self.assert_json_error(result, "Invalid parameters")
 | |
| 
 | |
|         bad_params = {
 | |
|             "is_web_public": orjson.dumps(True).decode(),
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", bad_params)
 | |
|         self.assert_json_error(result, "Invalid parameters")
 | |
| 
 | |
|         stream = get_stream("test_stream", realm)
 | |
|         self.assertFalse(stream.is_web_public)
 | |
| 
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         stream = get_stream("test_stream", realm)
 | |
|         self.assertTrue(stream.is_web_public)
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assertTrue(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**King Hamlet|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Public** to **Web-public**."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: False,
 | |
|             RealmAuditLog.NEW_VALUE: True,
 | |
|             "property": "is_web_public",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|     def test_change_history_access_for_private_streams(self) -> None:
 | |
|         user_profile = self.example_user("iago")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         self.make_stream("private_stream", realm=realm, invite_only=True)
 | |
|         stream_id = self.subscribe(user_profile, "private_stream").id
 | |
| 
 | |
|         params = {
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         stream = get_stream("private_stream", realm)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertTrue(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**Iago|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Private, protected history** to **Private, shared history**."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: False,
 | |
|             RealmAuditLog.NEW_VALUE: True,
 | |
|             "property": "history_public_to_subscribers",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         params = {
 | |
|             "history_public_to_subscribers": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         stream = get_stream("private_stream", realm)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertFalse(stream.history_public_to_subscribers)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 2)
 | |
|         expected_notification = (
 | |
|             f"@_**Iago|{user_profile.id}** changed the [access permissions](/help/channel-permissions) "
 | |
|             "for this channel from **Private, shared history** to **Private, protected history**."
 | |
|         )
 | |
|         self.assertEqual(messages[1].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: True,
 | |
|             RealmAuditLog.NEW_VALUE: False,
 | |
|             "property": "history_public_to_subscribers",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|     def test_add_and_remove_stream_as_default(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         stream = self.make_stream("stream", realm=realm)
 | |
|         stream_id = self.subscribe(user_profile, "stream").id
 | |
| 
 | |
|         params = {
 | |
|             "is_default_stream": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
|         self.assertFalse(stream_id in get_default_stream_ids_for_realm(realm.id))
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
|         self.assertTrue(stream_id in get_default_stream_ids_for_realm(realm.id))
 | |
| 
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "A default channel cannot be private.")
 | |
|         stream.refresh_from_db()
 | |
|         self.assertFalse(stream.invite_only)
 | |
| 
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|             "is_default_stream": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
|         stream.refresh_from_db()
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertFalse(stream_id in get_default_stream_ids_for_realm(realm.id))
 | |
| 
 | |
|         stream_2 = self.make_stream("stream_2", realm=realm)
 | |
|         stream_2_id = self.subscribe(user_profile, "stream_2").id
 | |
| 
 | |
|         bad_params = {
 | |
|             "is_default_stream": orjson.dumps(True).decode(),
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_2_id}", bad_params)
 | |
|         self.assert_json_error(result, "A default channel cannot be private.")
 | |
|         stream.refresh_from_db()
 | |
|         self.assertFalse(stream_2.invite_only)
 | |
|         self.assertFalse(stream_2_id in get_default_stream_ids_for_realm(realm.id))
 | |
| 
 | |
|         private_stream = self.make_stream("private_stream", realm=realm, invite_only=True)
 | |
|         private_stream_id = self.subscribe(user_profile, "private_stream").id
 | |
| 
 | |
|         params = {
 | |
|             "is_default_stream": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{private_stream_id}", params)
 | |
|         self.assert_json_error(result, "A default channel cannot be private.")
 | |
|         self.assertFalse(private_stream_id in get_default_stream_ids_for_realm(realm.id))
 | |
| 
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|             "is_default_stream": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{private_stream_id}", params)
 | |
|         self.assert_json_success(result)
 | |
|         private_stream.refresh_from_db()
 | |
|         self.assertFalse(private_stream.invite_only)
 | |
|         self.assertTrue(private_stream_id in get_default_stream_ids_for_realm(realm.id))
 | |
| 
 | |
|     def test_stream_permission_changes_updates_updates_attachments(self) -> None:
 | |
|         self.login("desdemona")
 | |
|         fp = StringIO("zulip!")
 | |
|         fp.name = "zulip.txt"
 | |
| 
 | |
|         result = self.client_post("/json/user_uploads", {"file": fp})
 | |
|         url = self.assert_json_success(result)["uri"]
 | |
| 
 | |
|         owner = self.example_user("desdemona")
 | |
|         realm = owner.realm
 | |
|         stream = self.make_stream("test_stream", realm=realm)
 | |
|         self.subscribe(owner, "test_stream")
 | |
|         body = f"First message ...[zulip.txt](http://{realm.host}" + url + ")"
 | |
|         msg_id = self.send_stream_message(owner, "test_stream", body, "test")
 | |
|         attachment = Attachment.objects.get(messages__id=msg_id)
 | |
| 
 | |
|         self.assertFalse(stream.is_web_public)
 | |
|         self.assertFalse(attachment.is_web_public)
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assertTrue(attachment.is_realm_public)
 | |
| 
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(True).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", params)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         attachment.refresh_from_db()
 | |
|         stream.refresh_from_db()
 | |
|         self.assertFalse(stream.is_web_public)
 | |
|         self.assertFalse(attachment.is_web_public)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertIsNone(attachment.is_realm_public)
 | |
| 
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         self.assertFalse(validate_attachment_request(cordelia, attachment.path_id))
 | |
|         self.assertTrue(validate_attachment_request(owner, attachment.path_id))
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertFalse(attachment.is_realm_public)
 | |
|         self.assertFalse(validate_attachment_request_for_spectator_access(realm, attachment))
 | |
| 
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|             "is_web_public": orjson.dumps(True).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", params)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         attachment.refresh_from_db()
 | |
|         stream.refresh_from_db()
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assertTrue(stream.is_web_public)
 | |
|         self.assertIsNone(attachment.is_realm_public)
 | |
|         self.assertIsNone(attachment.is_web_public)
 | |
| 
 | |
|         self.assertTrue(validate_attachment_request_for_spectator_access(realm, attachment))
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertTrue(attachment.is_web_public)
 | |
|         self.assertIsNone(attachment.is_realm_public)
 | |
| 
 | |
|         self.assertTrue(validate_attachment_request(cordelia, attachment.path_id))
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertTrue(attachment.is_realm_public)
 | |
| 
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|             "is_web_public": orjson.dumps(False).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(True).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", params)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         attachment.refresh_from_db()
 | |
|         stream.refresh_from_db()
 | |
|         self.assertIsNone(attachment.is_web_public)
 | |
|         self.assertFalse(stream.invite_only)
 | |
|         self.assertTrue(attachment.is_realm_public)
 | |
| 
 | |
|         self.assertFalse(validate_attachment_request_for_spectator_access(realm, attachment))
 | |
|         attachment.refresh_from_db()
 | |
|         stream.refresh_from_db()
 | |
|         self.assertFalse(attachment.is_web_public)
 | |
| 
 | |
|         # Verify moving a message to another public stream doesn't reset cache.
 | |
|         new_stream = self.make_stream("new_stream", realm=realm)
 | |
|         self.subscribe(owner, "new_stream")
 | |
|         result = self.client_patch(
 | |
|             "/json/messages/" + str(msg_id),
 | |
|             {
 | |
|                 "stream_id": new_stream.id,
 | |
|                 "propagate_mode": "change_all",
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertFalse(attachment.is_web_public)
 | |
|         self.assertTrue(attachment.is_realm_public)
 | |
| 
 | |
|         # Verify moving a message to a private stream
 | |
|         private_stream = self.make_stream("private_stream", realm=realm, invite_only=True)
 | |
|         self.subscribe(owner, "private_stream")
 | |
|         result = self.client_patch(
 | |
|             "/json/messages/" + str(msg_id),
 | |
|             {
 | |
|                 "stream_id": private_stream.id,
 | |
|                 "propagate_mode": "change_all",
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertFalse(attachment.is_web_public)
 | |
|         self.assertIsNone(attachment.is_realm_public)
 | |
| 
 | |
|         self.assertFalse(validate_attachment_request(cordelia, attachment.path_id))
 | |
|         self.assertTrue(validate_attachment_request(owner, attachment.path_id))
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertFalse(attachment.is_realm_public)
 | |
| 
 | |
|         # Verify moving a message to a web-public stream
 | |
|         web_public_stream = self.make_stream("web_public_stream", realm=realm, is_web_public=True)
 | |
|         result = self.client_patch(
 | |
|             "/json/messages/" + str(msg_id),
 | |
|             {
 | |
|                 "stream_id": web_public_stream.id,
 | |
|                 "propagate_mode": "change_all",
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertIsNone(attachment.is_web_public)
 | |
|         self.assertIsNone(attachment.is_realm_public)
 | |
| 
 | |
|         self.assertTrue(validate_attachment_request_for_spectator_access(realm, attachment))
 | |
|         attachment.refresh_from_db()
 | |
|         self.assertTrue(attachment.is_web_public)
 | |
| 
 | |
|     def test_try_make_stream_public_with_private_history(self) -> None:
 | |
|         # We only support public streams with private history if
 | |
|         # is_zephyr_mirror_realm, and don't allow changing stream
 | |
|         # permissions in such realms.  So changing the
 | |
|         # history_public_to_subscribers property of a public stream is
 | |
|         # not possible in Zulip today
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         self.make_stream("public_stream", realm=realm)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         params = {
 | |
|             "is_private": orjson.dumps(False).decode(),
 | |
|             "history_public_to_subscribers": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         stream_id = self.subscribe(user_profile, "public_stream").id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Invalid parameters")
 | |
| 
 | |
|         params = {
 | |
|             "history_public_to_subscribers": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", params)
 | |
|         self.assert_json_error(result, "Invalid parameters")
 | |
| 
 | |
|         web_public_stream = self.make_stream("web_public_stream", realm=realm, is_web_public=True)
 | |
|         result = self.client_patch(f"/json/streams/{web_public_stream.id}", params)
 | |
|         self.assert_json_error(result, "Invalid parameters")
 | |
| 
 | |
|     def test_subscriber_ids_with_stream_history_access(self) -> None:
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         polonius = self.example_user("polonius")
 | |
| 
 | |
|         stream1 = self.make_stream(
 | |
|             "history_private_stream", invite_only=True, history_public_to_subscribers=False
 | |
|         )
 | |
|         self.subscribe(hamlet, stream1.name)
 | |
|         self.subscribe(polonius, stream1.name)
 | |
|         self.assertEqual(set(), subscriber_ids_with_stream_history_access(stream1))
 | |
| 
 | |
|         stream2 = self.make_stream(
 | |
|             "history_public_web_private_stream",
 | |
|             invite_only=True,
 | |
|             is_web_public=False,
 | |
|             history_public_to_subscribers=True,
 | |
|         )
 | |
|         self.subscribe(hamlet, stream2.name)
 | |
|         self.subscribe(polonius, stream2.name)
 | |
|         self.assertEqual(
 | |
|             {hamlet.id, polonius.id}, subscriber_ids_with_stream_history_access(stream2)
 | |
|         )
 | |
| 
 | |
|         stream3 = self.make_stream(
 | |
|             "history_public_web_public_stream",
 | |
|             is_web_public=True,
 | |
|             history_public_to_subscribers=True,
 | |
|         )
 | |
|         self.subscribe(hamlet, stream3.name)
 | |
|         self.subscribe(polonius, stream3.name)
 | |
|         self.assertEqual(
 | |
|             {hamlet.id, polonius.id}, subscriber_ids_with_stream_history_access(stream3)
 | |
|         )
 | |
| 
 | |
|         stream4 = self.make_stream(
 | |
|             "regular_public_stream",
 | |
|         )
 | |
|         self.subscribe(hamlet, stream4.name)
 | |
|         self.subscribe(polonius, stream4.name)
 | |
|         self.assertEqual(
 | |
|             {hamlet.id, polonius.id}, subscriber_ids_with_stream_history_access(stream4)
 | |
|         )
 | |
| 
 | |
|     def test_deactivate_stream_backend(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         stream = self.make_stream("new_stream_1")
 | |
|         self.subscribe(user_profile, stream.name)
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         result = self.client_delete(f"/json/streams/{stream.id}")
 | |
|         self.assert_json_success(result)
 | |
|         subscription_exists = (
 | |
|             get_active_subscriptions_for_stream_id(stream.id, include_deactivated_users=True)
 | |
|             .filter(
 | |
|                 user_profile=user_profile,
 | |
|             )
 | |
|             .exists()
 | |
|         )
 | |
|         self.assertFalse(subscription_exists)
 | |
| 
 | |
|     def test_deactivate_stream_removes_default_stream(self) -> None:
 | |
|         stream = self.make_stream("new_stream")
 | |
|         do_add_default_stream(stream)
 | |
|         self.assertEqual(1, DefaultStream.objects.filter(stream_id=stream.id).count())
 | |
|         do_deactivate_stream(stream, acting_user=None)
 | |
|         self.assertEqual(0, DefaultStream.objects.filter(stream_id=stream.id).count())
 | |
| 
 | |
|     def test_deactivate_stream_removes_stream_from_default_stream_groups(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
|         streams_to_keep = [
 | |
|             ensure_stream(realm, stream_name, acting_user=None)
 | |
|             for stream_name in ["stream1", "stream2"]
 | |
|         ]
 | |
|         streams_to_remove = [ensure_stream(realm, "stream3", acting_user=None)]
 | |
|         all_streams = streams_to_keep + streams_to_remove
 | |
| 
 | |
|         def get_streams(group: DefaultStreamGroup) -> List[Stream]:
 | |
|             return list(group.streams.all().order_by("name"))
 | |
| 
 | |
|         group_name = "group1"
 | |
|         description = "This is group1"
 | |
|         do_create_default_stream_group(realm, group_name, description, all_streams)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assertEqual(get_streams(default_stream_groups[0]), all_streams)
 | |
| 
 | |
|         do_deactivate_stream(streams_to_remove[0], acting_user=None)
 | |
|         self.assertEqual(get_streams(default_stream_groups[0]), streams_to_keep)
 | |
| 
 | |
|     def test_deactivate_stream_marks_messages_as_read(self) -> None:
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         stream = self.make_stream("new_stream")
 | |
|         self.subscribe(hamlet, stream.name)
 | |
|         self.subscribe(cordelia, stream.name)
 | |
|         self.subscribe(hamlet, "Denmark")
 | |
|         self.subscribe(cordelia, "Denmark")
 | |
| 
 | |
|         self.send_stream_message(hamlet, stream.name)
 | |
|         new_stream_usermessage = most_recent_usermessage(cordelia)
 | |
| 
 | |
|         # We send a message to a different stream too, to verify that the
 | |
|         # deactivation of new_stream won't corrupt read state of UserMessage elsewhere.
 | |
|         self.send_stream_message(hamlet, "Denmark")
 | |
|         denmark_usermessage = most_recent_usermessage(cordelia)
 | |
| 
 | |
|         self.assertFalse(new_stream_usermessage.flags.read)
 | |
|         self.assertFalse(denmark_usermessage.flags.read)
 | |
| 
 | |
|         with self.captureOnCommitCallbacks(execute=True):
 | |
|             do_deactivate_stream(stream, acting_user=None)
 | |
|         new_stream_usermessage.refresh_from_db()
 | |
|         denmark_usermessage.refresh_from_db()
 | |
|         self.assertTrue(new_stream_usermessage.flags.read)
 | |
|         self.assertFalse(denmark_usermessage.flags.read)
 | |
| 
 | |
|     def test_deactivated_streams_by_old_name(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
|         stream = self.make_stream("new_stream")
 | |
|         do_deactivate_stream(stream, acting_user=None)
 | |
|         self.assertEqual(set(deactivated_streams_by_old_name(realm, "new_stream")), {stream})
 | |
| 
 | |
|         second_stream = self.make_stream("new_stream")
 | |
|         do_deactivate_stream(second_stream, acting_user=None)
 | |
|         self.assertEqual(
 | |
|             set(deactivated_streams_by_old_name(realm, "new_stream")), {stream, second_stream}
 | |
|         )
 | |
| 
 | |
|         self.make_stream("!DEACTIVATED:old_style")  # This is left active
 | |
|         old_style = self.make_stream("old_style")
 | |
|         do_deactivate_stream(old_style, acting_user=None)
 | |
|         old_style.name = "!!DEACTIVATED:old_style"
 | |
|         old_style.save()
 | |
|         self.assertEqual(set(deactivated_streams_by_old_name(realm, "old_style")), {old_style})
 | |
| 
 | |
|     def test_unarchive_stream_active_stream(self) -> None:
 | |
|         stream = self.make_stream("new_stream")
 | |
|         with self.assertRaisesRegex(JsonableError, "Channel is not currently deactivated"):
 | |
|             do_unarchive_stream(stream, new_name="new_stream", acting_user=None)
 | |
| 
 | |
|     def test_unarchive_stream_existing_name(self) -> None:
 | |
|         stream = self.make_stream("new_stream")
 | |
|         self.make_stream("existing")
 | |
|         do_deactivate_stream(stream, acting_user=None)
 | |
|         with self.assertRaisesRegex(JsonableError, "Channel named existing already exists"):
 | |
|             do_unarchive_stream(stream, new_name="existing", acting_user=None)
 | |
| 
 | |
|     def test_unarchive_stream(self) -> None:
 | |
|         desdemona = self.example_user("desdemona")
 | |
|         iago = self.example_user("iago")
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         cordelia = self.example_user("cordelia")
 | |
| 
 | |
|         stream = self.make_stream("new_stream", is_web_public=True)
 | |
|         self.subscribe(hamlet, stream.name)
 | |
|         self.subscribe(cordelia, stream.name)
 | |
|         do_deactivate_stream(stream, acting_user=None)
 | |
|         with self.capture_send_event_calls(expected_num_events=4) as events:
 | |
|             do_unarchive_stream(stream, new_name="new_stream", acting_user=None)
 | |
| 
 | |
|         # Tell all admins and owners that the stream exists
 | |
|         self.assertEqual(events[0]["event"]["op"], "create")
 | |
|         self.assertEqual(events[0]["event"]["streams"][0]["name"], "new_stream")
 | |
|         self.assertEqual(events[0]["event"]["streams"][0]["stream_id"], stream.id)
 | |
|         self.assertEqual(set(events[0]["users"]), {iago.id, desdemona.id})
 | |
| 
 | |
|         # Tell the owners that they're subscribed to it
 | |
|         self.assertEqual(events[1]["event"]["op"], "add")
 | |
|         self.assertEqual(events[1]["event"]["subscriptions"][0]["name"], "new_stream")
 | |
|         self.assertEqual(events[1]["event"]["subscriptions"][0]["stream_id"], stream.id)
 | |
|         self.assertEqual(events[1]["users"], [desdemona.id])
 | |
| 
 | |
|         # iago (as an admin) gets to know that desdemona (the owner) is now subscribed.
 | |
|         self.assertEqual(
 | |
|             events[2],
 | |
|             {
 | |
|                 "event": {
 | |
|                     "op": "peer_add",
 | |
|                     "stream_ids": [stream.id],
 | |
|                     "type": "subscription",
 | |
|                     "user_ids": [desdemona.id],
 | |
|                 },
 | |
|                 "users": [iago.id],
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         # Send a message there logging the reactivation
 | |
|         self.assertEqual(events[3]["event"]["type"], "message")
 | |
| 
 | |
|         stream = Stream.objects.get(id=stream.id)
 | |
|         self.assertFalse(stream.deactivated)
 | |
|         self.assertTrue(stream.invite_only)
 | |
|         self.assertFalse(stream.is_web_public)
 | |
|         self.assertTrue(stream.history_public_to_subscribers)
 | |
| 
 | |
|         self.assertEqual(
 | |
|             [desdemona.id],
 | |
|             [
 | |
|                 sub.user_profile_id
 | |
|                 for sub in get_active_subscriptions_for_stream_id(
 | |
|                     stream.id, include_deactivated_users=True
 | |
|                 )
 | |
|             ],
 | |
|         )
 | |
| 
 | |
|     def test_vacate_private_stream_removes_default_stream(self) -> None:
 | |
|         stream = self.make_stream("new_stream", invite_only=True)
 | |
|         self.subscribe(self.example_user("hamlet"), stream.name)
 | |
|         do_add_default_stream(stream)
 | |
|         self.assertEqual(1, DefaultStream.objects.filter(stream_id=stream.id).count())
 | |
|         self.unsubscribe(self.example_user("hamlet"), stream.name)
 | |
|         self.assertEqual(0, DefaultStream.objects.filter(stream_id=stream.id).count())
 | |
|         # Fetch stream again from database.
 | |
|         stream = Stream.objects.get(id=stream.id)
 | |
|         self.assertTrue(stream.deactivated)
 | |
| 
 | |
|     def test_deactivate_stream_backend_requires_existing_stream(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         self.make_stream("new_stream")
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         result = self.client_delete("/json/streams/999999999")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|     def test_deactivate_stream_backend_requires_admin(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         stream = self.subscribe(user_profile, "new_stream")
 | |
| 
 | |
|         result = self.client_delete(f"/json/streams/{stream.id}")
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|     def test_private_stream_live_updates(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         self.make_stream("private_stream", invite_only=True)
 | |
|         self.subscribe(user_profile, "private_stream")
 | |
|         self.subscribe(self.example_user("cordelia"), "private_stream")
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = get_stream("private_stream", user_profile.realm).id
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream_id}",
 | |
|                 {"description": "Test description"},
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         prospero = self.example_user("prospero")
 | |
| 
 | |
|         notified_user_ids = set(events[0]["users"])
 | |
|         self.assertIn(user_profile.id, notified_user_ids)
 | |
|         self.assertIn(cordelia.id, notified_user_ids)
 | |
|         self.assertNotIn(prospero.id, notified_user_ids)
 | |
| 
 | |
|         # Two events should be sent: a name event and a notification event
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = get_stream("private_stream", user_profile.realm).id
 | |
|             result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "whatever"})
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         notified_user_ids = set(events[0]["users"])
 | |
|         self.assertIn(user_profile.id, notified_user_ids)
 | |
|         self.assertIn(cordelia.id, notified_user_ids)
 | |
|         self.assertNotIn(prospero.id, notified_user_ids)
 | |
| 
 | |
|         notified_with_bot_users = events[-1]["users"]
 | |
|         notified_with_bot_user_ids = []
 | |
|         notified_with_bot_user_ids.append(notified_with_bot_users[0]["id"])
 | |
|         notified_with_bot_user_ids.append(notified_with_bot_users[1]["id"])
 | |
|         self.assertIn(user_profile.id, notified_with_bot_user_ids)
 | |
|         self.assertIn(cordelia.id, notified_with_bot_user_ids)
 | |
|         self.assertNotIn(prospero.id, notified_with_bot_user_ids)
 | |
| 
 | |
|     def test_rename_stream(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "stream_name1"})
 | |
|         self.assert_json_error(result, "Channel already has that name.")
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "Denmark"})
 | |
|         self.assert_json_error(result, "Channel name already in use.")
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "denmark "})
 | |
|         self.assert_json_error(result, "Channel name already in use.")
 | |
| 
 | |
|         # Do a rename that is case-only--this should succeed.
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "sTREAm_name1"})
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         # Two events should be sent: stream_name update and notification message.
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = get_stream("stream_name1", user_profile.realm).id
 | |
|             result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "stream_name2"})
 | |
|         self.assert_json_success(result)
 | |
|         event = events[0]["event"]
 | |
|         self.assertEqual(
 | |
|             event,
 | |
|             dict(
 | |
|                 op="update",
 | |
|                 type="stream",
 | |
|                 property="name",
 | |
|                 value="stream_name2",
 | |
|                 stream_id=stream_id,
 | |
|                 name="sTREAm_name1",
 | |
|             ),
 | |
|         )
 | |
|         notified_user_ids = set(events[0]["users"])
 | |
| 
 | |
|         self.assertRaises(Stream.DoesNotExist, get_stream, "stream_name1", realm)
 | |
| 
 | |
|         stream_name2_exists = get_stream("stream_name2", realm)
 | |
|         self.assertTrue(stream_name2_exists)
 | |
| 
 | |
|         self.assertEqual(notified_user_ids, set(active_non_guest_user_ids(realm.id)))
 | |
|         self.assertIn(user_profile.id, notified_user_ids)
 | |
|         self.assertIn(self.example_user("prospero").id, notified_user_ids)
 | |
|         self.assertNotIn(self.example_user("polonius").id, notified_user_ids)
 | |
| 
 | |
|         # Test case to handle Unicode stream name change
 | |
|         # *NOTE: Here encoding is needed when Unicode string is passed as an argument*
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = stream_name2_exists.id
 | |
|             result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "नया नाम"})
 | |
|         self.assert_json_success(result)
 | |
|         # While querying, system can handle Unicode strings.
 | |
|         stream_name_uni_exists = get_stream("नया नाम", realm)
 | |
|         self.assertTrue(stream_name_uni_exists)
 | |
| 
 | |
|         # Test case to handle changing of Unicode stream name to newer name
 | |
|         # NOTE: Unicode string being part of URL is handled cleanly
 | |
|         # by client_patch call, encoding of URL is not needed.
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = stream_name_uni_exists.id
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream_id}",
 | |
|                 {"new_name": "नाम में क्या रक्खा हे"},
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         # While querying, system can handle Unicode strings.
 | |
|         self.assertRaises(Stream.DoesNotExist, get_stream, "नया नाम", realm)
 | |
| 
 | |
|         stream_name_new_uni_exists = get_stream("नाम में क्या रक्खा हे", realm)
 | |
|         self.assertTrue(stream_name_new_uni_exists)
 | |
| 
 | |
|         # Test case to change name from one language to other.
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = stream_name_new_uni_exists.id
 | |
|             result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "français"})
 | |
|         self.assert_json_success(result)
 | |
|         stream_name_fr_exists = get_stream("français", realm)
 | |
|         self.assertTrue(stream_name_fr_exists)
 | |
| 
 | |
|         # Test case to change name to mixed language name.
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = stream_name_fr_exists.id
 | |
|             result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "français name"})
 | |
|         self.assert_json_success(result)
 | |
|         stream_name_mixed_exists = get_stream("français name", realm)
 | |
|         self.assertTrue(stream_name_mixed_exists)
 | |
| 
 | |
|         # Test case for notified users in private streams.
 | |
|         stream_private = self.make_stream(
 | |
|             "stream_private_name1", realm=user_profile.realm, invite_only=True
 | |
|         )
 | |
|         self.subscribe(self.example_user("cordelia"), "stream_private_name1")
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = get_stream("stream_private_name1", realm).id
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream_id}",
 | |
|                 {"new_name": "stream_private_name2"},
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         notified_user_ids = set(events[0]["users"])
 | |
|         self.assertEqual(notified_user_ids, can_access_stream_user_ids(stream_private))
 | |
|         self.assertIn(self.example_user("cordelia").id, notified_user_ids)
 | |
|         # An important corner case is that all organization admins are notified.
 | |
|         self.assertIn(self.example_user("iago").id, notified_user_ids)
 | |
|         # The current user, Hamlet was made an admin and thus should be notified too.
 | |
|         self.assertIn(user_profile.id, notified_user_ids)
 | |
|         self.assertNotIn(self.example_user("prospero").id, notified_user_ids)
 | |
| 
 | |
|     def test_rename_stream_requires_admin(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         self.make_stream("stream_name1")
 | |
|         self.subscribe(user_profile, "stream_name1")
 | |
| 
 | |
|         stream_id = get_stream("stream_name1", user_profile.realm).id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "stream_name2"})
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|     def test_notify_on_stream_rename(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         self.make_stream("stream_name1")
 | |
| 
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "stream_name2"})
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         # Inspect the notification message sent
 | |
|         message = self.get_last_message()
 | |
|         actual_stream = Stream.objects.get(id=message.recipient.type_id)
 | |
|         message_content = f"@_**King Hamlet|{user_profile.id}** renamed channel **stream_name1** to **stream_name2**."
 | |
|         self.assertEqual(actual_stream.name, "stream_name2")
 | |
|         self.assertEqual(actual_stream.realm_id, user_profile.realm_id)
 | |
|         self.assertEqual(message.recipient.type, Recipient.STREAM)
 | |
|         self.assertEqual(message.content, message_content)
 | |
|         self.assertEqual(message.sender.email, "notification-bot@zulip.com")
 | |
|         self.assertEqual(message.sender.realm, get_realm(settings.SYSTEM_BOT_REALM))
 | |
| 
 | |
|     def test_realm_admin_can_update_unsub_private_stream(self) -> None:
 | |
|         iago = self.example_user("iago")
 | |
|         hamlet = self.example_user("hamlet")
 | |
| 
 | |
|         self.login_user(iago)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             iago,
 | |
|             ["private_stream"],
 | |
|             dict(principals=orjson.dumps([hamlet.id]).decode()),
 | |
|             invite_only=True,
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         stream_id = get_stream("private_stream", iago.realm).id
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "new_private_stream"})
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}",
 | |
|             {"description": "new description"},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         # But cannot change stream type.
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}",
 | |
|             {
 | |
|                 "is_private": orjson.dumps(True).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|     def test_non_admin_cannot_access_unsub_private_stream(self) -> None:
 | |
|         iago = self.example_user("iago")
 | |
|         hamlet = self.example_user("hamlet")
 | |
| 
 | |
|         self.login_user(hamlet)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             hamlet,
 | |
|             ["private_stream_1"],
 | |
|             dict(principals=orjson.dumps([iago.id]).decode()),
 | |
|             invite_only=True,
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         stream_id = get_stream("private_stream_1", hamlet.realm).id
 | |
| 
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", {"new_name": "private_stream_2"})
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}",
 | |
|             {"description": "new description"},
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}",
 | |
|             {
 | |
|                 "is_private": orjson.dumps(True).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         result = self.client_delete(f"/json/streams/{stream_id}")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|     def test_change_stream_description(self) -> None:
 | |
|         user_profile = self.example_user("iago")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         self.subscribe(user_profile, "stream_name1")
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             stream_id = get_stream("stream_name1", realm).id
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream_id}",
 | |
|                 {"description": "Test description"},
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         event = events[0]["event"]
 | |
|         self.assertEqual(
 | |
|             event,
 | |
|             dict(
 | |
|                 op="update",
 | |
|                 type="stream",
 | |
|                 property="description",
 | |
|                 value="Test description",
 | |
|                 rendered_description="<p>Test description</p>",
 | |
|                 stream_id=stream_id,
 | |
|                 name="stream_name1",
 | |
|             ),
 | |
|         )
 | |
|         notified_user_ids = set(events[0]["users"])
 | |
| 
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(notified_user_ids, set(active_non_guest_user_ids(realm.id)))
 | |
|         self.assertIn(user_profile.id, notified_user_ids)
 | |
|         self.assertIn(self.example_user("prospero").id, notified_user_ids)
 | |
|         self.assertNotIn(self.example_user("polonius").id, notified_user_ids)
 | |
|         self.assertEqual("Test description", stream.description)
 | |
| 
 | |
|         result = self.client_patch(f"/json/streams/{stream_id}", {"description": "a" * 1025})
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             f"description is too long (limit: {Stream.MAX_DESCRIPTION_LENGTH} characters)",
 | |
|         )
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}",
 | |
|             {"description": ""},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(stream.description, "")
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         expected_notification = (
 | |
|             f"@_**{user_profile.full_name}|{user_profile.id}** changed the description for this channel.\n\n"
 | |
|             "* **Old description:**\n"
 | |
|             "```` quote\n"
 | |
|             "Test description\n"
 | |
|             "````\n"
 | |
|             "* **New description:**\n"
 | |
|             "```` quote\n"
 | |
|             "*No description.*\n"
 | |
|             "````"
 | |
|         )
 | |
|         self.assertEqual(messages[-1].content, expected_notification)
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}",
 | |
|             {"description": "Test description"},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(stream.description, "Test description")
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         expected_notification = (
 | |
|             f"@_**{user_profile.full_name}|{user_profile.id}** changed the description for this channel.\n\n"
 | |
|             "* **Old description:**\n"
 | |
|             "```` quote\n"
 | |
|             "*No description.*\n"
 | |
|             "````\n"
 | |
|             "* **New description:**\n"
 | |
|             "```` quote\n"
 | |
|             "Test description\n"
 | |
|             "````"
 | |
|         )
 | |
|         self.assertEqual(messages[-1].content, expected_notification)
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}",
 | |
|             {"description": "a\nmulti\nline\ndescription"},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(stream.description, "a multi line description")
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         expected_notification = (
 | |
|             f"@_**{user_profile.full_name}|{user_profile.id}** changed the description for this channel.\n\n"
 | |
|             "* **Old description:**\n"
 | |
|             "```` quote\n"
 | |
|             "Test description\n"
 | |
|             "````\n"
 | |
|             "* **New description:**\n"
 | |
|             "```` quote\n"
 | |
|             "a multi line description\n"
 | |
|             "````"
 | |
|         )
 | |
|         self.assertEqual(messages[-1].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: "Test description",
 | |
|             RealmAuditLog.NEW_VALUE: "a multi line description",
 | |
|             "property": "description",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         # Verify that we don't render inline URL previews in this code path.
 | |
|         with self.settings(INLINE_URL_EMBED_PREVIEW=True):
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream_id}",
 | |
|                 {"description": "See https://zulip.com/team/"},
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(
 | |
|             stream.rendered_description,
 | |
|             '<p>See <a href="https://zulip.com/team/">https://zulip.com/team/</a></p>',
 | |
|         )
 | |
| 
 | |
|     def test_change_stream_description_requires_admin(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
| 
 | |
|         self.subscribe(user_profile, "stream_name1")
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
| 
 | |
|         stream_id = get_stream("stream_name1", user_profile.realm).id
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}", {"description": "Test description"}
 | |
|         )
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|     def test_change_to_stream_post_policy_admins(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
| 
 | |
|         self.subscribe(user_profile, "stream_name1")
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         stream_id = get_stream("stream_name1", user_profile.realm).id
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream_id}", {"is_announcement_only": orjson.dumps(True).decode()}
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", user_profile.realm)
 | |
|         self.assertEqual(stream.stream_post_policy, Stream.STREAM_POST_POLICY_ADMINS)
 | |
| 
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         expected_notification = (
 | |
|             f"@_**{user_profile.full_name}|{user_profile.id}** changed the "
 | |
|             "[posting permissions](/help/channel-posting-policy) for this channel:\n\n"
 | |
|             "* **Old permissions**: All channel members can post.\n"
 | |
|             "* **New permissions**: Only organization administrators can post."
 | |
|         )
 | |
|         self.assertEqual(messages[-1].content, expected_notification)
 | |
| 
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|             modified_stream=stream,
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: Stream.STREAM_POST_POLICY_EVERYONE,
 | |
|             RealmAuditLog.NEW_VALUE: Stream.STREAM_POST_POLICY_ADMINS,
 | |
|             "property": "stream_post_policy",
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|     def test_change_stream_post_policy_requires_admin(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
| 
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
| 
 | |
|         do_set_realm_property(user_profile.realm, "waiting_period_threshold", 10, acting_user=None)
 | |
| 
 | |
|         def test_non_admin(how_old: int, is_new: bool, policy: int) -> None:
 | |
|             user_profile.date_joined = timezone_now() - timedelta(days=how_old)
 | |
|             user_profile.save()
 | |
|             self.assertEqual(user_profile.is_provisional_member, is_new)
 | |
|             stream_id = get_stream("stream_name1", user_profile.realm).id
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream_id}", {"stream_post_policy": orjson.dumps(policy).decode()}
 | |
|             )
 | |
|             self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|         policies = [
 | |
|             Stream.STREAM_POST_POLICY_ADMINS,
 | |
|             Stream.STREAM_POST_POLICY_MODERATORS,
 | |
|             Stream.STREAM_POST_POLICY_RESTRICT_NEW_MEMBERS,
 | |
|         ]
 | |
| 
 | |
|         for policy in policies:
 | |
|             test_non_admin(how_old=15, is_new=False, policy=policy)
 | |
|             test_non_admin(how_old=5, is_new=True, policy=policy)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         for policy in policies:
 | |
|             stream = get_stream("stream_name1", user_profile.realm)
 | |
|             old_post_policy = stream.stream_post_policy
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream.id}", {"stream_post_policy": orjson.dumps(policy).decode()}
 | |
|             )
 | |
|             self.assert_json_success(result)
 | |
|             stream = get_stream("stream_name1", user_profile.realm)
 | |
|             self.assertEqual(stream.stream_post_policy, policy)
 | |
| 
 | |
|             messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|             expected_notification = (
 | |
|                 f"@_**{user_profile.full_name}|{user_profile.id}** changed the "
 | |
|                 "[posting permissions](/help/channel-posting-policy) for this channel:\n\n"
 | |
|                 f"* **Old permissions**: {Stream.POST_POLICIES[old_post_policy]}.\n"
 | |
|                 f"* **New permissions**: {Stream.POST_POLICIES[policy]}."
 | |
|             )
 | |
| 
 | |
|             self.assertEqual(messages[-1].content, expected_notification)
 | |
| 
 | |
|             realm_audit_log = RealmAuditLog.objects.filter(
 | |
|                 event_type=RealmAuditLog.STREAM_PROPERTY_CHANGED,
 | |
|                 modified_stream=stream,
 | |
|             ).last()
 | |
|             assert realm_audit_log is not None
 | |
|             expected_extra_data = {
 | |
|                 RealmAuditLog.OLD_VALUE: old_post_policy,
 | |
|                 RealmAuditLog.NEW_VALUE: policy,
 | |
|                 "property": "stream_post_policy",
 | |
|             }
 | |
|             self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|     def test_change_stream_message_retention_days_notifications(self) -> None:
 | |
|         user_profile = self.example_user("desdemona")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         do_change_realm_plan_type(realm, Realm.PLAN_TYPE_SELF_HOSTED, acting_user=None)
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
| 
 | |
|         # Go from realm default (forever) to 2 days
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(2).decode()}
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 1)
 | |
|         expected_notification = (
 | |
|             f"@_**Desdemona|{user_profile.id}** has changed the [message retention period](/help/message-retention-policy) for this channel:\n"
 | |
|             "* **Old retention period**: Forever\n"
 | |
|             "* **New retention period**: 2 days\n\n"
 | |
|             "Messages in this channel will now be automatically deleted 2 days after they are sent."
 | |
|         )
 | |
|         self.assertEqual(messages[0].content, expected_notification)
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_MESSAGE_RETENTION_DAYS_CHANGED
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {RealmAuditLog.OLD_VALUE: None, RealmAuditLog.NEW_VALUE: 2}
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         # Go from 2 days to 8 days
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(8).decode()}
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 2)
 | |
|         expected_notification = (
 | |
|             f"@_**Desdemona|{user_profile.id}** has changed the [message retention period](/help/message-retention-policy) for this channel:\n"
 | |
|             "* **Old retention period**: 2 days\n"
 | |
|             "* **New retention period**: 8 days\n\n"
 | |
|             "Messages in this channel will now be automatically deleted 8 days after they are sent."
 | |
|         )
 | |
|         self.assertEqual(messages[1].content, expected_notification)
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_MESSAGE_RETENTION_DAYS_CHANGED
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {RealmAuditLog.OLD_VALUE: 2, RealmAuditLog.NEW_VALUE: 8}
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|         # Go from 8 days to realm default (None on stream, forever/-1 on realm)
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"message_retention_days": orjson.dumps("realm_default").decode()},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         messages = get_topic_messages(user_profile, stream, "channel events")
 | |
|         self.assert_length(messages, 3)
 | |
|         expected_notification = (
 | |
|             f"@_**Desdemona|{user_profile.id}** has changed the [message retention period](/help/message-retention-policy) for this channel:\n"
 | |
|             "* **Old retention period**: 8 days\n"
 | |
|             "* **New retention period**: Forever\n\n"
 | |
|             "Messages in this channel will now be retained forever."
 | |
|         )
 | |
|         self.assertEqual(messages[2].content, expected_notification)
 | |
|         realm_audit_log = RealmAuditLog.objects.filter(
 | |
|             event_type=RealmAuditLog.STREAM_MESSAGE_RETENTION_DAYS_CHANGED
 | |
|         ).last()
 | |
|         assert realm_audit_log is not None
 | |
|         expected_extra_data = {
 | |
|             RealmAuditLog.OLD_VALUE: 8,
 | |
|             RealmAuditLog.NEW_VALUE: None,
 | |
|         }
 | |
|         self.assertEqual(realm_audit_log.extra_data, expected_extra_data)
 | |
| 
 | |
|     def test_change_stream_message_retention_days(self) -> None:
 | |
|         user_profile = self.example_user("desdemona")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         do_change_realm_plan_type(realm, Realm.PLAN_TYPE_LIMITED, acting_user=None)
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(2).decode()}
 | |
|         )
 | |
|         self.assert_json_error(result, "Available on Zulip Cloud Standard. Upgrade to access.")
 | |
| 
 | |
|         do_change_realm_plan_type(realm, Realm.PLAN_TYPE_SELF_HOSTED, acting_user=None)
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(2).decode()}
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         event = events[0]["event"]
 | |
|         self.assertEqual(
 | |
|             event,
 | |
|             dict(
 | |
|                 op="update",
 | |
|                 type="stream",
 | |
|                 property="message_retention_days",
 | |
|                 value=2,
 | |
|                 stream_id=stream.id,
 | |
|                 name="stream_name1",
 | |
|             ),
 | |
|         )
 | |
|         notified_user_ids = set(events[0]["users"])
 | |
|         stream = get_stream("stream_name1", realm)
 | |
| 
 | |
|         self.assertEqual(notified_user_ids, set(active_non_guest_user_ids(realm.id)))
 | |
|         self.assertIn(user_profile.id, notified_user_ids)
 | |
|         self.assertIn(self.example_user("prospero").id, notified_user_ids)
 | |
|         self.assertNotIn(self.example_user("polonius").id, notified_user_ids)
 | |
|         self.assertEqual(stream.message_retention_days, 2)
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream.id}",
 | |
|                 {"message_retention_days": orjson.dumps("unlimited").decode()},
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         event = events[0]["event"]
 | |
|         self.assertEqual(
 | |
|             event,
 | |
|             dict(
 | |
|                 op="update",
 | |
|                 type="stream",
 | |
|                 property="message_retention_days",
 | |
|                 value=-1,
 | |
|                 stream_id=stream.id,
 | |
|                 name="stream_name1",
 | |
|             ),
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(stream.message_retention_days, -1)
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             result = self.client_patch(
 | |
|                 f"/json/streams/{stream.id}",
 | |
|                 {"message_retention_days": orjson.dumps("realm_default").decode()},
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         event = events[0]["event"]
 | |
|         self.assertEqual(
 | |
|             event,
 | |
|             dict(
 | |
|                 op="update",
 | |
|                 type="stream",
 | |
|                 property="message_retention_days",
 | |
|                 value=None,
 | |
|                 stream_id=stream.id,
 | |
|                 name="stream_name1",
 | |
|             ),
 | |
|         )
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(stream.message_retention_days, None)
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"message_retention_days": orjson.dumps("invalid").decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, "Bad value for 'message_retention_days': invalid")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(-1).decode()}
 | |
|         )
 | |
|         self.assert_json_error(result, "Bad value for 'message_retention_days': -1")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(0).decode()}
 | |
|         )
 | |
|         self.assert_json_error(result, "Bad value for 'message_retention_days': 0")
 | |
| 
 | |
|     def test_change_stream_message_retention_days_requires_realm_owner(self) -> None:
 | |
|         user_profile = self.example_user("iago")
 | |
|         self.login_user(user_profile)
 | |
|         realm = user_profile.realm
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(2).decode()}
 | |
|         )
 | |
|         self.assert_json_error(result, "Must be an organization owner")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_OWNER, acting_user=None)
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}", {"message_retention_days": orjson.dumps(2).decode()}
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(stream.message_retention_days, 2)
 | |
| 
 | |
|     def test_change_stream_can_remove_subscribers_group(self) -> None:
 | |
|         user_profile = self.example_user("iago")
 | |
|         realm = user_profile.realm
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
| 
 | |
|         moderators_system_group = NamedUserGroup.objects.get(
 | |
|             name="role:moderators", realm=realm, is_system_group=True
 | |
|         )
 | |
|         self.login("shiva")
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(moderators_system_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, "Must be an organization administrator")
 | |
| 
 | |
|         self.login("iago")
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(moderators_system_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name1", realm)
 | |
|         self.assertEqual(stream.can_remove_subscribers_group.id, moderators_system_group.id)
 | |
| 
 | |
|         # This setting can only be set to system groups.
 | |
|         hamletcharacters_group = NamedUserGroup.objects.get(name="hamletcharacters", realm=realm)
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(hamletcharacters_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result, "'can_remove_subscribers_group' must be a system user group."
 | |
|         )
 | |
| 
 | |
|         internet_group = NamedUserGroup.objects.get(
 | |
|             name="role:internet", is_system_group=True, realm=realm
 | |
|         )
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(internet_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             "'can_remove_subscribers_group' setting cannot be set to 'role:internet' group.",
 | |
|         )
 | |
| 
 | |
|         owners_group = NamedUserGroup.objects.get(
 | |
|             name="role:owners", is_system_group=True, realm=realm
 | |
|         )
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(owners_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             "'can_remove_subscribers_group' setting cannot be set to 'role:owners' group.",
 | |
|         )
 | |
| 
 | |
|         nobody_group = NamedUserGroup.objects.get(
 | |
|             name="role:nobody", is_system_group=True, realm=realm
 | |
|         )
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(nobody_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             "'can_remove_subscribers_group' setting cannot be set to 'role:nobody' group.",
 | |
|         )
 | |
| 
 | |
|         # For private streams, even admins must be subscribed to the stream to change
 | |
|         # can_remove_subscribers_group setting.
 | |
|         stream = self.make_stream("stream_name2", invite_only=True)
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(moderators_system_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         self.subscribe(user_profile, "stream_name2")
 | |
|         result = self.client_patch(
 | |
|             f"/json/streams/{stream.id}",
 | |
|             {"can_remove_subscribers_group": orjson.dumps(moderators_system_group.id).decode()},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         stream = get_stream("stream_name2", realm)
 | |
|         self.assertEqual(stream.can_remove_subscribers_group.id, moderators_system_group.id)
 | |
| 
 | |
|     def test_stream_message_retention_days_on_stream_creation(self) -> None:
 | |
|         """
 | |
|         Only admins can create streams with message_retention_days
 | |
|         with value other than None.
 | |
|         """
 | |
|         admin = self.example_user("iago")
 | |
| 
 | |
|         streams_raw: List[StreamDict] = [
 | |
|             {
 | |
|                 "name": "new_stream",
 | |
|                 "message_retention_days": 10,
 | |
|                 "is_web_public": False,
 | |
|             }
 | |
|         ]
 | |
|         with self.assertRaisesRegex(JsonableError, "Must be an organization owner"):
 | |
|             list_to_streams(streams_raw, admin, autocreate=True)
 | |
| 
 | |
|         streams_raw = [
 | |
|             {
 | |
|                 "name": "new_stream",
 | |
|                 "message_retention_days": -1,
 | |
|                 "is_web_public": False,
 | |
|             }
 | |
|         ]
 | |
|         with self.assertRaisesRegex(JsonableError, "Must be an organization owner"):
 | |
|             list_to_streams(streams_raw, admin, autocreate=True)
 | |
| 
 | |
|         streams_raw = [
 | |
|             {
 | |
|                 "name": "new_stream",
 | |
|                 "message_retention_days": None,
 | |
|                 "is_web_public": False,
 | |
|             }
 | |
|         ]
 | |
|         result = list_to_streams(streams_raw, admin, autocreate=True)
 | |
|         self.assert_length(result[0], 0)
 | |
|         self.assert_length(result[1], 1)
 | |
|         self.assertEqual(result[1][0].name, "new_stream")
 | |
|         self.assertEqual(result[1][0].message_retention_days, None)
 | |
| 
 | |
|         owner = self.example_user("desdemona")
 | |
|         realm = owner.realm
 | |
|         streams_raw = [
 | |
|             {
 | |
|                 "name": "new_stream1",
 | |
|                 "message_retention_days": 10,
 | |
|                 "is_web_public": False,
 | |
|             },
 | |
|             {
 | |
|                 "name": "new_stream2",
 | |
|                 "message_retention_days": -1,
 | |
|                 "is_web_public": False,
 | |
|             },
 | |
|             {
 | |
|                 "name": "new_stream3",
 | |
|                 "is_web_public": False,
 | |
|             },
 | |
|         ]
 | |
| 
 | |
|         do_change_realm_plan_type(realm, Realm.PLAN_TYPE_LIMITED, acting_user=admin)
 | |
|         with self.assertRaisesRegex(
 | |
|             JsonableError, "Available on Zulip Cloud Standard. Upgrade to access."
 | |
|         ):
 | |
|             list_to_streams(streams_raw, owner, autocreate=True)
 | |
| 
 | |
|         do_change_realm_plan_type(realm, Realm.PLAN_TYPE_SELF_HOSTED, acting_user=admin)
 | |
|         result = list_to_streams(streams_raw, owner, autocreate=True)
 | |
|         self.assert_length(result[0], 0)
 | |
|         self.assert_length(result[1], 3)
 | |
|         self.assertEqual(result[1][0].name, "new_stream1")
 | |
|         self.assertEqual(result[1][0].message_retention_days, 10)
 | |
|         self.assertEqual(result[1][1].name, "new_stream2")
 | |
|         self.assertEqual(result[1][1].message_retention_days, -1)
 | |
|         self.assertEqual(result[1][2].name, "new_stream3")
 | |
|         self.assertEqual(result[1][2].message_retention_days, None)
 | |
| 
 | |
|     def set_up_stream_for_archiving(
 | |
|         self, stream_name: str, invite_only: bool = False, subscribed: bool = True
 | |
|     ) -> Stream:
 | |
|         """
 | |
|         Create a stream for archiving by an administrator.
 | |
|         """
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         stream = self.make_stream(stream_name, invite_only=invite_only)
 | |
| 
 | |
|         # For testing archiving streams you aren't on.
 | |
|         if subscribed:
 | |
|             self.subscribe(user_profile, stream_name)
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         return stream
 | |
| 
 | |
|     def archive_stream(self, stream: Stream) -> None:
 | |
|         """
 | |
|         Archive the stream and assess the result.
 | |
|         """
 | |
|         active_name = stream.name
 | |
|         realm = stream.realm
 | |
|         stream_id = stream.id
 | |
| 
 | |
|         # Simulate that a stream by the same name has already been
 | |
|         # deactivated, just to exercise our renaming logic:
 | |
|         # Since we do not know the id of these simulated stream we prepend the name with a random hashed_stream_id
 | |
|         ensure_stream(realm, "DB32B77!DEACTIVATED:" + active_name, acting_user=None)
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=1) as events:
 | |
|             result = self.client_delete("/json/streams/" + str(stream_id))
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         # We no longer send subscription events for stream deactivations.
 | |
|         sub_events = [e for e in events if e["event"]["type"] == "subscription"]
 | |
|         self.assertEqual(sub_events, [])
 | |
| 
 | |
|         stream_events = [e for e in events if e["event"]["type"] == "stream"]
 | |
|         self.assert_length(stream_events, 1)
 | |
|         event = stream_events[0]["event"]
 | |
|         self.assertEqual(event["op"], "delete")
 | |
|         self.assertEqual(event["streams"][0]["stream_id"], stream.id)
 | |
| 
 | |
|         with self.assertRaises(Stream.DoesNotExist):
 | |
|             Stream.objects.get(realm=get_realm("zulip"), name=active_name)
 | |
| 
 | |
|         # A deleted stream's name is changed, is deactivated, is invite-only,
 | |
|         # and has no subscribers.
 | |
|         hashed_stream_id = hashlib.sha512(str(stream_id).encode()).hexdigest()[0:7]
 | |
|         deactivated_stream_name = hashed_stream_id + "!DEACTIVATED:" + active_name
 | |
|         deactivated_stream = get_stream(deactivated_stream_name, realm)
 | |
|         self.assertTrue(deactivated_stream.deactivated)
 | |
|         self.assertTrue(deactivated_stream.invite_only)
 | |
|         self.assertEqual(deactivated_stream.name, deactivated_stream_name)
 | |
|         subscribers = self.users_subscribed_to_stream(deactivated_stream_name, realm)
 | |
|         self.assertEqual(subscribers, [])
 | |
| 
 | |
|         # It doesn't show up in the list of public streams anymore.
 | |
|         result = self.client_get("/json/streams", {"include_subscribed": "false"})
 | |
|         public_streams = [s["name"] for s in self.assert_json_success(result)["streams"]]
 | |
|         self.assertNotIn(active_name, public_streams)
 | |
|         self.assertNotIn(deactivated_stream_name, public_streams)
 | |
| 
 | |
|         # Even if you could guess the new name, you can't subscribe to it.
 | |
|         result = self.client_post(
 | |
|             "/json/users/me/subscriptions",
 | |
|             {"subscriptions": orjson.dumps([{"name": deactivated_stream_name}]).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, f"Unable to access channel ({deactivated_stream_name}).")
 | |
| 
 | |
|         # You cannot re-archive the stream
 | |
|         with self.capture_send_event_calls(expected_num_events=0) as events:
 | |
|             result = self.client_delete("/json/streams/" + str(stream_id))
 | |
|         self.assert_json_error(result, "Channel is already deactivated")
 | |
| 
 | |
|     def test_you_must_be_realm_admin(self) -> None:
 | |
|         """
 | |
|         You must be on the realm to create a stream.
 | |
|         """
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
| 
 | |
|         other_realm = do_create_realm(string_id="other", name="other")
 | |
|         stream = self.make_stream("other_realm_stream", realm=other_realm)
 | |
| 
 | |
|         result = self.client_delete("/json/streams/" + str(stream.id))
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         # Even becoming a realm admin doesn't help us for an out-of-realm
 | |
|         # stream.
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         result = self.client_delete("/json/streams/" + str(stream.id))
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|     def test_delete_public_stream(self) -> None:
 | |
|         """
 | |
|         When an administrator deletes a public stream, that stream is not
 | |
|         visible to users at all anymore.
 | |
|         """
 | |
|         stream = self.set_up_stream_for_archiving("newstream")
 | |
|         self.archive_stream(stream)
 | |
| 
 | |
|     def test_delete_private_stream(self) -> None:
 | |
|         """
 | |
|         Administrators can delete private streams they are on.
 | |
|         """
 | |
|         stream = self.set_up_stream_for_archiving("newstream", invite_only=True)
 | |
|         self.archive_stream(stream)
 | |
| 
 | |
|     def test_archive_stream_youre_not_on(self) -> None:
 | |
|         """
 | |
|         Administrators can delete public streams they aren't on
 | |
|         """
 | |
|         pub_stream = self.set_up_stream_for_archiving("pubstream", subscribed=False)
 | |
|         self.archive_stream(pub_stream)
 | |
| 
 | |
|     def test_archive_invite_only_stream_youre_not_on(self) -> None:
 | |
|         """
 | |
|         Administrators can delete invite-only streams they aren't on
 | |
|         """
 | |
|         priv_stream = self.set_up_stream_for_archiving(
 | |
|             "privstream", subscribed=False, invite_only=True
 | |
|         )
 | |
|         self.archive_stream(priv_stream)
 | |
| 
 | |
|     def attempt_unsubscribe_of_principal(
 | |
|         self,
 | |
|         target_users: List[UserProfile],
 | |
|         query_count: int,
 | |
|         cache_count: Optional[int] = None,
 | |
|         is_realm_admin: bool = False,
 | |
|         is_subbed: bool = True,
 | |
|         invite_only: bool = False,
 | |
|         target_users_subbed: bool = True,
 | |
|         using_legacy_emails: bool = False,
 | |
|         other_sub_users: Sequence[UserProfile] = [],
 | |
|     ) -> "TestHttpResponse":
 | |
|         # Set up the main user, who is in most cases an admin.
 | |
|         if is_realm_admin:
 | |
|             user_profile = self.example_user("iago")
 | |
|         else:
 | |
|             user_profile = self.example_user("hamlet")
 | |
| 
 | |
|         self.login_user(user_profile)
 | |
| 
 | |
|         # Set up the stream.
 | |
|         stream_name = "hümbüǵ"
 | |
|         self.make_stream(stream_name, invite_only=invite_only)
 | |
| 
 | |
|         # Set up the principal to be unsubscribed.
 | |
|         principals = [user.email if using_legacy_emails else user.id for user in target_users]
 | |
| 
 | |
|         # Subscribe the admin and/or principal as specified in the flags.
 | |
|         if is_subbed:
 | |
|             self.subscribe(user_profile, stream_name)
 | |
|         if target_users_subbed:
 | |
|             for user in target_users:
 | |
|                 self.subscribe(user, stream_name)
 | |
|         for user in other_sub_users:
 | |
|             self.subscribe(user, stream_name)
 | |
| 
 | |
|         with self.assert_database_query_count(query_count):
 | |
|             with cache_tries_captured() as cache_tries:
 | |
|                 with self.captureOnCommitCallbacks(execute=True):
 | |
|                     result = self.client_delete(
 | |
|                         "/json/users/me/subscriptions",
 | |
|                         {
 | |
|                             "subscriptions": orjson.dumps([stream_name]).decode(),
 | |
|                             "principals": orjson.dumps(principals).decode(),
 | |
|                         },
 | |
|                     )
 | |
|         if cache_count is not None:
 | |
|             self.assert_length(cache_tries, cache_count)
 | |
| 
 | |
|         # If the removal succeeded, assert all target users are no longer subscribed.
 | |
|         if result.status_code not in [400]:
 | |
|             subbed_users = self.users_subscribed_to_stream(stream_name, user_profile.realm)
 | |
|             for user in target_users:
 | |
|                 self.assertNotIn(user, subbed_users)
 | |
| 
 | |
|         return result
 | |
| 
 | |
|     def test_cant_remove_other_users_from_stream(self) -> None:
 | |
|         """
 | |
|         If you're not an admin, you can't remove other people from streams except your own bots.
 | |
|         """
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=8,
 | |
|             target_users=[self.example_user("cordelia")],
 | |
|             is_realm_admin=False,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|     def test_realm_admin_remove_others_from_public_stream(self) -> None:
 | |
|         """
 | |
|         If you're a realm admin, you can remove people from public streams, even
 | |
|         those you aren't on.
 | |
|         """
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=17,
 | |
|             target_users=[self.example_user("cordelia")],
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=True,
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 1)
 | |
|         self.assert_length(json["not_removed"], 0)
 | |
| 
 | |
|     def test_realm_admin_remove_multiple_users_from_stream(self) -> None:
 | |
|         """
 | |
|         If you're a realm admin, you can remove multiple users from a stream.
 | |
| 
 | |
|         TODO: We have too many queries for this situation--each additional
 | |
|               user leads to 4 more queries.
 | |
| 
 | |
|               Fortunately, some of the extra work here is in
 | |
|               do_mark_stream_messages_as_read, which gets deferred
 | |
|               using a queue.
 | |
|         """
 | |
|         target_users = [
 | |
|             self.example_user(name)
 | |
|             for name in ["cordelia", "prospero", "iago", "hamlet", "outgoing_webhook_bot"]
 | |
|         ]
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=28,
 | |
|             cache_count=8,
 | |
|             target_users=target_users,
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=True,
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 5)
 | |
|         self.assert_length(json["not_removed"], 0)
 | |
| 
 | |
|     def test_realm_admin_remove_others_from_subbed_private_stream(self) -> None:
 | |
|         """
 | |
|         If you're a realm admin, you can remove other people from private streams you
 | |
|         are on.
 | |
|         """
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=17,
 | |
|             target_users=[self.example_user("cordelia")],
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=True,
 | |
|             invite_only=True,
 | |
|             target_users_subbed=True,
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 1)
 | |
|         self.assert_length(json["not_removed"], 0)
 | |
| 
 | |
|     def test_realm_admin_remove_others_from_unsubbed_private_stream(self) -> None:
 | |
|         """
 | |
|         If you're a realm admin, you can remove people from private
 | |
|         streams you aren't on.
 | |
|         """
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=17,
 | |
|             target_users=[self.example_user("cordelia")],
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=False,
 | |
|             invite_only=True,
 | |
|             target_users_subbed=True,
 | |
|             other_sub_users=[self.example_user("othello")],
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 1)
 | |
|         self.assert_length(json["not_removed"], 0)
 | |
| 
 | |
|     def test_cant_remove_others_from_stream_legacy_emails(self) -> None:
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=8,
 | |
|             is_realm_admin=False,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users=[self.example_user("cordelia")],
 | |
|             target_users_subbed=True,
 | |
|             using_legacy_emails=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|     def test_admin_remove_others_from_stream_legacy_emails(self) -> None:
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=17,
 | |
|             target_users=[self.example_user("cordelia")],
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=True,
 | |
|             using_legacy_emails=True,
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 1)
 | |
|         self.assert_length(json["not_removed"], 0)
 | |
| 
 | |
|     def test_admin_remove_multiple_users_from_stream_legacy_emails(self) -> None:
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=20,
 | |
|             target_users=[self.example_user("cordelia"), self.example_user("prospero")],
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=True,
 | |
|             using_legacy_emails=True,
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 2)
 | |
|         self.assert_length(json["not_removed"], 0)
 | |
| 
 | |
|     def test_remove_unsubbed_user_along_with_subbed(self) -> None:
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=17,
 | |
|             target_users=[self.example_user("cordelia"), self.example_user("iago")],
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=False,
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 1)
 | |
|         self.assert_length(json["not_removed"], 1)
 | |
| 
 | |
|     def test_remove_already_not_subbed(self) -> None:
 | |
|         """
 | |
|         Trying to unsubscribe someone who already isn't subscribed to a stream
 | |
|         fails gracefully.
 | |
|         """
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=9,
 | |
|             target_users=[self.example_user("cordelia")],
 | |
|             is_realm_admin=True,
 | |
|             is_subbed=False,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=False,
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assert_length(json["removed"], 0)
 | |
|         self.assert_length(json["not_removed"], 1)
 | |
| 
 | |
|     def test_bot_owner_can_remove_bot_from_stream(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         webhook_bot = self.example_user("webhook_bot")
 | |
|         do_change_bot_owner(webhook_bot, bot_owner=user_profile, acting_user=user_profile)
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=14,
 | |
|             target_users=[webhook_bot],
 | |
|             is_realm_admin=False,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=True,
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|     def test_non_bot_owner_cannot_remove_bot_from_stream(self) -> None:
 | |
|         other_user = self.example_user("cordelia")
 | |
|         webhook_bot = self.example_user("webhook_bot")
 | |
|         do_change_bot_owner(webhook_bot, bot_owner=other_user, acting_user=other_user)
 | |
|         result = self.attempt_unsubscribe_of_principal(
 | |
|             query_count=8,
 | |
|             target_users=[webhook_bot],
 | |
|             is_realm_admin=False,
 | |
|             is_subbed=True,
 | |
|             invite_only=False,
 | |
|             target_users_subbed=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|     def test_can_remove_subscribers_group(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
|         leadership_group = check_add_user_group(
 | |
|             realm,
 | |
|             "leadership",
 | |
|             [self.example_user("iago"), self.example_user("shiva")],
 | |
|             acting_user=None,
 | |
|         )
 | |
|         managers_group = check_add_user_group(
 | |
|             realm, "managers", [self.example_user("hamlet")], acting_user=None
 | |
|         )
 | |
|         add_subgroups_to_user_group(managers_group, [leadership_group], acting_user=None)
 | |
|         cordelia = self.example_user("cordelia")
 | |
| 
 | |
|         stream = self.make_stream("public_stream")
 | |
| 
 | |
|         def check_unsubscribing_user(
 | |
|             user: UserProfile, can_remove_subscribers_group: UserGroup, expect_fail: bool = False
 | |
|         ) -> None:
 | |
|             self.login_user(user)
 | |
|             self.subscribe(cordelia, stream.name)
 | |
|             do_change_stream_group_based_setting(
 | |
|                 stream,
 | |
|                 "can_remove_subscribers_group",
 | |
|                 can_remove_subscribers_group,
 | |
|                 acting_user=None,
 | |
|             )
 | |
|             result = self.client_delete(
 | |
|                 "/json/users/me/subscriptions",
 | |
|                 {
 | |
|                     "subscriptions": orjson.dumps([stream.name]).decode(),
 | |
|                     "principals": orjson.dumps([cordelia.id]).decode(),
 | |
|                 },
 | |
|             )
 | |
|             if expect_fail:
 | |
|                 self.assert_json_error(result, "Insufficient permission")
 | |
|                 return
 | |
| 
 | |
|             json = self.assert_json_success(result)
 | |
|             self.assert_length(json["removed"], 1)
 | |
|             self.assert_length(json["not_removed"], 0)
 | |
| 
 | |
|         check_unsubscribing_user(self.example_user("hamlet"), leadership_group, expect_fail=True)
 | |
|         check_unsubscribing_user(self.example_user("desdemona"), leadership_group, expect_fail=True)
 | |
|         check_unsubscribing_user(self.example_user("iago"), leadership_group)
 | |
| 
 | |
|         check_unsubscribing_user(self.example_user("othello"), managers_group, expect_fail=True)
 | |
|         check_unsubscribing_user(self.example_user("shiva"), managers_group)
 | |
|         check_unsubscribing_user(self.example_user("hamlet"), managers_group)
 | |
| 
 | |
|         stream = self.make_stream("private_stream", invite_only=True)
 | |
|         self.subscribe(self.example_user("hamlet"), stream.name)
 | |
|         # Non-admins are not allowed to unsubscribe others from private streams that they
 | |
|         # are not subscribed to even if they are member of the allowed group.
 | |
|         check_unsubscribing_user(self.example_user("shiva"), leadership_group, expect_fail=True)
 | |
|         check_unsubscribing_user(self.example_user("iago"), leadership_group)
 | |
| 
 | |
|         self.subscribe(self.example_user("shiva"), stream.name)
 | |
|         check_unsubscribing_user(self.example_user("shiva"), leadership_group)
 | |
| 
 | |
|     def test_remove_invalid_user(self) -> None:
 | |
|         """
 | |
|         Trying to unsubscribe an invalid user from a stream fails gracefully.
 | |
|         """
 | |
|         admin = self.example_user("iago")
 | |
|         self.login_user(admin)
 | |
|         self.assertTrue(admin.is_realm_admin)
 | |
| 
 | |
|         stream_name = "hümbüǵ"
 | |
|         self.make_stream(stream_name)
 | |
| 
 | |
|         result = self.client_delete(
 | |
|             "/json/users/me/subscriptions",
 | |
|             {
 | |
|                 "subscriptions": orjson.dumps([stream_name]).decode(),
 | |
|                 "principals": orjson.dumps([99]).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "No such user", status_code=400)
 | |
| 
 | |
| 
 | |
| class DefaultStreamTest(ZulipTestCase):
 | |
|     def get_default_stream_names(self, realm: Realm) -> Set[str]:
 | |
|         streams = get_default_streams_for_realm_as_dicts(realm.id)
 | |
|         return {s["name"] for s in streams}
 | |
| 
 | |
|     def test_query_count(self) -> None:
 | |
|         DefaultStream.objects.all().delete()
 | |
|         realm = get_realm("zulip")
 | |
| 
 | |
|         new_stream_ids = set()
 | |
| 
 | |
|         for i in range(5):
 | |
|             stream = ensure_stream(realm, f"stream {i}", acting_user=None)
 | |
|             new_stream_ids.add(stream.id)
 | |
|             do_add_default_stream(stream)
 | |
| 
 | |
|         with queries_captured() as queries:
 | |
|             default_streams = get_default_streams_for_realm_as_dicts(realm.id)
 | |
| 
 | |
|         self.assert_length(queries, 1)
 | |
|         self.assert_length(default_streams, 5)
 | |
|         self.assertEqual({dct["stream_id"] for dct in default_streams}, new_stream_ids)
 | |
| 
 | |
|         # Make sure our query isn't some bloated select_related query.
 | |
|         self.assertLess(len(queries[0].sql), 800)
 | |
| 
 | |
|         with queries_captured() as queries:
 | |
|             default_stream_ids = get_default_stream_ids_for_realm(realm.id)
 | |
| 
 | |
|         self.assert_length(queries, 1)
 | |
|         self.assertEqual(default_stream_ids, new_stream_ids)
 | |
| 
 | |
|     def test_add_and_remove_default_stream(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
|         stream = ensure_stream(realm, "Added stream", acting_user=None)
 | |
|         orig_stream_names = self.get_default_stream_names(realm)
 | |
|         do_add_default_stream(stream)
 | |
|         new_stream_names = self.get_default_stream_names(realm)
 | |
|         added_stream_names = new_stream_names - orig_stream_names
 | |
|         self.assertEqual(added_stream_names, {"Added stream"})
 | |
|         # idempotency--2nd call to add_default_stream should be a noop
 | |
|         do_add_default_stream(stream)
 | |
|         self.assertEqual(self.get_default_stream_names(realm), new_stream_names)
 | |
| 
 | |
|         # start removing
 | |
|         do_remove_default_stream(stream)
 | |
|         self.assertEqual(self.get_default_stream_names(realm), orig_stream_names)
 | |
|         # idempotency--2nd call to remove_default_stream should be a noop
 | |
|         do_remove_default_stream(stream)
 | |
|         self.assertEqual(self.get_default_stream_names(realm), orig_stream_names)
 | |
| 
 | |
|     def test_api_calls(self) -> None:
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         self.login_user(user_profile)
 | |
| 
 | |
|         DefaultStream.objects.filter(realm=user_profile.realm).delete()
 | |
| 
 | |
|         stream_name = "stream ADDED via api"
 | |
|         stream = ensure_stream(user_profile.realm, stream_name, acting_user=None)
 | |
|         result = self.client_post("/json/default_streams", dict(stream_id=stream.id))
 | |
|         self.assert_json_success(result)
 | |
|         self.assertTrue(stream_name in self.get_default_stream_names(user_profile.realm))
 | |
| 
 | |
|         # look for it
 | |
|         self.subscribe(user_profile, stream_name)
 | |
|         payload = dict(
 | |
|             include_public="true",
 | |
|             include_default="true",
 | |
|         )
 | |
|         result = self.client_get("/json/streams", payload)
 | |
|         streams = self.assert_json_success(result)["streams"]
 | |
|         default_streams = {stream["name"] for stream in streams if stream["is_default"]}
 | |
|         self.assertEqual(default_streams, {stream_name})
 | |
| 
 | |
|         other_streams = {stream["name"] for stream in streams if not stream["is_default"]}
 | |
|         self.assertGreater(len(other_streams), 0)
 | |
| 
 | |
|         # and remove it
 | |
|         result = self.client_delete("/json/default_streams", dict(stream_id=stream.id))
 | |
|         self.assert_json_success(result)
 | |
|         self.assertFalse(stream_name in self.get_default_stream_names(user_profile.realm))
 | |
| 
 | |
|         # Test admin can't access unsubscribed private stream for adding.
 | |
|         stream_name = "private_stream"
 | |
|         stream = self.make_stream(stream_name, invite_only=True)
 | |
|         self.subscribe(self.example_user("iago"), stream_name)
 | |
|         result = self.client_post("/json/default_streams", dict(stream_id=stream.id))
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         # Test admin can't add subscribed private stream also.
 | |
|         self.subscribe(user_profile, stream_name)
 | |
|         result = self.client_post("/json/default_streams", dict(stream_id=stream.id))
 | |
|         self.assert_json_error(result, "Private channels cannot be made default.")
 | |
| 
 | |
|     def test_guest_user_access_to_streams(self) -> None:
 | |
|         user_profile = self.example_user("polonius")
 | |
|         self.login_user(user_profile)
 | |
|         self.assertEqual(user_profile.role, UserProfile.ROLE_GUEST)
 | |
| 
 | |
|         # Get all the streams that Polonius has access to (subscribed + web-public streams)
 | |
|         result = self.client_get("/json/streams", {"include_web_public": "true"})
 | |
|         streams = self.assert_json_success(result)["streams"]
 | |
|         sub_info = gather_subscriptions_helper(user_profile)
 | |
| 
 | |
|         subscribed = sub_info.subscriptions
 | |
|         unsubscribed = sub_info.unsubscribed
 | |
|         never_subscribed = sub_info.never_subscribed
 | |
| 
 | |
|         self.assert_length(streams, len(subscribed) + len(unsubscribed) + len(never_subscribed))
 | |
|         stream_names = [stream["name"] for stream in streams]
 | |
|         expected_stream_names = [stream["name"] for stream in subscribed + unsubscribed]
 | |
|         expected_stream_names += [stream["name"] for stream in never_subscribed]
 | |
|         self.assertEqual(set(stream_names), set(expected_stream_names))
 | |
| 
 | |
| 
 | |
| class DefaultStreamGroupTest(ZulipTestCase):
 | |
|     def test_create_update_and_remove_default_stream_group(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
| 
 | |
|         # Test creating new default stream group
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 0)
 | |
| 
 | |
|         streams = [
 | |
|             ensure_stream(realm, stream_name, acting_user=None)
 | |
|             for stream_name in ["stream1", "stream2", "stream3"]
 | |
|         ]
 | |
| 
 | |
|         def get_streams(group: DefaultStreamGroup) -> List[Stream]:
 | |
|             return list(group.streams.all().order_by("name"))
 | |
| 
 | |
|         group_name = "group1"
 | |
|         description = "This is group1"
 | |
|         do_create_default_stream_group(realm, group_name, description, streams)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, group_name)
 | |
|         self.assertEqual(default_stream_groups[0].description, description)
 | |
|         self.assertEqual(get_streams(default_stream_groups[0]), streams)
 | |
| 
 | |
|         # Test adding streams to existing default stream group
 | |
|         group = lookup_default_stream_groups(["group1"], realm)[0]
 | |
|         new_stream_names = [
 | |
|             "stream4",
 | |
|             "stream5",
 | |
|             "stream6",
 | |
|             "stream7",
 | |
|             "stream8",
 | |
|             "stream9",
 | |
|         ]
 | |
|         new_streams = [
 | |
|             ensure_stream(realm, new_stream_name, acting_user=None)
 | |
|             for new_stream_name in new_stream_names
 | |
|         ]
 | |
|         streams += new_streams
 | |
| 
 | |
|         do_add_streams_to_default_stream_group(realm, group, new_streams)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, group_name)
 | |
|         self.assertEqual(get_streams(default_stream_groups[0]), streams)
 | |
| 
 | |
|         # Test removing streams from existing default stream group
 | |
|         with self.assert_database_query_count(5):
 | |
|             do_remove_streams_from_default_stream_group(realm, group, new_streams)
 | |
|         remaining_streams = streams[0:3]
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, group_name)
 | |
|         self.assertEqual(get_streams(default_stream_groups[0]), remaining_streams)
 | |
| 
 | |
|         # Test changing default stream group description
 | |
|         new_description = "group1 new description"
 | |
|         do_change_default_stream_group_description(realm, group, new_description)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assertEqual(default_stream_groups[0].description, new_description)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
| 
 | |
|         # Test changing default stream group name
 | |
|         new_group_name = "new group1"
 | |
|         do_change_default_stream_group_name(realm, group, new_group_name)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, new_group_name)
 | |
|         self.assertEqual(get_streams(default_stream_groups[0]), remaining_streams)
 | |
| 
 | |
|         # Test removing default stream group
 | |
|         do_remove_default_stream_group(realm, group)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 0)
 | |
| 
 | |
|         # Test creating a default stream group which contains a default stream
 | |
|         do_add_default_stream(remaining_streams[0])
 | |
|         with self.assertRaisesRegex(
 | |
|             JsonableError, "'stream1' is a default channel and cannot be added to 'new group1'"
 | |
|         ):
 | |
|             do_create_default_stream_group(
 | |
|                 realm, new_group_name, "This is group1", remaining_streams
 | |
|             )
 | |
| 
 | |
|     def test_api_calls(self) -> None:
 | |
|         self.login("hamlet")
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         realm = user_profile.realm
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
| 
 | |
|         # Test creating new default stream group
 | |
|         stream_names = ["stream1", "stream2", "stream3"]
 | |
|         group_name = "group1"
 | |
|         description = "This is group1"
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 0)
 | |
| 
 | |
|         streams = [
 | |
|             ensure_stream(realm, stream_name, acting_user=None) for stream_name in stream_names
 | |
|         ]
 | |
| 
 | |
|         result = self.client_post(
 | |
|             "/json/default_stream_groups/create",
 | |
|             {
 | |
|                 "group_name": group_name,
 | |
|                 "description": description,
 | |
|                 "stream_names": orjson.dumps(stream_names).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, group_name)
 | |
|         self.assertEqual(default_stream_groups[0].description, description)
 | |
|         self.assertEqual(list(default_stream_groups[0].streams.all().order_by("id")), streams)
 | |
| 
 | |
|         # Try adding the same streams to the group.
 | |
|         result = self.client_post(
 | |
|             "/json/default_stream_groups/create",
 | |
|             {
 | |
|                 "group_name": group_name,
 | |
|                 "description": description,
 | |
|                 "stream_names": orjson.dumps(stream_names).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "Default channel group 'group1' already exists")
 | |
| 
 | |
|         # Test adding streams to existing default stream group
 | |
|         group_id = default_stream_groups[0].id
 | |
|         new_stream_names = ["stream4", "stream5"]
 | |
|         new_streams = [
 | |
|             ensure_stream(realm, new_stream_name, acting_user=None)
 | |
|             for new_stream_name in new_stream_names
 | |
|         ]
 | |
|         streams += new_streams
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, "Missing 'op' argument")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"op": "invalid", "stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, 'Invalid value for "op". Specify one of "add" or "remove".')
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             "/json/default_stream_groups/12345/streams",
 | |
|             {"op": "add", "stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, "Default channel group with id '12345' does not exist.")
 | |
| 
 | |
|         result = self.client_patch(f"/json/default_stream_groups/{group_id}/streams", {"op": "add"})
 | |
|         self.assert_json_error(result, "Missing 'stream_names' argument")
 | |
| 
 | |
|         do_add_default_stream(new_streams[0])
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"op": "add", "stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result, "'stream4' is a default channel and cannot be added to 'group1'"
 | |
|         )
 | |
| 
 | |
|         do_remove_default_stream(new_streams[0])
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"op": "add", "stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, group_name)
 | |
|         self.assertEqual(list(default_stream_groups[0].streams.all().order_by("name")), streams)
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"op": "add", "stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result, "Channel 'stream4' is already present in default channel group 'group1'"
 | |
|         )
 | |
| 
 | |
|         # Test removing streams from default stream group
 | |
|         result = self.client_patch(
 | |
|             "/json/default_stream_groups/12345/streams",
 | |
|             {"op": "remove", "stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, "Default channel group with id '12345' does not exist.")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"op": "remove", "stream_names": orjson.dumps(["random stream name"]).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid channel name 'random stream name'")
 | |
| 
 | |
|         streams.remove(new_streams[0])
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"op": "remove", "stream_names": orjson.dumps([new_stream_names[0]]).decode()},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, group_name)
 | |
|         self.assertEqual(list(default_stream_groups[0].streams.all().order_by("name")), streams)
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}/streams",
 | |
|             {"op": "remove", "stream_names": orjson.dumps(new_stream_names).decode()},
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result, "Channel 'stream4' is not present in default channel group 'group1'"
 | |
|         )
 | |
| 
 | |
|         # Test changing description of default stream group
 | |
|         new_description = "new group1 description"
 | |
| 
 | |
|         result = self.client_patch(f"/json/default_stream_groups/{group_id}")
 | |
|         self.assert_json_error(result, 'You must pass "new_description" or "new_group_name".')
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             "/json/default_stream_groups/12345",
 | |
|             {"new_description": new_description},
 | |
|         )
 | |
|         self.assert_json_error(result, "Default channel group with id '12345' does not exist.")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}",
 | |
|             {"new_description": new_description},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, group_name)
 | |
|         self.assertEqual(default_stream_groups[0].description, new_description)
 | |
| 
 | |
|         # Test changing name of default stream group
 | |
|         new_group_name = "new group1"
 | |
|         do_create_default_stream_group(realm, "group2", "", [])
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}",
 | |
|             {"new_group_name": "group2"},
 | |
|         )
 | |
|         self.assert_json_error(result, "Default channel group 'group2' already exists")
 | |
|         new_group = lookup_default_stream_groups(["group2"], realm)[0]
 | |
|         do_remove_default_stream_group(realm, new_group)
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}",
 | |
|             {"new_group_name": group_name},
 | |
|         )
 | |
|         self.assert_json_error(result, "This default channel group is already named 'group1'")
 | |
| 
 | |
|         result = self.client_patch(
 | |
|             f"/json/default_stream_groups/{group_id}",
 | |
|             {"new_group_name": new_group_name},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 1)
 | |
|         self.assertEqual(default_stream_groups[0].name, new_group_name)
 | |
|         self.assertEqual(default_stream_groups[0].description, new_description)
 | |
| 
 | |
|         # Test deleting a default stream group
 | |
|         result = self.client_delete(f"/json/default_stream_groups/{group_id}")
 | |
|         self.assert_json_success(result)
 | |
|         default_stream_groups = get_default_stream_groups(realm)
 | |
|         self.assert_length(default_stream_groups, 0)
 | |
| 
 | |
|         result = self.client_delete(f"/json/default_stream_groups/{group_id}")
 | |
|         self.assert_json_error(
 | |
|             result, f"Default channel group with id '{group_id}' does not exist."
 | |
|         )
 | |
| 
 | |
|     def test_invalid_default_stream_group_name(self) -> None:
 | |
|         self.login("iago")
 | |
|         user_profile = self.example_user("iago")
 | |
|         realm = user_profile.realm
 | |
| 
 | |
|         stream_names = ["stream1", "stream2", "stream3"]
 | |
|         description = "This is group1"
 | |
|         for stream_name in stream_names:
 | |
|             ensure_stream(realm, stream_name, acting_user=None)
 | |
| 
 | |
|         result = self.client_post(
 | |
|             "/json/default_stream_groups/create",
 | |
|             {
 | |
|                 "group_name": "",
 | |
|                 "description": description,
 | |
|                 "stream_names": orjson.dumps(stream_names).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid default channel group name ''")
 | |
| 
 | |
|         result = self.client_post(
 | |
|             "/json/default_stream_groups/create",
 | |
|             {
 | |
|                 "group_name": "x" * 100,
 | |
|                 "description": description,
 | |
|                 "stream_names": orjson.dumps(stream_names).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             f"Default channel group name too long (limit: {DefaultStreamGroup.MAX_NAME_LENGTH} characters)",
 | |
|         )
 | |
| 
 | |
|         result = self.client_post(
 | |
|             "/json/default_stream_groups/create",
 | |
|             {
 | |
|                 "group_name": "abc\000",
 | |
|                 "description": description,
 | |
|                 "stream_names": orjson.dumps(stream_names).decode(),
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result, "Default channel group name 'abc\000' contains NULL (0x00) characters."
 | |
|         )
 | |
| 
 | |
|         # Also test that lookup_default_stream_groups raises an
 | |
|         # error if we pass it a bad name.  This function is used
 | |
|         # during registration, but it's a bit heavy to do a full
 | |
|         # test of that.
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid default channel group invalid-name"):
 | |
|             lookup_default_stream_groups(["invalid-name"], realm)
 | |
| 
 | |
| 
 | |
| class SubscriptionPropertiesTest(ZulipTestCase):
 | |
|     def test_set_stream_color(self) -> None:
 | |
|         """
 | |
|         A POST request to /api/v1/users/me/subscriptions/properties with stream_id and
 | |
|         color data sets the stream color, and for that stream only. Also, make sure that
 | |
|         any invalid hex color codes are bounced.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
| 
 | |
|         old_subs, _ = gather_subscriptions(test_user)
 | |
|         sub = old_subs[0]
 | |
|         stream_id = sub["stream_id"]
 | |
|         new_color = "#ffffff"  # TODO: ensure that this is different from old_color
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": "color", "stream_id": stream_id, "value": "#ffffff"}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         new_subs = gather_subscriptions(test_user)[0]
 | |
|         found_sub = None
 | |
|         for sub in new_subs:
 | |
|             if sub["stream_id"] == stream_id:
 | |
|                 found_sub = sub
 | |
|                 break
 | |
| 
 | |
|         assert found_sub is not None
 | |
|         self.assertEqual(found_sub["color"], new_color)
 | |
| 
 | |
|         new_subs.remove(found_sub)
 | |
|         for sub in old_subs:
 | |
|             if sub["stream_id"] == stream_id:
 | |
|                 found_sub = sub
 | |
|                 break
 | |
|         old_subs.remove(found_sub)
 | |
|         self.assertEqual(old_subs, new_subs)
 | |
| 
 | |
|         invalid_color = "3ffrff"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": "color", "stream_id": stream_id, "value": invalid_color}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "color is not a valid hex color code")
 | |
| 
 | |
|     def test_set_color_missing_stream_id(self) -> None:
 | |
|         """
 | |
|         Updating the color property requires a `stream_id` key.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": "color", "value": "#ffffff"}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "stream_id key is missing from subscription_data[0]")
 | |
| 
 | |
|     def test_set_color_unsubscribed_stream_id(self) -> None:
 | |
|         """
 | |
|         Updating the color property requires a subscribed stream.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
| 
 | |
|         sub_info = gather_subscriptions_helper(test_user)
 | |
| 
 | |
|         not_subbed = sub_info.never_subscribed
 | |
| 
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [
 | |
|                         {
 | |
|                             "property": "color",
 | |
|                             "stream_id": not_subbed[0]["stream_id"],
 | |
|                             "value": "#ffffff",
 | |
|                         }
 | |
|                     ]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result, "Not subscribed to channel ID {}".format(not_subbed[0]["stream_id"])
 | |
|         )
 | |
| 
 | |
|     def test_set_color_missing_color(self) -> None:
 | |
|         """
 | |
|         Updating the color property requires a color.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
|         subs = gather_subscriptions(test_user)[0]
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": "color", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "value key is missing from subscription_data[0]")
 | |
| 
 | |
|     def test_set_stream_wildcard_mentions_notify(self) -> None:
 | |
|         """
 | |
|         A POST request to /api/v1/users/me/subscriptions/properties with wildcard_mentions_notify
 | |
|         sets the property.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
| 
 | |
|         subs = gather_subscriptions(test_user)[0]
 | |
|         sub = subs[0]
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [
 | |
|                         {
 | |
|                             "property": "wildcard_mentions_notify",
 | |
|                             "stream_id": sub["stream_id"],
 | |
|                             "value": True,
 | |
|                         }
 | |
|                     ]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         updated_sub = get_subscription(sub["name"], test_user)
 | |
|         self.assertIsNotNone(updated_sub)
 | |
|         self.assertEqual(updated_sub.wildcard_mentions_notify, True)
 | |
| 
 | |
|     def test_set_pin_to_top(self) -> None:
 | |
|         """
 | |
|         A POST request to /api/v1/users/me/subscriptions/properties with stream_id and
 | |
|         pin_to_top data pins the stream.
 | |
|         """
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         old_subs, _ = gather_subscriptions(user)
 | |
|         sub = old_subs[0]
 | |
|         stream_id = sub["stream_id"]
 | |
|         new_pin_to_top = not sub["pin_to_top"]
 | |
|         result = self.api_post(
 | |
|             user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": "pin_to_top", "stream_id": stream_id, "value": new_pin_to_top}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         updated_sub = get_subscription(sub["name"], user)
 | |
| 
 | |
|         self.assertIsNotNone(updated_sub)
 | |
|         self.assertEqual(updated_sub.pin_to_top, new_pin_to_top)
 | |
| 
 | |
|     def test_change_is_muted(self) -> None:
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
|         subs = gather_subscriptions(test_user)[0]
 | |
| 
 | |
|         sub = Subscription.objects.get(
 | |
|             recipient__type=Recipient.STREAM,
 | |
|             recipient__type_id=subs[0]["stream_id"],
 | |
|             user_profile=test_user,
 | |
|         )
 | |
|         self.assertEqual(sub.is_muted, False)
 | |
| 
 | |
|         property_name = "is_muted"
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             result = self.api_post(
 | |
|                 test_user,
 | |
|                 "/api/v1/users/me/subscriptions/properties",
 | |
|                 {
 | |
|                     "subscription_data": orjson.dumps(
 | |
|                         [
 | |
|                             {
 | |
|                                 "property": property_name,
 | |
|                                 "value": True,
 | |
|                                 "stream_id": subs[0]["stream_id"],
 | |
|                             }
 | |
|                         ]
 | |
|                     ).decode()
 | |
|                 },
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         self.assertEqual(events[0]["event"]["property"], "in_home_view")
 | |
|         self.assertEqual(events[0]["event"]["value"], False)
 | |
|         self.assertEqual(events[1]["event"]["property"], "is_muted")
 | |
|         self.assertEqual(events[1]["event"]["value"], True)
 | |
|         sub = Subscription.objects.get(
 | |
|             recipient__type=Recipient.STREAM,
 | |
|             recipient__type_id=subs[0]["stream_id"],
 | |
|             user_profile=test_user,
 | |
|         )
 | |
|         self.assertEqual(sub.is_muted, True)
 | |
| 
 | |
|         legacy_property_name = "in_home_view"
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             result = self.api_post(
 | |
|                 test_user,
 | |
|                 "/api/v1/users/me/subscriptions/properties",
 | |
|                 {
 | |
|                     "subscription_data": orjson.dumps(
 | |
|                         [
 | |
|                             {
 | |
|                                 "property": legacy_property_name,
 | |
|                                 "value": True,
 | |
|                                 "stream_id": subs[0]["stream_id"],
 | |
|                             }
 | |
|                         ]
 | |
|                     ).decode()
 | |
|                 },
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         self.assertEqual(events[0]["event"]["property"], "in_home_view")
 | |
|         self.assertEqual(events[0]["event"]["value"], True)
 | |
|         self.assertEqual(events[1]["event"]["property"], "is_muted")
 | |
|         self.assertEqual(events[1]["event"]["value"], False)
 | |
|         self.assert_json_success(result)
 | |
|         sub = Subscription.objects.get(
 | |
|             recipient__type=Recipient.STREAM,
 | |
|             recipient__type_id=subs[0]["stream_id"],
 | |
|             user_profile=test_user,
 | |
|         )
 | |
|         self.assertEqual(sub.is_muted, False)
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             result = self.api_post(
 | |
|                 test_user,
 | |
|                 "/api/v1/users/me/subscriptions/properties",
 | |
|                 {
 | |
|                     "subscription_data": orjson.dumps(
 | |
|                         [
 | |
|                             {
 | |
|                                 "property": legacy_property_name,
 | |
|                                 "value": False,
 | |
|                                 "stream_id": subs[0]["stream_id"],
 | |
|                             }
 | |
|                         ]
 | |
|                     ).decode()
 | |
|                 },
 | |
|             )
 | |
|         self.assert_json_success(result)
 | |
|         self.assertEqual(events[0]["event"]["property"], "in_home_view")
 | |
|         self.assertEqual(events[0]["event"]["value"], False)
 | |
|         self.assertEqual(events[1]["event"]["property"], "is_muted")
 | |
|         self.assertEqual(events[1]["event"]["value"], True)
 | |
| 
 | |
|         sub = Subscription.objects.get(
 | |
|             recipient__type=Recipient.STREAM,
 | |
|             recipient__type_id=subs[0]["stream_id"],
 | |
|             user_profile=test_user,
 | |
|         )
 | |
|         self.assertEqual(sub.is_muted, True)
 | |
| 
 | |
|     def test_set_subscription_property_incorrect(self) -> None:
 | |
|         """
 | |
|         Trying to set a property incorrectly returns a JSON error.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
|         subs = gather_subscriptions(test_user)[0]
 | |
| 
 | |
|         property_name = "is_muted"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, f"{property_name} is not a boolean")
 | |
| 
 | |
|         property_name = "in_home_view"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, f"{property_name} is not a boolean")
 | |
| 
 | |
|         property_name = "desktop_notifications"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, f"{property_name} is not a boolean")
 | |
| 
 | |
|         property_name = "audible_notifications"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, f"{property_name} is not a boolean")
 | |
| 
 | |
|         property_name = "push_notifications"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, f"{property_name} is not a boolean")
 | |
| 
 | |
|         property_name = "email_notifications"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, f"{property_name} is not a boolean")
 | |
| 
 | |
|         property_name = "wildcard_mentions_notify"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         self.assert_json_error(result, f"{property_name} is not a boolean")
 | |
| 
 | |
|         property_name = "color"
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": property_name, "value": False, "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, f"{property_name} is not a string")
 | |
| 
 | |
|     def test_json_subscription_property_invalid_stream(self) -> None:
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
| 
 | |
|         stream_id = 1000
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": "is_muted", "stream_id": stream_id, "value": False}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|     def test_set_invalid_property(self) -> None:
 | |
|         """
 | |
|         Trying to set an invalid property returns a JSON error.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
|         subs = gather_subscriptions(test_user)[0]
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [{"property": "bad", "value": "bad", "stream_id": subs[0]["stream_id"]}]
 | |
|                 ).decode()
 | |
|             },
 | |
|         )
 | |
|         self.assert_json_error(result, "Unknown subscription property: bad")
 | |
| 
 | |
|     def test_ignored_parameters_in_subscriptions_properties_endpoint(self) -> None:
 | |
|         """
 | |
|         Sending an invalid parameter with a valid parameter returns
 | |
|         an `ignored_parameters_unsupported` array.
 | |
|         """
 | |
|         test_user = self.example_user("hamlet")
 | |
|         self.login_user(test_user)
 | |
| 
 | |
|         subs = gather_subscriptions(test_user)[0]
 | |
|         sub = subs[0]
 | |
|         result = self.api_post(
 | |
|             test_user,
 | |
|             "/api/v1/users/me/subscriptions/properties",
 | |
|             {
 | |
|                 "subscription_data": orjson.dumps(
 | |
|                     [
 | |
|                         {
 | |
|                             "property": "wildcard_mentions_notify",
 | |
|                             "stream_id": sub["stream_id"],
 | |
|                             "value": True,
 | |
|                         }
 | |
|                     ]
 | |
|                 ).decode(),
 | |
|                 "invalid_parameter": orjson.dumps(
 | |
|                     [{"property": "pin_to_top", "stream_id": sub["stream_id"], "value": False}]
 | |
|                 ).decode(),
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         self.assert_json_success(result, ignored_parameters=["invalid_parameter"])
 | |
| 
 | |
| 
 | |
| class SubscriptionRestApiTest(ZulipTestCase):
 | |
|     def test_basic_add_delete(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         # add
 | |
|         request = {
 | |
|             "add": orjson.dumps([{"name": "my_test_stream_1"}]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_success(result)
 | |
|         streams = self.get_streams(user)
 | |
|         self.assertTrue("my_test_stream_1" in streams)
 | |
| 
 | |
|         # now delete the same stream
 | |
|         request = {
 | |
|             "delete": orjson.dumps(["my_test_stream_1"]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_success(result)
 | |
|         streams = self.get_streams(user)
 | |
|         self.assertTrue("my_test_stream_1" not in streams)
 | |
| 
 | |
|     def test_add_with_color(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         # add with color proposition
 | |
|         request = {
 | |
|             "add": orjson.dumps([{"name": "my_test_stream_2", "color": "#afafaf"}]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|         # incorrect color format
 | |
|         request = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "my_test_stream_3", "color": "#0g0g0g"}]
 | |
|             ).decode(),
 | |
|         }
 | |
|         result = self.api_post(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_error(result, 'subscriptions[0]["color"] is not a valid hex color code')
 | |
| 
 | |
|     def test_api_valid_property(self) -> None:
 | |
|         """
 | |
|         Trying to set valid json returns success message.
 | |
|         """
 | |
|         user = self.example_user("hamlet")
 | |
| 
 | |
|         self.login_user(user)
 | |
|         subs = gather_subscriptions(user)[0]
 | |
|         result = self.api_patch(
 | |
|             user,
 | |
|             "/api/v1/users/me/subscriptions/{}".format(subs[0]["stream_id"]),
 | |
|             {"property": "color", "value": "#c2c2c2"},
 | |
|         )
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|     def test_api_invalid_property(self) -> None:
 | |
|         """
 | |
|         Trying to set an invalid property returns a JSON error.
 | |
|         """
 | |
| 
 | |
|         user = self.example_user("hamlet")
 | |
| 
 | |
|         self.login_user(user)
 | |
|         subs = gather_subscriptions(user)[0]
 | |
| 
 | |
|         result = self.api_patch(
 | |
|             user,
 | |
|             "/api/v1/users/me/subscriptions/{}".format(subs[0]["stream_id"]),
 | |
|             {"property": "invalid", "value": "somevalue"},
 | |
|         )
 | |
|         self.assert_json_error(result, "Unknown subscription property: invalid")
 | |
| 
 | |
|     def test_api_invalid_stream_id(self) -> None:
 | |
|         """
 | |
|         Trying to set an invalid stream id returns a JSON error.
 | |
|         """
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
|         result = self.api_patch(
 | |
|             user,
 | |
|             "/api/v1/users/me/subscriptions/121",
 | |
|             {"property": "is_muted", "value": "somevalue"},
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|     def test_bad_add_parameters(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         def check_for_error(val: Any, expected_message: str) -> None:
 | |
|             request = {
 | |
|                 "add": orjson.dumps(val).decode(),
 | |
|             }
 | |
|             result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|             self.assert_json_error(result, expected_message)
 | |
| 
 | |
|         check_for_error(["foo"], "add[0] is not a dict")
 | |
|         check_for_error([{"bogus": "foo"}], "name key is missing from add[0]")
 | |
|         check_for_error([{"name": {}}], 'add[0]["name"] is not a string')
 | |
| 
 | |
|     def test_bad_principals(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         request = {
 | |
|             "add": orjson.dumps([{"name": "my_new_stream"}]).decode(),
 | |
|             "principals": orjson.dumps([{}]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_error(result, "principals is not an allowed_type")
 | |
| 
 | |
|     def test_bad_delete_parameters(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         request = {
 | |
|             "delete": orjson.dumps([{"name": "my_test_stream_1"}]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_error(result, "delete[0] is not a string")
 | |
| 
 | |
|     def test_add_or_delete_not_specified(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", {})
 | |
|         self.assert_json_error(result, 'Nothing to do. Specify at least one of "add" or "delete".')
 | |
| 
 | |
|     def test_patch_enforces_valid_stream_name_check(self) -> None:
 | |
|         """
 | |
|         Only way to force an error is with a empty string.
 | |
|         """
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         invalid_stream_name = ""
 | |
|         request = {
 | |
|             "delete": orjson.dumps([invalid_stream_name]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_error(result, "Channel name can't be empty.")
 | |
| 
 | |
|     def test_stream_name_too_long(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         long_stream_name = "a" * 61
 | |
|         request = {
 | |
|             "delete": orjson.dumps([long_stream_name]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_error(result, "Channel name too long (limit: 60 characters).")
 | |
| 
 | |
|     def test_stream_name_contains_null(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         stream_name = "abc\000"
 | |
|         request = {
 | |
|             "delete": orjson.dumps([stream_name]).decode(),
 | |
|         }
 | |
|         result = self.api_patch(user, "/api/v1/users/me/subscriptions", request)
 | |
|         self.assert_json_error(result, "Invalid character in channel name, at position 4.")
 | |
| 
 | |
|     def test_compose_views_rollback(self) -> None:
 | |
|         """
 | |
|         The compose_views function() is used under the hood by
 | |
|         update_subscriptions_backend.  It's a pretty simple method in terms of
 | |
|         control flow, but it uses a Django rollback, which may make it brittle
 | |
|         code when we upgrade Django.  We test the functions's rollback logic
 | |
|         here with a simple scenario to avoid false positives related to
 | |
|         subscription complications.
 | |
|         """
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         user_profile.full_name = "Hamlet"
 | |
|         user_profile.save()
 | |
|         request = HostRequestMock(user_profile=user_profile)
 | |
| 
 | |
|         def thunk1() -> HttpResponse:
 | |
|             user_profile.full_name = "Should not be committed"
 | |
|             user_profile.save()
 | |
|             return json_success(request)
 | |
| 
 | |
|         def thunk2() -> HttpResponse:
 | |
|             raise JsonableError("random failure")
 | |
| 
 | |
|         with self.assertRaises(JsonableError):
 | |
|             compose_views([thunk1, thunk2])
 | |
| 
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.assertEqual(user_profile.full_name, "Hamlet")
 | |
| 
 | |
| 
 | |
| class SubscriptionAPITest(ZulipTestCase):
 | |
|     @override
 | |
|     def setUp(self) -> None:
 | |
|         """
 | |
|         All tests will be logged in as hamlet. Also save various useful values
 | |
|         as attributes that tests can access.
 | |
|         """
 | |
|         super().setUp()
 | |
|         self.user_profile = self.example_user("hamlet")
 | |
|         self.test_email = self.user_profile.email
 | |
|         self.test_user = self.user_profile
 | |
|         self.login_user(self.user_profile)
 | |
|         self.test_realm = self.user_profile.realm
 | |
|         self.streams = self.get_streams(self.user_profile)
 | |
| 
 | |
|     def make_random_stream_names(self, existing_stream_names: List[str]) -> List[str]:
 | |
|         """
 | |
|         Helper function to make up random stream names. It takes
 | |
|         existing_stream_names and randomly appends a digit to the end of each,
 | |
|         but avoids names of streams already in the realm.
 | |
|         """
 | |
|         all_stream_names = [stream.name for stream in Stream.objects.filter(realm=self.test_realm)]
 | |
|         return [
 | |
|             random_stream
 | |
|             for stream in existing_stream_names
 | |
|             if (random_stream := stream + str(random.randint(0, 9))) not in all_stream_names
 | |
|         ]
 | |
| 
 | |
|     def test_invalid_stream_name(self) -> None:
 | |
|         """
 | |
|         Creating a stream with invalid 'Cc' and 'Cn' category of unicode characters in stream name
 | |
|         """
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         # For Cc category
 | |
|         post_data_cc = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new\n\rstream", "description": "this is description"}]
 | |
|             ).decode(),
 | |
|             "invite_only": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.api_post(
 | |
|             user, "/api/v1/users/me/subscriptions", post_data_cc, subdomain="zulip"
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid character in channel name, at position 4.")
 | |
| 
 | |
|         # For Cn category
 | |
|         post_data_cn = {
 | |
|             "subscriptions": orjson.dumps(
 | |
|                 [{"name": "new\ufffestream", "description": "this is description"}]
 | |
|             ).decode(),
 | |
|             "invite_only": orjson.dumps(False).decode(),
 | |
|         }
 | |
|         result = self.api_post(
 | |
|             user, "/api/v1/users/me/subscriptions", post_data_cn, subdomain="zulip"
 | |
|         )
 | |
|         self.assert_json_error(result, "Invalid character in channel name, at position 4.")
 | |
| 
 | |
|     def test_invalid_stream_rename(self) -> None:
 | |
|         """
 | |
|         Renaming a stream with invalid characters.
 | |
|         """
 | |
|         user_profile = self.example_user("hamlet")
 | |
|         self.login_user(user_profile)
 | |
|         stream = self.subscribe(user_profile, "stream_name1")
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         # Check for empty name
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": ""})
 | |
|         self.assert_json_error(result, "Channel name can't be empty.")
 | |
|         # Check for long name
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "a" * 61})
 | |
|         self.assert_json_error(result, "Channel name too long (limit: 60 characters).")
 | |
|         # Check for Cc characters
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "test\n\rname"})
 | |
|         self.assert_json_error(result, "Invalid character in channel name, at position 5.")
 | |
|         # Check for Cn characters
 | |
|         result = self.client_patch(f"/json/streams/{stream.id}", {"new_name": "test\ufffeame"})
 | |
|         self.assert_json_error(result, "Invalid character in channel name, at position 5.")
 | |
| 
 | |
|     def test_successful_subscriptions_list(self) -> None:
 | |
|         """
 | |
|         Calling /api/v1/users/me/subscriptions should successfully return your subscriptions.
 | |
|         """
 | |
|         result = self.api_get(self.test_user, "/api/v1/users/me/subscriptions")
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertIn("subscriptions", json)
 | |
|         for stream in json["subscriptions"]:
 | |
|             self.assertIsInstance(stream["name"], str)
 | |
|             self.assertIsInstance(stream["color"], str)
 | |
|             self.assertIsInstance(stream["invite_only"], bool)
 | |
|             # check that the stream name corresponds to an actual
 | |
|             # stream; will throw Stream.DoesNotExist if it doesn't
 | |
|             get_stream(stream["name"], self.test_realm)
 | |
|         list_streams = [stream["name"] for stream in json["subscriptions"]]
 | |
|         # also check that this matches the list of your subscriptions
 | |
|         self.assertEqual(sorted(list_streams), sorted(self.streams))
 | |
| 
 | |
|     def test_successful_subscriptions_list_subscribers(self) -> None:
 | |
|         """
 | |
|         Calling /api/v1/users/me/subscriptions should successfully return your subscriptions.
 | |
|         """
 | |
|         result = self.api_get(
 | |
|             self.test_user,
 | |
|             "/api/v1/users/me/subscriptions",
 | |
|             {"include_subscribers": "true"},
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertIn("subscriptions", json)
 | |
|         for stream in json["subscriptions"]:
 | |
|             self.assertIsInstance(stream["name"], str)
 | |
|             self.assertIsInstance(stream["color"], str)
 | |
|             self.assertIsInstance(stream["invite_only"], bool)
 | |
|             # check that the stream name corresponds to an actual
 | |
|             # stream; will throw Stream.DoesNotExist if it doesn't
 | |
|             get_stream(stream["name"], self.test_realm)
 | |
|         list_streams = [stream["name"] for stream in json["subscriptions"]]
 | |
|         # also check that this matches the list of your subscriptions
 | |
|         self.assertEqual(sorted(list_streams), sorted(self.streams))
 | |
| 
 | |
|     def helper_check_subs_before_and_after_add(
 | |
|         self,
 | |
|         subscriptions: List[str],
 | |
|         other_params: Dict[str, Any],
 | |
|         subscribed: List[str],
 | |
|         already_subscribed: List[str],
 | |
|         email: str,
 | |
|         new_subs: List[str],
 | |
|         realm: Realm,
 | |
|         invite_only: bool = False,
 | |
|     ) -> None:
 | |
|         """
 | |
|         Check result of adding subscriptions.
 | |
| 
 | |
|         You can add subscriptions for yourself or possibly many
 | |
|         principals, which is why e-mails map to subscriptions in the
 | |
|         result.
 | |
| 
 | |
|         The result json is of the form
 | |
| 
 | |
|         {"msg": "",
 | |
|          "result": "success",
 | |
|          "already_subscribed": {self.example_email("iago"): ["Venice", "Verona"]},
 | |
|          "subscribed": {self.example_email("iago"): ["Venice8"]}}
 | |
|         """
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user, subscriptions, other_params, invite_only=invite_only
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(sorted(subscribed), sorted(json["subscribed"][email]))
 | |
|         self.assertEqual(sorted(already_subscribed), sorted(json["already_subscribed"][email]))
 | |
|         user = get_user(email, realm)
 | |
|         new_streams = self.get_streams(user)
 | |
|         self.assertEqual(sorted(new_streams), sorted(new_subs))
 | |
| 
 | |
|     def test_successful_subscriptions_add(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions should successfully add
 | |
|         streams, and should determine which are new subscriptions vs
 | |
|         which were already subscribed. We add 2 new streams to the
 | |
|         list of subscriptions and confirm the right number of events
 | |
|         are generated.
 | |
|         """
 | |
|         self.assertNotEqual(len(self.streams), 0)  # necessary for full test coverage
 | |
|         add_streams = ["Verona2", "Denmark5"]
 | |
|         self.assertNotEqual(len(add_streams), 0)  # necessary for full test coverage
 | |
|         # Three events should be sent for each stream for stream creation, subscription add and message notifications.
 | |
|         with self.capture_send_event_calls(expected_num_events=6):
 | |
|             self.helper_check_subs_before_and_after_add(
 | |
|                 self.streams + add_streams,
 | |
|                 {},
 | |
|                 add_streams,
 | |
|                 self.streams,
 | |
|                 self.test_email,
 | |
|                 self.streams + add_streams,
 | |
|                 self.test_realm,
 | |
|             )
 | |
| 
 | |
|     def test_successful_subscriptions_add_with_announce(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions should successfully add
 | |
|         streams, and should determine which are new subscriptions vs
 | |
|         which were already subscribed. We add 2 new streams to the
 | |
|         list of subscriptions and confirm the right number of events
 | |
|         are generated.
 | |
|         """
 | |
|         self.assertNotEqual(len(self.streams), 0)
 | |
|         add_streams = ["Verona2", "Denmark5"]
 | |
|         self.assertNotEqual(len(add_streams), 0)
 | |
|         other_params = {
 | |
|             "announce": "true",
 | |
|         }
 | |
|         new_stream_announcements_stream = get_stream(self.streams[0], self.test_realm)
 | |
|         self.test_realm.new_stream_announcements_stream_id = new_stream_announcements_stream.id
 | |
|         self.test_realm.save()
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=7) as events:
 | |
|             self.helper_check_subs_before_and_after_add(
 | |
|                 self.streams + add_streams,
 | |
|                 other_params,
 | |
|                 add_streams,
 | |
|                 self.streams,
 | |
|                 self.test_email,
 | |
|                 self.streams + add_streams,
 | |
|                 self.test_realm,
 | |
|             )
 | |
| 
 | |
|         expected_stream_ids = {get_stream(stream, self.test_realm).id for stream in add_streams}
 | |
| 
 | |
|         (peer_add_event,) = (event for event in events if event["event"].get("op") == "peer_add")
 | |
| 
 | |
|         self.assertEqual(set(peer_add_event["event"]["stream_ids"]), expected_stream_ids)
 | |
|         self.assertEqual(set(peer_add_event["event"]["user_ids"]), {self.test_user.id})
 | |
| 
 | |
|     def test_successful_subscriptions_notifies_pm(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions should notify when a new stream is created.
 | |
|         """
 | |
|         invitee = self.example_user("iago")
 | |
| 
 | |
|         current_stream = self.get_streams(invitee)[0]
 | |
|         invite_streams = self.make_random_stream_names([current_stream])[:1]
 | |
|         self.common_subscribe_to_streams(
 | |
|             invitee,
 | |
|             invite_streams,
 | |
|             extra_post_data={
 | |
|                 "announce": "true",
 | |
|                 "principals": orjson.dumps([self.user_profile.id]).decode(),
 | |
|             },
 | |
|         )
 | |
| 
 | |
|     def test_successful_subscriptions_notifies_stream(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions should notify when a new stream is created.
 | |
|         """
 | |
|         invitee = self.example_user("iago")
 | |
|         invitee_full_name = "Iago"
 | |
| 
 | |
|         current_stream = self.get_streams(invitee)[0]
 | |
|         invite_streams = self.make_random_stream_names([current_stream])[:1]
 | |
| 
 | |
|         new_stream_announcements_stream = get_stream(current_stream, self.test_realm)
 | |
|         self.test_realm.new_stream_announcements_stream_id = new_stream_announcements_stream.id
 | |
|         self.test_realm.save()
 | |
| 
 | |
|         self.common_subscribe_to_streams(
 | |
|             invitee,
 | |
|             invite_streams,
 | |
|             extra_post_data=dict(
 | |
|                 announce="true",
 | |
|                 principals=orjson.dumps([self.user_profile.id]).decode(),
 | |
|             ),
 | |
|         )
 | |
|         target_stream = get_stream(invite_streams[0], self.test_realm)
 | |
| 
 | |
|         msg = self.get_second_to_last_message()
 | |
|         self.assertEqual(msg.recipient.type, Recipient.STREAM)
 | |
|         self.assertEqual(msg.recipient.type_id, new_stream_announcements_stream.id)
 | |
|         self.assertEqual(msg.sender_id, self.notification_bot(self.test_realm).id)
 | |
|         expected_msg = f"@_**{invitee_full_name}|{invitee.id}** created a new channel #**{invite_streams[0]}**."
 | |
|         self.assertEqual(msg.content, expected_msg)
 | |
| 
 | |
|         msg = self.get_last_message()
 | |
|         self.assertEqual(msg.recipient.type, Recipient.STREAM)
 | |
|         self.assertEqual(msg.recipient.type_id, target_stream.id)
 | |
|         self.assertEqual(msg.sender_id, self.notification_bot(self.test_realm).id)
 | |
|         expected_msg = (
 | |
|             f"**Public** channel created by @_**{invitee_full_name}|{invitee.id}**. **Description:**\n"
 | |
|             "```` quote\n*No description.*\n````"
 | |
|         )
 | |
|         self.assertEqual(msg.content, expected_msg)
 | |
| 
 | |
|     def test_successful_cross_realm_notification(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions in a new realm
 | |
|         should notify with a proper new stream link
 | |
|         """
 | |
|         realm = do_create_realm("testrealm", "Test Realm")
 | |
| 
 | |
|         new_stream_announcements_stream = Stream.objects.get(name="general", realm=realm)
 | |
|         realm.new_stream_announcements_stream = new_stream_announcements_stream
 | |
|         realm.save()
 | |
| 
 | |
|         invite_streams = ["cross_stream"]
 | |
| 
 | |
|         user = self.example_user("AARON")
 | |
|         user.realm = realm
 | |
|         user.save()
 | |
| 
 | |
|         self.common_subscribe_to_streams(
 | |
|             user,
 | |
|             invite_streams,
 | |
|             extra_post_data=dict(
 | |
|                 announce="true",
 | |
|             ),
 | |
|             subdomain="testrealm",
 | |
|         )
 | |
| 
 | |
|         msg = self.get_second_to_last_message()
 | |
|         self.assertEqual(msg.recipient.type, Recipient.STREAM)
 | |
|         self.assertEqual(msg.recipient.type_id, new_stream_announcements_stream.id)
 | |
|         self.assertEqual(msg.sender_id, self.notification_bot(realm).id)
 | |
|         stream_id = Stream.objects.latest("id").id
 | |
|         expected_rendered_msg = f'<p><span class="user-mention silent" data-user-id="{user.id}">{user.full_name}</span> created a new channel <a class="stream" data-stream-id="{stream_id}" href="/#narrow/stream/{stream_id}-{invite_streams[0]}">#{invite_streams[0]}</a>.</p>'
 | |
|         self.assertEqual(msg.rendered_content, expected_rendered_msg)
 | |
| 
 | |
|     def test_successful_subscriptions_notifies_with_escaping(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions should notify when a new stream is created.
 | |
|         """
 | |
|         invitee_full_name = "Iago"
 | |
|         invitee = self.example_user("iago")
 | |
| 
 | |
|         current_stream = self.get_streams(invitee)[0]
 | |
|         new_stream_announcements_stream = get_stream(current_stream, self.test_realm)
 | |
|         self.test_realm.new_stream_announcements_stream_id = new_stream_announcements_stream.id
 | |
|         self.test_realm.save()
 | |
| 
 | |
|         invite_streams = ["strange ) \\ test"]
 | |
|         self.common_subscribe_to_streams(
 | |
|             invitee,
 | |
|             invite_streams,
 | |
|             extra_post_data={
 | |
|                 "announce": "true",
 | |
|                 "principals": orjson.dumps([self.user_profile.id]).decode(),
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         msg = self.get_second_to_last_message()
 | |
|         self.assertEqual(
 | |
|             msg.sender_id, self.notification_bot(new_stream_announcements_stream.realm).id
 | |
|         )
 | |
|         expected_msg = f"@_**{invitee_full_name}|{invitee.id}** created a new channel #**{invite_streams[0]}**."
 | |
|         self.assertEqual(msg.content, expected_msg)
 | |
| 
 | |
|     def test_non_ascii_stream_subscription(self) -> None:
 | |
|         """
 | |
|         Subscribing to a stream name with non-ASCII characters succeeds.
 | |
|         """
 | |
|         self.helper_check_subs_before_and_after_add(
 | |
|             [*self.streams, "hümbüǵ"],
 | |
|             {},
 | |
|             ["hümbüǵ"],
 | |
|             self.streams,
 | |
|             self.test_email,
 | |
|             [*self.streams, "hümbüǵ"],
 | |
|             self.test_realm,
 | |
|         )
 | |
| 
 | |
|     def test_subscriptions_add_too_long(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions on a stream whose name is >60
 | |
|         characters should return a JSON error.
 | |
|         """
 | |
|         # character limit is 60 characters
 | |
|         long_stream_name = "a" * 61
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user, [long_stream_name], allow_fail=True
 | |
|         )
 | |
|         self.assert_json_error(result, "Channel name too long (limit: 60 characters).")
 | |
| 
 | |
|     def test_subscriptions_add_stream_with_null(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions on a stream whose name contains
 | |
|         null characters should return a JSON error.
 | |
|         """
 | |
|         stream_name = "abc\000"
 | |
|         result = self.common_subscribe_to_streams(self.test_user, [stream_name], allow_fail=True)
 | |
|         self.assert_json_error(result, "Invalid character in channel name, at position 4.")
 | |
| 
 | |
|     def _test_user_settings_for_creating_streams(
 | |
|         self,
 | |
|         stream_policy: str,
 | |
|         *,
 | |
|         invite_only: bool,
 | |
|         is_web_public: bool,
 | |
|     ) -> None:
 | |
|         user_profile = self.example_user("cordelia")
 | |
|         realm = user_profile.realm
 | |
| 
 | |
|         do_set_realm_property(realm, stream_policy, Realm.POLICY_ADMINS_ONLY, acting_user=None)
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MODERATOR, acting_user=None)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             user_profile,
 | |
|             ["new_stream1"],
 | |
|             invite_only=invite_only,
 | |
|             is_web_public=is_web_public,
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         self.common_subscribe_to_streams(user_profile, ["new_stream1"], invite_only=invite_only)
 | |
| 
 | |
|         do_set_realm_property(realm, stream_policy, Realm.POLICY_MODERATORS_ONLY, acting_user=None)
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
|         # Make sure that we are checking the permission with a full member,
 | |
|         # as full member is the user just below moderator in the role hierarchy.
 | |
|         self.assertFalse(user_profile.is_provisional_member)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             user_profile,
 | |
|             ["new_stream2"],
 | |
|             allow_fail=True,
 | |
|             invite_only=invite_only,
 | |
|             is_web_public=is_web_public,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MODERATOR, acting_user=None)
 | |
|         self.common_subscribe_to_streams(user_profile, ["new_stream2"], invite_only=invite_only)
 | |
| 
 | |
|         do_set_realm_property(realm, stream_policy, Realm.POLICY_MEMBERS_ONLY, acting_user=None)
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_GUEST, acting_user=None)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             user_profile,
 | |
|             ["new_stream3"],
 | |
|             invite_only=invite_only,
 | |
|             is_web_public=is_web_public,
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Not allowed for guest users")
 | |
| 
 | |
|         do_change_user_role(user_profile, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             ["new_stream4"],
 | |
|             invite_only=invite_only,
 | |
|             is_web_public=is_web_public,
 | |
|         )
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm, stream_policy, Realm.POLICY_FULL_MEMBERS_ONLY, acting_user=None
 | |
|         )
 | |
|         do_set_realm_property(realm, "waiting_period_threshold", 100000, acting_user=None)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             user_profile,
 | |
|             ["new_stream5"],
 | |
|             invite_only=invite_only,
 | |
|             is_web_public=is_web_public,
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_set_realm_property(realm, "waiting_period_threshold", 0, acting_user=None)
 | |
|         self.common_subscribe_to_streams(user_profile, ["new_stream3"], invite_only=invite_only)
 | |
| 
 | |
|     def test_user_settings_for_creating_private_streams(self) -> None:
 | |
|         self._test_user_settings_for_creating_streams(
 | |
|             "create_private_stream_policy",
 | |
|             invite_only=True,
 | |
|             is_web_public=False,
 | |
|         )
 | |
| 
 | |
|     def test_user_settings_for_creating_public_streams(self) -> None:
 | |
|         self._test_user_settings_for_creating_streams(
 | |
|             "create_public_stream_policy",
 | |
|             invite_only=False,
 | |
|             is_web_public=False,
 | |
|         )
 | |
| 
 | |
|     def test_user_settings_for_creating_web_public_streams(self) -> None:
 | |
|         self._test_user_settings_for_creating_streams(
 | |
|             "create_web_public_stream_policy", invite_only=False, is_web_public=True
 | |
|         )
 | |
| 
 | |
|     def test_stream_creator_id(self) -> None:
 | |
|         iago = self.example_user("iago")
 | |
|         self.login_user(iago)
 | |
|         user1 = self.example_user("hamlet")
 | |
|         user2 = self.example_user("desdemona")
 | |
| 
 | |
|         streams_to_sub = ["new_stream"]
 | |
|         # We create streams by subscribing users to non-existent streams
 | |
|         # Here we subscribe users other than the stream creator
 | |
|         with self.capture_send_event_calls(5) as events:
 | |
|             self.common_subscribe_to_streams(
 | |
|                 iago,
 | |
|                 streams_to_sub,
 | |
|                 dict(principals=orjson.dumps([user1.id, user2.id]).decode()),
 | |
|             )
 | |
|         self.assertEqual(events[0]["event"]["streams"][0]["creator_id"], iago.id)
 | |
|         created_stream_id = events[0]["event"]["streams"][0]["stream_id"]
 | |
| 
 | |
|         all_streams = self.api_get(iago, "/api/v1/streams")
 | |
|         json = self.assert_json_success(all_streams)
 | |
|         for stream in json["streams"]:
 | |
|             if stream["stream_id"] == created_stream_id:
 | |
|                 # Acting user should be the creator for api created streams
 | |
|                 self.assertEqual(stream["creator_id"], iago.id)
 | |
|                 continue
 | |
| 
 | |
|             # We assign creator to some streams in populate_db.
 | |
|             if stream["name"] == "Venice":
 | |
|                 self.assertEqual(stream["creator_id"], self.example_user("polonius").id)
 | |
|                 continue
 | |
| 
 | |
|             if stream["name"] == "Scotland":
 | |
|                 self.assertEqual(stream["creator_id"], self.example_user("iago").id)
 | |
|                 continue
 | |
| 
 | |
|             if stream["name"] == "core team":
 | |
|                 self.assertEqual(stream["creator_id"], self.example_user("desdemona").id)
 | |
|                 continue
 | |
| 
 | |
|             # Other streams that weren't created using the api should have no creator.
 | |
|             self.assertIsNone(stream["creator_id"])
 | |
| 
 | |
|     def test_private_stream_policies(self) -> None:
 | |
|         def validation_func(user_profile: UserProfile) -> bool:
 | |
|             return user_profile.can_create_private_streams()
 | |
| 
 | |
|         self.check_has_permission_policies("create_private_stream_policy", validation_func)
 | |
| 
 | |
|     def test_public_stream_policies(self) -> None:
 | |
|         def validation_func(user_profile: UserProfile) -> bool:
 | |
|             return user_profile.can_create_public_streams()
 | |
| 
 | |
|         self.check_has_permission_policies("create_public_stream_policy", validation_func)
 | |
| 
 | |
|     def test_web_public_stream_policies(self) -> None:
 | |
|         def validation_func(user_profile: UserProfile) -> bool:
 | |
|             return user_profile.can_create_web_public_streams()
 | |
| 
 | |
|         self.check_has_permission_policies("create_web_public_stream_policy", validation_func)
 | |
| 
 | |
|     def test_user_settings_for_subscribing_other_users(self) -> None:
 | |
|         """
 | |
|         You can't subscribe other people to streams if you are a guest or your account is not old
 | |
|         enough.
 | |
|         """
 | |
|         user_profile = self.example_user("cordelia")
 | |
|         invitee_user_id = user_profile.id
 | |
|         realm = user_profile.realm
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm, "create_public_stream_policy", Realm.POLICY_MEMBERS_ONLY, acting_user=None
 | |
|         )
 | |
|         do_set_realm_property(
 | |
|             realm, "invite_to_stream_policy", Realm.POLICY_ADMINS_ONLY, acting_user=None
 | |
|         )
 | |
|         do_change_user_role(self.test_user, UserProfile.ROLE_MODERATOR, acting_user=None)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             ["stream1"],
 | |
|             {"principals": orjson.dumps([invitee_user_id]).decode()},
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_change_user_role(self.test_user, UserProfile.ROLE_REALM_ADMINISTRATOR, acting_user=None)
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.test_user, ["stream1"], {"principals": orjson.dumps([invitee_user_id]).decode()}
 | |
|         )
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm, "invite_to_stream_policy", Realm.POLICY_MODERATORS_ONLY, acting_user=None
 | |
|         )
 | |
|         do_change_user_role(self.test_user, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
|         # Make sure that we are checking the permission with a full member,
 | |
|         # as full member is the user just below moderator in the role hierarchy.
 | |
|         self.assertFalse(self.test_user.is_provisional_member)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             ["stream2"],
 | |
|             {"principals": orjson.dumps([invitee_user_id]).decode()},
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_change_user_role(self.test_user, UserProfile.ROLE_MODERATOR, acting_user=None)
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.test_user, ["stream2"], {"principals": orjson.dumps([invitee_user_id]).decode()}
 | |
|         )
 | |
|         self.unsubscribe(user_profile, "stream2")
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm, "invite_to_stream_policy", Realm.POLICY_MEMBERS_ONLY, acting_user=None
 | |
|         )
 | |
|         do_change_user_role(self.test_user, UserProfile.ROLE_GUEST, acting_user=None)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             ["stream2"],
 | |
|             {"principals": orjson.dumps([invitee_user_id]).decode()},
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Not allowed for guest users")
 | |
| 
 | |
|         do_change_user_role(self.test_user, UserProfile.ROLE_MEMBER, acting_user=None)
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             ["stream2"],
 | |
|             {"principals": orjson.dumps([self.test_user.id, invitee_user_id]).decode()},
 | |
|         )
 | |
|         self.unsubscribe(user_profile, "stream2")
 | |
| 
 | |
|         do_set_realm_property(
 | |
|             realm,
 | |
|             "invite_to_stream_policy",
 | |
|             Realm.POLICY_FULL_MEMBERS_ONLY,
 | |
|             acting_user=None,
 | |
|         )
 | |
|         do_set_realm_property(realm, "waiting_period_threshold", 100000, acting_user=None)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             ["stream2"],
 | |
|             {"principals": orjson.dumps([invitee_user_id]).decode()},
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "Insufficient permission")
 | |
| 
 | |
|         do_set_realm_property(realm, "waiting_period_threshold", 0, acting_user=None)
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.test_user, ["stream2"], {"principals": orjson.dumps([invitee_user_id]).decode()}
 | |
|         )
 | |
| 
 | |
|     def test_can_subscribe_other_users(self) -> None:
 | |
|         """
 | |
|         You can't subscribe other people to streams if you are a guest or your account is not old
 | |
|         enough.
 | |
|         """
 | |
| 
 | |
|         def validation_func(user_profile: UserProfile) -> bool:
 | |
|             return user_profile.can_subscribe_other_users()
 | |
| 
 | |
|         self.check_has_permission_policies("invite_to_stream_policy", validation_func)
 | |
| 
 | |
|     def test_subscriptions_add_invalid_stream(self) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions on a stream whose name is invalid (as
 | |
|         defined by valid_stream_name in zerver/views.py) should return a JSON
 | |
|         error.
 | |
|         """
 | |
|         # currently, the only invalid name is the empty string
 | |
|         invalid_stream_name = ""
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user, [invalid_stream_name], allow_fail=True
 | |
|         )
 | |
|         self.assert_json_error(result, "Channel name can't be empty.")
 | |
| 
 | |
|     def assert_adding_subscriptions_for_principal(
 | |
|         self,
 | |
|         invitee_data: Union[str, int],
 | |
|         invitee_realm: Realm,
 | |
|         streams: List[str],
 | |
|         policy_name: str,
 | |
|         invite_only: bool = False,
 | |
|     ) -> None:
 | |
|         """
 | |
|         Calling POST /json/users/me/subscriptions on behalf of another principal (for
 | |
|         whom you have permission to add subscriptions) should successfully add
 | |
|         those subscriptions and send a message to the subscribee notifying
 | |
|         them.
 | |
|         """
 | |
|         if isinstance(invitee_data, str):
 | |
|             other_profile = get_user(invitee_data, invitee_realm)
 | |
|         else:
 | |
|             other_profile = get_user_profile_by_id_in_realm(invitee_data, invitee_realm)
 | |
|         current_streams = self.get_streams(other_profile)
 | |
|         self.assertIsInstance(other_profile, UserProfile)
 | |
|         self.assertNotEqual(len(current_streams), 0)  # necessary for full test coverage
 | |
|         self.assertNotEqual(len(streams), 0)  # necessary for full test coverage
 | |
|         streams_to_sub = streams[:1]  # just add one, to make the message easier to check
 | |
|         streams_to_sub.extend(current_streams)
 | |
|         self.helper_check_subs_before_and_after_add(
 | |
|             streams_to_sub,
 | |
|             {"principals": orjson.dumps([invitee_data]).decode()},
 | |
|             streams[:1],
 | |
|             current_streams,
 | |
|             other_profile.email,
 | |
|             streams_to_sub,
 | |
|             invitee_realm,
 | |
|             invite_only=invite_only,
 | |
|         )
 | |
| 
 | |
|         # verify that a welcome message was sent to the stream
 | |
|         msg = self.get_last_message()
 | |
|         self.assertEqual(msg.recipient.type, msg.recipient.STREAM)
 | |
|         self.assertEqual(msg.topic_name(), "channel events")
 | |
|         self.assertEqual(msg.sender.email, settings.NOTIFICATION_BOT)
 | |
|         self.assertIn(
 | |
|             f"**{policy_name}** channel created by @_**{self.test_user.full_name}|{self.test_user.id}**. **Description:**\n"
 | |
|             "```` quote",
 | |
|             msg.content,
 | |
|         )
 | |
| 
 | |
|     def test_multi_user_subscription(self) -> None:
 | |
|         user1 = self.example_user("cordelia")
 | |
|         user2 = self.example_user("iago")
 | |
|         realm = get_realm("zulip")
 | |
|         streams_to_sub = ["multi_user_stream"]
 | |
|         with self.capture_send_event_calls(expected_num_events=5) as events:
 | |
|             with self.assert_database_query_count(36):
 | |
|                 self.common_subscribe_to_streams(
 | |
|                     self.test_user,
 | |
|                     streams_to_sub,
 | |
|                     dict(principals=orjson.dumps([user1.id, user2.id]).decode()),
 | |
|                 )
 | |
| 
 | |
|         for ev in [x for x in events if x["event"]["type"] not in ("message", "stream")]:
 | |
|             if ev["event"]["op"] == "add":
 | |
|                 self.assertEqual(
 | |
|                     set(ev["event"]["subscriptions"][0]["subscribers"]),
 | |
|                     {user1.id, user2.id},
 | |
|                 )
 | |
|             else:
 | |
|                 # Check "peer_add" events for streams users were
 | |
|                 # never subscribed to, in order for the neversubscribed
 | |
|                 # structure to stay up-to-date.
 | |
|                 self.assertEqual(ev["event"]["op"], "peer_add")
 | |
| 
 | |
|         stream = get_stream("multi_user_stream", realm)
 | |
|         self.assertEqual(num_subscribers_for_stream_id(stream.id), 2)
 | |
| 
 | |
|         # Now add ourselves
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             with self.assert_database_query_count(14):
 | |
|                 self.common_subscribe_to_streams(
 | |
|                     self.test_user,
 | |
|                     streams_to_sub,
 | |
|                     dict(principals=orjson.dumps([self.test_user.id]).decode()),
 | |
|                 )
 | |
| 
 | |
|         add_event, add_peer_event = events
 | |
|         self.assertEqual(add_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_event["event"]["op"], "add")
 | |
|         self.assertEqual(add_event["users"], [get_user(self.test_email, self.test_realm).id])
 | |
|         self.assertEqual(
 | |
|             set(add_event["event"]["subscriptions"][0]["subscribers"]),
 | |
|             {user1.id, user2.id, self.test_user.id},
 | |
|         )
 | |
| 
 | |
|         self.assertNotIn(self.example_user("polonius").id, add_peer_event["users"])
 | |
|         self.assert_length(add_peer_event["users"], 11)
 | |
|         self.assertEqual(add_peer_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_peer_event["event"]["op"], "peer_add")
 | |
|         self.assertEqual(add_peer_event["event"]["user_ids"], [self.user_profile.id])
 | |
| 
 | |
|         stream = get_stream("multi_user_stream", realm)
 | |
|         self.assertEqual(num_subscribers_for_stream_id(stream.id), 3)
 | |
| 
 | |
|         # Finally, add othello.
 | |
|         events = []
 | |
|         user_profile = self.example_user("othello")
 | |
|         email3 = user_profile.email
 | |
|         user3 = user_profile
 | |
|         realm3 = user_profile.realm
 | |
|         stream = get_stream("multi_user_stream", realm)
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             bulk_add_subscriptions(realm, [stream], [user_profile], acting_user=None)
 | |
| 
 | |
|         add_event, add_peer_event = events
 | |
| 
 | |
|         self.assertEqual(add_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_event["event"]["op"], "add")
 | |
|         self.assertEqual(add_event["users"], [get_user(email3, realm3).id])
 | |
|         self.assertEqual(
 | |
|             set(add_event["event"]["subscriptions"][0]["subscribers"]),
 | |
|             {user1.id, user2.id, user3.id, self.test_user.id},
 | |
|         )
 | |
| 
 | |
|         # We don't send a peer_add event to othello
 | |
|         self.assertNotIn(user_profile.id, add_peer_event["users"])
 | |
|         self.assertNotIn(self.example_user("polonius").id, add_peer_event["users"])
 | |
|         self.assert_length(add_peer_event["users"], 11)
 | |
|         self.assertEqual(add_peer_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_peer_event["event"]["op"], "peer_add")
 | |
|         self.assertEqual(add_peer_event["event"]["user_ids"], [user_profile.id])
 | |
| 
 | |
|     def test_private_stream_subscription(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
| 
 | |
|         # Create a private stream with Hamlet subscribed
 | |
|         stream_name = "private"
 | |
|         stream = ensure_stream(realm, stream_name, invite_only=True, acting_user=None)
 | |
| 
 | |
|         existing_user_profile = self.example_user("hamlet")
 | |
|         bulk_add_subscriptions(realm, [stream], [existing_user_profile], acting_user=None)
 | |
| 
 | |
|         # Now subscribe Cordelia to the stream, capturing events
 | |
|         user_profile = self.example_user("cordelia")
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=3) as events:
 | |
|             bulk_add_subscriptions(realm, [stream], [user_profile], acting_user=None)
 | |
| 
 | |
|         create_event, add_event, add_peer_event = events
 | |
| 
 | |
|         self.assertEqual(create_event["event"]["type"], "stream")
 | |
|         self.assertEqual(create_event["event"]["op"], "create")
 | |
|         self.assertEqual(create_event["users"], [user_profile.id])
 | |
|         self.assertEqual(create_event["event"]["streams"][0]["name"], stream_name)
 | |
| 
 | |
|         self.assertEqual(add_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_event["event"]["op"], "add")
 | |
|         self.assertEqual(add_event["users"], [user_profile.id])
 | |
|         self.assertEqual(
 | |
|             set(add_event["event"]["subscriptions"][0]["subscribers"]),
 | |
|             {user_profile.id, existing_user_profile.id},
 | |
|         )
 | |
| 
 | |
|         # We don't send a peer_add event to othello, but we do send peer_add event to
 | |
|         # all realm admins.
 | |
|         self.assertNotIn(user_profile.id, add_peer_event["users"])
 | |
|         self.assert_length(add_peer_event["users"], 3)
 | |
|         self.assertEqual(add_peer_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_peer_event["event"]["op"], "peer_add")
 | |
|         self.assertEqual(add_peer_event["event"]["user_ids"], [user_profile.id])
 | |
| 
 | |
|         # Do not send stream creation event to realm admin users
 | |
|         # even if realm admin is subscribed to stream cause realm admin already get
 | |
|         # private stream creation event on stream creation.
 | |
|         new_stream = ensure_stream(realm, "private stream", invite_only=True, acting_user=None)
 | |
|         with self.capture_send_event_calls(expected_num_events=2) as events:
 | |
|             bulk_add_subscriptions(
 | |
|                 realm, [new_stream], [self.example_user("iago")], acting_user=None
 | |
|             )
 | |
| 
 | |
|         # Note that since iago is an admin, he won't get a stream/create
 | |
|         # event here.
 | |
|         self.assert_length(events, 2)
 | |
|         add_event, add_peer_event = events
 | |
| 
 | |
|         self.assertEqual(add_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_event["event"]["op"], "add")
 | |
|         self.assertEqual(add_event["users"], [self.example_user("iago").id])
 | |
| 
 | |
|         self.assert_length(add_peer_event["users"], 1)
 | |
|         self.assertEqual(add_peer_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_peer_event["event"]["op"], "peer_add")
 | |
|         self.assertEqual(add_peer_event["event"]["user_ids"], [self.example_user("iago").id])
 | |
| 
 | |
|     def test_subscribe_to_stream_post_policy_admins_stream(self) -> None:
 | |
|         """
 | |
|         Members can subscribe to streams where only admins can post
 | |
|         """
 | |
|         member = self.example_user("AARON")
 | |
|         stream = self.make_stream("stream1")
 | |
|         do_change_stream_post_policy(stream, Stream.STREAM_POST_POLICY_ADMINS, acting_user=member)
 | |
|         result = self.common_subscribe_to_streams(member, ["stream1"])
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["subscribed"], {member.email: ["stream1"]})
 | |
|         self.assertEqual(json["already_subscribed"], {})
 | |
| 
 | |
|     def test_subscribe_to_stream_post_policy_restrict_new_members_stream(self) -> None:
 | |
|         """
 | |
|         New members can subscribe to streams where they cannot post
 | |
|         """
 | |
|         new_member_email = self.nonreg_email("test")
 | |
|         self.register(new_member_email, "test")
 | |
|         new_member = self.nonreg_user("test")
 | |
| 
 | |
|         do_set_realm_property(new_member.realm, "waiting_period_threshold", 10, acting_user=None)
 | |
|         self.assertTrue(new_member.is_provisional_member)
 | |
| 
 | |
|         stream = self.make_stream("stream1")
 | |
|         do_change_stream_post_policy(
 | |
|             stream, Stream.STREAM_POST_POLICY_RESTRICT_NEW_MEMBERS, acting_user=new_member
 | |
|         )
 | |
|         result = self.common_subscribe_to_streams(new_member, ["stream1"])
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["subscribed"], {new_member.email: ["stream1"]})
 | |
|         self.assertEqual(json["already_subscribed"], {})
 | |
| 
 | |
|     def test_subscribe_to_stream_post_policy_moderators_stream(self) -> None:
 | |
|         """
 | |
|         Members can subscribe to streams where only admins and moderators can post
 | |
|         """
 | |
|         member = self.example_user("AARON")
 | |
|         stream = self.make_stream("stream1")
 | |
|         # Make sure that we are testing this with full member which is just below the moderator
 | |
|         # in the role hierarchy.
 | |
|         self.assertFalse(member.is_provisional_member)
 | |
|         do_change_stream_post_policy(
 | |
|             stream, Stream.STREAM_POST_POLICY_MODERATORS, acting_user=member
 | |
|         )
 | |
|         result = self.common_subscribe_to_streams(member, ["stream1"])
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["subscribed"], {member.email: ["stream1"]})
 | |
|         self.assertEqual(json["already_subscribed"], {})
 | |
| 
 | |
|     def test_guest_user_subscribe(self) -> None:
 | |
|         """Guest users cannot subscribe themselves to anything"""
 | |
|         guest_user = self.example_user("polonius")
 | |
|         result = self.common_subscribe_to_streams(guest_user, ["Denmark"], allow_fail=True)
 | |
|         self.assert_json_error(result, "Not allowed for guest users")
 | |
| 
 | |
|         # Verify the internal checks also block guest users.
 | |
|         stream = get_stream("Denmark", guest_user.realm)
 | |
|         self.assertEqual(filter_stream_authorization(guest_user, [stream]), ([], [stream]))
 | |
| 
 | |
|         stream = self.make_stream("private_stream", invite_only=True)
 | |
|         result = self.common_subscribe_to_streams(guest_user, ["private_stream"], allow_fail=True)
 | |
|         self.assert_json_error(result, "Not allowed for guest users")
 | |
|         self.assertEqual(filter_stream_authorization(guest_user, [stream]), ([], [stream]))
 | |
| 
 | |
|         web_public_stream = self.make_stream("web_public_stream", is_web_public=True)
 | |
|         public_stream = self.make_stream("public_stream", invite_only=False)
 | |
|         private_stream = self.make_stream("private_stream2", invite_only=True)
 | |
|         # This test should be added as soon as the subscription endpoint allows
 | |
|         # guest users to subscribe to web-public streams. Although they are already
 | |
|         # authorized, the decorator in "add_subscriptions_backend" still needs to be
 | |
|         # deleted.
 | |
|         #
 | |
|         # result = self.common_subscribe_to_streams(guest_user, ['web_public_stream'],
 | |
|         #                                           is_web_public=True, allow_fail=True)
 | |
|         # self.assert_json_success(result)
 | |
|         streams_to_sub = [web_public_stream, public_stream, private_stream]
 | |
|         self.assertEqual(
 | |
|             filter_stream_authorization(guest_user, streams_to_sub),
 | |
|             ([web_public_stream], [public_stream, private_stream]),
 | |
|         )
 | |
| 
 | |
|         # Guest can be subscribed by other users.
 | |
|         normal_user = self.example_user("aaron")
 | |
|         with self.capture_send_event_calls(expected_num_events=6) as events:
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.example_user("hamlet"),
 | |
|                 ["Denmark"],
 | |
|                 dict(principals=orjson.dumps([guest_user.id, normal_user.id]).decode()),
 | |
|             )
 | |
| 
 | |
|         # Verify that stream creation event is sent to guest user only.
 | |
|         stream_create_events = [
 | |
|             event
 | |
|             for event in events
 | |
|             if event["event"]["type"] == "stream" and event["event"]["op"] == "create"
 | |
|         ]
 | |
|         self.assert_length(stream_create_events, 1)
 | |
|         self.assertEqual(stream_create_events[0]["users"], [guest_user.id])
 | |
| 
 | |
|         # Verify that subscription add event is sent to both the users.
 | |
|         subscription_add_events = [
 | |
|             event
 | |
|             for event in events
 | |
|             if event["event"]["type"] == "subscription" and event["event"]["op"] == "add"
 | |
|         ]
 | |
|         self.assert_length(subscription_add_events, 2)
 | |
|         self.assertEqual(subscription_add_events[0]["users"], [guest_user.id])
 | |
|         self.assertEqual(subscription_add_events[1]["users"], [normal_user.id])
 | |
| 
 | |
|     def test_users_getting_add_peer_event(self) -> None:
 | |
|         """
 | |
|         Check users getting add_peer_event is correct
 | |
|         """
 | |
|         streams_to_sub = ["multi_user_stream"]
 | |
|         othello = self.example_user("othello")
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         iago = self.example_user("iago")
 | |
|         orig_user_ids_to_subscribe = [self.test_user.id, othello.id]
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             streams_to_sub,
 | |
|             dict(principals=orjson.dumps(orig_user_ids_to_subscribe).decode()),
 | |
|         )
 | |
| 
 | |
|         new_user_ids_to_subscribe = [iago.id, cordelia.id]
 | |
|         with self.capture_send_event_calls(expected_num_events=5) as events:
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.test_user,
 | |
|                 streams_to_sub,
 | |
|                 dict(principals=orjson.dumps(new_user_ids_to_subscribe).decode()),
 | |
|             )
 | |
| 
 | |
|         add_peer_events = [event for event in events if event["event"].get("op") == "peer_add"]
 | |
|         (add_peer_event,) = add_peer_events
 | |
| 
 | |
|         self.assertEqual(add_peer_event["event"]["type"], "subscription")
 | |
|         self.assertEqual(add_peer_event["event"]["op"], "peer_add")
 | |
|         event_sent_to_ids = add_peer_event["users"]
 | |
|         for user_id in new_user_ids_to_subscribe:
 | |
|             # Make sure new users subscribed to stream is not in
 | |
|             # peer_add event recipient list
 | |
|             self.assertNotIn(user_id, event_sent_to_ids)
 | |
|         for old_user in orig_user_ids_to_subscribe:
 | |
|             # Check non-new users are in peer_add event recipient list.
 | |
|             self.assertIn(old_user, event_sent_to_ids)
 | |
| 
 | |
|     def test_users_getting_remove_peer_event(self) -> None:
 | |
|         """
 | |
|         Check users getting add_peer_event is correct
 | |
|         """
 | |
|         user1 = self.example_user("othello")
 | |
|         user2 = self.example_user("cordelia")
 | |
|         user3 = self.example_user("hamlet")
 | |
|         user4 = self.example_user("iago")
 | |
|         user5 = self.example_user("AARON")
 | |
|         guest = self.example_user("polonius")
 | |
| 
 | |
|         realm = user1.realm
 | |
| 
 | |
|         stream1 = self.make_stream("stream1")
 | |
|         stream2 = self.make_stream("stream2")
 | |
|         stream3 = self.make_stream("stream3")
 | |
|         private = self.make_stream("private_stream", invite_only=True)
 | |
| 
 | |
|         self.subscribe(user1, "stream1")
 | |
|         self.subscribe(user2, "stream1")
 | |
|         self.subscribe(user3, "stream1")
 | |
| 
 | |
|         self.subscribe(user2, "stream2")
 | |
|         self.subscribe(user2, "stream3")
 | |
| 
 | |
|         self.subscribe(user1, "private_stream")
 | |
|         self.subscribe(user2, "private_stream")
 | |
|         self.subscribe(user3, "private_stream")
 | |
| 
 | |
|         # Sends 3 peer-remove events, 2 unsubscribe events
 | |
|         # and 2 stream delete events for private streams.
 | |
|         with self.assert_database_query_count(16):
 | |
|             with self.assert_memcached_count(3):
 | |
|                 with self.capture_send_event_calls(expected_num_events=7) as events:
 | |
|                     bulk_remove_subscriptions(
 | |
|                         realm,
 | |
|                         [user1, user2],
 | |
|                         [stream1, stream2, stream3, private],
 | |
|                         acting_user=None,
 | |
|                     )
 | |
| 
 | |
|         peer_events = [e for e in events if e["event"].get("op") == "peer_remove"]
 | |
|         stream_delete_events = [
 | |
|             e
 | |
|             for e in events
 | |
|             if e["event"].get("type") == "stream" and e["event"].get("op") == "delete"
 | |
|         ]
 | |
| 
 | |
|         # We only care about a subset of users when we inspect
 | |
|         # peer_remove events.
 | |
|         our_user_ids = {
 | |
|             user1.id,
 | |
|             user2.id,
 | |
|             user3.id,
 | |
|             user4.id,
 | |
|             user5.id,
 | |
|             guest.id,
 | |
|         }
 | |
| 
 | |
|         notifications = []
 | |
|         for event in peer_events:
 | |
|             stream_ids = event["event"]["stream_ids"]
 | |
|             stream_names = sorted(Stream.objects.get(id=stream_id).name for stream_id in stream_ids)
 | |
|             removed_user_ids = set(event["event"]["user_ids"])
 | |
|             notified_user_ids = set(event["users"]) & our_user_ids
 | |
|             notifications.append((",".join(stream_names), removed_user_ids, notified_user_ids))
 | |
| 
 | |
|         notifications.sort(key=lambda tup: tup[0])
 | |
| 
 | |
|         self.assertEqual(
 | |
|             notifications,
 | |
|             [
 | |
|                 ("private_stream", {user1.id, user2.id}, {user3.id, user4.id}),
 | |
|                 ("stream1", {user1.id, user2.id}, {user3.id, user4.id, user5.id}),
 | |
|                 ("stream2,stream3", {user2.id}, {user1.id, user3.id, user4.id, user5.id}),
 | |
|             ],
 | |
|         )
 | |
| 
 | |
|         self.assert_length(stream_delete_events, 2)
 | |
|         self.assertEqual(stream_delete_events[0]["users"], [user1.id])
 | |
|         self.assertEqual(stream_delete_events[1]["users"], [user2.id])
 | |
|         for event in stream_delete_events:
 | |
|             event_streams = event["event"]["streams"]
 | |
|             self.assert_length(event_streams, 1)
 | |
|             self.assertEqual(event_streams[0]["name"], "private_stream")
 | |
| 
 | |
|     def test_bulk_subscribe_MIT(self) -> None:
 | |
|         mit_user = self.mit_user("starnine")
 | |
|         num_streams = 15
 | |
| 
 | |
|         realm = get_realm("zephyr")
 | |
|         stream_names = [f"stream_{i}" for i in range(num_streams)]
 | |
|         streams = [self.make_stream(stream_name, realm=realm) for stream_name in stream_names]
 | |
| 
 | |
|         for stream in streams:
 | |
|             stream.is_in_zephyr_realm = True
 | |
|             stream.save()
 | |
| 
 | |
|         # Verify that peer_event events are never sent in Zephyr
 | |
|         # realm. This does generate stream creation events from
 | |
|         # send_stream_creation_events_for_previously_inaccessible_streams.
 | |
|         with self.assert_database_query_count(num_streams + 11):
 | |
|             with self.capture_send_event_calls(expected_num_events=num_streams + 1) as events:
 | |
|                 self.common_subscribe_to_streams(
 | |
|                     mit_user,
 | |
|                     stream_names,
 | |
|                     dict(principals=orjson.dumps([mit_user.id]).decode()),
 | |
|                     subdomain="zephyr",
 | |
|                 )
 | |
|             # num_streams stream creation events:
 | |
|             self.assertEqual(
 | |
|                 {(event["event"]["type"], event["event"]["op"]) for event in events[0:num_streams]},
 | |
|                 {("stream", "create")},
 | |
|             )
 | |
|             # Followed by one subscription event:
 | |
|             self.assertEqual(events[num_streams]["event"]["type"], "subscription")
 | |
| 
 | |
|         with self.capture_send_event_calls(expected_num_events=2):
 | |
|             bulk_remove_subscriptions(
 | |
|                 realm,
 | |
|                 users=[mit_user],
 | |
|                 streams=streams,
 | |
|                 acting_user=None,
 | |
|             )
 | |
| 
 | |
|     def test_subscribe_others_to_public_stream_in_zephyr_realm(self) -> None:
 | |
|         """
 | |
|         Users cannot be subscribed to public streams by other users in zephyr realm.
 | |
|         """
 | |
|         starnine = self.mit_user("starnine")
 | |
|         espuser = self.mit_user("espuser")
 | |
| 
 | |
|         realm = get_realm("zephyr")
 | |
|         stream = self.make_stream("stream_1", realm=realm)
 | |
|         stream.is_in_zephyr_realm = True
 | |
|         stream.save()
 | |
| 
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             starnine,
 | |
|             ["stream_1"],
 | |
|             dict(principals=orjson.dumps([starnine.id, espuser.id]).decode()),
 | |
|             subdomain="zephyr",
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(
 | |
|             result,
 | |
|             "You can only invite other Zephyr mirroring users to private channels.",
 | |
|             status_code=400,
 | |
|         )
 | |
| 
 | |
|     def test_bulk_subscribe_many(self) -> None:
 | |
|         # Create a whole bunch of streams
 | |
|         streams = [f"stream_{i}" for i in range(30)]
 | |
|         for stream_name in streams:
 | |
|             self.make_stream(stream_name)
 | |
| 
 | |
|         desdemona = self.example_user("desdemona")
 | |
| 
 | |
|         test_users = [
 | |
|             desdemona,
 | |
|             self.example_user("cordelia"),
 | |
|             self.example_user("hamlet"),
 | |
|             self.example_user("othello"),
 | |
|             self.example_user("iago"),
 | |
|             self.example_user("prospero"),
 | |
|         ]
 | |
| 
 | |
|         # Subscribe out test users to some streams, including
 | |
|         # some that we may soon subscribe them to.
 | |
|         for stream_name in ["Verona", "Denmark", *streams[:10]]:
 | |
|             for user in test_users:
 | |
|                 self.subscribe(user, stream_name)
 | |
| 
 | |
|         # Now unsubscribe users from the first few streams,
 | |
|         # so they have to reactivate.
 | |
|         for stream_name in streams[:5]:
 | |
|             for user in test_users:
 | |
|                 self.unsubscribe(user, stream_name)
 | |
| 
 | |
|         test_user_ids = [user.id for user in test_users]
 | |
| 
 | |
|         # The only known O(N) behavior here is that we call
 | |
|         # principal_to_user_profile for each of our users, but it
 | |
|         # should be cached.
 | |
|         with self.assert_database_query_count(21):
 | |
|             with self.assert_memcached_count(3):
 | |
|                 with mock.patch("zerver.views.streams.send_messages_for_new_subscribers"):
 | |
|                     self.common_subscribe_to_streams(
 | |
|                         desdemona,
 | |
|                         streams,
 | |
|                         dict(principals=orjson.dumps(test_user_ids).decode()),
 | |
|                     )
 | |
| 
 | |
|     def test_subscriptions_add_for_principal(self) -> None:
 | |
|         """
 | |
|         You can subscribe other people to streams.
 | |
|         """
 | |
|         invitee = self.example_user("iago")
 | |
|         current_streams = self.get_streams(invitee)
 | |
|         invite_streams = self.make_random_stream_names(current_streams)
 | |
|         self.assert_adding_subscriptions_for_principal(
 | |
|             invitee.id, invitee.realm, invite_streams, policy_name="Public"
 | |
|         )
 | |
| 
 | |
|     def test_subscriptions_add_for_principal_legacy_emails(self) -> None:
 | |
|         invitee = self.example_user("iago")
 | |
|         current_streams = self.get_streams(invitee)
 | |
|         invite_streams = self.make_random_stream_names(current_streams)
 | |
|         self.assert_adding_subscriptions_for_principal(
 | |
|             invitee.email, invitee.realm, invite_streams, policy_name="Public"
 | |
|         )
 | |
| 
 | |
|     def test_subscriptions_add_for_principal_deactivated(self) -> None:
 | |
|         """
 | |
|         You can't subscribe deactivated people to streams.
 | |
|         """
 | |
|         target_profile = self.example_user("cordelia")
 | |
|         post_data = dict(
 | |
|             principals=orjson.dumps([target_profile.id]).decode(),
 | |
|         )
 | |
|         self.common_subscribe_to_streams(self.test_user, "Verona", post_data)
 | |
| 
 | |
|         do_deactivate_user(target_profile, acting_user=None)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user, "Denmark", post_data, allow_fail=True
 | |
|         )
 | |
|         self.assert_json_error(result, "User is deactivated", status_code=400)
 | |
| 
 | |
|     def test_subscriptions_add_for_principal_invite_only(self) -> None:
 | |
|         """
 | |
|         You can subscribe other people to invite only streams.
 | |
|         """
 | |
|         invitee = self.example_user("iago")
 | |
|         current_streams = self.get_streams(invitee)
 | |
|         invite_streams = self.make_random_stream_names(current_streams)
 | |
|         self.assert_adding_subscriptions_for_principal(
 | |
|             invitee.id,
 | |
|             invitee.realm,
 | |
|             invite_streams,
 | |
|             invite_only=True,
 | |
|             policy_name="Private, protected history",
 | |
|         )
 | |
| 
 | |
|     def test_non_ascii_subscription_for_principal(self) -> None:
 | |
|         """
 | |
|         You can subscribe other people to streams even if they containing
 | |
|         non-ASCII characters.
 | |
|         """
 | |
|         iago = self.example_user("iago")
 | |
|         self.assert_adding_subscriptions_for_principal(
 | |
|             iago.id, get_realm("zulip"), ["hümbüǵ"], policy_name="Public"
 | |
|         )
 | |
| 
 | |
|     def test_subscription_add_invalid_principal_legacy_emails(self) -> None:
 | |
|         """
 | |
|         Calling subscribe on behalf of a principal that does not exist
 | |
|         should return a JSON error.
 | |
|         """
 | |
|         invalid_principal = "rosencrantz-and-guildenstern@zulip.com"
 | |
|         invalid_principal_realm = get_realm("zulip")
 | |
|         # verify that invalid_principal actually doesn't exist
 | |
|         with self.assertRaises(UserProfile.DoesNotExist):
 | |
|             get_user(invalid_principal, invalid_principal_realm)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             self.streams,
 | |
|             {"principals": orjson.dumps([invalid_principal]).decode()},
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "No such user", status_code=400)
 | |
| 
 | |
|     def test_subscription_add_invalid_principal(self) -> None:
 | |
|         invalid_principal = 999
 | |
|         invalid_principal_realm = get_realm("zulip")
 | |
|         with self.assertRaises(UserProfile.DoesNotExist):
 | |
|             get_user_profile_by_id_in_realm(invalid_principal, invalid_principal_realm)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             self.streams,
 | |
|             {"principals": orjson.dumps([invalid_principal]).decode()},
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "No such user", status_code=400)
 | |
| 
 | |
|     def test_subscription_add_principal_other_realm(self) -> None:
 | |
|         """
 | |
|         Calling subscribe on behalf of a principal in another realm
 | |
|         should return a JSON error.
 | |
|         """
 | |
|         profile = self.mit_user("starnine")
 | |
|         principal = profile.id
 | |
|         # verify that principal exists (thus, the reason for the error is the cross-realming)
 | |
|         self.assertIsInstance(profile, UserProfile)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             self.test_user,
 | |
|             self.streams,
 | |
|             {"principals": orjson.dumps([principal]).decode()},
 | |
|             allow_fail=True,
 | |
|         )
 | |
|         self.assert_json_error(result, "No such user", status_code=400)
 | |
| 
 | |
|     def helper_check_subs_before_and_after_remove(
 | |
|         self,
 | |
|         subscriptions: List[str],
 | |
|         json_dict: Dict[str, Any],
 | |
|         email: str,
 | |
|         new_subs: List[str],
 | |
|         realm: Realm,
 | |
|     ) -> None:
 | |
|         """
 | |
|         Check result of removing subscriptions.
 | |
| 
 | |
|         Unlike adding subscriptions, you can only remove subscriptions
 | |
|         for yourself, so the result format is different.
 | |
| 
 | |
|         {"msg": "",
 | |
|          "removed": ["Denmark", "Scotland", "Verona"],
 | |
|          "not_removed": ["Rome"], "result": "success"}
 | |
|         """
 | |
|         result = self.client_delete(
 | |
|             "/json/users/me/subscriptions", {"subscriptions": orjson.dumps(subscriptions).decode()}
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         for key, val in json_dict.items():
 | |
|             # we don't care about the order of the items
 | |
|             self.assertEqual(sorted(val), sorted(json[key]))
 | |
|         user = get_user(email, realm)
 | |
|         new_streams = self.get_streams(user)
 | |
|         self.assertEqual(sorted(new_streams), sorted(new_subs))
 | |
| 
 | |
|     def test_successful_subscriptions_remove(self) -> None:
 | |
|         """
 | |
|         Calling DELETE /json/users/me/subscriptions should successfully remove streams,
 | |
|         and should determine which were removed vs which weren't subscribed to.
 | |
|         We cannot randomly generate stream names because the remove code
 | |
|         verifies whether streams exist.
 | |
|         """
 | |
|         self.assertGreaterEqual(len(self.streams), 2)
 | |
|         streams_to_remove = self.streams[1:]
 | |
|         not_subbed = [
 | |
|             stream.name
 | |
|             for stream in Stream.objects.filter(realm=get_realm("zulip"))
 | |
|             if stream.name not in self.streams
 | |
|         ]
 | |
|         random.shuffle(not_subbed)
 | |
|         self.assertNotEqual(len(not_subbed), 0)  # necessary for full test coverage
 | |
|         try_to_remove = not_subbed[:3]  # attempt to remove up to 3 streams not already subbed to
 | |
|         streams_to_remove.extend(try_to_remove)
 | |
|         self.helper_check_subs_before_and_after_remove(
 | |
|             streams_to_remove,
 | |
|             {"removed": self.streams[1:], "not_removed": try_to_remove},
 | |
|             self.test_email,
 | |
|             [self.streams[0]],
 | |
|             self.test_realm,
 | |
|         )
 | |
| 
 | |
|     def test_subscriptions_remove_fake_stream(self) -> None:
 | |
|         """
 | |
|         Calling DELETE /json/users/me/subscriptions on a stream that doesn't exist
 | |
|         should return a JSON error.
 | |
|         """
 | |
|         random_streams = self.make_random_stream_names(self.streams)
 | |
|         self.assertNotEqual(len(random_streams), 0)  # necessary for full test coverage
 | |
|         # pick only one fake stream, to make checking the error message easy
 | |
|         streams_to_remove = random_streams[:1]
 | |
|         result = self.client_delete(
 | |
|             "/json/users/me/subscriptions",
 | |
|             {"subscriptions": orjson.dumps(streams_to_remove).decode()},
 | |
|         )
 | |
|         self.assert_json_error(result, f"Channel(s) ({random_streams[0]}) do not exist")
 | |
| 
 | |
|     def get_subscription(self, user_profile: UserProfile, stream_name: str) -> Subscription:
 | |
|         stream = get_stream(stream_name, self.test_realm)
 | |
|         return Subscription.objects.get(
 | |
|             user_profile=user_profile,
 | |
|             recipient__type=Recipient.STREAM,
 | |
|             recipient__type_id=stream.id,
 | |
|         )
 | |
| 
 | |
|     def test_subscriptions_add_notification_default_none(self) -> None:
 | |
|         """
 | |
|         When creating a subscription, the desktop, push, and audible notification
 | |
|         settings for that stream are none. A value of None means to use the values
 | |
|         inherited from the global notification settings.
 | |
|         """
 | |
|         user_profile = self.example_user("iago")
 | |
|         invitee_user_id = user_profile.id
 | |
|         invitee_realm = user_profile.realm
 | |
|         user_profile.enable_stream_desktop_notifications = True
 | |
|         user_profile.enable_stream_push_notifications = True
 | |
|         user_profile.enable_stream_audible_notifications = True
 | |
|         user_profile.enable_stream_email_notifications = True
 | |
|         user_profile.save()
 | |
|         current_stream = self.get_streams(user_profile)[0]
 | |
|         invite_streams = self.make_random_stream_names([current_stream])
 | |
|         self.assert_adding_subscriptions_for_principal(
 | |
|             invitee_user_id, invitee_realm, invite_streams, policy_name="Public"
 | |
|         )
 | |
|         subscription = self.get_subscription(user_profile, invite_streams[0])
 | |
| 
 | |
|         with mock.patch("zerver.models.Recipient.__repr__", return_value="recip"):
 | |
|             self.assertEqual(
 | |
|                 repr(subscription),
 | |
|                 "<Subscription: "
 | |
|                 f"<UserProfile: {user_profile.email} {user_profile.realm!r}> -> recip>",
 | |
|             )
 | |
| 
 | |
|         self.assertIsNone(subscription.desktop_notifications)
 | |
|         self.assertIsNone(subscription.push_notifications)
 | |
|         self.assertIsNone(subscription.audible_notifications)
 | |
|         self.assertIsNone(subscription.email_notifications)
 | |
| 
 | |
|     def test_mark_messages_as_unread_on_unsubscribe(self) -> None:
 | |
|         realm = get_realm("zulip")
 | |
|         user = self.example_user("iago")
 | |
|         random_user = self.example_user("hamlet")
 | |
|         stream1 = ensure_stream(realm, "stream1", invite_only=False, acting_user=None)
 | |
|         stream2 = ensure_stream(realm, "stream2", invite_only=False, acting_user=None)
 | |
|         private = ensure_stream(realm, "private_stream", invite_only=True, acting_user=None)
 | |
| 
 | |
|         self.subscribe(user, "stream1")
 | |
|         self.subscribe(user, "stream2")
 | |
|         self.subscribe(user, "private_stream")
 | |
|         self.subscribe(random_user, "stream1")
 | |
|         self.subscribe(random_user, "stream2")
 | |
|         self.subscribe(random_user, "private_stream")
 | |
| 
 | |
|         self.send_stream_message(random_user, "stream1", "test", "test")
 | |
|         self.send_stream_message(random_user, "stream2", "test", "test")
 | |
|         self.send_stream_message(random_user, "private_stream", "test", "test")
 | |
| 
 | |
|         def get_unread_stream_data() -> List[UnreadStreamInfo]:
 | |
|             raw_unread_data = get_raw_unread_data(user)
 | |
|             aggregated_data = aggregate_unread_data(raw_unread_data)
 | |
|             return aggregated_data["streams"]
 | |
| 
 | |
|         result = get_unread_stream_data()
 | |
|         self.assert_length(result, 3)
 | |
|         self.assertEqual(result[0]["stream_id"], stream1.id)
 | |
|         self.assertEqual(result[1]["stream_id"], stream2.id)
 | |
|         self.assertEqual(result[2]["stream_id"], private.id)
 | |
| 
 | |
|         with self.captureOnCommitCallbacks(execute=True):
 | |
|             # Unsubscribing should mark all the messages in stream2 as read
 | |
|             self.unsubscribe(user, "stream2")
 | |
|             self.unsubscribe(user, "private_stream")
 | |
| 
 | |
|         self.subscribe(user, "stream2")
 | |
|         self.subscribe(user, "private_stream")
 | |
|         result = get_unread_stream_data()
 | |
|         self.assert_length(result, 1)
 | |
|         self.assertEqual(result[0]["stream_id"], stream1.id)
 | |
| 
 | |
|     def test_gather_subscriptions_excludes_deactivated_streams(self) -> None:
 | |
|         """
 | |
|         Check that gather_subscriptions_helper does not include deactivated streams in its
 | |
|         results.
 | |
|         """
 | |
|         realm = get_realm("zulip")
 | |
|         admin_user = self.example_user("iago")
 | |
|         non_admin_user = self.example_user("cordelia")
 | |
| 
 | |
|         self.login_user(admin_user)
 | |
| 
 | |
|         for stream_name in ["stream1", "stream2", "stream3"]:
 | |
|             self.make_stream(stream_name, realm=realm, invite_only=False)
 | |
|             self.subscribe(admin_user, stream_name)
 | |
|             self.subscribe(non_admin_user, stream_name)
 | |
|             self.subscribe(self.example_user("othello"), stream_name)
 | |
| 
 | |
|         def archive_stream(stream_name: str) -> None:
 | |
|             stream_id = get_stream(stream_name, realm).id
 | |
|             result = self.client_delete(f"/json/streams/{stream_id}")
 | |
|             self.assert_json_success(result)
 | |
| 
 | |
|         # Deleted/deactivated stream should not be returned in the helper results
 | |
|         admin_before_delete = gather_subscriptions_helper(admin_user)
 | |
|         non_admin_before_delete = gather_subscriptions_helper(non_admin_user)
 | |
| 
 | |
|         # Delete our stream
 | |
|         archive_stream("stream1")
 | |
| 
 | |
|         # Get subs after delete
 | |
|         admin_after_delete = gather_subscriptions_helper(admin_user)
 | |
|         non_admin_after_delete = gather_subscriptions_helper(non_admin_user)
 | |
| 
 | |
|         # Compare results - should be 1 stream less
 | |
|         self.assertTrue(
 | |
|             len(admin_before_delete.subscriptions) == len(admin_after_delete.subscriptions) + 1,
 | |
|             "Expected exactly 1 less stream from gather_subscriptions_helper",
 | |
|         )
 | |
|         self.assertTrue(
 | |
|             len(non_admin_before_delete.subscriptions)
 | |
|             == len(non_admin_after_delete.subscriptions) + 1,
 | |
|             "Expected exactly 1 less stream from gather_subscriptions_helper",
 | |
|         )
 | |
| 
 | |
|     def test_validate_user_access_to_subscribers_helper(self) -> None:
 | |
|         """
 | |
|         Ensure the validate_user_access_to_subscribers_helper is properly raising
 | |
|         ValidationError on missing user, user not-in-realm.
 | |
|         """
 | |
|         user_profile = self.example_user("othello")
 | |
|         realm_name = "no_othello_allowed"
 | |
|         realm = do_create_realm(realm_name, "Everyone but Othello is allowed")
 | |
|         stream_dict = {
 | |
|             "name": "publicstream",
 | |
|             "description": "Public stream with public history",
 | |
|             "realm_id": realm.id,
 | |
|         }
 | |
| 
 | |
|         # For this test to work, othello can't be in the no_othello_here realm
 | |
|         self.assertNotEqual(
 | |
|             user_profile.realm.id, realm.id, "Expected othello user to not be in this realm."
 | |
|         )
 | |
| 
 | |
|         # This should result in missing user
 | |
|         with self.assertRaises(ValidationError):
 | |
|             validate_user_access_to_subscribers_helper(None, stream_dict, lambda user_profile: True)
 | |
| 
 | |
|         # This should result in user not in realm
 | |
|         with self.assertRaises(ValidationError):
 | |
|             validate_user_access_to_subscribers_helper(
 | |
|                 user_profile, stream_dict, lambda user_profile: True
 | |
|             )
 | |
| 
 | |
|     def test_subscriptions_query_count(self) -> None:
 | |
|         """
 | |
|         Test database query count when creating stream with api/v1/users/me/subscriptions.
 | |
|         """
 | |
|         user1 = self.example_user("cordelia")
 | |
|         user2 = self.example_user("iago")
 | |
|         new_streams = [
 | |
|             "query_count_stream_1",
 | |
|             "query_count_stream_2",
 | |
|             "query_count_stream_3",
 | |
|         ]
 | |
| 
 | |
|         # Test creating a public stream when realm does not have a notification stream.
 | |
|         with self.assert_database_query_count(36):
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.test_user,
 | |
|                 [new_streams[0]],
 | |
|                 dict(principals=orjson.dumps([user1.id, user2.id]).decode()),
 | |
|             )
 | |
| 
 | |
|         # Test creating private stream.
 | |
|         with self.assert_database_query_count(38):
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.test_user,
 | |
|                 [new_streams[1]],
 | |
|                 dict(principals=orjson.dumps([user1.id, user2.id]).decode()),
 | |
|                 invite_only=True,
 | |
|             )
 | |
| 
 | |
|         # Test creating a public stream with announce when realm has a new_stream_announcements_stream.
 | |
|         new_stream_announcements_stream = get_stream(self.streams[0], self.test_realm)
 | |
|         self.test_realm.new_stream_announcements_stream_id = new_stream_announcements_stream.id
 | |
|         self.test_realm.save()
 | |
|         with self.assert_database_query_count(47):
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.test_user,
 | |
|                 [new_streams[2]],
 | |
|                 dict(
 | |
|                     announce="true",
 | |
|                     principals=orjson.dumps([user1.id, user2.id]).decode(),
 | |
|                 ),
 | |
|             )
 | |
| 
 | |
| 
 | |
| class GetStreamsTest(ZulipTestCase):
 | |
|     def test_streams_api_for_bot_owners(self) -> None:
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         test_bot = self.create_test_bot("foo", hamlet)
 | |
|         assert test_bot is not None
 | |
|         realm = get_realm("zulip")
 | |
|         self.login_user(hamlet)
 | |
| 
 | |
|         # Check it correctly lists the bot owner's subs with
 | |
|         # include_owner_subscribed=true
 | |
|         filters = dict(
 | |
|             include_owner_subscribed="true",
 | |
|             include_public="false",
 | |
|             include_subscribed="false",
 | |
|         )
 | |
|         result = self.api_get(test_bot, "/api/v1/streams", filters)
 | |
|         owner_subs = self.api_get(hamlet, "/api/v1/users/me/subscriptions")
 | |
| 
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertIn("streams", json)
 | |
|         self.assertIsInstance(json["streams"], list)
 | |
| 
 | |
|         self.assert_json_success(owner_subs)
 | |
|         owner_subs_json = orjson.loads(owner_subs.content)
 | |
| 
 | |
|         self.assertEqual(
 | |
|             sorted(s["name"] for s in json["streams"]),
 | |
|             sorted(s["name"] for s in owner_subs_json["subscriptions"]),
 | |
|         )
 | |
| 
 | |
|         # Check it correctly lists the bot owner's subs and the
 | |
|         # bot's subs
 | |
|         self.subscribe(test_bot, "Scotland")
 | |
|         filters = dict(
 | |
|             include_owner_subscribed="true",
 | |
|             include_public="false",
 | |
|             include_subscribed="true",
 | |
|         )
 | |
|         result = self.api_get(test_bot, "/api/v1/streams", filters)
 | |
| 
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertIn("streams", json)
 | |
|         self.assertIsInstance(json["streams"], list)
 | |
| 
 | |
|         actual = sorted(s["name"] for s in json["streams"])
 | |
|         expected = [s["name"] for s in owner_subs_json["subscriptions"]]
 | |
|         expected.append("Scotland")
 | |
|         expected.sort()
 | |
| 
 | |
|         self.assertEqual(actual, expected)
 | |
| 
 | |
|         # Check it correctly lists the bot owner's subs + all public streams
 | |
|         self.make_stream("private_stream", realm=realm, invite_only=True)
 | |
|         self.subscribe(test_bot, "private_stream")
 | |
|         result = self.api_get(
 | |
|             test_bot,
 | |
|             "/api/v1/streams",
 | |
|             {
 | |
|                 "include_owner_subscribed": "true",
 | |
|                 "include_public": "true",
 | |
|                 "include_subscribed": "false",
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertIn("streams", json)
 | |
|         self.assertIsInstance(json["streams"], list)
 | |
| 
 | |
|         actual = sorted(s["name"] for s in json["streams"])
 | |
|         expected = [s["name"] for s in owner_subs_json["subscriptions"]]
 | |
|         expected.extend(["Rome", "Venice", "Scotland"])
 | |
|         expected.sort()
 | |
| 
 | |
|         self.assertEqual(actual, expected)
 | |
| 
 | |
|         # Check it correctly lists the bot owner's subs + all public streams +
 | |
|         # the bot's subs
 | |
|         result = self.api_get(
 | |
|             test_bot,
 | |
|             "/api/v1/streams",
 | |
|             {
 | |
|                 "include_owner_subscribed": "true",
 | |
|                 "include_public": "true",
 | |
|                 "include_subscribed": "true",
 | |
|             },
 | |
|         )
 | |
| 
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertIn("streams", json)
 | |
|         self.assertIsInstance(json["streams"], list)
 | |
| 
 | |
|         actual = sorted(s["name"] for s in json["streams"])
 | |
|         expected = [s["name"] for s in owner_subs_json["subscriptions"]]
 | |
|         expected.extend(["Rome", "Venice", "Scotland", "private_stream"])
 | |
|         expected.sort()
 | |
| 
 | |
|         self.assertEqual(actual, expected)
 | |
| 
 | |
|     def test_all_active_streams_api(self) -> None:
 | |
|         url = "/api/v1/streams"
 | |
|         data = {"include_all_active": "true"}
 | |
| 
 | |
|         # Check non-superuser can't use include_all_active
 | |
|         normal_user = self.example_user("cordelia")
 | |
|         result = self.api_get(normal_user, url, data)
 | |
|         self.assertEqual(result.status_code, 400)
 | |
| 
 | |
|         # Realm admin users can see all active streams.
 | |
|         admin_user = self.example_user("iago")
 | |
|         self.assertTrue(admin_user.is_realm_admin)
 | |
| 
 | |
|         result = self.api_get(admin_user, url, data)
 | |
|         json = self.assert_json_success(result)
 | |
| 
 | |
|         self.assertIn("streams", json)
 | |
|         self.assertIsInstance(json["streams"], list)
 | |
| 
 | |
|         stream_names = {s["name"] for s in json["streams"]}
 | |
| 
 | |
|         self.assertEqual(
 | |
|             stream_names,
 | |
|             {
 | |
|                 "Venice",
 | |
|                 "Denmark",
 | |
|                 "Scotland",
 | |
|                 "Verona",
 | |
|                 "Rome",
 | |
|                 "core team",
 | |
|                 "Zulip",
 | |
|                 "sandbox",
 | |
|             },
 | |
|         )
 | |
| 
 | |
|     def test_public_streams_api(self) -> None:
 | |
|         """
 | |
|         Ensure that the query we use to get public streams successfully returns
 | |
|         a list of streams
 | |
|         """
 | |
|         user = self.example_user("hamlet")
 | |
|         realm = get_realm("zulip")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         # Check it correctly lists the user's subs with include_public=false
 | |
|         result = self.api_get(user, "/api/v1/streams", {"include_public": "false"})
 | |
|         result2 = self.api_get(user, "/api/v1/users/me/subscriptions")
 | |
| 
 | |
|         json = self.assert_json_success(result)
 | |
| 
 | |
|         self.assertIn("streams", json)
 | |
| 
 | |
|         self.assertIsInstance(json["streams"], list)
 | |
| 
 | |
|         self.assert_json_success(result2)
 | |
|         json2 = orjson.loads(result2.content)
 | |
| 
 | |
|         self.assertEqual(
 | |
|             sorted(s["name"] for s in json["streams"]),
 | |
|             sorted(s["name"] for s in json2["subscriptions"]),
 | |
|         )
 | |
| 
 | |
|         # Check it correctly lists all public streams with include_subscribed=false
 | |
|         filters = dict(include_public="true", include_subscribed="false")
 | |
|         result = self.api_get(user, "/api/v1/streams", filters)
 | |
|         json = self.assert_json_success(result)
 | |
|         all_streams = [
 | |
|             stream.name for stream in Stream.objects.filter(realm=realm, invite_only=False)
 | |
|         ]
 | |
|         self.assertEqual(sorted(s["name"] for s in json["streams"]), sorted(all_streams))
 | |
| 
 | |
|     def test_get_single_stream_api(self) -> None:
 | |
|         self.login("hamlet")
 | |
|         realm = get_realm("zulip")
 | |
|         denmark_stream = get_stream("Denmark", realm)
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}")
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["stream"]["name"], "Denmark")
 | |
|         self.assertEqual(json["stream"]["stream_id"], denmark_stream.id)
 | |
| 
 | |
|         result = self.client_get("/json/streams/9999")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         private_stream = self.make_stream("private_stream", invite_only=True)
 | |
|         self.subscribe(self.example_user("cordelia"), "private_stream")
 | |
| 
 | |
|         # Non-admins cannot access unsubscribed private streams.
 | |
|         result = self.client_get(f"/json/streams/{private_stream.id}")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         self.login("iago")
 | |
|         result = self.client_get(f"/json/streams/{private_stream.id}")
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["stream"]["name"], "private_stream")
 | |
|         self.assertEqual(json["stream"]["stream_id"], private_stream.id)
 | |
| 
 | |
|         self.login("cordelia")
 | |
|         result = self.client_get(f"/json/streams/{private_stream.id}")
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["stream"]["name"], "private_stream")
 | |
|         self.assertEqual(json["stream"]["stream_id"], private_stream.id)
 | |
| 
 | |
|     def test_get_stream_email_address(self) -> None:
 | |
|         self.login("hamlet")
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         iago = self.example_user("iago")
 | |
|         polonius = self.example_user("polonius")
 | |
|         realm = get_realm("zulip")
 | |
|         denmark_stream = get_stream("Denmark", realm)
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}/email_address")
 | |
|         json = self.assert_json_success(result)
 | |
|         denmark_email = encode_email_address_helper(
 | |
|             denmark_stream.name, denmark_stream.email_token, show_sender=True
 | |
|         )
 | |
|         self.assertEqual(json["email"], denmark_email)
 | |
| 
 | |
|         self.login("polonius")
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}/email_address")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         self.subscribe(polonius, "Denmark")
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}/email_address")
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["email"], denmark_email)
 | |
| 
 | |
|         do_change_stream_permission(
 | |
|             denmark_stream,
 | |
|             invite_only=True,
 | |
|             history_public_to_subscribers=True,
 | |
|             is_web_public=False,
 | |
|             acting_user=iago,
 | |
|         )
 | |
|         self.login("hamlet")
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}/email_address")
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["email"], denmark_email)
 | |
| 
 | |
|         self.unsubscribe(hamlet, "Denmark")
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}/email_address")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         self.login("iago")
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}/email_address")
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["email"], denmark_email)
 | |
| 
 | |
|         self.unsubscribe(iago, "Denmark")
 | |
|         result = self.client_get(f"/json/streams/{denmark_stream.id}/email_address")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
| 
 | |
| class StreamIdTest(ZulipTestCase):
 | |
|     def test_get_stream_id(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
|         stream = gather_subscriptions(user)[0][0]
 | |
|         result = self.client_get("/json/get_stream_id", {"stream": stream["name"]})
 | |
|         response_dict = self.assert_json_success(result)
 | |
|         self.assertEqual(response_dict["stream_id"], stream["stream_id"])
 | |
| 
 | |
|     def test_get_stream_id_wrong_name(self) -> None:
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
|         result = self.client_get("/json/get_stream_id", {"stream": "wrongname"})
 | |
|         self.assert_json_error(result, "Invalid channel name 'wrongname'")
 | |
| 
 | |
| 
 | |
| class InviteOnlyStreamTest(ZulipTestCase):
 | |
|     def test_must_be_subbed_to_send(self) -> None:
 | |
|         """
 | |
|         If you try to send a message to an invite-only stream to which
 | |
|         you aren't subscribed, you'll get a 400.
 | |
|         """
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
|         # Create Saxony as an invite-only stream.
 | |
|         self.assert_json_success(
 | |
|             self.common_subscribe_to_streams(user, ["Saxony"], invite_only=True)
 | |
|         )
 | |
| 
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         with self.assertRaises(JsonableError):
 | |
|             self.send_stream_message(cordelia, "Saxony")
 | |
| 
 | |
|     def test_list_respects_invite_only_bit(self) -> None:
 | |
|         """
 | |
|         Make sure that /api/v1/users/me/subscriptions properly returns
 | |
|         the invite-only bit for streams that are invite-only
 | |
|         """
 | |
| 
 | |
|         user = self.example_user("hamlet")
 | |
|         self.login_user(user)
 | |
| 
 | |
|         self.common_subscribe_to_streams(user, ["Saxony"], invite_only=True)
 | |
|         self.common_subscribe_to_streams(user, ["Normandy"], invite_only=False)
 | |
|         result = self.api_get(user, "/api/v1/users/me/subscriptions")
 | |
|         response_dict = self.assert_json_success(result)
 | |
|         self.assertIn("subscriptions", response_dict)
 | |
|         for sub in response_dict["subscriptions"]:
 | |
|             if sub["name"] == "Normandy":
 | |
|                 self.assertEqual(
 | |
|                     sub["invite_only"], False, "Normandy was mistakenly marked private"
 | |
|                 )
 | |
|             if sub["name"] == "Saxony":
 | |
|                 self.assertEqual(sub["invite_only"], True, "Saxony was not properly marked private")
 | |
| 
 | |
|     def test_inviteonly(self) -> None:
 | |
|         # Creating an invite-only stream is allowed
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         othello = self.example_user("othello")
 | |
| 
 | |
|         stream_name = "Saxony"
 | |
| 
 | |
|         result = self.common_subscribe_to_streams(hamlet, [stream_name], invite_only=True)
 | |
| 
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["subscribed"], {hamlet.email: [stream_name]})
 | |
|         self.assertEqual(json["already_subscribed"], {})
 | |
| 
 | |
|         # Subscribing oneself to an invite-only stream is not allowed
 | |
|         self.login_user(othello)
 | |
|         result = self.common_subscribe_to_streams(othello, [stream_name], allow_fail=True)
 | |
|         self.assert_json_error(result, "Unable to access channel (Saxony).")
 | |
| 
 | |
|         # authorization_errors_fatal=False works
 | |
|         self.login_user(othello)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             othello,
 | |
|             [stream_name],
 | |
|             extra_post_data={"authorization_errors_fatal": orjson.dumps(False).decode()},
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["unauthorized"], [stream_name])
 | |
|         self.assertEqual(json["subscribed"], {})
 | |
|         self.assertEqual(json["already_subscribed"], {})
 | |
| 
 | |
|         # Inviting another user to an invite-only stream is allowed
 | |
|         self.login_user(hamlet)
 | |
|         result = self.common_subscribe_to_streams(
 | |
|             hamlet,
 | |
|             [stream_name],
 | |
|             extra_post_data={"principals": orjson.dumps([othello.id]).decode()},
 | |
|         )
 | |
|         json = self.assert_json_success(result)
 | |
|         self.assertEqual(json["subscribed"], {othello.email: [stream_name]})
 | |
|         self.assertEqual(json["already_subscribed"], {})
 | |
| 
 | |
|         # Make sure both users are subscribed to this stream
 | |
|         stream_id = get_stream(stream_name, hamlet.realm).id
 | |
|         result = self.api_get(hamlet, f"/api/v1/streams/{stream_id}/members")
 | |
|         json = self.assert_json_success(result)
 | |
| 
 | |
|         self.assertTrue(othello.id in json["subscribers"])
 | |
|         self.assertTrue(hamlet.id in json["subscribers"])
 | |
| 
 | |
| 
 | |
| class GetSubscribersTest(ZulipTestCase):
 | |
|     @override
 | |
|     def setUp(self) -> None:
 | |
|         super().setUp()
 | |
|         self.user_profile = self.example_user("hamlet")
 | |
|         self.login_user(self.user_profile)
 | |
| 
 | |
|     def verify_sub_fields(self, sub_data: SubscriptionInfo) -> None:
 | |
|         other_fields = {
 | |
|             "is_announcement_only",
 | |
|             "in_home_view",
 | |
|             "stream_id",
 | |
|             "stream_weekly_traffic",
 | |
|             "subscribers",
 | |
|         }
 | |
| 
 | |
|         expected_fields = set(Stream.API_FIELDS) | set(Subscription.API_FIELDS) | other_fields
 | |
|         expected_fields -= {"id", "can_remove_subscribers_group_id"}
 | |
|         expected_fields |= {"can_remove_subscribers_group"}
 | |
| 
 | |
|         for lst in [sub_data.subscriptions, sub_data.unsubscribed]:
 | |
|             for sub in lst:
 | |
|                 self.assertEqual(set(sub), expected_fields)
 | |
| 
 | |
|         other_fields = {
 | |
|             "is_announcement_only",
 | |
|             "stream_id",
 | |
|             "stream_weekly_traffic",
 | |
|             "subscribers",
 | |
|         }
 | |
| 
 | |
|         expected_fields = set(Stream.API_FIELDS) | other_fields
 | |
|         expected_fields -= {"id", "can_remove_subscribers_group_id"}
 | |
|         expected_fields |= {"can_remove_subscribers_group"}
 | |
| 
 | |
|         for never_sub in sub_data.never_subscribed:
 | |
|             self.assertEqual(set(never_sub), expected_fields)
 | |
| 
 | |
|     def assert_user_got_subscription_notification(
 | |
|         self, user: UserProfile, expected_msg: str
 | |
|     ) -> None:
 | |
|         # verify that the user was sent a message informing them about the subscription
 | |
|         realm = user.realm
 | |
|         msg = most_recent_message(user)
 | |
|         self.assertEqual(msg.recipient.type, msg.recipient.PERSONAL)
 | |
|         self.assertEqual(msg.sender_id, self.notification_bot(realm).id)
 | |
| 
 | |
|         def non_ws(s: str) -> str:
 | |
|             return s.replace("\n", "").replace(" ", "")
 | |
| 
 | |
|         self.assertEqual(non_ws(msg.content), non_ws(expected_msg))
 | |
| 
 | |
|     def check_well_formed_result(
 | |
|         self, result: Dict[str, Any], stream_name: str, realm: Realm
 | |
|     ) -> None:
 | |
|         """
 | |
|         A successful call to get_subscribers returns the list of subscribers in
 | |
|         the form:
 | |
| 
 | |
|         {"msg": "",
 | |
|          "result": "success",
 | |
|          "subscribers": [hamlet_user.id, prospero_user.id]}
 | |
|         """
 | |
|         self.assertIn("subscribers", result)
 | |
|         self.assertIsInstance(result["subscribers"], list)
 | |
|         true_subscribers = [
 | |
|             user_profile.id for user_profile in self.users_subscribed_to_stream(stream_name, realm)
 | |
|         ]
 | |
|         self.assertEqual(sorted(result["subscribers"]), sorted(true_subscribers))
 | |
| 
 | |
|     def make_subscriber_request(
 | |
|         self, stream_id: int, user: Optional[UserProfile] = None
 | |
|     ) -> "TestHttpResponse":
 | |
|         if user is None:
 | |
|             user = self.user_profile
 | |
|         return self.api_get(user, f"/api/v1/streams/{stream_id}/members")
 | |
| 
 | |
|     def make_successful_subscriber_request(self, stream_name: str) -> None:
 | |
|         stream_id = get_stream(stream_name, self.user_profile.realm).id
 | |
|         result = self.make_subscriber_request(stream_id)
 | |
|         response_dict = self.assert_json_success(result)
 | |
|         self.check_well_formed_result(response_dict, stream_name, self.user_profile.realm)
 | |
| 
 | |
|     def test_subscriber(self) -> None:
 | |
|         """
 | |
|         get_subscribers returns the list of subscribers.
 | |
|         """
 | |
|         stream_name = gather_subscriptions(self.user_profile)[0][0]["name"]
 | |
|         self.make_successful_subscriber_request(stream_name)
 | |
| 
 | |
|     def test_gather_subscriptions(self) -> None:
 | |
|         """
 | |
|         gather_subscriptions returns correct results with only 3 queries
 | |
| 
 | |
|         (We also use this test to verify subscription notifications to
 | |
|         folks who get subscribed to streams.)
 | |
|         """
 | |
|         hamlet = self.example_user("hamlet")
 | |
|         cordelia = self.example_user("cordelia")
 | |
|         othello = self.example_user("othello")
 | |
|         polonius = self.example_user("polonius")
 | |
| 
 | |
|         streams = [f"stream_{i}" for i in range(10)]
 | |
|         for stream_name in streams:
 | |
|             self.make_stream(stream_name)
 | |
| 
 | |
|         users_to_subscribe = [
 | |
|             self.user_profile.id,
 | |
|             othello.id,
 | |
|             cordelia.id,
 | |
|             polonius.id,
 | |
|         ]
 | |
| 
 | |
|         with self.assert_database_query_count(46):
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.user_profile,
 | |
|                 streams,
 | |
|                 dict(principals=orjson.dumps(users_to_subscribe).decode()),
 | |
|             )
 | |
| 
 | |
|         msg = f"""
 | |
|             @**King Hamlet|{hamlet.id}** subscribed you to the following channels:
 | |
| 
 | |
|             * #**stream_0**
 | |
|             * #**stream_1**
 | |
|             * #**stream_2**
 | |
|             * #**stream_3**
 | |
|             * #**stream_4**
 | |
|             * #**stream_5**
 | |
|             * #**stream_6**
 | |
|             * #**stream_7**
 | |
|             * #**stream_8**
 | |
|             * #**stream_9**
 | |
|             """
 | |
| 
 | |
|         for user in [cordelia, othello, polonius]:
 | |
|             self.assert_user_got_subscription_notification(user, msg)
 | |
| 
 | |
|         # Subscribe ourself first.
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.user_profile,
 | |
|             ["stream_invite_only_1"],
 | |
|             dict(principals=orjson.dumps([self.user_profile.id]).decode()),
 | |
|             invite_only=True,
 | |
|         )
 | |
| 
 | |
|         # Now add in other users, and this should trigger messages
 | |
|         # to notify the user.
 | |
|         self.common_subscribe_to_streams(
 | |
|             self.user_profile,
 | |
|             ["stream_invite_only_1"],
 | |
|             dict(principals=orjson.dumps(users_to_subscribe).decode()),
 | |
|             invite_only=True,
 | |
|         )
 | |
| 
 | |
|         msg = f"""
 | |
|             @**King Hamlet|{hamlet.id}** subscribed you to the channel #**stream_invite_only_1**.
 | |
|             """
 | |
|         for user in [cordelia, othello, polonius]:
 | |
|             self.assert_user_got_subscription_notification(user, msg)
 | |
| 
 | |
|         with self.assert_database_query_count(4):
 | |
|             subscribed_streams, _ = gather_subscriptions(
 | |
|                 self.user_profile, include_subscribers=True
 | |
|             )
 | |
|         self.assertGreaterEqual(len(subscribed_streams), 11)
 | |
|         for sub in subscribed_streams:
 | |
|             if not sub["name"].startswith("stream_"):
 | |
|                 continue
 | |
|             self.assert_length(sub["subscribers"], len(users_to_subscribe))
 | |
| 
 | |
|     def test_never_subscribed_streams(self) -> None:
 | |
|         """
 | |
|         Check never_subscribed streams are fetched correctly and not include invite_only streams,
 | |
|         or invite_only and public streams to guest users.
 | |
|         """
 | |
|         realm = get_realm("zulip")
 | |
|         users_to_subscribe = [
 | |
|             self.example_user("othello").id,
 | |
|             self.example_user("cordelia").id,
 | |
|         ]
 | |
| 
 | |
|         public_streams = [
 | |
|             "test_stream_public_1",
 | |
|             "test_stream_public_2",
 | |
|             "test_stream_public_3",
 | |
|             "test_stream_public_4",
 | |
|             "test_stream_public_5",
 | |
|         ]
 | |
| 
 | |
|         private_streams = [
 | |
|             "test_stream_invite_only_1",
 | |
|             "test_stream_invite_only_2",
 | |
|         ]
 | |
| 
 | |
|         web_public_streams = [
 | |
|             "test_stream_web_public_1",
 | |
|             "test_stream_web_public_2",
 | |
|         ]
 | |
| 
 | |
|         def create_public_streams() -> None:
 | |
|             for stream_name in public_streams:
 | |
|                 self.make_stream(stream_name, realm=realm)
 | |
| 
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.user_profile,
 | |
|                 public_streams,
 | |
|                 dict(principals=orjson.dumps(users_to_subscribe).decode()),
 | |
|             )
 | |
| 
 | |
|         create_public_streams()
 | |
| 
 | |
|         def create_web_public_streams() -> None:
 | |
|             for stream_name in web_public_streams:
 | |
|                 self.make_stream(stream_name, realm=realm, is_web_public=True)
 | |
| 
 | |
|             ret = self.common_subscribe_to_streams(
 | |
|                 self.user_profile,
 | |
|                 web_public_streams,
 | |
|                 dict(principals=orjson.dumps(users_to_subscribe).decode()),
 | |
|             )
 | |
|             self.assert_json_success(ret)
 | |
| 
 | |
|         create_web_public_streams()
 | |
| 
 | |
|         def create_private_streams() -> None:
 | |
|             self.common_subscribe_to_streams(
 | |
|                 self.user_profile,
 | |
|                 private_streams,
 | |
|                 dict(principals=orjson.dumps(users_to_subscribe).decode()),
 | |
|                 invite_only=True,
 | |
|             )
 | |
| 
 | |
|         create_private_streams()
 | |
| 
 | |
|         def get_never_subscribed() -> List[NeverSubscribedStreamDict]:
 | |
|             with self.assert_database_query_count(4):
 | |
|                 sub_data = gather_subscriptions_helper(self.user_profile)
 | |
|                 self.verify_sub_fields(sub_data)
 | |
|             never_subscribed = sub_data.never_subscribed
 | |
| 
 | |
|             # Ignore old streams.
 | |
|             never_subscribed = [dct for dct in never_subscribed if dct["name"].startswith("test_")]
 | |
|             return never_subscribed
 | |
| 
 | |
|         never_subscribed = get_never_subscribed()
 | |
| 
 | |
|         # Invite only stream should not be there in never_subscribed streams
 | |
|         self.assert_length(never_subscribed, len(public_streams) + len(web_public_streams))
 | |
|         for stream_dict in never_subscribed:
 | |
|             name = stream_dict["name"]
 | |
|             self.assertFalse("invite_only" in name)
 | |
|             self.assert_length(stream_dict["subscribers"], len(users_to_subscribe))
 | |
| 
 | |
|         # Send private stream subscribers to all realm admins.
 | |
|         def test_admin_case() -> None:
 | |
|             self.user_profile.role = UserProfile.ROLE_REALM_ADMINISTRATOR
 | |
|             # Test realm admins can get never subscribed private stream's subscribers.
 | |
|             never_subscribed = get_never_subscribed()
 | |
| 
 | |
|             self.assertEqual(
 | |
|                 len(never_subscribed),
 | |
|                 len(public_streams) + len(private_streams) + len(web_public_streams),
 | |
|             )
 | |
|             for stream_dict in never_subscribed:
 | |
|                 self.assert_length(stream_dict["subscribers"], len(users_to_subscribe))
 | |
| 
 | |
|         test_admin_case()
 | |
| 
 | |
|         def test_guest_user_case() -> None:
 | |
|             self.user_profile.role = UserProfile.ROLE_GUEST
 | |
|             helper_result = gather_subscriptions_helper(self.user_profile)
 | |
|             self.verify_sub_fields(helper_result)
 | |
|             sub = helper_result.subscriptions
 | |
|             unsub = helper_result.unsubscribed
 | |
|             never_sub = helper_result.never_subscribed
 | |
| 
 | |
|             # It's +1 because of the stream Rome.
 | |
|             self.assert_length(never_sub, len(web_public_streams) + 1)
 | |
|             sub_ids = [stream["stream_id"] for stream in sub]
 | |
|             unsub_ids = [stream["stream_id"] for stream in unsub]
 | |
| 
 | |
|             for stream_dict in never_sub:
 | |
|                 self.assertTrue(stream_dict["is_web_public"])
 | |
|                 self.assertTrue(stream_dict["stream_id"] not in sub_ids)
 | |
|                 self.assertTrue(stream_dict["stream_id"] not in unsub_ids)
 | |
| 
 | |
|                 # The Rome stream has is_web_public=True, with default
 | |
|                 # subscribers not set up by this test, so we do the
 | |
|                 # following check only for the streams we created.
 | |
|                 if stream_dict["name"] in web_public_streams:
 | |
|                     self.assert_length(stream_dict["subscribers"], len(users_to_subscribe))
 | |
| 
 | |
|         test_guest_user_case()
 | |
| 
 | |
|     def test_gather_subscribed_streams_for_guest_user(self) -> None:
 | |
|         guest_user = self.example_user("polonius")
 | |
| 
 | |
|         stream_name_sub = "public_stream_1"
 | |
|         self.make_stream(stream_name_sub, realm=get_realm("zulip"))
 | |
|         self.subscribe(guest_user, stream_name_sub)
 | |
| 
 | |
|         stream_name_unsub = "public_stream_2"
 | |
|         self.make_stream(stream_name_unsub, realm=get_realm("zulip"))
 | |
|         self.subscribe(guest_user, stream_name_unsub)
 | |
|         self.unsubscribe(guest_user, stream_name_unsub)
 | |
| 
 | |
|         stream_name_never_sub = "public_stream_3"
 | |
|         self.make_stream(stream_name_never_sub, realm=get_realm("zulip"))
 | |
| 
 | |
|         normal_user = self.example_user("aaron")
 | |
|         self.subscribe(normal_user, stream_name_sub)
 | |
|         self.subscribe(normal_user, stream_name_unsub)
 | |
|         self.subscribe(normal_user, stream_name_unsub)
 | |
| 
 | |
|         helper_result = gather_subscriptions_helper(guest_user)
 | |
|         self.verify_sub_fields(helper_result)
 | |
|         subs = helper_result.subscriptions
 | |
|         neversubs = helper_result.never_subscribed
 | |
| 
 | |
|         # Guest users get info about subscribed public stream's subscribers
 | |
|         expected_stream_exists = False
 | |
|         for sub in subs:
 | |
|             if sub["name"] == stream_name_sub:
 | |
|                 expected_stream_exists = True
 | |
|                 self.assert_length(sub["subscribers"], 2)
 | |
|         self.assertTrue(expected_stream_exists)
 | |
| 
 | |
|         # Guest user only get data about never subscribed streams if they're
 | |
|         # web-public.
 | |
|         for stream in neversubs:
 | |
|             self.assertTrue(stream["is_web_public"])
 | |
| 
 | |
|         # Guest user only get data about never subscribed web-public streams
 | |
|         self.assert_length(neversubs, 1)
 | |
| 
 | |
|     def test_api_fields_present(self) -> None:
 | |
|         user = self.example_user("cordelia")
 | |
| 
 | |
|         sub_data = gather_subscriptions_helper(user)
 | |
|         subscribed = sub_data.subscriptions
 | |
|         self.assertGreaterEqual(len(subscribed), 1)
 | |
|         self.verify_sub_fields(sub_data)
 | |
| 
 | |
|     def test_previously_subscribed_private_streams(self) -> None:
 | |
|         admin_user = self.example_user("iago")
 | |
|         non_admin_user = self.example_user("cordelia")
 | |
|         guest_user = self.example_user("polonius")
 | |
|         stream_name = "private_stream"
 | |
| 
 | |
|         self.make_stream(stream_name, realm=get_realm("zulip"), invite_only=True)
 | |
|         self.subscribe(admin_user, stream_name)
 | |
|         self.subscribe(non_admin_user, stream_name)
 | |
|         self.subscribe(guest_user, stream_name)
 | |
|         self.subscribe(self.example_user("othello"), stream_name)
 | |
| 
 | |
|         self.unsubscribe(admin_user, stream_name)
 | |
|         self.unsubscribe(non_admin_user, stream_name)
 | |
|         self.unsubscribe(guest_user, stream_name)
 | |
| 
 | |
|         # Test admin user gets previously subscribed private stream's subscribers.
 | |
|         sub_data = gather_subscriptions_helper(admin_user)
 | |
|         self.verify_sub_fields(sub_data)
 | |
|         unsubscribed_streams = sub_data.unsubscribed
 | |
|         self.assert_length(unsubscribed_streams, 1)
 | |
|         self.assert_length(unsubscribed_streams[0]["subscribers"], 1)
 | |
| 
 | |
|         # Test non-admin users cannot get previously subscribed private stream's subscribers.
 | |
|         sub_data = gather_subscriptions_helper(non_admin_user)
 | |
|         self.verify_sub_fields(sub_data)
 | |
|         unsubscribed_streams = sub_data.unsubscribed
 | |
|         self.assert_length(unsubscribed_streams, 0)
 | |
| 
 | |
|         sub_data = gather_subscriptions_helper(guest_user)
 | |
|         self.verify_sub_fields(sub_data)
 | |
|         unsubscribed_streams = sub_data.unsubscribed
 | |
|         self.assert_length(unsubscribed_streams, 0)
 | |
| 
 | |
|     def test_previously_subscribed_public_streams(self) -> None:
 | |
|         public_stream_name = "public_stream"
 | |
|         web_public_stream_name = "web_public_stream"
 | |
|         guest_user = self.example_user("polonius")
 | |
|         member_user = self.example_user("hamlet")
 | |
| 
 | |
|         self.make_stream(public_stream_name, realm=get_realm("zulip"))
 | |
|         self.make_stream(web_public_stream_name, realm=get_realm("zulip"), is_web_public=True)
 | |
| 
 | |
|         for stream_name in [public_stream_name, web_public_stream_name]:
 | |
|             self.subscribe(guest_user, stream_name)
 | |
|             self.subscribe(member_user, stream_name)
 | |
|             self.subscribe(self.example_user("othello"), stream_name)
 | |
| 
 | |
|         for stream_name in [public_stream_name, web_public_stream_name]:
 | |
|             self.unsubscribe(guest_user, stream_name)
 | |
|             self.unsubscribe(member_user, stream_name)
 | |
| 
 | |
|         # Test member user gets previously subscribed public stream and its subscribers.
 | |
|         sub_data = gather_subscriptions_helper(member_user)
 | |
|         self.verify_sub_fields(sub_data)
 | |
|         unsubscribed_streams = sub_data.unsubscribed
 | |
|         self.assert_length(unsubscribed_streams, 2)
 | |
|         self.assert_length(unsubscribed_streams[0]["subscribers"], 1)
 | |
|         self.assert_length(unsubscribed_streams[1]["subscribers"], 1)
 | |
| 
 | |
|         # Test guest users cannot get previously subscribed public stream but can get
 | |
|         # web-public stream and its subscribers.
 | |
|         sub_data = gather_subscriptions_helper(guest_user)
 | |
|         self.verify_sub_fields(sub_data)
 | |
|         unsubscribed_streams = sub_data.unsubscribed
 | |
|         self.assert_length(unsubscribed_streams, 1)
 | |
|         self.assertEqual(unsubscribed_streams[0]["is_web_public"], True)
 | |
|         self.assert_length(unsubscribed_streams[0]["subscribers"], 1)
 | |
| 
 | |
|     def test_gather_subscriptions_mit(self) -> None:
 | |
|         """
 | |
|         gather_subscriptions returns correct results with only 3 queries
 | |
|         """
 | |
|         # Subscribe only ourself because invites are disabled on mit.edu
 | |
|         mit_user_profile = self.mit_user("starnine")
 | |
|         user_id = mit_user_profile.id
 | |
|         users_to_subscribe = [user_id, self.mit_user("espuser").id]
 | |
|         for email in users_to_subscribe:
 | |
|             stream = self.subscribe(mit_user_profile, "mit_stream")
 | |
|             self.assertTrue(stream.is_in_zephyr_realm)
 | |
| 
 | |
|         self.common_subscribe_to_streams(
 | |
|             mit_user_profile,
 | |
|             ["mit_invite_only"],
 | |
|             dict(principals=orjson.dumps(users_to_subscribe).decode()),
 | |
|             invite_only=True,
 | |
|             subdomain="zephyr",
 | |
|         )
 | |
| 
 | |
|         with self.assert_database_query_count(3):
 | |
|             subscribed_streams, _ = gather_subscriptions(mit_user_profile, include_subscribers=True)
 | |
| 
 | |
|         self.assertGreaterEqual(len(subscribed_streams), 2)
 | |
|         for sub in subscribed_streams:
 | |
|             if not sub["name"].startswith("mit_"):
 | |
|                 raise AssertionError("Unexpected stream!")
 | |
|             if sub["name"] == "mit_invite_only":
 | |
|                 self.assert_length(sub["subscribers"], len(users_to_subscribe))
 | |
|             else:
 | |
|                 self.assert_length(sub["subscribers"], 0)
 | |
|             self.assertIsNone(sub["stream_weekly_traffic"])
 | |
| 
 | |
|         # Create a web-public stream to test never_subscried data.
 | |
|         self.make_stream("mit_stream_2", realm=mit_user_profile.realm, is_web_public=True)
 | |
|         self.make_stream("mit_stream_3", realm=mit_user_profile.realm)
 | |
| 
 | |
|         sub_info = gather_subscriptions_helper(mit_user_profile, include_subscribers=True)
 | |
|         never_subscribed_streams = sub_info.never_subscribed
 | |
|         # Users in zephyr mirror realm can only access web-public never subscribed streams.
 | |
|         self.assert_length(never_subscribed_streams, 1)
 | |
|         self.assertEqual(never_subscribed_streams[0]["name"], "mit_stream_2")
 | |
|         self.assertTrue(never_subscribed_streams[0]["is_web_public"])
 | |
|         self.assertIsNone(never_subscribed_streams[0]["stream_weekly_traffic"])
 | |
| 
 | |
|     def test_nonsubscriber(self) -> None:
 | |
|         """
 | |
|         Even a non-subscriber to a public stream can query a stream's membership
 | |
|         with get_subscribers.
 | |
|         """
 | |
|         # Create a stream for which Hamlet is the only subscriber.
 | |
|         stream_name = "Saxony"
 | |
|         self.common_subscribe_to_streams(self.user_profile, [stream_name])
 | |
|         other_user = self.example_user("othello")
 | |
| 
 | |
|         # Fetch the subscriber list as a non-member.
 | |
|         self.login_user(other_user)
 | |
|         self.make_successful_subscriber_request(stream_name)
 | |
| 
 | |
|     def test_subscriber_private_stream(self) -> None:
 | |
|         """
 | |
|         A subscriber to a private stream can query that stream's membership.
 | |
|         """
 | |
|         stream_name = "Saxony"
 | |
|         self.common_subscribe_to_streams(self.user_profile, [stream_name], invite_only=True)
 | |
|         self.make_successful_subscriber_request(stream_name)
 | |
| 
 | |
|         stream_id = get_stream(stream_name, self.user_profile.realm).id
 | |
|         # Verify another user can't get the data.
 | |
|         self.login("cordelia")
 | |
|         result = self.client_get(f"/json/streams/{stream_id}/members")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         # But an organization administrator can
 | |
|         self.login("iago")
 | |
|         result = self.client_get(f"/json/streams/{stream_id}/members")
 | |
|         self.assert_json_success(result)
 | |
| 
 | |
|     def test_json_get_subscribers_stream_not_exist(self) -> None:
 | |
|         """
 | |
|         json_get_subscribers also returns the list of subscribers for a stream.
 | |
|         """
 | |
|         stream_id = 99999999
 | |
|         result = self.client_get(f"/json/streams/{stream_id}/members")
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|     def test_json_get_subscribers(self) -> None:
 | |
|         """
 | |
|         json_get_subscribers in zerver/views/streams.py
 | |
|         also returns the list of subscribers for a stream, when requested.
 | |
|         """
 | |
|         stream_name = gather_subscriptions(self.user_profile)[0][0]["name"]
 | |
|         stream_id = get_stream(stream_name, self.user_profile.realm).id
 | |
|         expected_subscribers = gather_subscriptions(self.user_profile, include_subscribers=True)[0][
 | |
|             0
 | |
|         ]["subscribers"]
 | |
|         result = self.client_get(f"/json/streams/{stream_id}/members")
 | |
|         result_dict = self.assert_json_success(result)
 | |
|         self.assertIn("subscribers", result_dict)
 | |
|         self.assertIsInstance(result_dict["subscribers"], list)
 | |
|         subscribers: List[int] = []
 | |
|         for subscriber in result_dict["subscribers"]:
 | |
|             self.assertIsInstance(subscriber, int)
 | |
|             subscribers.append(subscriber)
 | |
|         self.assertEqual(set(subscribers), set(expected_subscribers))
 | |
| 
 | |
|     def test_json_get_subscribers_for_guest_user(self) -> None:
 | |
|         """
 | |
|         Guest users should have access to subscribers of web-public streams, even
 | |
|         if they aren't subscribed or have never subscribed to that stream.
 | |
|         """
 | |
|         guest_user = self.example_user("polonius")
 | |
|         never_subscribed = gather_subscriptions_helper(guest_user, True).never_subscribed
 | |
| 
 | |
|         # A guest user can only see never subscribed streams that are web-public.
 | |
|         # For Polonius, the only web-public stream that he is not subscribed at
 | |
|         # this point is Rome.
 | |
|         self.assert_length(never_subscribed, 1)
 | |
| 
 | |
|         web_public_stream_id = never_subscribed[0]["stream_id"]
 | |
|         result = self.client_get(f"/json/streams/{web_public_stream_id}/members")
 | |
|         result_dict = self.assert_json_success(result)
 | |
|         self.assertIn("subscribers", result_dict)
 | |
|         self.assertIsInstance(result_dict["subscribers"], list)
 | |
|         self.assertGreater(len(result_dict["subscribers"]), 0)
 | |
| 
 | |
|     def test_nonsubscriber_private_stream(self) -> None:
 | |
|         """
 | |
|         A non-subscriber non-realm-admin user to a private stream can't query that stream's membership.
 | |
|         But unsubscribed realm admin users can query private stream's membership.
 | |
|         """
 | |
|         # Create a private stream for which Hamlet is the only subscriber.
 | |
|         stream_name = "NewStream"
 | |
|         self.common_subscribe_to_streams(self.user_profile, [stream_name], invite_only=True)
 | |
|         user_profile = self.example_user("othello")
 | |
| 
 | |
|         # Try to fetch the subscriber list as a non-member & non-realm-admin-user.
 | |
|         stream_id = get_stream(stream_name, user_profile.realm).id
 | |
|         result = self.make_subscriber_request(stream_id, user=user_profile)
 | |
|         self.assert_json_error(result, "Invalid channel ID")
 | |
| 
 | |
|         # Try to fetch the subscriber list as a non-member & realm-admin-user.
 | |
|         self.login("iago")
 | |
|         self.make_successful_subscriber_request(stream_name)
 | |
| 
 | |
| 
 | |
| class AccessStreamTest(ZulipTestCase):
 | |
|     def test_access_stream(self) -> None:
 | |
|         """
 | |
|         A comprehensive security test for the access_stream_by_* API functions.
 | |
|         """
 | |
|         # Create a private stream for which Hamlet is the only subscriber.
 | |
|         hamlet = self.example_user("hamlet")
 | |
| 
 | |
|         stream_name = "new_private_stream"
 | |
|         self.login_user(hamlet)
 | |
|         self.common_subscribe_to_streams(hamlet, [stream_name], invite_only=True)
 | |
|         stream = get_stream(stream_name, hamlet.realm)
 | |
| 
 | |
|         othello = self.example_user("othello")
 | |
| 
 | |
|         # Nobody can access a stream that doesn't exist
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel ID"):
 | |
|             access_stream_by_id(hamlet, 501232)
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel name 'invalid stream'"):
 | |
|             access_stream_by_name(hamlet, "invalid stream")
 | |
| 
 | |
|         # Hamlet can access the private stream
 | |
|         (stream_ret, sub_ret) = access_stream_by_id(hamlet, stream.id)
 | |
|         self.assertEqual(stream.id, stream_ret.id)
 | |
|         assert sub_ret is not None
 | |
|         self.assertEqual(sub_ret.recipient.type_id, stream.id)
 | |
|         (stream_ret2, sub_ret2) = access_stream_by_name(hamlet, stream.name)
 | |
|         self.assertEqual(stream_ret.id, stream_ret2.id)
 | |
|         self.assertEqual(sub_ret, sub_ret2)
 | |
| 
 | |
|         # Othello cannot access the private stream
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel ID"):
 | |
|             access_stream_by_id(othello, stream.id)
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel name 'new_private_stream'"):
 | |
|             access_stream_by_name(othello, stream.name)
 | |
| 
 | |
|         # Both Othello and Hamlet can access a public stream that only
 | |
|         # Hamlet is subscribed to in this realm
 | |
|         public_stream_name = "public_stream"
 | |
|         self.common_subscribe_to_streams(hamlet, [public_stream_name], invite_only=False)
 | |
|         public_stream = get_stream(public_stream_name, hamlet.realm)
 | |
|         access_stream_by_id(othello, public_stream.id)
 | |
|         access_stream_by_name(othello, public_stream.name)
 | |
|         access_stream_by_id(hamlet, public_stream.id)
 | |
|         access_stream_by_name(hamlet, public_stream.name)
 | |
| 
 | |
|         # Nobody can access a public stream in another realm
 | |
|         mit_realm = get_realm("zephyr")
 | |
|         mit_stream = ensure_stream(mit_realm, "mit_stream", invite_only=False, acting_user=None)
 | |
|         sipbtest = self.mit_user("sipbtest")
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel ID"):
 | |
|             access_stream_by_id(hamlet, mit_stream.id)
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel name 'mit_stream'"):
 | |
|             access_stream_by_name(hamlet, mit_stream.name)
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel ID"):
 | |
|             access_stream_by_id(sipbtest, stream.id)
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel name 'new_private_stream'"):
 | |
|             access_stream_by_name(sipbtest, stream.name)
 | |
| 
 | |
|         # MIT realm users cannot access even public streams in their realm
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel ID"):
 | |
|             access_stream_by_id(sipbtest, mit_stream.id)
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel name 'mit_stream'"):
 | |
|             access_stream_by_name(sipbtest, mit_stream.name)
 | |
| 
 | |
|         # But they can access streams they are subscribed to
 | |
|         self.common_subscribe_to_streams(sipbtest, [mit_stream.name], subdomain="zephyr")
 | |
|         access_stream_by_id(sipbtest, mit_stream.id)
 | |
|         access_stream_by_name(sipbtest, mit_stream.name)
 | |
| 
 | |
|     def test_stream_access_by_guest(self) -> None:
 | |
|         guest_user_profile = self.example_user("polonius")
 | |
|         self.login_user(guest_user_profile)
 | |
|         stream_name = "public_stream_1"
 | |
|         stream = self.make_stream(stream_name, guest_user_profile.realm, invite_only=False)
 | |
| 
 | |
|         # Guest user don't have access to unsubscribed public streams
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel ID"):
 | |
|             access_stream_by_id(guest_user_profile, stream.id)
 | |
| 
 | |
|         # Guest user have access to subscribed public streams
 | |
|         self.subscribe(guest_user_profile, stream_name)
 | |
|         (stream_ret, sub_ret) = access_stream_by_id(guest_user_profile, stream.id)
 | |
|         assert sub_ret is not None
 | |
|         self.assertEqual(stream.id, stream_ret.id)
 | |
|         self.assertEqual(sub_ret.recipient.type_id, stream.id)
 | |
| 
 | |
|         stream_name = "private_stream_1"
 | |
|         stream = self.make_stream(stream_name, guest_user_profile.realm, invite_only=True)
 | |
|         # Obviously, a guest user doesn't have access to unsubscribed private streams either
 | |
|         with self.assertRaisesRegex(JsonableError, "Invalid channel ID"):
 | |
|             access_stream_by_id(guest_user_profile, stream.id)
 | |
| 
 | |
|         # Guest user have access to subscribed private streams
 | |
|         self.subscribe(guest_user_profile, stream_name)
 | |
|         (stream_ret, sub_ret) = access_stream_by_id(guest_user_profile, stream.id)
 | |
|         assert sub_ret is not None
 | |
|         self.assertEqual(stream.id, stream_ret.id)
 | |
|         self.assertEqual(sub_ret.recipient.type_id, stream.id)
 | |
| 
 | |
|         stream_name = "web_public_stream"
 | |
|         stream = self.make_stream(stream_name, guest_user_profile.realm, is_web_public=True)
 | |
|         # Guest users have access to web-public streams even if they aren't subscribed.
 | |
|         (stream_ret, sub_ret) = access_stream_by_id(guest_user_profile, stream.id)
 | |
|         self.assertTrue(can_access_stream_history(guest_user_profile, stream))
 | |
|         assert sub_ret is None
 | |
|         self.assertEqual(stream.id, stream_ret.id)
 | |
| 
 | |
| 
 | |
| class StreamTrafficTest(ZulipTestCase):
 | |
|     def test_average_weekly_stream_traffic_calculation(self) -> None:
 | |
|         # No traffic data for the stream
 | |
|         self.assertEqual(
 | |
|             get_average_weekly_stream_traffic(42, timezone_now() - timedelta(days=300), {1: 4003}),
 | |
|             0,
 | |
|         )
 | |
| 
 | |
|         # using high numbers here to make it more likely to catch small errors in the denominators
 | |
|         # of the calculations. That being said we don't want to go over 100, since then the 2
 | |
|         # significant digits calculation gets applied
 | |
|         # old stream
 | |
|         self.assertEqual(
 | |
|             get_average_weekly_stream_traffic(
 | |
|                 42, timezone_now() - timedelta(days=300), {42: 98 * 4 + 3}
 | |
|             ),
 | |
|             98,
 | |
|         )
 | |
|         # stream between 7 and 27 days old
 | |
|         self.assertEqual(
 | |
|             get_average_weekly_stream_traffic(
 | |
|                 42, timezone_now() - timedelta(days=10), {42: (98 * 10 + 9) // 7}
 | |
|             ),
 | |
|             98,
 | |
|         )
 | |
|         # stream less than 7 days old
 | |
|         self.assertEqual(
 | |
|             get_average_weekly_stream_traffic(42, timezone_now() - timedelta(days=5), {42: 100}),
 | |
|             None,
 | |
|         )
 | |
| 
 | |
|         # average traffic between 0 and 1
 | |
|         self.assertEqual(
 | |
|             get_average_weekly_stream_traffic(42, timezone_now() - timedelta(days=300), {42: 1}), 1
 | |
|         )
 | |
| 
 | |
|     def test_round_to_2_significant_digits(self) -> None:
 | |
|         self.assertEqual(120, round_to_2_significant_digits(116))
 | |
| 
 | |
| 
 | |
| class NoRecipientIDsTest(ZulipTestCase):
 | |
|     def test_no_recipient_ids(self) -> None:
 | |
|         user_profile = self.example_user("cordelia")
 | |
| 
 | |
|         Subscription.objects.filter(
 | |
|             user_profile=user_profile, recipient__type=Recipient.STREAM
 | |
|         ).delete()
 | |
|         subs = gather_subscriptions_helper(user_profile).subscriptions
 | |
| 
 | |
|         # Checks that gather_subscriptions_helper will not return anything
 | |
|         # since there will not be any recipients, without crashing.
 | |
|         #
 | |
|         # This covers a rare corner case.
 | |
|         self.assert_length(subs, 0)
 |