mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 05:53:43 +00:00
ca428cfc24
There is a particular case in which when a user clicks on a tab, then uses the goto method to go to another, and then clicks on the original tab again, it will not load the original tab. This is due to the fact that the goto function that is used to navigate to a tab without clicking does not set the last_value, therefore leaving a state that is incorrect and denying a view update in the case that a user performs the following: Click B -> Goto A -> Click B In this case, it saves the last_value as “B” and so when a user clicks back on “B” it does not trigger any change as it thinks the user is going from “B” to “B”.
126 lines
3.9 KiB
JavaScript
126 lines
3.9 KiB
JavaScript
var components = (function () {
|
|
|
|
var exports = {};
|
|
|
|
/* USAGE:
|
|
Toggle x = components.toggle({
|
|
name: String toggle_name,
|
|
selected: Integer selected_index,
|
|
values: Array<Object> [
|
|
{ label: String title }
|
|
],
|
|
callback: function () {
|
|
// .. on value change.
|
|
},
|
|
}).get();
|
|
*/
|
|
|
|
exports.toggle = (function () {
|
|
var keys = {};
|
|
|
|
var __toggle = function (opts) {
|
|
var component = (function render_component(opts) {
|
|
var _component = $("<div class='tab-switcher'></div>");
|
|
opts.values.forEach(function (value, i) {
|
|
// create a tab with a tab-id so they don't have to be referenced
|
|
// by text value which can be inconsistent.
|
|
var tab = $("<div class='ind-tab' data-tab-key='" + value.key + "' data-tab-id='" + i + "'>" + value.label + "</div>");
|
|
|
|
// add proper classes for styling in CSS.
|
|
if (i === 0) {
|
|
tab.addClass("first");
|
|
} else if (i === opts.values.length - 1) {
|
|
tab.addClass("last");
|
|
} else {
|
|
tab.addClass("middle");
|
|
}
|
|
_component.append(tab);
|
|
});
|
|
return _component;
|
|
}(opts));
|
|
|
|
// store once a copy of the tabs inside the parent in a jQuery object/array.
|
|
var meta = {
|
|
$ind_tab: component.find(".ind-tab"),
|
|
last_value: null,
|
|
};
|
|
|
|
(function () {
|
|
meta.$ind_tab.click(function () {
|
|
meta.$ind_tab.removeClass("selected");
|
|
$(this).addClass("selected");
|
|
if (opts.callback) {
|
|
var id = +$(this).data("tab-id");
|
|
|
|
if (meta.last_value !== opts.values[id].label) {
|
|
meta.last_value = opts.values[id].label;
|
|
opts.callback(meta.last_value, opts.values[id].key);
|
|
}
|
|
}
|
|
});
|
|
if (typeof opts.selected === "number") {
|
|
$(component).find(".ind-tab[data-tab-id='" + opts.selected + "']").click();
|
|
}
|
|
}());
|
|
|
|
var prototype = {
|
|
value: function () {
|
|
// find whatever is visually selected in the tab switcher.
|
|
var sel = component.find(".selected");
|
|
|
|
if (sel.length > 0) {
|
|
var id = +sel.eq(0).data("tab-id");
|
|
return opts.values[id].label;
|
|
}
|
|
},
|
|
get: function () {
|
|
return component;
|
|
},
|
|
// go through the process of finding the correct tab for a given name,
|
|
// and when found, select that one and provide the proper callback.
|
|
goto: function (name) {
|
|
var value = _.find(opts.values, function (o) {
|
|
return o.label === name || o.key === name;
|
|
});
|
|
|
|
var idx = opts.values.indexOf(value);
|
|
|
|
if (idx !== -1 && idx !== meta.last_value) {
|
|
meta.$ind_tab.removeClass("selected");
|
|
meta.$ind_tab.filter("[data-tab-id='" + idx + "']").addClass("selected");
|
|
|
|
opts.callback(value.label, value.key);
|
|
|
|
meta.last_value = idx;
|
|
}
|
|
},
|
|
};
|
|
|
|
if (opts.name) {
|
|
keys[opts.name] = {
|
|
opts: opts,
|
|
component: component,
|
|
value: prototype.value,
|
|
goto: prototype.goto,
|
|
};
|
|
}
|
|
|
|
return prototype;
|
|
};
|
|
|
|
// look up a toggle globally by the name you set it as and return
|
|
// the prototype.
|
|
__toggle.lookup = function (id) {
|
|
return keys[id];
|
|
};
|
|
|
|
return __toggle;
|
|
}());
|
|
|
|
return exports;
|
|
}());
|
|
|
|
if (typeof module !== 'undefined') {
|
|
module.exports = components;
|
|
}
|