mirror of
https://github.com/zulip/zulip.git
synced 2025-11-10 17:07:07 +00:00
The `tidy` parameter is buggy, and ignores all ordering metaparameters. This is fixed in Puppet 7[^1], but it's helpful to resolve it now. Specifically, this fixes bugs with tidy running too early, and deleting the old version of a package before its new version is installed or symlinked, leaving a race condition if anything tries to run the binary in this window. This is mostly not a problem for Supervisor-managed processes, since the binary is already running, and can continue to run if it is tidied out from under the running process. For stand-alone tools like wal-g, which are run frequently by PostgreSQL, this may cause issues if PostgreSQL tries to call them during a puppet run. Remove all complicated uses of tidy, and replace them with an `exec` which does the equivalent. We also generate `file` resources for binaries, making them easier (and clearer) to specify as dependencies. [^1]: https://puppet.atlassian.net/browse/PUP-10688
21 lines
639 B
Puppet
21 lines
639 B
Puppet
# @summary Installs Vector to transform Prometheus data
|
|
#
|
|
class kandra::vector {
|
|
$version = $zulip::common::versions['vector']['version']
|
|
$dir = "/srv/zulip-vector-${version}"
|
|
$bin = "${dir}/bin/vector"
|
|
|
|
$arch = $facts['os']['architecture'] ? {
|
|
'amd64' => 'x86_64',
|
|
'aarch64' => 'aarch64',
|
|
}
|
|
|
|
zulip::external_dep { 'vector':
|
|
version => $version,
|
|
url => "https://packages.timber.io/vector/${version}/vector-${version}-${arch}-unknown-linux-gnu.tar.gz",
|
|
tarball_prefix => "vector-${arch}-unknown-linux-gnu",
|
|
bin => [$bin],
|
|
cleanup_after => [Service[supervisor]],
|
|
}
|
|
}
|