mirror of
https://github.com/zulip/zulip.git
synced 2025-11-07 23:43:43 +00:00
6deb165ef6
This commit adds a new tab to the stream settings overlay called "Not subscribed" which lists all the streams the user is not subscribed to. This tab is disabled if the user is a guest. Introduced a new variable called "show_not_subscribed" to replicate a similar model to how the subscribed tab is working. Currently, there are only two tabs: "subscribed" and "all streams" so we can use an if-else condition. Refactored the 'update_stream_row_in_settings_tab' function inside stream_ui_updates.js to include the case of a 'Not-subscribed' tab, so that the tab is immediately updated in any add/remove subscription event. Fixed and added the node tests for these changes.
56 lines
2.2 KiB
TypeScript
56 lines
2.2 KiB
TypeScript
import type {ElementHandle, Page} from "puppeteer";
|
|
|
|
import * as common from "./lib/common";
|
|
|
|
async function test_subscription_button(page: Page): Promise<void> {
|
|
const all_stream_selector = "[data-tab-key='all-streams']";
|
|
await page.waitForSelector(all_stream_selector, {visible: true});
|
|
await page.click(all_stream_selector);
|
|
const stream_selector = "[data-stream-name='Venice']";
|
|
const button_selector = `${stream_selector} .sub_unsub_button`;
|
|
const subscribed_selector = `${button_selector}.checked`;
|
|
const unsubscribed_selector = `${button_selector}:not(.checked)`;
|
|
|
|
async function subscribed(): Promise<ElementHandle | null> {
|
|
await page.waitForSelector(
|
|
`xpath///*[${common.has_class_x("stream_settings_header")}]//*[${common.has_class_x(
|
|
"sub_unsub_button",
|
|
)} and normalize-space()="Unsubscribe"]`,
|
|
);
|
|
return await page.waitForSelector(subscribed_selector, {visible: true});
|
|
}
|
|
|
|
async function unsubscribed(): Promise<ElementHandle | null> {
|
|
await page.waitForSelector(
|
|
`xpath///*[${common.has_class_x("stream_settings_header")}]//*[${common.has_class_x(
|
|
"sub_unsub_button",
|
|
)} and normalize-space()="Subscribe"]`,
|
|
);
|
|
return await page.waitForSelector(unsubscribed_selector, {visible: true});
|
|
}
|
|
|
|
// Make sure that Venice is even in our list of streams.
|
|
await page.waitForSelector(stream_selector, {visible: true});
|
|
await page.waitForSelector(button_selector, {visible: true});
|
|
|
|
await page.click(stream_selector);
|
|
|
|
// Note that we intentionally re-find the button after each click, since
|
|
// the live-update code may replace the whole row.
|
|
// We assume Venice is already subscribed, so the first line here
|
|
// should happen immediately.
|
|
await (await subscribed())!.click();
|
|
await (await unsubscribed())!.click();
|
|
await (await subscribed())!.click();
|
|
await (await unsubscribed())!.click();
|
|
await subscribed();
|
|
}
|
|
|
|
async function subscriptions_tests(page: Page): Promise<void> {
|
|
await common.log_in(page);
|
|
await common.open_streams_modal(page);
|
|
await test_subscription_button(page);
|
|
}
|
|
|
|
common.run_test(subscriptions_tests);
|