mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 14:03:30 +00:00
c4efc97d5a
Navigation key presses like `Up` and `PageUp` with an empty recipient boxes will now close the compose and propagate the keypress to the message list or recent topics, depending upon the active view. This extends behavior we've had for a long time with focus in the compose box itself.
87 lines
2.8 KiB
JavaScript
87 lines
2.8 KiB
JavaScript
import $ from "jquery";
|
|
|
|
import * as compose_pm_pill from "./compose_pm_pill";
|
|
|
|
let message_type = false; // 'stream', 'private', or false-y
|
|
|
|
export function set_message_type(msg_type) {
|
|
message_type = msg_type;
|
|
}
|
|
|
|
export function get_message_type() {
|
|
return message_type;
|
|
}
|
|
|
|
export function composing() {
|
|
// This is very similar to get_message_type(), but it returns
|
|
// a boolean.
|
|
return Boolean(message_type);
|
|
}
|
|
|
|
function get_or_set(fieldname, keep_leading_whitespace) {
|
|
// We can't hoist the assignment of 'elem' out of this lambda,
|
|
// because the DOM element might not exist yet when get_or_set
|
|
// is called.
|
|
return function (newval) {
|
|
const elem = $(`#${CSS.escape(fieldname)}`);
|
|
const oldval = elem.val();
|
|
if (newval !== undefined) {
|
|
elem.val(newval);
|
|
}
|
|
return keep_leading_whitespace ? oldval.trimEnd() : oldval.trim();
|
|
};
|
|
}
|
|
|
|
// TODO: Break out setters and getter into their own functions.
|
|
export const stream_name = get_or_set("stream_message_recipient_stream");
|
|
|
|
export const topic = get_or_set("stream_message_recipient_topic");
|
|
|
|
// We can't trim leading whitespace in `compose_textarea` because
|
|
// of the indented syntax for multi-line code blocks.
|
|
export const message_content = get_or_set("compose-textarea", true);
|
|
|
|
export function focus_in_empty_compose() {
|
|
// A user trying to press arrow keys in an empty compose is mostly
|
|
// likely trying to navigate messages. This helper function
|
|
// decides whether the compose box is "empty" for this purpose.
|
|
if (!composing() || message_content() !== "") {
|
|
return false;
|
|
}
|
|
|
|
const focused_element_id = document.activeElement.id;
|
|
if (focused_element_id === "compose-textarea") {
|
|
// Focus will be in the compose textarea after sending a
|
|
// message; this is the most common situation.
|
|
return true;
|
|
}
|
|
|
|
// If the current focus is in one of the recipient inputs, we need
|
|
// to check whether the input is empty, to avoid accidentally
|
|
// overriding the browser feature where the Up/Down arrow keys jump
|
|
// you to the start/end of a non-empty text input.
|
|
//
|
|
// Check whether the current input element is empty for each input type.
|
|
switch (focused_element_id) {
|
|
case "private_message_recipient":
|
|
return private_message_recipient().length === 0;
|
|
case "stream_message_recipient_topic":
|
|
case "stream_message_recipient_stream":
|
|
return document.activeElement.value === "";
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
export function private_message_recipient(value) {
|
|
if (typeof value === "string") {
|
|
compose_pm_pill.set_from_emails(value);
|
|
return undefined;
|
|
}
|
|
return compose_pm_pill.get_emails();
|
|
}
|
|
|
|
export function has_message_content() {
|
|
return message_content() !== "";
|
|
}
|