mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 13:33:24 +00:00
The `get_link_embed_data` / `link_embed_data_from_cache` pair as introduced inc93f1d4edauses the cache as a temporary store inside of the `embed_links` worker; this means that it must be durable storage, or the worker will stall and re-fetch the same links to preview them. Switch to plumbing through the fetched URL embed data as an parameter to the Markdown evaluation which uses them, rather than using the cache as an intermediary. This frees up the cache to be merely a non-durable cache. As a side-effect, this removes get_cache_with_key, and link_embed_data_from_cache which was its only callsite. (cherry picked from commit351bdfaf78)